Status Update
No update yet.
Comments
za...@gmail.com
an...@google.com
si...@google.com
It is generally quite tricky to run all of them locally and do diffs in between. Unless there are some partciular ones where you already know they might be failing :) So detecting later in CI is WAI.
However the command to run them is:
- lock your cpu clocks
./gradlew lockClocks
- run the benchmarks
./gradlew :compose:integration-tests:benchmark:connectedCheck
^- this will run them all which I would not recommend as it takes lot of time
./gradlew :compose:integration-tests:benchmark:connectedCheck -Pandroid.testInstrumentationRunnerArguments.class=<fully-qualified-class>
^- this will run only a specific class with benchmarks in it
And to get the result, typically just Android Studio -> logcat -> filter "Benchmark" keyword
se...@gmail.com
I would also recommend trying to repro the regression before and after the change. As we are not doing when filing the bugs, hoping we got it right :)
ha...@google.com
ap...@google.com
The regression for some tests is 30x. Please consider reverting.
Description
Currently, the
drawTextfunction is not available for @Composable Canvas. To draw a text, we need to usecanvas.nativeCanvas.drawText, which is the function from android.graphics.Canvas.java. The drawText function could have similar parameters like drawLine or other functions from @Composable Canvas. for example: fun drawText(text: String, color: Color, position: Offset, alpha: Float = 1.0f) This probably should also have style, size, and other parameters from @Composable Text.