IssueTracker

Oh, worth noting that rule from that sample project works fine if Lint run via console.

Hi all! I face the same issue when using AS 4.2.2. I've tried on macOS and on Windows, but I can't see highlighting. I don't see highlighting neither opening the project nor after running :app:lint command (but I can see errors in the console).

+1

Something needs to trigger building the lint artifact, but as a workaround, here's what I did which made it work:

1. Opened the sample project in Flamingo, and used the upgrade assistant to update it to 8.0.0-alpha10 (the same version of Flamingo I was using)
2. Opened the test file ("Test) -- there's no lint warning yet
3. Opened the terminal window inside the IDE (Help > Find Action > terminal)
4. Ran "./gradlew lint"

That triggered a build, and once it finished, the IDE also updated to start showing the lint warning without me having to do anything else (see screenshot).

Something needs to trigger building the lint artifact

Here are 2 options that come to mind:

1. Trigger building the lint.jar file during sync.
2. Add a dependency from common build commands (e.g., assembleDebug) to the task that creates the lint.jar file (so that at least the lint.jar file would exist more often than it does now).

Chris, do you have more context to suggest the best way forward? Both of these seem like they might cause performance regressions, and I'm not sure that option 1 is even allowed.

Yes, I agree we need a way to do this, but also that those options both have downsides as Scott identifies.

I wonder if we need to have a 'build custom lint checks' action in the IDE, maybe with some level of prompting to trigger it in Studio if we detect that the user has configured their project to have custom lint rules but they're not built yet.

What if we had a lint{} block option which basically says to aggressively build local lint checks? And then I realized that maybe the presence of lintChecks in the dependencies block is that option?

Checking in after a year with no movement. We're still missing custom lint check highlighting in AndroidX, which is causing issues to only show up in presubmit e.g. at the end of the development cycle rather than a more appropriate time in the IDE. I agree with comment#15 that if we're going to support creating custom lint checks then they should actually work in the IDE.

At a minimum, if this is going to stay P3 then please provide a reliable, recommended workaround that we can implement in the build.

I'm not a Gradle expert but the trick is to make sure that the lint check jars are actually built -- that doesn't happen when you just sync your project. So a build time workaround is to actually run lint before you open the project. There are probably Gradle targets that do less than that; Scott or Chris would know.

So a build time workaround is to actually run lint before you open the project.

To clarify, studio has no way of picking up lint jars that are built since studio was opened / the project was opened? So we would need to run this as a prerequisite to opening the studio project, and require restarting studio if new lint checks have been added since studio was launched?

Uhm it does do up to date checks each time it runs (https://cs.android.com/android-studio/platform/tools/base/+/mirror-goog-studio-main:lint/libs/lint-api/src/main/java/com/android/tools/lint/client/api/JarFileIssueRegistry.kt;l=65;drc=308eda3d5b4e4a9ff6b7f704b134404003627f1f); I think it should work. I do remember testing it.

Just running assemble on the projects that define the custom lint checks is enough, and as Tor says they are picked up almost immediately.

So for androidx I guess you could have studiow do that building if you wanted to ensure the checks were built when opening studio, and downloading/starting Studio could happen in parallel to that building.

And yes, maybe the right answer here is to have studio at have the option to automatically trigger or prompt to trigger the building of custom lint checks if they are not built after the project is imported. Annoyingly we don't have all the information we'd need to do that correctly from the models we pass to the IDE now, and I'm wary of heuristics for things like this, but there's no technical blocker to adding the information needed.

I think we're adding an option right now to let people skip sync, right? Maybe we can add an option for this too. I understand that basing it on something like the presence of lintConfig or lintPublish is tricky (not available yet when needed) but maybe a gradle.properties? (We can even warn in the IDE if we see local lint checks and the flag hasn't been set to encourage usage.)

cc Karima who was looking into this recently.

I ran lint locally (Compose studio project) and it seemed to cause studio to quickly pick up the lint jars, and start warning in IDE as well, so confirming that this workaround seems to work at least.

I recently submitted a change: https://cs.android.com/android-studio/platform/tools/adt/idea/+/37a77d7289824eae400262e804cf648d87a4b732

that should improve how Android Studio discovers/registers third party lint checks (from jars). It does not change anything on the Gradle/sync side, and I am not completely sure how it relates to checks that are provided as source, and need to be built. But it may help. It should be available in Meerkat Feature Drop Canary 8.