Fixed
Status Update
No update yet.
Comments
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit 59dd0c5754bf390e647c95572e2d146ee66d646f
Author: Chris Craik <ccraik@google.com>
Date: Fri Jul 16 14:38:11 2021
Append UI metadata to trace file directly, instead of load+append+write
Fixes: 193923003
Test: UiStateTest
Test: TrivialStartupBenchmark # verified UI metadata via Studio
Relnote: Reduce cost of appending Ui metadata to traces by 50+ ms
TIL - you can simply concatenate traces on disk, so appending got a
lot simpler.
From very simple logcat timing of TrivialStartupBenchmark, takes
average append from ~56ms to ~1ms, likely much larger difference for
longer tests.
Change-Id: Ic839003ca1a321d56dca7686db29cb3c00c67fc5
M benchmark/benchmark-macro/src/main/java/androidx/benchmark/macro/perfetto/UiState.kt
https://android-review.googlesource.com/1770019
Branch: androidx-main
commit 59dd0c5754bf390e647c95572e2d146ee66d646f
Author: Chris Craik <ccraik@google.com>
Date: Fri Jul 16 14:38:11 2021
Append UI metadata to trace file directly, instead of load+append+write
Fixes: 193923003
Test: UiStateTest
Test: TrivialStartupBenchmark # verified UI metadata via Studio
Relnote: Reduce cost of appending Ui metadata to traces by 50+ ms
TIL - you can simply concatenate traces on disk, so appending got a
lot simpler.
From very simple logcat timing of TrivialStartupBenchmark, takes
average append from ~56ms to ~1ms, likely much larger difference for
longer tests.
Change-Id: Ic839003ca1a321d56dca7686db29cb3c00c67fc5
M benchmark/benchmark-macro/src/main/java/androidx/benchmark/macro/perfetto/UiState.kt
Description
Lalit/Primiano clarified that we don't need to read the entire trace to add to it.
Local test shows this works fine, CL in a moment.