Status Update
Comments
al...@google.com <al...@google.com>
ca...@google.com <ca...@google.com> #2
Can you please double check the link to your git repository for the repro? It leads to a 404
da...@gmail.com <da...@gmail.com> #3
gs...@gmail.com <gs...@gmail.com> #4
After looking at the code, what surprises me is that it works on Android 12.
The correct way to achieve this is to never return false in the KeepOnScreenCondition
. Otherwise, the time between the condition being false and the new activity being visible will let the splash screen activity appear
The condition is evaluated for the current view tree only, so as soon as you start the next activity, it will be ignored and the splash screen will be removed.
we...@gmail.com <we...@gmail.com> #5
I'm marking this as working as intended, but please let me know if it doesn't work.
ju...@gmail.com <ju...@gmail.com> #6
As said above this is supposed to be available in the SplashScreen compat api as it claims that it renders the same on all versions of Android.
IMHO this ticket should be a bug like 204364858, not a feature.
ca...@google.com <ca...@google.com>
wi...@google.com <wi...@google.com> #7
I am afraid that we cannot support the windowSplashScreenBrandingImage for API < 31.
The position of branding image can be adjusting based on the display size, for example, framework will decide to not show it if there doesn't have enough space on the screen for it, so those calculation need to happen at runtime.
For API < 31 device, the support library will draw the icon on the splash screen window, however, and it can only support for static layout since at that time framework does not support this feature. If we want to support this attribute and force it to show at a specific position, user may saw it overlays the icon or out of screen on a small device.
If the branding image is really important, consider to use the attribute windowBackground for API <31 device.
ar...@gmail.com <ar...@gmail.com> #9
ca...@digitalchargingsolutions.com <ca...@digitalchargingsolutions.com> #10
So reading #7 this seems to be a wontfix, but it's still assigned? Can you please clarify this?
Even with the reasoning of "we can't backport it", the attr "windowSplashScreenBrandingImage" should still be available at the compat library, especially as the docs say "but we strongly recommend using the Androidx SplashScreen compat library instead."
wi...@google.com <wi...@google.com> #11
we should fix it, but haven't find time to do that.
su...@fisglobal.com <su...@fisglobal.com> #12
ca...@digitalchargingsolutions.com <ca...@digitalchargingsolutions.com> #13
Bump, it would be nice to have this worked on...
ki...@protonmail.com <ki...@protonmail.com> #14
af...@vexiza.com <af...@vexiza.com> #15
Since the inclusion of the SplashScreen is mandatory, and not being able to use a brand image... this limits the functionality that we had previously.
We have to implement actions not recommended in the documentation, such as having the SplashScreen and having a custom screen as well. No sense...
wi...@google.com <wi...@google.com>
es...@oracle.com <es...@oracle.com> #16
ca...@digitalchargingsolutions.com <ca...@digitalchargingsolutions.com> #17
Unfortunately the Splash Screen APIs (& the compat lib) are becoming a meme in the Android dev community...
It's strongly suggested we use this lib and then Google basically treats it as feature complete or deprecated (depends on how you see it) without ever having feature completed it. I don't want to only be negative, so hey, I and others would be happy if this would be improved :).
fa...@gmail.com <fa...@gmail.com> #18
jo...@gmail.com <jo...@gmail.com> #19
I'm using windowBackground
as a fallback as ?android:actionBarSize
.
Description
Component used: core-splashscreen Version used: 1.0.0 Devices/Android versions reproduced on: Samsung S10, Android 11
I'm trying to create a backwards compatible splash screen, I understand that from this documentation that:
However I don't seem to be able to use
windowSplashScreenBrandingImage
either as it's missing from the attrs file in the core-splashscreen library. Is this something that can be introduced in an update to the splashscreen library or will it also be unsupported pre-31?