windowSplashScreenBrandingImage missing from SplashScreen [194301890]

Assigned

Feature Request

core-splashscreen

Status Update

No update yet.

Description

sc...@gmail.com

created issue #1

Jul 22, 2021 11:13AM

Component used: core-splashscreen Version used: 1.0.0 Devices/Android versions reproduced on: Samsung S10, Android 11

I'm trying to create a backwards compatible splash screen, I understand that from this documentation that:

Prior API 31, the platform behavior is replicated with the exception of the Animated Vector Drawable support on the launch screen.

However I don't seem to be able to use windowSplashScreenBrandingImage either as it's missing from the attrs file in the core-splashscreen library. Is this something that can be introduced in an update to the splashscreen library or will it also be unsupported pre-31?

Comments

al...@google.com <al...@google.com> Jul 27, 2021 02:34PM

Reassigned to ca...@google.com.

ca...@google.com <ca...@google.com> #2Aug 2, 2021 12:20PM

The splash screen is dismissed as soon as the app is drawn and doesn't wait for the animation to finish which might be the reason why the animation doesn't repeat. At most, the icon will animate for the value set in windowSplashScreenAnimationDuration.

If that's not the case, can you please share your theme values and icon file? or at least a reproduction sample?

da...@gmail.com <da...@gmail.com> #3Oct 8, 2021 12:13PM

windowSplashScreenAnimationDuration is set 10000.
windowSplashScreenBackground is #fff and #000 for dark theme.

The animation duration of Animated Vector Drawable is 1600.

I might not be able to share the icon since it is the one we are going to use in production. Is there any working Animated Vector Drawable you can provide from your side for us to compare? Anything from unit test?

Message last modified on Oct 8, 2021 02:36PM

gs...@gmail.com <gs...@gmail.com> #4Oct 18, 2021 01:04PM

Here is the sample of Animated Vector Drawable. (Not the one mentioned earlier)

Message last modified on Oct 18, 2021 07:21PM

we...@gmail.com <we...@gmail.com> #5Oct 19, 2021 10:08AM

In the <objectAnimator tag, you need the repeat* attributes

<objectAnimator xmlns:android="http://schemas.android.com/apk/res/android"
    android:duration="1000"
    android:valueTo="200"
    android:valueType="floatType"
    android:propertyName="y"
    android:repeatCount="1"
    android:repeatMode="reverse"/>

https://developer.android.com/reference/android/animation/ObjectAnimator

ju...@gmail.com <ju...@gmail.com> #6Sep 22, 2022 09:59AM

It makes sense for objectAnimator that all have the same startOffset and duration. What if there are series of objectAnimator which have different startOffset as the attachment - test_anim_2.xml?

ca...@google.com <ca...@google.com> Sep 22, 2022 10:08AM

Reassigned to wi...@google.com.

wi...@google.com <wi...@google.com> #7Sep 22, 2022 01:34PM

test_anim_3.xml has the expected effect. However, I try to avoid creating lots of objectAnimator for repeating animator. It will be great, if core-splashscreen API can support it.

wi...@google.com <wi...@google.com> #8Sep 23, 2022 01:32AM

In that case, you'd need to manually make you application repeat using other ObjecAnimator. Since the splash screen is supposed to be short lived, an animation shouldn't need to be repeated. If the loading time of your application is too high and require the use of some progress indicator, then I suggest to implement that in the app directly, ideally using skeletons loaders (https://medium.com/android-dev-nation/android-skeleton-loaders-1ae979a9d8c9)

ar...@gmail.com <ar...@gmail.com> #9Nov 2, 2022 10:37PM

Understood. However, we still think it's useful to have core-splashscreen API support animation replay. Thank you!

ca...@digitalchargingsolutions.com <ca...@digitalchargingsolutions.com> #10Nov 17, 2022 11:57AM

That's definitely something worth discussing internally, I've added it to the list of thing to consider for the next version. Thanks for your feedback.

Message last modified on Nov 17, 2022 12:08PM

wi...@google.com <wi...@google.com> #11Nov 17, 2022 12:19PM

we should fix it, but haven't find time to do that.

su...@fisglobal.com <su...@fisglobal.com> #12Jan 20, 2023 01:15PM

Android has now made Splash screen mandatory and this is required for migrating existing apps. Can you please let us know when would this be fixed?

ca...@digitalchargingsolutions.com <ca...@digitalchargingsolutions.com> #13Mar 14, 2023 01:43PM

Bump, it would be nice to have this worked on...

ki...@protonmail.com <ki...@protonmail.com> #14Mar 24, 2023 05:20PM

It would be great to fix this issue, it's been 3 years :)

af...@vexiza.com <af...@vexiza.com> #15Apr 4, 2023 12:57PM

Is there an expected date when the problem will be fixed?

Since the inclusion of the SplashScreen is mandatory, and not being able to use a brand image... this limits the functionality that we had previously.
We have to implement actions not recommended in the documentation, such as having the SplashScreen and having a custom screen as well. No sense...

wi...@google.com <wi...@google.com> Apr 14, 2023 02:17AM

Reassigned to rg...@google.com.

es...@oracle.com <es...@oracle.com> #16Apr 29, 2023 02:09AM

Is there a date or timeframe when this fix will be implemented?

ca...@digitalchargingsolutions.com <ca...@digitalchargingsolutions.com> #17Aug 5, 2023 07:12AM

Unfortunately the Splash Screen APIs (& the compat lib) are becoming a meme in the Android dev community...

It's strongly suggested we use this lib and then Google basically treats it as feature complete or deprecated (depends on how you see it) without ever having feature completed it. I don't want to only be negative, so hey, I and others would be happy if this would be improved :).

Message last modified on Aug 5, 2023 07:12AM

fa...@gmail.com <fa...@gmail.com> #18Nov 17, 2023 09:24AM

For version 11 and earlier "android:windowBackground" is available, I tested it and it works fine.

jo...@gmail.com <jo...@gmail.com> #19Feb 27, 2024 08:59AM

I'm using windowBackground as a fallback as comment#18 mentioned, but don't know how to get the exact corner radius value of logo from the system like ?android:actionBarSize.