After upgrade to 7.0.0, R8 crashes with "Unexpected usage left in method after inline" error [195234829]

Verified

Bug

adexe s nau

Status Update

No update yet.

Description

jd...@xooloo.com

created issue #1

Aug 2, 2021 02:51PM

This is the same issues than #171302401 but it still occurs with stable release.

Actually, it is even more buggy, as it can't even give the right class name in the error message.

I tried to write a reduced test case available at https://github.com/Jean-Daniel/r8bug.git

Checkout.

./gradlew :jetpack:minifyReleaseWithR8

ERROR:/Users/jddupas/.gradle/caches/transforms-3/088f8f389b21611a76087e8b0a8842d7/transformed/jetified-tracing-1.0.0-runtime.jar: R8: com.android.tools.r8.internal.GG: Unexpected usage left in method `java.lang.CharSequence androidx.tracing.TraceApi18Impl.onChatEvent(com.xooloo.r8bug.model.messages.BaseMessage, com.xooloo.r8bug.messages.Components)` after inlining: Bg                   v49 <- v22; com.squareup.moshi.JsonAdapter$2

Comments

ch...@google.com <ch...@google.com> #2Aug 3, 2021 07:20AM

Reassigned to ch...@google.com.

Why is TwoRowsTopAppBar even private and not public... Related: STOP MAKING ALL USEFUL APIS INTERNAL

dump2247739737839044.zip

12 MB

Download

ch...@google.com <ch...@google.com> #3Aug 3, 2021 09:56AM

Added TwoRowsTopAppBar API here.

This should allow more flexibility when creating top app bars with two rows.

jd...@xooloo.com <jd...@xooloo.com> #4Aug 3, 2021 10:02AM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.compose.material3:material3:1.4.0-alpha07
androidx.compose.material3:material3-android:1.4.0-alpha07
androidx.compose.material3:material3-jvmstubs:1.4.0-alpha07
androidx.compose.material3:material3-linuxx64stubs:1.4.0-alpha07

ap...@google.com <ap...@google.com> #5Aug 4, 2021 07:52AM

Project: platform/frameworks/support
Branch: androidx-main
Author: Shalom Gibly <sgibly@google.com>
Link: https://android-review.googlesource.com/3478344

Update the TwoRowsTopAppBar API

Expand for full commit details

Update the TwoRowsTopAppBar API 
 
- Update the API to the feedback from the API council. 
- Remove the `expanded` lambda parameter and have a separate params for 
  the expanded and collapsed heights. 
 
Test: Updated 
Bug: 306697446 
Bug: 229134133 
Bug: 268068946 
Fixes: 394144086 
Relnote: "Updates to the TowRowsTopAppBar API. We removed the `expanded` 
lambda parameters and added separate parameters for the expanded and 
collapsed heights." 
 
Change-Id: Idd6777bc381871b9e77c040762c6bca7355cda8a

Files:

M compose/material3/material3/api/current.txt
M compose/material3/material3/api/restricted_current.txt
M compose/material3/material3/samples/src/main/java/androidx/compose/material3/samples/AppBarSamples.kt
M compose/material3/material3/src/androidInstrumentedTest/kotlin/androidx/compose/material3/AppBarTest.kt
M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/AppBar.kt

Hash: e414ed68307128f55615f1e482bee2212677098c
Date: Thu Feb 06 13:54:36 2025

ap...@google.com <ap...@google.com> #6Aug 4, 2021 11:19AM

Project: r8
Branch: 3.0

commit 6fb5ed05b6b3ba790724a53a5abda5981fd20cf1
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Wed Aug 04 10:45:24 2021

Version 3.0.64

Bug: 195234829
Bug: 195037294
Change-Id: Icacacbec15e6bfc9a5c5663bca12b3b06f21cb05

M src/main/java/com/android/tools/r8/Version.java

https://r8-review.googlesource.com/61865

ap...@google.com <ap...@google.com> #7Aug 4, 2021 11:19AM

Project: r8
Branch: 3.0

commit b933ad2432421e301aaeac32618dd756247f655e
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Wed Aug 04 10:44:32 2021

Unset class inliner method constraint after method specialization

Bug: 195234829
Change-Id: I51c36cc31e4209b25aa17a23232bb1ce88cb2cd4

M src/main/java/com/android/tools/r8/ir/optimize/info/OptimizationFeedbackSimple.java
M src/main/java/com/android/tools/r8/ir/optimize/info/UpdatableMethodOptimizationInfo.java
M src/main/java/com/android/tools/r8/ir/optimize/typechecks/CheckCastAndInstanceOfMethodSpecialization.java
A src/test/java/com/android/tools/r8/ir/optimize/classinliner/InstanceOfSpecializedMethodClassInlinerTest.java

https://r8-review.googlesource.com/61864

ap...@google.com <ap...@google.com> #8Aug 4, 2021 11:19AM

Project: r8
Branch: 2.2

commit 012bd3a37101c6bd659a094e68ccd77adb27c454
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Wed Aug 04 10:36:21 2021

Version 2.2.82

Bug: 195234829
Bug: 195037294
Change-Id: I3d7b82263e06197f1c5b97531aa9e751d5037606

M src/main/java/com/android/tools/r8/Version.java

https://r8-review.googlesource.com/61862

ap...@google.com <ap...@google.com> #9Aug 4, 2021 11:19AM

Project: r8
Branch: 2.2

commit eb6c5f9f058cd231bfefd92d65ed58762c3941f6
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Wed Aug 04 10:34:25 2021

Unset class inliner method constraint after method specialization

Bug: 195234829
Change-Id: I51c36cc31e4209b25aa17a23232bb1ce88cb2cd4

M src/main/java/com/android/tools/r8/ir/optimize/info/OptimizationFeedbackSimple.java
M src/main/java/com/android/tools/r8/ir/optimize/info/UpdatableMethodOptimizationInfo.java
M src/main/java/com/android/tools/r8/ir/optimize/typechecks/CheckCastAndInstanceOfMethodSpecialization.java
A src/test/java/com/android/tools/r8/ir/optimize/classinliner/InstanceOfSpecializedMethodClassInlinerTest.java

https://r8-review.googlesource.com/61861

ap...@google.com <ap...@google.com> #10Aug 4, 2021 11:20AM

https://r8-review.googlesource.com/61864

ch...@google.com <ch...@google.com> #11Aug 5, 2021 06:41AM

Verified by ch...@google.com.

This should now be fixed in R8 versions 2.2.82 and 3.0.64. You can build with 3.0.64 by making the following changes to build.gradle:

buildscript {
    repositories {
        maven {
            url 'https://storage.googleapis.com/r8-releases/raw'
        }
    }
    dependencies {
        classpath 'com.android.tools:r8:3.0.64'          // Must be before the Gradle Plugin for Android.
        classpath 'com.android.tools.build:gradle:X.Y.Z' // Your current AGP version.
     }
}