Fixed
Status Update
No update yet.
Comments
pa...@gmail.com
Related to
ad...@google.com
ad...@google.com
Project: platform/frameworks/support
Branch: androidx-main
Author: Marcello Galhardo <
Link:
Add MutableStateFlowSerializer for serializing MutableState
Expand for full commit details
Add `MutableStateFlowSerializer` for serializing `MutableState`
- Introduced an inline `MutableStateFlowSerializer` function to infer and retrieve the appropriate `KSerializer` for `MutableStateFlow` of a serializable type.
- Added an overload of `MutableStateFlowSerializer` that accepts an explicit `KSerializer` for the wrapped type, allowing for customizing the `KSerializer`.
- Implemented `MutableStateFlowSerializerImpl`, a private class that handles the serialization and deserialization logic for `MutableStateFlow`, delegating inner value processing to the provided `KSerializer`.
- Only `KSerializer<MutableStateFlow<T>>` is exposed; the `MutableStateFlowSerializerImpl` remains private.
RelNote: "Add `MutableStateFlowSerializer` for serializing `kotlinx.coroutines.flow.MutableStateFlow`."
Test: MutableStateFlowSerializerTest.kt
Fixes: 378895070
Change-Id: I6a8925772d2f124d2db4a83bff0062c1db0eb0fb
Files:
- M
savedstate/savedstate/api/current.txt - M
savedstate/savedstate/api/restricted_current.txt - M
savedstate/savedstate/bcv/native/current.txt - M
savedstate/savedstate/build.gradle - A
savedstate/savedstate/src/commonMain/kotlin/androidx/savedstate/serialization/serializers/MutableStateFlowSerializer.kt - A
savedstate/savedstate/src/commonTest/kotlin/androidx/savedstate/serialization/MutableStateFlowSerializerTest.kt
Hash: 3f45907910984f32745d62d9846e7083a3c75e4a
Date: Mon Jan 20 12:32:07 2025
pa...@gmail.com
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.savedstate:savedstate:1.3.0-alpha07androidx.savedstate:savedstate-android:1.3.0-alpha07androidx.savedstate:savedstate-desktop:1.3.0-alpha07androidx.savedstate:savedstate-iosarm64:1.3.0-alpha07androidx.savedstate:savedstate-iossimulatorarm64:1.3.0-alpha07androidx.savedstate:savedstate-iosx64:1.3.0-alpha07androidx.savedstate:savedstate-linuxarm64:1.3.0-alpha07androidx.savedstate:savedstate-linuxx64:1.3.0-alpha07androidx.savedstate:savedstate-macosarm64:1.3.0-alpha07androidx.savedstate:savedstate-macosx64:1.3.0-alpha07
ad...@google.com
We have passed this to the development team and will update this issue with more information as it becomes available.
ci...@gmail.com
We have the same problem.
We confirmed the reproduction of the phenomenon in the following environment.
■Android Build Version (go to Settings > About Device > Build Number (hold down to copy))
【Pixel4a (5G)】
・12.0.0 (SPB4.210715.011)：Reproduce[NG]★
・12.0.0 (SPB4.210715.014)：Reproduce[NG]★
(On earlier beta versions system did not displayed Approximate location dialog when targetSdkVersion was set to 30)
Since this issue has a great impact on the operation of the application, we want you to disclose the information.
We confirmed the reproduction of the phenomenon in the following environment.
■Android Build Version (go to Settings > About Device > Build Number (hold down to copy))
【Pixel4a (5G)】
・12.0.0 (SPB4.210715.011)：Reproduce[NG]★
・12.0.0 (SPB4.210715.014)：Reproduce[NG]★
(On earlier beta versions system did not displayed Approximate location dialog when targetSdkVersion was set to 30)
Since this issue has a great impact on the operation of the application, we want you to disclose the information.
[Deleted User] <[Deleted User]>
I am also facing the same issue i.e. my app is not targetting AOS 12 but still the system showed dialog with Approximate and Precise location, which ideally should only happen if the app is targetting AOS 12.
[Deleted User] <[Deleted User]>
This issue should be of high priority as it is of high impact to our apps on Playstore which are not targetting AOS 12. Following are my device's details
Device: Pixel4 XL
Build No: SPB4.210715.014
Device: Pixel4 XL
Build No: SPB4.210715.014
ad...@google.com
The issue has been fixed and it will be available in a future build.
ci...@gmail.com
The reply #9 says "fixed in a future build", but are you expecting a fix on Android 12 Beta?
It has a big impact, so we hope to fix it as soon as possible.
It has a big impact, so we hope to fix it as soon as possible.
sm...@gmail.com
This is still a bug in Beta 5 just released on Sept 8. I was expecting the fix to be in that release. Could you please confirm that this issue is actually fixed and whether or not the fix made the Beta 5 release?
I'm running: sdk_gphone64_x86_64-userdebug 12 SPB5.210812.003 7673742 dev-keys
I'm running: sdk_gphone64_x86_64-userdebug 12 SPB5.210812.003 7673742 dev-keys
po...@gmail.com
In Android 12 beta 4, Android 12 beta 4.1, and Android 12 beta 5, when you request location permission, you will be prompted to choose between exact location and approximate location, regardless of the "targetSdkVersion".
The behavior is different from the description of "https://developer.android.com/about/versions/12/approximate-location ".
It was working as documented until Android 12 beta 3.1.
Please bug fix.
The behavior is different from the description of "
It was working as documented until Android 12 beta 3.1.
Please bug fix.
ci...@gmail.com
As a result of checking the operation on Android 12 Beta5, this problem was not fixed, so the following ticket was issued.
Please check this ticket.
https://issuetracker.google.com/199304074
Please check this ticket.
al...@hotmail.com
Can we please get confirmation that the behaviour as of Beta 3 and earlier will be restored when the public Android 12 release drops?
This issue is marked as resolved, however it is still present in Beta 5, which means we can't verify our apps behaviour before the public release.
This issue is marked as resolved, however it is still present in Beta 5, which means we can't verify our apps behaviour before the public release.
pa...@gmail.com
As mentioned in earlier comments, the issue can still be reproduced on Beta 5 for a sample project available at https://github.com/PaulinaKornatowicz/LocationAndroid12Beta
I see that there are two other issues mentioning this problem on Beta 5 that were marked as duplicates - is it intentional that this bug was not fixed for Beta 5 but will be in the final release?
If I understand correctly, Beta 5 is a release candidate build that should be used for final testing of our applications, but right now I'm not sure what to expect in a final release and how I should prepare my application for handling location when my target is not set to support android 12
I see that there are two other issues mentioning this problem on Beta 5 that were marked as duplicates - is it intentional that this bug was not fixed for Beta 5 but will be in the final release?
If I understand correctly, Beta 5 is a release candidate build that should be used for final testing of our applications, but right now I'm not sure what to expect in a final release and how I should prepare my application for handling location when my target is not set to support android 12
[Deleted User] <[Deleted User]>
The issue is still reproducible on the current BETA Version which is quite concerning as all our apps on playstore are getting impacted.
Can you please provide an update as to when this fix will be incorporated in the builds?
Can you please provide an update as to when this fix will be incorporated in the builds?
el...@gmail.com
I am puzzled by the lack of feedback from the devs. This bug is a major issue for any app requesting fine location, and it will break the user experience. It is already extremely surprising that such a big issue passed through the test and became a regression in the beta cycle. It is even more surprising that there is no communication on which release it will be fixed.
We are close to the release of Android 12 and we still have no clue whether this bug will leak in the release or will be fixed. We have no Android image to test. For us, app developers, it is a not a minor issue that we can easily fix at the last minute.
ca...@gmail.com
Can we please have an update on this?
po...@gmail.com
> If your app targets Android 12 (API level 31) or higher,
> users can request that your app retrieve only approximate location information,
> even when your app requests the ACCESS_FINE_LOCATION runtime permission.
snip
In the official release version,
if an app with TargetSdkVersion less than 30 requests location permission,
the user cannot select an approximate location. Is it correct to understand that?
However, from the settings screen, the user can select/set the approximate location
regardless of the TargetSdkVersion, so make sure your app works even if the approximate
location is selected/set. Is that what you mean?
el...@gmail.com
Today, Android 12 is released based on beta 5. So it seems it has been released with a severely broken location dialog in compatibility mode. This is contradiction with the documentation and a regression from the previous betas. Despite a several months old report, no relevant feedback for the Android devs. This is just insanely wrong.
sa...@google.com
Reopened this since this is reproducible with stable version of Android S.
al...@hotmail.com
Could we please get an update on when this will be resolved? It's over 2 weeks now since the issue was re-opened, and this is impacting our production apps.
Thanks in advance for any update that you can give.
Thanks in advance for any update that you can give.
ad...@google.com
The issue has been fixed and it will be available in a future build.
ia...@gmail.com
Developers deserve more transparency here. Lack of visibility into changes during the beta program is understandable, but more detail should be given when Android 12 behavior is being altered after release.
Android 12 was released with the wrong behavior, but it was released. Developers were forced to incorporate the incorrect behavior into their apps.
Is there a mechanism that allows developers to know which behavior will be presented to a user?
When will this future build be released?
Thank you.
Android 12 was released with the wrong behavior, but it was released. Developers were forced to incorporate the incorrect behavior into their apps.
Is there a mechanism that allows developers to know which behavior will be presented to a user?
When will this future build be released?
Thank you.
ci...@gmail.com
We are disappointed that the status of this report has changed to "Fixed" again without explanation.
The following Issue Trackers have pointed out similar things, but they are all in "Assigned" status.
"https://issuetracker.google.com/issues/204794927 "
"https://issuetracker.google.com/issues/202569598 "
"https://issuetracker.google.com/issues/202043846 "
Why did only this report change to "Fixed"?
Android 12 has already been released, so a clear explanation is needed.
We think this is a serious problem.
Please investigate immediately and disclose additional information.
The following Issue Trackers have pointed out similar things, but they are all in "Assigned" status.
"
"
"
Why did only this report change to "Fixed"?
Android 12 has already been released, so a clear explanation is needed.
We think this is a serious problem.
Please investigate immediately and disclose additional information.
ad...@google.com
We have updated the docs :
ar...@electrosmart.app
I am just logging this sentence here for the record " If you try to request only ACCESS_FINE_LOCATION, the system ignores the request on some releases of Android 12." from https://developer.android.com/training/location/permissions#approximate-request
No detail is provided in what "some" really means. It is great to see how an unspecified behavior is explicitly acknowledge in the documentation.
No detail is provided in what "some" really means. It is great to see how an unspecified behavior is explicitly acknowledge in the documentation.
Description
Android Version: 12 Beta 4 (SPB4.210715.011)
Device: Pixel 3
Steps to reproduce:
Create new app with targetSdkVersion 30 and request ACCESS_FINE_LOCATION and ACCESS_COARSE_LOCATION location permissions
Expected result:
After requesting permissions, system should display old permission request dialog, like on Android 11
Actual result:
System showed dialog with Approximate and Precise location (screenshot attached) which should be available only after app targets Android 12, as described in here