IssueTracker

Issue with notification access code in core. Unclear where, but probably safe to assume NotificationCompat.

Note that this is a lint error and can be suppressed or lowered to warning-level on the client side. Lowering back to P2.

It's at

frameworks/support/core/core/src/main/java/androidx/core/app/NotificationManagerCompat.java:223: Error: When targeting Android 13 or higher, posting a permission requires holding the POST_NOTIFICATIONS permission [NotificationPermission]
            mNotificationManager.notify(tag, id, notification);
            ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

   Explanation for issues of type "NotificationPermission":
   When targeting Android 13 and higher, posting permissions requires holding
   the runtime permission android.permission.POST_NOTIFICATIONS.

Handling this as part of b/238790278.

I believe we still want to do this.

Pulling off BugJuggler so we can discuss this in weekly meeting.

Looking into whether this is really blocked on b/111253910.

Detected these failing tasks: [':annotation:annotation:compileKotlinJvm']
> Task :annotation:annotation:compileKotlinJvm
e: file://$SUPPORT/annotation/annotation/src/jvmMain/kotlin/androidx/annotation/Px.kt:28:1 This annotation is not applicable to target 'annotation class'
e: file://$SUPPORT/annotation/annotation/src/jvmMain/kotlin/androidx/annotation/RequiresApi.kt:52:5 This annotation is not applicable to target 'value parameter'
e: file://$SUPPORT/annotation/annotation/src/jvmMain/kotlin/androidx/annotation/RequiresApi.kt:54:5 This annotation is not applicable to target 'value parameter'
e: file://$SUPPORT/annotation/annotation/src/jvmMain/kotlin/androidx/annotation/RequiresExtension.kt:64:5 This annotation is not applicable to target 'value parameter'
e: file://$SUPPORT/annotation/annotation/src/jvmMain/kotlin/androidx/annotation/RequiresExtension.kt:66:5 This annotation is not applicable to target 'value parameter'

And we're immediately hit by this ourselves.

public annotation class RequiresApi(
    /**
     * The API level to require. Alias for [.api] which allows you to leave out the `api=` part.
     */
    @IntRange(from = 1) val value: Int = 1,
    /** The API level to require  */
    @IntRange(from = 1) val api: Int = 1
)

The annotation needs to be moved next to Int. This would be highly disruptive for clients.

Maybe we don't?

Or, at the very least, maybe we add TYPE_USE but don't remove the targets?

Please don't add type use to these annotations without also updating the lint analysis to support/check on types.

without also updating the lint analysis to support/check on types.

Lint team would need to do that, but I'm happy to provide motivation. We have a parallel bug for Metalava that my team would be handling.

Or, at the very least, maybe we add TYPE_USE but don't remove the targets?

We could consider adding TYPE_USE, implementing a lint check with auto-fix to migrate, and effectively "deprecating" the other targets. It would still be extremely disruptive, though. And we'd be on the hook for migrating google3, which would be somewhere between difficult and impossible.

Lint team would need to do that, but I'm happy to provide motivation. We have a parallel bug for Metalava that my team would be handling.

Right -- just making it clear that this isn't currently in the plans from the lint team, so let's not update the public annotations with type use and then leaving tools support as TODO, since the primary purpose of these annotations is enforcement.

Putting this on the backburner again. There are still some big questions around whether this is a good idea given the trade-offs around (1) disrupting clients and (2) ownership in g3.

We have an owner and time scheduled for the blocking issue, so this is likely to make progress in Q3.

Right -- just making it clear that this isn't currently in the plans from the lint team, so let's not update the public annotations with type use and then leaving tools support as TODO, since the primary purpose of these annotations is enforcement.

Unclear what we'll do about lint, though. Tor, I'm finding a couple of bugs filed against Lint public component that touch on type annotations but nothing that's obviously "implement support for TYPE." Is there an existing bug that I can use as blocking, or do you want a new one?

Related with

• b/209843426
• https://youtrack.jetbrains.com/issue/KT-48900
• https://youtrack.jetbrains.com/issue/KT-67981

Since Kotlin 1.6, kotlin compiler warns when use androidx.annotation in Container types. Also, Since kotlin 2.0, kotlin compiler warning cannot be suppressed and it looks that Kotlin compiler team will not provide workaround to suppress.