core-splashscreen: Set postSplashScreenTheme programmatically [197150004]

Fixed

Bug

core-splashscreen

Status Update

No update yet.

Description

ma...@gmail.com

created issue #1

Aug 19, 2021 05:59PM

Component used: core-splashscreen

Version used: 1.0.0-alpha01

Devices/Android versions reproduced on: Pixel 4a (Android 11)

We set our app theme programmatically based on user preference, loaded from shared preferences at startup. Pre-Android 12 we called context.setTheme() before setContentView(), but with the Splash Screen library we lose control over this since SplashScreen.setPostSplashScreenTheme() reads the postSplashScreenTheme attribute directly from the theme. We can add a dark mode implementation in values-night but still it only follows the system dark mode and cannot respect an app-level user preference to force a dark theme.

It would be nice to have a callback like setOnExitAnimationListener or a mutable property on SplashScreen to allow setting the postSplashScreenTheme programmatically.

Comments

al...@google.com <al...@google.com> Aug 19, 2021 06:04PM

Reassigned to ca...@google.com.

vi...@gmail.com <vi...@gmail.com> #2Aug 19, 2021 06:35PM

The splash screen is dismissed as soon as the app is drawn and doesn't wait for the animation to finish which might be the reason why the animation doesn't repeat. At most, the icon will animate for the value set in windowSplashScreenAnimationDuration.

If that's not the case, can you please share your theme values and icon file? or at least a reproduction sample?

Message last modified on Aug 19, 2021 06:37PM

ca...@google.com <ca...@google.com> #3Aug 19, 2021 07:22PM

windowSplashScreenAnimationDuration is set 10000.
windowSplashScreenBackground is #fff and #000 for dark theme.

The animation duration of Animated Vector Drawable is 1600.

I might not be able to share the icon since it is the one we are going to use in production. Is there any working Animated Vector Drawable you can provide from your side for us to compare? Anything from unit test?

vi...@gmail.com <vi...@gmail.com> #4Aug 19, 2021 07:53PM

Here is the sample of Animated Vector Drawable. (Not the one mentioned earlier)

ca...@google.com <ca...@google.com> Oct 4, 2021 05:32PM

Marked as fixed.

ma...@gmail.com <ma...@gmail.com> #5Oct 17, 2022 09:21PM

In the <objectAnimator tag, you need the repeat* attributes

<objectAnimator xmlns:android="http://schemas.android.com/apk/res/android"
    android:duration="1000"
    android:valueTo="200"
    android:valueType="floatType"
    android:propertyName="y"
    android:repeatCount="1"
    android:repeatMode="reverse"/>

https://developer.android.com/reference/android/animation/ObjectAnimator

Issue 197150004