Sluggish painting performance in the new project template chooser [197882517]

Fixed

Bug

Status Update

No update yet.

Description

tn...@google.com

created issue #1

Aug 26, 2021 08:11PM

Using BB canary 10, I noticed that when I open the new project wizard and scroll around the graphics performance is very sluggish. I checked the process monitor and nothing else is running. I grabbed a thread dump and it shows a lot of busy painting -- thread dump below.

Build: AI-211.7628.21.2111.7667256, 202108231940,

AI-211.7628.21.2111.7667256, JRE 11.0.11+0-b60-7590822x64 JetBrains s.r.o., OS Mac OS X(x86_64) v11.5.1, screens 3840.0x2160.0; Retina

AS: Bumblebee | 2021.1.1 Canary 10; Kotlin plugin: 211-1.5.20-release-284-AS7442.40; Android Gradle Plugin: (plugin information not found); Gradle: 7.2; Gradle JDK: version 11.0.11; NDK: from local.properties: (not specified), latest from SDK: (not found); LLDB: pinned revision 3.1 not found, latest from SDK: (package not found); CMake: from local.properties: (not specified), latest from SDK: 3.18.1-g262b901, from PATH: (not found)

IMPORTANT: Please read https://developer.android.com/studio/report-bugs.html carefully and supply all required information.

"AWT-EventQueue-0" #26 prio=6 os_prio=31 cpu=36109.00ms elapsed=90.96s tid=0x00007f9f39876000 nid=0x10803 runnable  [0x0000700009dc2000]
   java.lang.Thread.State: RUNNABLE
	at sun.java2d.loops.TransformHelper.Transform(java.desktop@11.0.11/Native Method)
	at sun.java2d.pipe.DrawImage.renderImageXform(java.desktop@11.0.11/DrawImage.java:499)
	at sun.java2d.pipe.DrawImage.transformImage(java.desktop@11.0.11/DrawImage.java:264)
	at sun.java2d.pipe.DrawImage.scaleImage(java.desktop@11.0.11/DrawImage.java:124)
	at sun.java2d.pipe.DrawImage.scaleImage(java.desktop@11.0.11/DrawImage.java:1063)
	at sun.java2d.pipe.ValidatePipe.scaleImage(java.desktop@11.0.11/ValidatePipe.java:207)
	at sun.java2d.SunGraphics2D.drawImage(java.desktop@11.0.11/SunGraphics2D.java:3386)
	at sun.java2d.SunGraphics2D.drawImage(java.desktop@11.0.11/SunGraphics2D.java:3324)
	at org.imgscalr.Scalr.scaleImage(Scalr.java:2140)
	at org.imgscalr.Scalr.resize(Scalr.java:1694)
	at com.intellij.util.ImageLoader.scaleImage(ImageLoader.java:494)
	at com.intellij.util.ImageLoader.convertImage(ImageLoader.java:381)
	at com.intellij.util.ImageLoader.loadImage(ImageLoader.java:159)
	at com.intellij.openapi.util.IconLoader$ImageDataResolverImpl.loadImage(IconLoader.java:1173)
	at com.intellij.openapi.util.IconLoader$CachedImageIcon.loadImage(IconLoader.java:936)
	at com.intellij.openapi.util.IconLoader$ScaledIconCache.getOrScaleIcon(IconLoader.java:1005)
	at com.intellij.openapi.util.IconLoader$CachedImageIcon.getRealIcon(IconLoader.java:824)
	- locked <0x00000007d73509c0> (a java.lang.Object)
	at com.intellij.openapi.util.IconLoader$CachedImageIcon.paintIcon(IconLoader.java:746)
	at com.android.tools.idea.npw.ui.TemplateIcon.paintIcon(TemplateIcon.kt:49)
	at com.intellij.util.IconUtil.paintScaled(IconUtil.java:536)
	at com.intellij.util.IconUtil$3.paintIcon(IconUtil.java:509)
	at javax.swing.plaf.basic.BasicLabelUI.paint(java.desktop@11.0.11/BasicLabelUI.java:185)
	at javax.swing.plaf.ComponentUI.update(java.desktop@11.0.11/ComponentUI.java:161)
	at javax.swing.JComponent.paintComponent(java.desktop@11.0.11/JComponent.java:800)
	at javax.swing.JComponent.paint(java.desktop@11.0.11/JComponent.java:1077)
	at javax.swing.JComponent.paintChildren(java.desktop@11.0.11/JComponent.java:910)
	- locked <0x00000007b38001a8> (a java.awt.Component$AWTTreeLock)
	at javax.swing.JComponent.paint(java.desktop@11.0.11/JComponent.java:1086)
	at javax.swing.CellRendererPane.paintComponent(java.desktop@11.0.11/CellRendererPane.java:165)
	at javax.swing.plaf.basic.BasicListUI.paintCell(java.desktop@11.0.11/BasicListUI.java:288)
	at com.intellij.ui.components.WideSelectionListUI.paintCell(WideSelectionListUI.java:65)
	at javax.swing.plaf.basic.BasicListUI.paintImpl(java.desktop@11.0.11/BasicListUI.java:378)
	at javax.swing.plaf.basic.BasicListUI.paint(java.desktop@11.0.11/BasicListUI.java:301)
	at com.intellij.ui.components.WideSelectionListUI.paint(WideSelectionListUI.java:34)
	at javax.swing.plaf.ComponentUI.update(java.desktop@11.0.11/ComponentUI.java:161)
	at javax.swing.JComponent.paintComponent(java.desktop@11.0.11/JComponent.java:800)
	at com.intellij.ui.components.JBList.paintComponent(JBList.java:174)
	at javax.swing.JComponent.paint(java.desktop@11.0.11/JComponent.java:1077)
	at com.intellij.ui.components.JBList.paint(JBList.java:106)
	at javax.swing.JComponent.paintChildren(java.desktop@11.0.11/JComponent.java:910)
	- locked <0x00000007b38001a8> (a java.awt.Component$AWTTreeLock)
	at javax.swing.JComponent.paint(java.desktop@11.0.11/JComponent.java:1086)
	at javax.swing.JViewport.paint(java.desktop@11.0.11/JViewport.java:737)
	at com.intellij.ui.components.JBViewport.paint(JBViewport.java:237)
	at javax.swing.JComponent.paintChildren(java.desktop@11.0.11/JComponent.java:910)
	- locked <0x00000007b38001a8> (a java.awt.Component$AWTTreeLock)
	at javax.swing.JComponent.paint(java.desktop@11.0.11/JComponent.java:1086)
	at javax.swing.JComponent.paintToOffscreen(java.desktop@11.0.11/JComponent.java:5263)
	at javax.swing.BufferStrategyPaintManager.paint(java.desktop@11.0.11/BufferStrategyPaintManager.java:246)
	at javax.swing.RepaintManager.paint(java.desktop@11.0.11/RepaintManager.java:1333)
	at javax.swing.JComponent._paintImmediately(java.desktop@11.0.11/JComponent.java:5211)
	at javax.swing.JComponent.paintImmediately(java.desktop@11.0.11/JComponent.java:5021)
	at javax.swing.RepaintManager$4.run(java.desktop@11.0.11/RepaintManager.java:868)
	at javax.swing.RepaintManager$4.run(java.desktop@11.0.11/RepaintManager.java:851)
	at java.security.AccessController.doPrivileged(java.base@11.0.11/Native Method)
	at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(java.base@11.0.11/ProtectionDomain.java:85)
	at javax.swing.RepaintManager.paintDirtyRegions(java.desktop@11.0.11/RepaintManager.java:851)
	at javax.swing.RepaintManager.paintDirtyRegions(java.desktop@11.0.11/RepaintManager.java:826)
	at javax.swing.RepaintManager.prePaintDirtyRegions(java.desktop@11.0.11/RepaintManager.java:775)
	at javax.swing.RepaintManager$ProcessingRunnable.run(java.desktop@11.0.11/RepaintManager.java:1901)
	at java.awt.event.InvocationEvent.dispatch(java.desktop@11.0.11/InvocationEvent.java:313)
	at java.awt.EventQueue.dispatchEventImpl(java.desktop@11.0.11/EventQueue.java:776)
	at java.awt.EventQueue$4.run(java.desktop@11.0.11/EventQueue.java:727)
	at java.awt.EventQueue$4.run(java.desktop@11.0.11/EventQueue.java:721)
	at java.security.AccessController.doPrivileged(java.base@11.0.11/Native Method)
	at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(java.base@11.0.11/ProtectionDomain.java:85)
	at java.awt.EventQueue.dispatchEvent(java.desktop@11.0.11/EventQueue.java:746)
	at com.intellij.ide.IdeEventQueue.defaultDispatchEvent(IdeEventQueue.java:969)
	at com.intellij.ide.IdeEventQueue._dispatchEvent(IdeEventQueue.java:839)
	at com.intellij.ide.IdeEventQueue.lambda$dispatchEvent$8(IdeEventQueue.java:449)
	at com.intellij.ide.IdeEventQueue$$Lambda$664/0x0000000800764c40.compute(Unknown Source)
	at com.intellij.openapi.progress.impl.CoreProgressManager.computePrioritized(CoreProgressManager.java:808)
	at com.intellij.ide.IdeEventQueue.lambda$dispatchEvent$9(IdeEventQueue.java:448)
	at com.intellij.ide.IdeEventQueue$$Lambda$663/0x0000000800766440.run(Unknown Source)
	at com.intellij.ide.IdeEventQueue.dispatchEvent(IdeEventQueue.java:492)
	at java.awt.EventDispatchThread.pumpOneEventForFilters(java.desktop@11.0.11/EventDispatchThread.java:203)
	at java.awt.EventDispatchThread.pumpEventsForFilter(java.desktop@11.0.11/EventDispatchThread.java:124)
	at java.awt.EventDispatchThread.pumpEventsForFilter(java.desktop@11.0.11/EventDispatchThread.java:117)
	at java.awt.WaitDispatchSupport$2.run(java.desktop@11.0.11/WaitDispatchSupport.java:190)
	at java.awt.WaitDispatchSupport$4.run(java.desktop@11.0.11/WaitDispatchSupport.java:235)
	at java.awt.WaitDispatchSupport$4.run(java.desktop@11.0.11/WaitDispatchSupport.java:233)
	at java.security.AccessController.doPrivileged(java.base@11.0.11/Native Method)
	at java.awt.WaitDispatchSupport.enter(java.desktop@11.0.11/WaitDispatchSupport.java:233)
	at java.awt.Dialog.show(java.desktop@11.0.11/Dialog.java:1063)
	at com.intellij.openapi.ui.impl.DialogWrapperPeerImpl$MyDialog.show(DialogWrapperPeerImpl.java:694)
	at com.intellij.openapi.ui.impl.DialogWrapperPeerImpl.show(DialogWrapperPeerImpl.java:436)
	at com.intellij.openapi.ui.DialogWrapper.doShow(DialogWrapper.java:1702)
	at com.intellij.openapi.ui.DialogWrapper.show(DialogWrapper.java:1661)
	at com.android.tools.idea.actions.AndroidNewProjectAction.actionPerformed(AndroidNewProjectAction.kt:50)
	at com.intellij.openapi.actionSystem.ex.ActionUtil.lambda$performActionDumbAware$5(ActionUtil.java:273)
	at com.intellij.openapi.actionSystem.ex.ActionUtil$$Lambda$1700/0x0000000801399440.run(Unknown Source)
	at com.intellij.util.SlowOperations.lambda$allowSlowOperations$0(SlowOperations.java:77)
	at com.intellij.util.SlowOperations$$Lambda$1564/0x000000080128a840.compute(Unknown Source)
	at com.intellij.util.SlowOperations.allowSlowOperations(SlowOperations.java:64)
	at com.intellij.util.SlowOperations.allowSlowOperations(SlowOperations.java:76)
	at com.intellij.openapi.actionSystem.ex.ActionUtil.performActionDumbAware(ActionUtil.java:273)
	at com.intellij.openapi.actionSystem.ex.ActionUtil.performActionDumbAwareWithCallbacks(ActionUtil.java:267)
	at com.intellij.openapi.wm.impl.welcomeScreen.WelcomeScreenActionsUtil.performAnActionForComponent(WelcomeScreenActionsUtil.java:96)
	at com.intellij.openapi.wm.impl.welcomeScreen.WelcomeScreenActionsUtil$ToolbarTextButtonWrapper$1.actionPerformed(WelcomeScreenActionsUtil.java:56)
	at javax.swing.AbstractButton.fireActionPerformed(java.desktop@11.0.11/AbstractButton.java:1967)
	at javax.swing.AbstractButton$Handler.actionPerformed(java.desktop@11.0.11/AbstractButton.java:2308)
	at javax.swing.DefaultButtonModel.fireActionPerformed(java.desktop@11.0.11/DefaultButtonModel.java:405)
	at javax.swing.DefaultButtonModel.setPressed(java.desktop@11.0.11/DefaultButtonModel.java:262)
	at javax.swing.plaf.basic.BasicButtonListener.mouseReleased(java.desktop@11.0.11/BasicButtonListener.java:270)
	at java.awt.Component.processMouseEvent(java.desktop@11.0.11/Component.java:6652)
	at javax.swing.JComponent.processMouseEvent(java.desktop@11.0.11/JComponent.java:3345)
	at java.awt.Component.processEvent(java.desktop@11.0.11/Component.java:6417)
	at java.awt.Container.processEvent(java.desktop@11.0.11/Container.java:2263)
	at java.awt.Component.dispatchEventImpl(java.desktop@11.0.11/Component.java:5027)
	at java.awt.Container.dispatchEventImpl(java.desktop@11.0.11/Container.java:2321)
	at java.awt.Component.dispatchEvent(java.desktop@11.0.11/Component.java:4859)
	at java.awt.LightweightDispatcher.retargetMouseEvent(java.desktop@11.0.11/Container.java:4918)
	at java.awt.LightweightDispatcher.processMouseEvent(java.desktop@11.0.11/Container.java:4547)
	at java.awt.LightweightDispatcher.dispatchEvent(java.desktop@11.0.11/Container.java:4488)
	at java.awt.Container.dispatchEventImpl(java.desktop@11.0.11/Container.java:2307)
	at java.awt.Window.dispatchEventImpl(java.desktop@11.0.11/Window.java:2784)
	at java.awt.Component.dispatchEvent(java.desktop@11.0.11/Component.java:4859)
	at java.awt.EventQueue.dispatchEventImpl(java.desktop@11.0.11/EventQueue.java:778)
	at java.awt.EventQueue$4.run(java.desktop@11.0.11/EventQueue.java:727)
	at java.awt.EventQueue$4.run(java.desktop@11.0.11/EventQueue.java:721)
	at java.security.AccessController.doPrivileged(java.base@11.0.11/Native Method)
	at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(java.base@11.0.11/ProtectionDomain.java:85)
	at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(java.base@11.0.11/ProtectionDomain.java:95)
	at java.awt.EventQueue$5.run(java.desktop@11.0.11/EventQueue.java:751)
	at java.awt.EventQueue$5.run(java.desktop@11.0.11/EventQueue.java:749)
	at java.security.AccessController.doPrivileged(java.base@11.0.11/Native Method)
	at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(java.base@11.0.11/ProtectionDomain.java:85)
	at java.awt.EventQueue.dispatchEvent(java.desktop@11.0.11/EventQueue.java:748)
	at com.intellij.ide.IdeEventQueue.defaultDispatchEvent(IdeEventQueue.java:969)
	at com.intellij.ide.IdeEventQueue.dispatchMouseEvent(IdeEventQueue.java:906)
	at com.intellij.ide.IdeEventQueue._dispatchEvent(IdeEventQueue.java:836)
	at com.intellij.ide.IdeEventQueue.lambda$dispatchEvent$8(IdeEventQueue.java:449)
	at com.intellij.ide.IdeEventQueue$$Lambda$664/0x0000000800764c40.compute(Unknown Source)
	at com.intellij.openapi.progress.impl.CoreProgressManager.computePrioritized(CoreProgressManager.java:808)
	at com.intellij.ide.IdeEventQueue.lambda$dispatchEvent$9(IdeEventQueue.java:448)
	at com.intellij.ide.IdeEventQueue$$Lambda$663/0x0000000800766440.run(Unknown Source)
	at com.intellij.openapi.application.impl.ApplicationImpl.runIntendedWriteActionOnCurrentThread(ApplicationImpl.java:787)
	at com.intellij.ide.IdeEventQueue.dispatchEvent(IdeEventQueue.java:502)
	at java.awt.EventDispatchThread.pumpOneEventForFilters(java.desktop@11.0.11/EventDispatchThread.java:203)
	at java.awt.EventDispatchThread.pumpEventsForFilter(java.desktop@11.0.11/EventDispatchThread.java:124)
	at java.awt.EventDispatchThread.pumpEventsForHierarchy(java.desktop@11.0.11/EventDispatchThread.java:113)
	at java.awt.EventDispatchThread.pumpEvents(java.desktop@11.0.11/EventDispatchThread.java:109)
	at java.awt.EventDispatchThread.pumpEvents(java.desktop@11.0.11/EventDispatchThread.java:101)
	at java.awt.EventDispatchThread.run(java.desktop@11.0.11/EventDispatchThread.java:90)

Comments

tn...@google.com <tn...@google.com> #2Aug 26, 2021 08:12PM

(To be clear I notice this when I'm trying to scroll -- the frame rate is like 2-3 fps.)

rp...@google.com <rp...@google.com> Aug 26, 2021 08:14PM

Assigned to pa...@google.com.

tn...@google.com <tn...@google.com> #3Aug 26, 2021 08:35PM

Random guess -- did we add an svg icon into one of the templates which now requires expensive rasterization?

di...@google.com <di...@google.com> #4Sep 14, 2021 04:16PM

The issue seems to be Mac specific. In Linux, the scrolling seems to be much better.

di...@google.com <di...@google.com> #5Sep 14, 2021 04:28PM

Disabling all new templates does not seem to make any difference. I do not see any svg thumbnails in the code but Jose can confirm.

tn...@google.com <tn...@google.com> #6Sep 14, 2021 04:41PM

What about size? Are all the icons reasonable size? (I tried to look in the codebase but I can't find the template content :-) )

di...@google.com <di...@google.com> #7Sep 14, 2021 04:42PM

This might have been a platform change. The main time drain seems to be the scaling in TemplateIcon.paintIcon but this code has not changed in quite a while. The scale is 1.0, and ignoring the scaling operation with that scale, makes the dialog usable (like 20-30 FPS).

di...@google.com <di...@google.com> #8Sep 14, 2021 04:43PM

scaling during the paintIcon is probably not ideal, so maybe we should cache the scaling operation in TemplateIcon.

tn...@google.com <tn...@google.com> #9Sep 15, 2021 01:22AM

ag/15832434 appears to fix it here

tn...@google.com <tn...@google.com> #10Sep 15, 2021 02:33PM

Marked as fixed.

Fixed in Bumblebee.

sa...@google.com <sa...@google.com> #11Sep 30, 2021 03:42PM

Thank you for your patience while our engineering team worked to resolve this issue. A fix for this issue is now available in:

Android Studio Bumblebee Canary 13 (2021.1.1.13)
Android Gradle Plugin 7.1.0-alpha13

We encourage you to try the latest update.

If you notice further issues or have questions, please file a new bug report.

Thank you for taking the time to submit feedback — we really appreciate it!