Enabling both KSP and Kapt in a project with both containing processors that generate sources breaks BundleLibraryClassesInputs [198667126]

Fixed

Bug

Status Update

No update yet.

Description

zs...@salesforce.com

created issue #1

Sep 3, 2021 02:48PM

DESCRIBE THE ISSUE IN DETAIL: Having multiple tasks/dirs contributing META-INF/proguard directories appears to break BundleLibraryClassesInputs

STEPS TO REPRODUCE:

Enable KSP and Kapt in a project
Add some auto-value-moshi classes for kapt code gen and plain kotlin data classes using @JsonClass(generateAdapter = true) for use with moshi-ksp code gen
Run the bundleLibRuntimeToDirRelease task and observe this failure

[2021-08-28T01:45:53.750Z] FAILURE: Build failed with an exception.

[2021-08-28T01:45:53.750Z] 

[2021-08-28T01:45:53.750Z] * What went wrong:

[2021-08-28T01:45:53.750Z] Execution failed for task ':libraries:model:bundleLibRuntimeToDirRelease'.

[2021-08-28T01:45:53.750Z] > A failure occurred while executing com.android.build.gradle.internal.tasks.BundleLibraryClassesWorkAction

[2021-08-28T01:45:53.750Z]    > /mnt/tmp/android-dev/libraries/model/build/intermediates/runtime_library_classes_dir/release/META-INF/proguard

...

[2021-08-28T01:45:53.760Z] Caused by: java.nio.file.DirectoryNotEmptyException: /mnt/tmp/android-dev/libraries/model/build/intermediates/runtime_library_classes_dir/release/META-INF/proguard

[2021-08-28T01:45:53.760Z] 	at com.android.utils.FileUtils.copyFile(FileUtils.java:151)

[2021-08-28T01:45:53.760Z] 	at com.android.utils.FileUtils.copyFile(FileUtils.java:133)

[2021-08-28T01:45:53.761Z] 	at com.android.utils.FileUtils.copyFile(FileUtils.java:116)

[2021-08-28T01:45:53.761Z] 	at com.android.build.gradle.internal.tasks.BundleLibraryClassesWorkAction.copyFilesNonIncrementally(BundleLibraryClasses.kt:372)

[2021-08-28T01:45:53.761Z] 	at com.android.build.gradle.internal.tasks.BundleLibraryClassesWorkAction.run(BundleLibraryClasses.kt:315)

[2021-08-28T01:45:53.761Z] 	at com.android.build.gradle.internal.profile.ProfileAwareWorkAction.execute(ProfileAwareWorkAction.kt:74)

In some testing with Ivan to print the classes property in a doFirst block

build/intermediates/javac/release/classes - no META-INF/proguard dir
build/tmp/kotlin-classes/release - no, only containing a META-INF/... .kotlin_module  file
build/tmp/kapt3/classes/release - yes, containing generated proguard files for moshi
build/generated/ksp/release/resources - yes, containing generated proguard files for moshi

the build/intermediates/runtime_library_classes_dir/release/META-INF/proguard dir it's complaining about not being empty only contains the kapt-generated proguard files though, interestingly. This is also the case without KSP too (not empty)

Studio Build: N/A
Version of Gradle Plugin: 7.0.2
Version of Gradle: 7.2
Version of Java: 16.0.3
OS: macOS Big Sur

Comments

ga...@google.com <ga...@google.com> #2Sep 3, 2021 03:03PM

Assigned to ga...@google.com.

Using the attached project and running ./gradlew bundleLibRuntimeToDirRelease -s fails with

Caused by: java.nio.file.DirectoryNotEmptyException: /home/gavra/AndroidStudioProjects/MyApplication75/mylibrary/build/intermediates/runtime_library_classes_dir/release/META-INF/proguard
        at com.android.utils.FileUtils.copyFile(FileUtils.java:151)
        at com.android.utils.FileUtils.copyFile(FileUtils.java:133)
        at com.android.utils.FileUtils.copyFile(FileUtils.java:116)
        at com.android.build.gradle.internal.tasks.BundleLibraryClassesWorkAction.copyFilesNonIncrementally(BundleLibraryClasses.kt:377)

This is caused by

  libraryVariants.all {
        it.registerPreJavacGeneratedBytecode(project.files("input1"))
        it.registerPreJavacGeneratedBytecode(project.files("input2"))
    }

where these dirs contain input1/META-INF/proguard/1.txt and input2/META-INF/proguard/2.txt.

rules_merge.zip

118 KB

Download

ga...@google.com <ga...@google.com> #3Sep 16, 2021 04:17PM

Marked as fixed.

This will be fixed in the next versions of AGP 7.1 and 7.2.

Change: I848cd0ef3623dd3a55d53e9c7ac4e316ee276a6d

zs...@salesforce.com <zs...@salesforce.com> #4Sep 16, 2021 08:09PM

If there's a 7.0.3, could it be CP'd into that?

ga...@google.com <ga...@google.com> #5Sep 21, 2021 08:35AM

The fix will also be released with AGP 7.0.3, thanks for the report!

zs...@salesforce.com <zs...@salesforce.com> #6Sep 21, 2021 03:17PM

Thank you!!

On Tue, Sep 21, 2021 at 4:36 AM <buganizer-system@google.com> wrote:

- Show quoted text -

sa...@google.com <sa...@google.com> #7Sep 30, 2021 03:42PM

Thank you for your patience while our engineering team worked to resolve this issue. A fix for this issue is now available in:

Android Studio Bumblebee Canary 13 (2021.1.1.13)
Android Gradle Plugin 7.1.0-alpha13

We encourage you to try the latest update.

If you notice further issues or have questions, please file a new bug report.

Thank you for taking the time to submit feedback — we really appreciate it!

ch...@gmail.com <ch...@gmail.com> #8Sep 30, 2021 04:47PM

No 7.0.x release?

On Thu, Sep 30, 2021 at 9:43 AM <buganizer-system@google.com> wrote:

- Show quoted text -

ga...@google.com <ga...@google.com> #9Sep 30, 2021 04:51PM

The fix will also land in 7.0.3 which should be released soon. The update in #7 is just about the already released versions.

ch...@gmail.com <ch...@gmail.com> #10Sep 30, 2021 06:39PM

Cool, thank you.

On Thu, Sep 30, 2021 at 10:51 AM <buganizer-system@google.com> wrote:

- Show quoted text -

Issue 198667126

Description

Issue summary

Comments

ga...@google.com <ga...@google.com> #2Sep 3, 2021 03:03PM

ga...@google.com <ga...@google.com> #3Sep 16, 2021 04:17PM

zs...@salesforce.com <zs...@salesforce.com> #4Sep 16, 2021 08:09PM

ga...@google.com <ga...@google.com> #5Sep 21, 2021 08:35AM

zs...@salesforce.com <zs...@salesforce.com> #6Sep 21, 2021 03:17PM

sa...@google.com <sa...@google.com> #7Sep 30, 2021 03:42PM

ch...@gmail.com <ch...@gmail.com> #8Sep 30, 2021 04:47PM

ga...@google.com <ga...@google.com> #9Sep 30, 2021 04:51PM

ch...@gmail.com <ch...@gmail.com> #10Sep 30, 2021 06:39PM

Add comment

Issue metadata