Fixed

Process

Status Update

No update yet.

Description

al...@google.com

created issue #1

Nov 2, 2021 08:57PM

The following lint check is baseline suppressed in your project. Please remove all instances of this suppression from camera/camera-core/lint-baseline.xml and address the associated issues before your next stable release.

30 instance(s) of `SupportAnnotationUsage`

The API level is already known to be at least 21 here from outer annotations

Found in src/main/java/androidx/camera/core/AndroidImageProxy.java at line 101:
```
@RequiresApi(21) // TODO(b/200306659): Remove and replace with annotation on package-info.java
~~~~~~~~~~~~~~~~
```
The API level is already known to be at least 21 here from outer annotations

Found in src/main/java/androidx/camera/core/CameraControl.java at line 192:
```
@RequiresApi(21) // TODO(b/200306659): Remove and replace with annotation on package-info.java
~~~~~~~~~~~~~~~~
```
The API level is already known to be at least 21 here from outer annotations

Found in src/main/java/androidx/camera/core/CameraSelector.java at line 194:
```
@RequiresApi(21) // TODO(b/200306659): Remove and replace with annotation on package-info.java
~~~~~~~~~~~~~~~~
```
The API level is already known to be at least 21 here from outer annotations

Found in src/main/java/androidx/camera/core/CameraState.java at line 261:
```
@RequiresApi(21) // TODO(b/200306659): Remove and replace with annotation on package-info.java
~~~~~~~~~~~~~~~~
```
The API level is already known to be at least 21 here from outer annotations

Found in src/main/java/androidx/camera/core/CameraState.java at line 283:
```
@RequiresApi(21) // TODO(b/200306659): Remove and replace with annotation on package-info.java
~~~~~~~~~~~~~~~~
```
The API level is already known to be at least 21 here from outer annotations

Found in src/main/java/androidx/camera/core/CameraState.java at line 445:
```
@RequiresApi(21) // TODO(b/200306659): Remove and replace with annotation on package-info.java
~~~~~~~~~~~~~~~~
```
The API level is already known to be at least 21 here from outer annotations

Found in src/main/java/androidx/camera/core/CameraXConfig.java at line 74:
```
@RequiresApi(21) // TODO(b/200306659): Remove and replace with annotation on package-info.java
~~~~~~~~~~~~~~~~
```
The API level is already known to be at least 21 here from outer annotations

Found in src/main/java/androidx/camera/core/CameraXConfig.java at line 208:
```
@RequiresApi(21) // TODO(b/200306659): Remove and replace with annotation on package-info.java
~~~~~~~~~~~~~~~~
```
The API level is already known to be at least 21 here from outer annotations

Found in src/main/java/androidx/camera/core/FocusMeteringAction.java at line 159:
```
@RequiresApi(21) // TODO(b/200306659): Remove and replace with annotation on package-info.java
~~~~~~~~~~~~~~~~
```
The API level is already known to be at least 21 here from outer annotations

Found in src/main/java/androidx/camera/core/ImageAnalysis.java at line 677:
```
@RequiresApi(21) // TODO(b/200306659): Remove and replace with annotation on package-info.java
~~~~~~~~~~~~~~~~
```
The API level is already known to be at least 21 here from outer annotations

Found in src/main/java/androidx/camera/core/ImageAnalysis.java at line 725:
```
@RequiresApi(21) // TODO(b/200306659): Remove and replace with annotation on package-info.java
~~~~~~~~~~~~~~~~
```
The API level is already known to be at least 21 here from outer annotations

Found in src/main/java/androidx/camera/core/ImageAnalysis.java at line 752:
```
@RequiresApi(21) // TODO(b/200306659): Remove and replace with annotation on package-info.java
~~~~~~~~~~~~~~~~
```
The API level is already known to be at least 21 here from outer annotations

Found in src/main/java/androidx/camera/core/ImageCapture.java at line 1793:
```
@RequiresApi(21) // TODO(b/200306659): Remove and replace with annotation on package-info.java
~~~~~~~~~~~~~~~~
```
The API level is already known to be at least 21 here from outer annotations

Found in src/main/java/androidx/camera/core/ImageCapture.java at line 1810:
```
@RequiresApi(21) // TODO(b/200306659): Remove and replace with annotation on package-info.java
~~~~~~~~~~~~~~~~
```
The API level is already known to be at least 21 here from outer annotations

Found in src/main/java/androidx/camera/core/ImageCapture.java at line 1892:
```
@RequiresApi(21) // TODO(b/200306659): Remove and replace with annotation on package-info.java
~~~~~~~~~~~~~~~~
```
The API level is already known to be at least 21 here from outer annotations

Found in src/main/java/androidx/camera/core/ImageCapture.java at line 1963:
```
    @RequiresApi(21) // TODO(b/200306659): Remove and replace with annotation on package-info
    ~~~~~~~~~~~~~~~~
```
The API level is already known to be at least 21 here from outer annotations

Found in src/main/java/androidx/camera/core/ImageCapture.java at line 2054:
```
@RequiresApi(21) // TODO(b/200306659): Remove and replace with annotation on package-info.java
~~~~~~~~~~~~~~~~
```
The API level is already known to be at least 21 here from outer annotations

Found in src/main/java/androidx/camera/core/ImageCapture.java at line 2077:
```
@RequiresApi(21) // TODO(b/200306659): Remove and replace with annotation on package-info.java
~~~~~~~~~~~~~~~~
```
The API level is already known to be at least 21 here from outer annotations

Found in src/main/java/androidx/camera/core/ImageCapture.java at line 2319:
```
@RequiresApi(21) // TODO(b/200306659): Remove and replace with annotation on package-info.java
~~~~~~~~~~~~~~~~
```
The API level is already known to be at least 21 here from outer annotations

Found in src/main/java/androidx/camera/core/ImageCapture.java at line 2508:
```
@RequiresApi(21) // TODO(b/200306659): Remove and replace with annotation on package-info.java
~~~~~~~~~~~~~~~~
```
The API level is already known to be at least 21 here from outer annotations

Found in src/main/java/androidx/camera/core/ImageProxy.java at line 89:
```
@RequiresApi(21) // TODO(b/200306659): Remove and replace with annotation on package-info.java
~~~~~~~~~~~~~~~~
```
The API level is already known to be at least 21 here from outer annotations

Found in src/main/java/androidx/camera/core/Preview.java at line 564:
```
@RequiresApi(21) // TODO(b/200306659): Remove and replace with annotation on package-info.java
~~~~~~~~~~~~~~~~
```
The API level is already known to be at least 21 here from outer annotations

Found in src/main/java/androidx/camera/core/Preview.java at line 654:
```
@RequiresApi(21) // TODO(b/200306659): Remove and replace with annotation on package-info.java
~~~~~~~~~~~~~~~~
```
The API level is already known to be at least 21 here from outer annotations

Found in src/main/java/androidx/camera/core/impl/StateObservable.java at line 185:
```
@RequiresApi(21) // TODO(b/200306659): Remove and replace with annotation on package-info.java
~~~~~~~~~~~~~~~~
```
The API level is already known to be at least 21 here from outer annotations

Found in src/main/java/androidx/camera/core/SurfaceRequest.java at line 479:
```
@RequiresApi(21) // TODO(b/200306659): Remove and replace with annotation on package-info.java
~~~~~~~~~~~~~~~~
```
The API level is already known to be at least 21 here from outer annotations

Found in src/main/java/androidx/camera/core/SurfaceRequest.java at line 504:
```
@RequiresApi(21) // TODO(b/200306659): Remove and replace with annotation on package-info.java
~~~~~~~~~~~~~~~~
```
The API level is already known to be at least 21 here from outer annotations

Found in src/main/java/androidx/camera/core/SurfaceRequest.java at line 658:
```
@RequiresApi(21) // TODO(b/200306659): Remove and replace with annotation on package-info.java
~~~~~~~~~~~~~~~~
```
The API level is already known to be at least 21 here from outer annotations

Found in src/main/java/androidx/camera/core/UseCaseGroup.java at line 69:
```
@RequiresApi(21) // TODO(b/200306659): Remove and replace with annotation on package-info.java
~~~~~~~~~~~~~~~~
```
The API level is already known to be at least 21 here from outer annotations

Found in src/main/java/androidx/camera/core/VideoCapture.java at line 1315:
```
@RequiresApi(21) // TODO(b/200306659): Remove and replace with annotation on package-info.java
~~~~~~~~~~~~~~~~
```
The API level is already known to be at least 21 here from outer annotations

Found in src/main/java/androidx/camera/core/ViewPort.java at line 204:
```
@RequiresApi(21) // TODO(b/200306659): Remove and replace with annotation on package-info.java
~~~~~~~~~~~~~~~~
```

Comments

wu...@google.com <wu...@google.com> Nov 3, 2021 02:28AM

Reassigned to ch...@google.com.

ch...@google.com <ch...@google.com> Nov 3, 2021 07:59AM

Accepted by ch...@google.com.

ch...@google.com <ch...@google.com> #2Nov 3, 2021 08:57AM

Assigned to al...@google.com.

Can you attach logcat and traces from iterations where the metric wasn't captured?

al...@google.com <al...@google.com> #3Nov 3, 2021 01:53PM

Reassigned to ch...@google.com.

I've attempted to repro this issue with other apps and this seems to be exclusive to a particular app that I'm testing with. I wouldn't be able to provide traces or full logcat for IP reasons but I can provide a filtered log of one of the iterations that failed.

al...@google.com <al...@google.com> #4Nov 3, 2021 02:05PM

Thanks very much for the logs!

Are you sure you're using benchmark 1.2.3?

In 1.2.0-alpha04 we removed the constraint to look for startActivityAndWait (see b/245414235), but it's still in your query/results. It's possible we had a branch management issue when releasing, but can you check the version of benchmark you're using?

On a newer version, the query results for this iteration look like they should work, I tried converting them to slices in the internal implementation of StartupTimingQuery:

    listOf(
        Slice("MetricsLogger:launchObserverNotifyIntentStarted",748393772361,29705),
        Slice("launching: androidx.benchmark.integration.macrobenchmark.target",748404581583,881311671),
        Slice("activityResume",748731008508,4916798),
        Slice("Choreographer#doFrame",748764833776,519637337),
        Slice("DrawFrame",748897201189,387112642),
        Slice("Choreographer#doFrame",749285086939,89017),
        Slice("Choreographer#doFrame",749305484396,730140),
        Slice("DrawFrame",749305899852,121651546),
    )

And received the following startup event:

SubMetrics(timeToInitialDisplayNs=879732248, timeToFullDisplayNs=null, timelineRangeNs=748404581583..749284313831)

So you should be good with new versions of macrobenchmark.

The other constraint we removed in that same fix was asserting that the launching event was contained in the startActivityAndWait event, which seems to be the problem in this iteration:

04-01 11:54:55.097  6289  6311 I System.out: query result line "startActivityAndWait",748335793781,1096645119
04-01 11:54:55.097  6289  6311 I System.out: query result line "launching: <app_test_package>",748404581583,881311671

748335793781 + 1096645119 is greater than 748404581583, so the launching: event starts after the startActivityAndWait slice from macrobenchmark. Not sure why that is without looking at a trace, but you could look to see if there's anything strange there (like startActivityAndWait not waiting for the actual launch somehow, that would do it).

ch...@google.com <ch...@google.com> #5Nov 4, 2021 07:38AM

Ah right, I'm blocked on using 1.2.3 in a specific use case due to

https://issuetracker.google.com/issues/329145808. I have a local workaround to use 1.2.3 but didn't use it for today's repro. Let me try to repro with 1.2.3 today

wu...@google.com <wu...@google.com> Nov 10, 2021 08:36AM

Accepted by ch...@google.com.

ap...@google.com <ap...@google.com> #6Nov 11, 2021 02:21AM

Okay, looks like I'm unable to repro this on 1.2.3 anymore. I'm getting an entirely different error consistently with 1.2.3 which is "java.util.NoSuchElementException: Collection contains no element matching the predicate." I'll create a separate issue for this if one doesn't exist already.

Feel free to close this issue out. Thanks for all your help!

ch...@google.com <ch...@google.com> Nov 11, 2021 02:34AM

Marked as fixed.

IssueTracker

Fix 30 lint baseline suppression(s) of SupportAnnotationUsage

Status Update

Description

30 instance(s) of `SupportAnnotationUsage`

Comments

wu...@google.com <wu...@google.com> Nov 3, 2021 02:28AM

ch...@google.com <ch...@google.com> Nov 3, 2021 07:59AM

ch...@google.com <ch...@google.com> #2Nov 3, 2021 08:57AM

al...@google.com <al...@google.com> #3Nov 3, 2021 01:53PM

al...@google.com <al...@google.com> #4Nov 3, 2021 02:05PM

ch...@google.com <ch...@google.com> #5Nov 4, 2021 07:38AM

wu...@google.com <wu...@google.com> Nov 10, 2021 08:36AM

ap...@google.com <ap...@google.com> #6Nov 11, 2021 02:21AM

ch...@google.com <ch...@google.com> Nov 11, 2021 02:34AM

Issue 204917951

Description

30 instance(s) of SupportAnnotationUsage

Issue summary

Comments

wu...@google.com <wu...@google.com> Nov 3, 2021 02:28AM

ch...@google.com <ch...@google.com> Nov 3, 2021 07:59AM

ch...@google.com <ch...@google.com> #2Nov 3, 2021 08:57AM

al...@google.com <al...@google.com> #3Nov 3, 2021 01:53PM

al...@google.com <al...@google.com> #4Nov 3, 2021 02:05PM

ch...@google.com <ch...@google.com> #5Nov 4, 2021 07:38AM

wu...@google.com <wu...@google.com> Nov 10, 2021 08:36AM

ap...@google.com <ap...@google.com> #6Nov 11, 2021 02:21AM

ch...@google.com <ch...@google.com> Nov 11, 2021 02:34AM

Add comment

Issue metadata

30 instance(s) of `SupportAnnotationUsage`