IssueTracker

Thanks, can you please add information about the Android version/device as well?

I can reproduce it both on Emulator Pixel 5 API 31 arm64 version, and on Meizu X8 API 27

note: prototype in here

before and after images are attached.

Siyamed, just FYI that the duplicate bug was closed a while ago with WAI b/150683935

I skimmed over the comments on the ticket.

Working on the include font padding I saw some opportunities to provide kind of tighter bounds API.

As far as I can see at the time we didn't know what is the absolute right solution and mention a lot about different alignments, rtl, ltr etc.

it looks like it is worth to investigate this a little further to see if there is any non-binary solution to it (API, handling cases separately, the concept of tight-er bounds that would not work for Bidi text where each line paragraph is LTR / RTL.)

I changed it to be a feature request.

Assigning to myself as this related to the bug I'm working on b/223447799

Facing the same issue in one of my production apps.

Compose UI version: 1.4.3
Compose compiler version: 1.4.7
Compose material version: 1.2.0

This happens when I use modifier = Modifier.weight(1f, fill = false) in my text.

Please try the following code snippet to reproduce the behavior

Row(
    horizontalArrangement = Arrangement.spacedBy(
        dimensionResource(id = size.sizes.spaceBetween)
    ),
    verticalAlignment = Alignment.CenterVertically,
    modifier = modifier.clickable(
        interactionSource = interactionSource,
        indication = null,
        role = Role.Button
    ) {
        onClick()
    }
) {
    Text(
        text = "this is a very loooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooong text",
        style = TextStyle(
            color = theme.textColor,
            fontSize = dimenToSp(size.sizes.fontSize),
            lineHeight = dimenToSp(size.sizes.lineHeight),
            textDecoration = decoration,
            fontWeight = if (isBold) FontWeight.Bold else FontWeight.Normal,
            textAlign = multilineTextAlign
        ),
        modifier = Modifier.weight(1f, fill = false)   // <--- The issue happens when I apply this modifier
    )
    Icon(
        painter = <Some icon here>,
        contentDescription = "",
        tint = theme.iconColor,
        modifier = Modifier.size(
            dimensionResource(id = size.sizes.iconSizing) * getSystemFontScale()
        )
    )
}

You can use this workaround for now, but given its shortcomings in terms of performance, a decent fix is really needed here!

https://cs.android.com/androidx/platform/frameworks/support/+/androidx-main:compose/ui/ui-text/src/commonMain/kotlin/androidx/compose/ui/text/MultiParagraph.kt;l=372?q=MultiParagraph.kt

https://cs.android.com/androidx/platform/frameworks/support/+/androidx-main:compose/ui/ui-text/src/androidMain/kotlin/androidx/compose/ui/text/AndroidParagraph.android.kt;l=210?q=AndroidParagraph.android.kt

Behavior since Compose 1.0. This is ported diligently during Modifiers port https://cs.android.com/androidx/platform/frameworks/support/+/androidx-main:compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/modifiers/MultiParagraphLayoutCache.kt;l=283?q=MultiParagraphLayoutCache

There are two cases:

1. maxIntrinsicWidth <= constraints.maxWidth. The BasicText is sized to the maxIntrinsicWidth
2. maxIntrinsicWidth > constraints.maxWidth (multiline). The BasicText is sized to constraints.maxWidth.

Changing this is a major breaking behavior modification from Compose 1.0.

(since public - just doing triage and adding debug notes right now)

@seanmcq not sure if you saw the prototype mentioned in https://buganizer.corp.google.com/issues/206039942#comment4

Even if it is not in the prototype, I believed that this could be a new API. (there were multiple tight text idea, one of them for vertical, one of them for horizontal where the horizontal one is the issue in this ticket)

Nice!

For the note, we did work in MultiParagraph so it accepts Constraints object rather than simply maxWidth, which is pre-requisite for this change. I think that wrapping behaviour should have been a default behaviour. This is pretty much what we do in Row and Column for example, because expanding from wrapping to filling is easy compared to the other way around.

Now, as per comment#7, apparently I was working on this issue as part of a bug mentioned in the comment. I don't remember the details now but at the time I didn't merge the fix as I needed more testing; likely because it was a breaking behaviour in some cases indeed. So as Siyamed mentioned above, we might need to consider an API.

Picking this one up as it's next.

Any news about this?

I still waiting for update.

A workaround that doesn't rely on subcomposition:

@Preview(widthDp = 300, heightDp = 400)
@Preview(widthDp = 400, heightDp = 400)
@Preview(widthDp = 500, heightDp = 400)
@Preview(widthDp = 600, heightDp = 400)
@Preview(widthDp = 700, heightDp = 400)
@Preview(widthDp = 800, heightDp = 400)
@Composable
private fun TightWrapText() {
  var textLayoutResult: TextLayoutResult? by remember { mutableStateOf(null) }
  BasicText(
    text = "Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua.",
    modifier = Modifier
      .background(Color.Blue)
      .layout { measurable, constraints ->
        val placeable = measurable.measure(constraints)
        val newTextLayoutResult = textLayoutResult!!

        if (newTextLayoutResult.lineCount == 0) {
          // Default behavior if there is no text
          layout(placeable.width, placeable.height) {
            placeable.placeRelative(0, 0)
          }
        } else {
          val minX = (0 until newTextLayoutResult.lineCount).minOf(newTextLayoutResult::getLineLeft)
          val maxX = (0 until newTextLayoutResult.lineCount).maxOf(newTextLayoutResult::getLineRight)

          layout(ceil(maxX - minX).toInt(), placeable.height) {
            placeable.place(-floor(minX).toInt(), 0)
          }
        }
      },
    onTextLayout = {
      textLayoutResult = it
    }
  )
}

Curios if anything is in the works?

Used workaround for my case (centered left-aligned multiline text):

                Column(
                    horizontalAlignment = Alignment.Start,
                    verticalArrangement = Arrangement.Center,
                    modifier = Modifier
                        .wrapContentWidth()
                        .padding(10.dp)
                        .weight(1f)
                ) {
                    text.split('\n').forEach{
                        Text(
                            text = it.trim(),
                            fontSize = 6.em,
                            modifier = Modifier
                                .wrapContentWidth()
                        )
                    }
                }