App compat 1.4.0 randomly crash with TextView and char buffers [206859724]

Fixed

Bug

Status Update

No update yet.

Description

to...@gmail.com

created issue #1

Nov 18, 2021 05:54PM

Component used: Appcompat 1.4.0 / Constraint layout 2.1.1 Version used: Devices/Android versions reproduced on: All

Since this is a long post I'll start by the end: Doing a bisect, the issue was introduced in 1.4.0 alpha 3 and is not present in 1.4.0 alpha 2.

I'm trying to build a repro but don't really understand what is going on, randomly on first start I have crashes from Textview whose data is set via setText(buffer.data, 0, buffer.sizeCopied). If I catch the error and just log it, then navigating or returning to the same state won't crash again. But killing the app and restart it can trigger it. So only happens on first run.

The buffer is stable and not edited anywhere it was working since ages and works nicely when reverting to app compat 1.3.1.

Strangely the crash have no reference to appcompat stuff, but it's the update to 1.4.0 that cause this.

Since I have no idea of a possible cause and this happens randomly in a very deep part of the app, I'd like some pointers about changes in appcompat 1.4.0 to narrow the possible cause and be able to create a repro. Sounds like there where changes to delay loading of things or maybe side effect of the emoji stuff that double init the textviews after the emoji library is loaded or not found? Or maybe some kind of data cache now and the crash occurs when the same final string is displayed multiple times?

Anyway any pointer to be able to help me provide more info and / or build a repro would be nice.

Crash log:

java.lang.NullPointerException: Attempt to get length of null array
        at android.graphics.BaseRecordingCanvas.drawText(BaseRecordingCanvas.java:448)
        at android.widget.TextView$CharWrapper.drawText(TextView.java:13594)
        at android.graphics.BaseRecordingCanvas.drawText(BaseRecordingCanvas.java:467)
        at android.text.Layout.drawText(Layout.java:569)
        at android.text.Layout.draw(Layout.java:325)
        at android.text.BoringLayout.draw(BoringLayout.java:460)
        at android.widget.TextView.onDraw(TextView.java:8120)
        at android.view.View.draw(View.java:22644)
        at android.view.View.updateDisplayListIfDirty(View.java:21519)
        at android.view.View.draw(View.java:22375)
        at android.view.ViewGroup.drawChild(ViewGroup.java:4528)
        at android.view.ViewGroup.dispatchDraw(ViewGroup.java:4289)
        at androidx.constraintlayout.widget.ConstraintLayout.dispatchDraw(ConstraintLayout.java:1994)
        at android.view.View.draw(View.java:22647)
        at xxx.xxxx.android.utils.view.ForegroundConstraintLayout.draw(ForegroundConstraintLayout.kt:94)
        at android.view.View.updateDisplayListIfDirty(View.java:21519)
        at android.view.ViewGroup.recreateChildDisplayList(ViewGroup.java:4512)
        at android.view.ViewGroup.dispatchGetDisplayList(ViewGroup.java:4485)
        at android.view.View.updateDisplayListIfDirty(View.java:21475)
        at android.view.ViewGroup.recreateChildDisplayList(ViewGroup.java:4512)
        at android.view.ViewGroup.dispatchGetDisplayList(ViewGroup.java:4485)
        at android.view.View.updateDisplayListIfDirty(View.java:21475)
        at android.view.ViewGroup.recreateChildDisplayList(ViewGroup.java:4512)
        at android.view.ViewGroup.dispatchGetDisplayList(ViewGroup.java:4485)
        at android.view.View.updateDisplayListIfDirty(View.java:21475)
        at android.view.ViewGroup.recreateChildDisplayList(ViewGroup.java:4512)
        at android.view.ViewGroup.dispatchGetDisplayList(ViewGroup.java:4485)
        at android.view.View.updateDisplayListIfDirty(View.java:21475)
        at android.view.ViewGroup.recreateChildDisplayList(ViewGroup.java:4512)
        at android.view.ViewGroup.dispatchGetDisplayList(ViewGroup.java:4485)
        at android.view.View.updateDisplayListIfDirty(View.java:21475)
        at android.view.ViewGroup.recreateChildDisplayList(ViewGroup.java:4512)
        at android.view.ViewGroup.dispatchGetDisplayList(ViewGroup.java:4485)
        at android.view.View.updateDisplayListIfDirty(View.java:21475)
        at android.view.View.draw(View.java:22375)
        at android.view.ViewGroup.drawChild(ViewGroup.java:4528)
        at android.view.ViewGroup.dispatchDraw(ViewGroup.java:4289)
        at android.view.View.draw(View.java:22647)
        at androidx.viewpager.widget.ViewPager.draw(ViewPager.java:2426)
        at android.view.View.updateDisplayListIfDirty(View.java:21519)
        at android.view.View.draw(View.java:22375)
        at android.view.ViewGroup.drawChild(ViewGroup.java:4528)
        at androidx.coordinatorlayout.widget.CoordinatorLayout.drawChild(CoordinatorLayout.java:1277)
        at android.view.ViewGroup.dispatchDraw(ViewGroup.java:4289)
        at android.view.View.updateDisplayListIfDirty(View.java:21510)
        at android.view.View.draw(View.java:22375)
        at android.view.ViewGroup.drawChild(ViewGroup.java:4528)
        at androidx.fragment.app.FragmentContainerView.drawChild(FragmentContainerView.kt:235)
        at android.view.ViewGroup.dispatchDraw(ViewGroup.java:4289)
        at androidx.fragment.app.FragmentContainerView.dispatchDraw(FragmentContainerView.kt:225)
        at android.view.View.updateDisplayListIfDirty(View.java:21510)
        at android.view.View.draw(View.java:22375)
        at android.view.ViewGroup.drawChild(ViewGroup.java:4528)
        at androidx.coordinatorlayout.widget.CoordinatorLayout.drawChild(CoordinatorLayout.java:1277)
        at android.view.ViewGroup.dispatchDraw(ViewGroup.java:4289)
        at android.view.View.updateDisplayListIfDirty(View.java:21510)
        at android.view.View.draw(View.java:22375)
        at android.view.ViewGroup.drawChild(ViewGroup.java:4528)
2021-11-18 18:24:48.958 5016-5066/xxx.xxxx.debug E/AAAA:     at androidx.drawerlayout.widget.DrawerLayout.drawChild(DrawerLayout.java:1478)
        at android.view.ViewGroup.dispatchDraw(ViewGroup.java:4289)
        at android.view.View.updateDisplayListIfDirty(View.java:21510)
        at android.view.View.draw(View.java:22375)
        at android.view.ViewGroup.drawChild(ViewGroup.java:4528)
        at android.view.ViewGroup.dispatchDraw(ViewGroup.java:4289)
        at android.view.View.updateDisplayListIfDirty(View.java:21510)
        at android.view.View.draw(View.java:22375)
        at android.view.ViewGroup.drawChild(ViewGroup.java:4528)
        at android.view.ViewGroup.dispatchDraw(ViewGroup.java:4289)
        at android.view.View.updateDisplayListIfDirty(View.java:21510)
        at android.view.View.draw(View.java:22375)
        at android.view.ViewGroup.drawChild(ViewGroup.java:4528)
        at android.view.ViewGroup.dispatchDraw(ViewGroup.java:4289)
        at android.view.View.updateDisplayListIfDirty(View.java:21510)
        at android.view.View.draw(View.java:22375)
        at android.view.ViewGroup.drawChild(ViewGroup.java:4528)
        at android.view.ViewGroup.dispatchDraw(ViewGroup.java:4289)
        at android.view.View.updateDisplayListIfDirty(View.java:21510)
        at android.view.View.draw(View.java:22375)
        at android.view.ViewGroup.drawChild(ViewGroup.java:4528)
        at android.view.ViewGroup.dispatchDraw(ViewGroup.java:4289)
        at android.view.View.draw(View.java:22647)
        at com.android.internal.policy.DecorView.draw(DecorView.java:820)
        at android.view.View.updateDisplayListIfDirty(View.java:21519)
        at android.view.ThreadedRenderer.updateViewTreeDisplayList(ThreadedRenderer.java:534)
        at android.view.ThreadedRenderer.updateRootDisplayList(ThreadedRenderer.java:540)
        at android.view.ThreadedRenderer.draw(ThreadedRenderer.java:616)
        at android.view.ViewRootImpl.draw(ViewRootImpl.java:4418)
        at android.view.ViewRootImpl.performDraw(ViewRootImpl.java:4146)
        at android.view.ViewRootImpl.performTraversals(ViewRootImpl.java:3306)
        at android.view.ViewRootImpl.doTraversal(ViewRootImpl.java:2126)
        at android.view.ViewRootImpl$TraversalRunnable.run(ViewRootImpl.java:8649)
        at android.view.Choreographer$CallbackRecord.run(Choreographer.java:1037)
        at android.view.Choreographer.doCallbacks(Choreographer.java:845)
        at android.view.Choreographer.doFrame(Choreographer.java:780)
        at android.view.Choreographer$FrameDisplayEventReceiver.run(Choreographer.java:1022)
        at android.os.Handler.handleCallback(Handler.java:938)
        at android.os.Handler.dispatchMessage(Handler.java:99)
        at android.os.Looper.loopOnce(Looper.java:201)
        at android.os.Looper.loop(Looper.java:288)
        at android.app.ActivityThread.main(ActivityThread.java:7838)
        at java.lang.reflect.Method.invoke(Native Method)
        at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:548)
        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1003)

Comments

al...@google.com <al...@google.com> #2Nov 18, 2021 06:20PM

Reassigned to si...@google.com.

I have unintentionally posted this as a bug but it is a Feature Request instead. Please change the category, thank you.

to...@gmail.com <to...@gmail.com> #3Jan 17, 2022 02:24PM

Thanks for filing this - I've changed it to a Feature request and marked it for our team to look at for Video development. Thanks!

si...@google.com <si...@google.com> #4Jan 18, 2022 06:04PM

Reassigned to se...@google.com.

Hi, we're heavily using CameraX API for recording video and this is much anticipated feature for us. Is there any timeframe for this issue? Thanks

se...@google.com <se...@google.com> #5Jan 18, 2022 06:50PM

Hi, it is expected to release the first alpha soon. This feature is in our current roadmap, but we are not able to provide an exact timeframe to support this feature. Please stay tuned. Thanks!

to...@gmail.com <to...@gmail.com> #6Jan 18, 2022 06:59PM

Hi, seems like the latest alpha doesn't have the changes, does it?

se...@google.com <se...@google.com> #7Jan 18, 2022 07:01PM

Yes, the first video capture library doesn't support mirror/non-mirror output, but it's in our pipeline. :)

to...@gmail.com <to...@gmail.com> #8Feb 23, 2022 06:24PM

Hi, are there any updates?

se...@google.com <se...@google.com> Mar 3, 2022 06:22PM

Accepted by se...@google.com.

se...@google.com <se...@google.com> #9Mar 3, 2022 10:47PM

Hi there,

Thanks for the question - I've added this to our 1.2 candidate list so we'll be working on it. Note: We're going to be releasing 1.1 beta soon, then following the sem-versioning of 1.1 RC, 1.1 Stable, then proceeding to 1.2 branch. We hope the process with go more quickly this year. Thanks!

se...@google.com <se...@google.com> #10Mar 3, 2022 10:58PM

+1 for this feature

ap...@google.com <ap...@google.com> #11Mar 4, 2022 01:42AM

Marked as fixed.

Hi there, any update on this?

to...@gmail.com <to...@gmail.com> #12Mar 4, 2022 07:37AM

Hi,

We are currently working on this feature and it is high priority. Stay tuned!

se...@google.com <se...@google.com> #13Mar 7, 2022 05:50PM

Project: platform/frameworks/support
Branch: androidx-main

commit 4e979f702d053727557118464e0fb5ae4df9220f
Author: leo huang <leohuang@google.com>
Date: Tue Feb 14 18:04:22 2023

Apply mirror mode to VideoCapture, Preview and StreamSharing

- For Preview, MIRROR_MODE_FRONT_ON is the default value and can not be changed.
- For VideoCapture, add getMirrorMode()/Builder.setMirrorMode() which will be exposed later.
- For StreamSharing, VirtualCamera refers to UseCase mirror mode when generating child SurfaceProcessorNode.OutConfig.

Bug: 194634656
Test: ./gradlew camera:camera-core:testDebug; ./gradlew camera:camera-video:testDebug
Change-Id: I674c7bdf8b0516cefe298090549f5e22882cfddb

M camera/camera-core/src/main/java/androidx/camera/core/Preview.java
M camera/camera-core/src/main/java/androidx/camera/core/processing/SurfaceProcessorNode.java
M camera/camera-core/src/main/java/androidx/camera/core/streamsharing/VirtualCamera.java
M camera/camera-core/src/test/java/androidx/camera/core/PreviewTest.kt
M camera/camera-core/src/test/java/androidx/camera/core/streamsharing/VirtualCameraTest.kt
M camera/camera-video/src/main/java/androidx/camera/video/VideoCapture.java
M camera/camera-video/src/test/java/androidx/camera/video/VideoCaptureTest.kt

https://android-review.googlesource.com/2463056

se...@google.com <se...@google.com> #14Mar 7, 2022 05:53PM

Project: platform/frameworks/support
Branch: androidx-main

commit 0c78e313a38f1fee57742af743ad1fbb628255e9
Author: leo huang <leohuang@google.com>
Date: Tue Feb 14 16:01:29 2023

Add MirrorMode and apply to UseCases

- API design go/camerax-videocapture-mirroring
- The default mirror mode is MIRROR_MODE_OFF.
- Throw UnsupportedOperationException to Builder.setMirrorMode() by default.

Bug: 194634656
Test: ./gradlew camera:camera-core:testDebug; ./gradlew camera:camera-video:testDebug
Change-Id: If5128439c48b4b226c7fe6b8a6e6bcb516f16804

M camera/camera-core/src/androidTest/java/androidx/camera/core/UseCaseTest.kt
M camera/camera-core/src/main/java/androidx/camera/core/ImageAnalysis.java
M camera/camera-core/src/main/java/androidx/camera/core/ImageCapture.java
A camera/camera-core/src/main/java/androidx/camera/core/MirrorMode.java
M camera/camera-core/src/main/java/androidx/camera/core/Preview.java
M camera/camera-core/src/main/java/androidx/camera/core/UseCase.java
M camera/camera-core/src/main/java/androidx/camera/core/impl/ImageOutputConfig.java
M camera/camera-core/src/test/java/androidx/camera/core/ImageAnalysisTest.java
M camera/camera-core/src/test/java/androidx/camera/core/ImageCaptureTest.kt
M camera/camera-core/src/test/java/androidx/camera/core/PreviewTest.kt
M camera/camera-testing/src/main/java/androidx/camera/testing/fakes/FakeCamera.java
M camera/camera-testing/src/main/java/androidx/camera/testing/fakes/FakeUseCaseConfig.java
M camera/camera-video/src/main/java/androidx/camera/video/VideoCapture.java
M camera/camera-video/src/test/java/androidx/camera/video/VideoCaptureTest.kt

https://android-review.googlesource.com/2463055

to...@gmail.com <to...@gmail.com> #15Jun 3, 2022 04:47PM

Hello, are there any updates on when this is going live? Thank you

se...@google.com <se...@google.com> #16Jun 6, 2022 09:12PM

We are still working on this feature. Please stay tuned. Thanks!