Integrate ViewModel CreationExtras APIs into NavBackStackEntry [207012490]

Fixed

Feature Request

adexe s nau

Status Update

No update yet.

Description

il...@google.com

created issue #1

Nov 18, 2021 09:18PM

Component used: Navigation

ViewModel added new CreationExtras APIs for providing information from ViewModelStoreOwners to ViewModel factories. This should be integrated into NavBackStackEntry so that custom factories can rely on these extras being available.

Comments

ap...@google.com <ap...@google.com> #2Dec 10, 2021 04:28AM

I see that this issue was assigned. I can create Pull Request if need.

ap...@google.com <ap...@google.com> #3Jan 12, 2022 10:19PM

Feel free to do so and we will review.

ap...@google.com <ap...@google.com> #4Jan 20, 2022 01:10AM

Just created the PR with this change

jb...@google.com <jb...@google.com> #5Jan 20, 2022 01:52AM

Marked as fixed.

I think your PR also fixes our problem: we have links like .../search/ .../search?documentId=123 .../search?folder=123

And each should be redirected to different navigation destinations. Currently they all redirect to one page, and sometimes crash.

Issue 207012490

Description

Issue summary

Comments

ap...@google.com <ap...@google.com> #2Dec 10, 2021 04:28AM

ap...@google.com <ap...@google.com> #3Jan 12, 2022 10:19PM

ap...@google.com <ap...@google.com> #4Jan 20, 2022 01:10AM

jb...@google.com <jb...@google.com> #5Jan 20, 2022 01:52AM

Add comment

Issue metadata