Status Update
Comments
xa...@google.com <xa...@google.com>
je...@google.com <je...@google.com>
is...@google.com <is...@google.com>
co...@gmail.com <co...@gmail.com> #2
Just a heads up that this is still a problem. Are you open to accept external PRs to solve this?
co...@gmail.com <co...@gmail.com> #3
To add to this, with AGP 7.1.x things got even worse as now there are several configureNdk*
tasks, one for each ABI. Like: configureNdkBuildDebug[x86_64]
.
All those tasks (both the NDK and the CMake ones) are not plugged correctly in the task graph and they’re not depending on preBuild
, preDebugBuild
, and so on.
We have to manually add those dependencies in our build.gradle
which feels extremely hacky.
I saw that the issues got unassigned on the issue tracker, so I’m asking what should we do to get more visibility.
xa...@google.com <xa...@google.com> #4
Jerome for re-assigning this to someone.
je...@google.com <je...@google.com>
jo...@google.com <jo...@google.com> #5
@corti.nico regarding preBuild
hooks like preDebugBuild[x86_64]
before you're unblocked?
co...@gmail.com <co...@gmail.com> #6
regarding
, do you need per-ABI preBuild hooks like preDebugBuild[x86_64] before you're unblocked? comment#13
Thanks for the follow up.
I'd say that depending on preBuild
would be the minimum requirement, as those tasks have no dependencies at all at the moment.
If you could properly let them depend on the build-variant preBuild tasks (i.e. preDebugBuild
), would be great.
per-ABI hooks feel unnecessary to me.
al...@google.com <al...@google.com>
le...@gmail.com <le...@gmail.com> #7
This seems fixed for me btw in
- Tasks:
clean
andassembleDebug
- ABIs: All 4 default and single ones like
x86_64
- OS: MacOS 12.3-12.4Beta2 (local dev) and
(CI Flow with GitHub Actions)Ubuntu 20.04.4 - Version of Java: Temurin 11, Temurin 18, OpenJDK 18 locally, etc
- Version of Gradle: 7.3.3, 7.5 nightly (20220331233901)
- Version of SDK Build Tools: 31.0.0
- Version of NDK: 24.0.8215888, 25.0.8221429 rc2
Looking solid, lemme kno if worth identifying the
Full details including repro and logs
Description
This issue should probably be moved to the
Android Public Tracker > App Development > Android Studio > Gradle > Android Gradle Plugin
component but I don't have the rights to open it over there.DESCRIBE THE ISSUE IN DETAIL:
I’ve noticed that AGP 7.x introduces a new task called
configureNdkBuild
(and similar tasks per variant such as configureNdkBuildDebug and so on) which is supposed to configure the Android NDK.It seems like that task is NOT depending on
preBuild
in any form. Apparently theconfigureNdkBuild
has no dependency at all. The reason why I’m asking is because on one of the project I’m working on, I need to download native sources from Github releases.Having no possibility to do any work before
configureNdkBuild
is a bit of a bummer as I need to specify an explicit task dependency on a AGP task (which I would like to avoid).I had a contact with a Googler and they mentioned this is a bug and could be fixed inside AGP.
REPRODUCER:
Without the explicit:
the build will not work.
ENVIRONMEMT