Cannot sync project with KMP module in Chipmunk with MPSS [208357458]

Fixed

Bug

Status Update

No update yet.

Description

an...@gmail.com

created issue #1

Nov 30, 2021 04:22PM

DESCRIBE THE ISSUE IN DETAIL: Getting an error during sync. The project syncs just fine in anything other than Chipmunk. Please see the attached reproduction project, but we also see this in our main project at work. The issue seems to involve a module that is Kotlin Multiplatform.

Cannot find module with id: GradleProjectPath(buildRoot=/Users/Antal.Monori/AndroidStudioProjects/GradleProjectPathIssue, path=:network-kmm, sourceSet=MAIN)

STEPS TO REPRODUCE:

Open project in Chipmunk
Let it sync
See failure

Loading the project in Arctic Fox and Bumblebee works without any modifications.

Following error is present in the logs that might pin point to the issue:

Caused by: java.lang.IllegalStateException: Cannot find module with id: GradleProjectPath(buildRoot=/Users/Antal.Monori/AndroidStudioProjects/GradleProjectPathIssue, path=:network-kmm, sourceSet=MAIN)
	at com.android.tools.idea.gradle.project.sync.idea.AndroidDependenciesSetupContext.createModuleLibraryWorkItem(DependencyUtil.kt:302)
	at com.android.tools.idea.gradle.project.sync.idea.AndroidDependenciesSetupContext.setupForArtifact(DependencyUtil.kt:312)
	at com.android.tools.idea.gradle.project.sync.idea.DependencyUtilKt.setupAndroidDependenciesForMpss$populateDependenciesFromArtifact(DependencyUtil.kt:446)
	at com.android.tools.idea.gradle.project.sync.idea.DependencyUtilKt.setupAndroidDependenciesForMpss(DependencyUtil.kt:459)
	at com.android.tools.idea.gradle.project.sync.idea.AndroidGradleProjectResolver.populateModuleDependencies(AndroidGradleProjectResolver.java:837)
	at org.jetbrains.plugins.gradle.service.project.AbstractProjectResolverExtension.populateModuleDependencies(AbstractProjectResolverExtension.java:105)
	at org.jetbrains.kotlin.idea.configuration.KotlinGradleProjectResolverExtension.populateModuleDependencies(KotlinGradleProjectResolverExtension.kt:238)
	at org.jetbrains.plugins.gradle.service.project.AbstractProjectResolverExtension.populateModuleDependencies(AbstractProjectResolverExtension.java:105)
	at org.jetbrains.plugins.gradle.service.project.AbstractProjectResolverExtension.populateModuleDependencies(AbstractProjectResolverExtension.java:105)
	at org.jetbrains.plugins.gradle.service.project.AbstractProjectResolverExtension.populateModuleDependencies(AbstractProjectResolverExtension.java:105)
	at org.jetbrains.plugins.gradle.service.project.AbstractProjectResolverExtension.populateModuleDependencies(AbstractProjectResolverExtension.java:105)
	at org.jetbrains.plugins.gradle.service.project.AbstractProjectResolverExtension.populateModuleDependencies(AbstractProjectResolverExtension.java:105)
	at org.jetbrains.plugins.gradle.service.project.AbstractProjectResolverExtension.populateModuleDependencies(AbstractProjectResolverExtension.java:105)
	at org.jetbrains.plugins.gradle.service.project.TracedProjectResolverExtension.populateModuleDependencies(TracedProjectResolverExtension.java:72)
	at org.jetbrains.plugins.gradle.service.project.GradleProjectResolver.convertData(GradleProjectResolver.java:448)
	at org.jetbrains.plugins.gradle.service.project.GradleProjectResolver.doResolveProjectInfo(GradleProjectResolver.java:308)
	at org.jetbrains.plugins.gradle.service.project.GradleProjectResolver$ProjectConnectionDataNodeFunction.fun(GradleProjectResolver.java:775)

Android Studio Chipmunk | 2021.2.1 Canary 5 | Build #AI-212.5457.46.2112.7905983, built on November 11, 2021

Runtime version: 11.0.12+0-b1504.28-7817840 x86_64

VM: OpenJDK 64-Bit Server VM by JetBrains s.r.o.

OS: macOS 11.5.2

GC: G1 Young Generation, G1 Old Generation

Memory: 4096M

Cores: 12

Registry: external.system.auto.import.disabled=true

Non-Bundled Plugins: ski.chrzanow.foldableprojectview (1.1.1)

Kotlin: 1.5.31

Groovy: 3.0.9

Gradle: 7.3

GradleProjectPathIssueOnChipmunk.zip

67 KB

Download

idea.log

74 KB

View

Download

Comments

an...@gmail.com <an...@gmail.com> #2Dec 1, 2021 09:51AM

This upgrade assistant change will add android.defaults.buildfeatures.resvalues=true to the gradle.properties file in AGP 9.0.0, and there will be a separate refactoring option to move the flag (when necessary) to the build files (DSL).

ad...@google.com <ad...@google.com> Dec 2, 2021 01:03AM

Assigned to an...@google.com.

xa...@google.com <xa...@google.com> Dec 6, 2021 05:24PM

Reassigned to sm...@google.com.

ss...@gmail.com <ss...@gmail.com> #3Dec 14, 2021 07:02PM

Thank you for your patience while our engineering team worked to resolve this issue. A fix for this issue is now available in:

Android Studio Ladybug Feature Drop | 2024.2.2 Canary 6
Android Gradle Plugin 8.8.0-alpha06

We encourage you to try the latest update.

If you notice further issues or have questions, please file a new bug report.

Thank you for taking the time to submit feedback — we really appreciate it!

ss...@gmail.com <ss...@gmail.com> #4Dec 14, 2021 08:48PM

Note: I just tried with Bumblebee Beta 5 with the same code, and it's working fine.

an...@gmail.com <an...@gmail.com> #5Feb 1, 2022 08:59AM

Tried again with Gradle 7.3.3, AGP 7.1.0, Kotlin 1.5.31 and it still fails with both Chipmunk Beta 1 and Dolphin Canary 1

ga...@google.com <ga...@google.com> #6Feb 9, 2022 09:58AM

Here is another project that reproduces the issue: https://github.com/irgaly/as-chipmunk-kmm-reproducer

ga...@google.com <ga...@google.com> #7Feb 9, 2022 11:14AM

The structure of project from #6 is the following:

app: application project, depends on core
core: KMP project, has only JVM and common

Without MPSS, this does not break as:

during dependency resolution we assume that app depends on MAIN sourceset from core
w/o MPSS, in AndroidGradleProjectResolver we will register MAIN sourceset for core

=> data from 1) will match to mapping information in 2), so nothing breaks.

With MPSS:

during dependency resolution we assume that app depends on MAIN sourceset from core
with MPSS, in AndroidGradleProjectResolver, we register a more correct information about core, and we have jvmMain, commonMain, jvmTest, commonTest sourcesets.

=> this means there is no correct mapping from 1) to 2) i.e sync fails.

so...@google.com <so...@google.com> #8Feb 12, 2022 11:17PM

Fixed?

ir...@gmail.com <ir...@gmail.com> #9Feb 15, 2022 04:43AM

still fails AS Dolphin Canary 3

ss...@gmail.com <ss...@gmail.com> #10Mar 9, 2022 10:14PM

Still failing in AS Dolphin Canary 5

cp...@gmail.com <cp...@gmail.com> #11Mar 15, 2022 05:23PM

Still failing in AS Dolphin Canary 6

sm...@google.com <sm...@google.com> #12Apr 7, 2022 05:16PM

Marked as fixed.

Thanks for the report, this should be fixed in the upcoming Dolphin betas please let us know if this it not the case.

an...@gmail.com <an...@gmail.com> #13Apr 13, 2022 10:24AM

Thanks! It's not clear from your message, but will it also be backported to a Chipmunk release too, as the issue started to appear starting from that version?

sm...@google.com <sm...@google.com> #14Apr 13, 2022 11:10AM

There will be a limited fix included within Chipmunk, it will stop crashing and should set up direct dependencies on KMP modules (your example project should work okay) however it might not setup dependencies on some KMP source set modules (e.g commonMain). These other KMP dependencies should all be there the latest Dolphin Canaries however.

de...@google.com <de...@google.com> #15Apr 21, 2022 11:39PM