New Splashscreen crashes Android 9 [210367198]

Fixed

Bug

Needs Info

core-splashscreen

Status Update

No update yet.

Description

ap...@gtempaccount.com

created issue #1

Dec 13, 2021 05:51PM

The new androidx.core:core-splashscreen:1.0.0-alpha02 is crashing android 9 devices (leads to a direct reboot) - reproducible by implementing the new splash screen according to the official guide* and running on Android 9 Emulator.

*

https://developer.android.com/guide/topics/ui/splash-screen/migrate
Steps to reproduce
- Traget/compileSDK 31
- Add dependency
- Create splash screen theme in styles.xml
- Add style to main/launch activity
- Add installSplashScreen() to said activity
- Run on Android 9 device/emulator

Comments

al...@google.com <al...@google.com> Dec 13, 2021 05:56PM

Reassigned to ca...@google.com.

ca...@google.com <ca...@google.com> #2Dec 13, 2021 06:48PM

The splash screen is dismissed as soon as the app is drawn and doesn't wait for the animation to finish which might be the reason why the animation doesn't repeat. At most, the icon will animate for the value set in windowSplashScreenAnimationDuration.

If that's not the case, can you please share your theme values and icon file? or at least a reproduction sample?

ap...@gtempaccount.com <ap...@gtempaccount.com> #3Dec 13, 2021 06:52PM

windowSplashScreenAnimationDuration is set 10000.
windowSplashScreenBackground is #fff and #000 for dark theme.

The animation duration of Animated Vector Drawable is 1600.

I might not be able to share the icon since it is the one we are going to use in production. Is there any working Animated Vector Drawable you can provide from your side for us to compare? Anything from unit test?

ca...@google.com <ca...@google.com> #4Dec 13, 2021 07:02PM

Here is the sample of Animated Vector Drawable. (Not the one mentioned earlier)

ca...@google.com <ca...@google.com> #5Jan 18, 2022 10:14AM

Status: Won't Fix (Infeasible)

In the <objectAnimator tag, you need the repeat* attributes

<objectAnimator xmlns:android="http://schemas.android.com/apk/res/android"
    android:duration="1000"
    android:valueTo="200"
    android:valueType="floatType"
    android:propertyName="y"
    android:repeatCount="1"
    android:repeatMode="reverse"/>

https://developer.android.com/reference/android/animation/ObjectAnimator

ap...@gtempaccount.com <ap...@gtempaccount.com> #6Jan 18, 2022 08:39PM

It makes sense for objectAnimator that all have the same startOffset and duration. What if there are series of objectAnimator which have different startOffset as the attachment - test_anim_2.xml?

ap...@gtempaccount.com <ap...@gtempaccount.com> #7Jan 18, 2022 08:56PM

test_anim_3.xml has the expected effect. However, I try to avoid creating lots of objectAnimator for repeating animator. It will be great, if core-splashscreen API can support it.

Message last modified on Jan 18, 2022 09:00PM

ca...@google.com <ca...@google.com> #8Jan 19, 2022 10:25AM

Status: Assigned (reopened)

In that case, you'd need to manually make you application repeat using other ObjecAnimator. Since the splash screen is supposed to be short lived, an animation shouldn't need to be repeated. If the loading time of your application is too high and require the use of some progress indicator, then I suggest to implement that in the app directly, ideally using skeletons loaders (https://medium.com/android-dev-nation/android-skeleton-loaders-1ae979a9d8c9)

ca...@google.com <ca...@google.com> #9Jan 19, 2022 10:37AM

Marked as fixed.

Understood. However, we still think it's useful to have core-splashscreen API support animation replay. Thank you!

Message last modified on Jan 19, 2022 10:37AM

ap...@gtempaccount.com <ap...@gtempaccount.com> #10Jan 24, 2022 05:21PM

That's definitely something worth discussing internally, I've added it to the list of thing to consider for the next version. Thanks for your feedback.

ap...@gtempaccount.com <ap...@gtempaccount.com> #11Jan 24, 2022 05:42PM

Sadly still not working - now the splashscreen is shown (although not with the actual logo but only with the default android placeholder) but the app is still not opening, heres the crash

2022-01-24 18:35:19.874 9946-9946/com.xx.yy E/AndroidRuntime: FATAL EXCEPTION: main
Process: com.xx.yy, PID: 9946
java.lang.RuntimeException: Unable to start activity ComponentInfo{com.xx.yy/com.xx.yy.MainActivity}: java.lang.IllegalStateException: You need to use a Theme.AppCompat theme (or descendant) with this activity.
at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:2913)
at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:3048)
at android.app.servertransaction.LaunchActivityItem.execute(LaunchActivityItem.java:78)
at android.app.servertransaction.TransactionExecutor.executeCallbacks(TransactionExecutor.java:108)
at android.app.servertransaction.TransactionExecutor.execute(TransactionExecutor.java:68)
at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1808)
at android.os.Handler.dispatchMessage(Handler.java:106)
at android.os.Looper.loop(Looper.java:193)
at android.app.ActivityThread.main(ActivityThread.java:6669)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:493)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:858)
Caused by: java.lang.IllegalStateException: You need to use a Theme.AppCompat theme (or descendant) with this activity.
at androidx.appcompat.app.AppCompatDelegateImpl.createSubDecor(AppCompatDelegateImpl.java:852)
at androidx.appcompat.app.AppCompatDelegateImpl.ensureSubDecor(AppCompatDelegateImpl.java:815)
at androidx.appcompat.app.AppCompatDelegateImpl.setContentView(AppCompatDelegateImpl.java:703)
at androidx.appcompat.app.AppCompatActivity.setContentView(AppCompatActivity.java:195)
at com.xx.yy.MainActivity.onCreate(MainActivity.kt:42)
at android.app.Activity.performCreate(Activity.java:7136)
at android.app.Activity.performCreate(Activity.java:7127)
at android.app.Instrumentation.callActivityOnCreate(Instrumentation.java:1271)
at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:2893)
at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:3048)
at android.app.servertransaction.LaunchActivityItem.execute(LaunchActivityItem.java:78)
at android.app.servertransaction.TransactionExecutor.executeCallbacks(TransactionExecutor.java:108)
at android.app.servertransaction.TransactionExecutor.execute(TransactionExecutor.java:68)
at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1808)
at android.os.Handler.dispatchMessage(Handler.java:106)
at android.os.Looper.loop(Looper.java:193)
at android.app.ActivityThread.main(ActivityThread.java:6669)
at android.app.Instrumentation.callActivityOnCreate(Instrumentation.java:1271)
at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:2893)
at java.lang.reflect.Method.invoke(Native Method)
at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:3048)
at android.app.servertransaction.LaunchActivityItem.execute(LaunchActivityItem.java:78)
at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:493)
at android.app.servertransaction.TransactionExecutor.executeCallbacks(TransactionExecutor.java:108)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:858)
at android.app.servertransaction.TransactionExecutor.execute(TransactionExecutor.java:68)
at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1808)
at android.os.Handler.dispatchMessage(Handler.java:106)
at android.os.Looper.loop(Looper.java:193)
at android.app.ActivityThread.main(ActivityThread.java:6669)

using the current 1.0.0-beta01
style is still the one posted above, the postSplashScreenTheme is a descendant of Theme.AppCompat.Light.NoActionBar

Message last modified on Jan 24, 2022 05:45PM

ca...@google.com <ca...@google.com> #12Jan 24, 2022 05:52PM

Did you call installSplashScreen() before super.onCreate()?

Can you share your manifest and themes files?

ca...@google.com <ca...@google.com> #13Jan 24, 2022 05:54PM

although not with the actual logo but only with the default android placeholder

That's because you didn't set windowSplashScreenAnimatedIcon, at least in comment#7

Message last modified on Jan 24, 2022 06:01PM

ap...@gtempaccount.com <ap...@gtempaccount.com> #14Jan 25, 2022 09:02AM

yea that was it, i had installSplashscreen after the super.oncreate thanks a lot!
EDITED: sorry for the false negative before, i sometimes have issues with android studio not rebuilding correctly (mixing up ressources, cache etc.)

windowSplashScreenAnimatedIcon
isnt the app icon (from manifest) the default?

Message last modified on Jan 25, 2022 09:46AM

ca...@google.com <ca...@google.com> #15Jan 25, 2022 09:31AM

Thanks for checking.

windowSplashScreenAnimatedIcon
isnt the app icon (from manifest) the default?

Unfortunately no, because there is no way to read the manifest from the theme file or tell the system to do so, and there is no default theme attribute pointing to the launcher icon.

To help me debug, can you please check if the issue arises when the android:theme="@style/SplashTheme" is used on the <application> tag?

Message last modified on Jan 25, 2022 09:31AM

ap...@gtempaccount.com <ap...@gtempaccount.com> #16Jan 25, 2022 09:43AM

I see, so how do i get the icon then, i only have foreground/background.xml or can i use mipmap?

EDIT: mipmap seems so work, but the scale is off, is there an autofit setting?

Message last modified on Jan 25, 2022 09:54AM

ca...@google.com <ca...@google.com> #17Jan 25, 2022 09:59AM

No there is not autofit setting, your icon should follow the adaptive icon guidelines If you are using an adaptive icon for your launcher icon, then using the foreground of the adaptive icon as the the splash screen icon will work.