Assistant does not forward focus parameter [212779546]

Obsolete

Bug

[AOSP] assigned

NeedsInfo

Status Update

No update yet.

Description

da...@soundcloud.com

created issue #1

Jan 2, 2022 11:44AM

The documentation for handling voice searches

https://developer.android.com/guide/topics/media-apps/interacting-with-assistant#parse_voice
is showing in the sample to check the parameter
MediaStore.EXTRA_MEDIA_FOCUS
and check against constants like MediaStore.Audio.Artists.ENTRY_CONTENT_TYPE.

In reality though, the focus parameter is *always* generic
vnd.android.cursor.item/*
!
This was confirmed by our technical Google contact for Android Auto. The assistant does not forward this parameter to media apps.

It would be good to either fix this in the system or to upgrade the samples in the documentation.

faulty code (1:1 from documentation):

override fun onPlayFromSearch(query: String?, extras: Bundle?) {
// ...
// Build a queue based on songs that match "query" or "extras" param
val mediaFocus: String? = extras?.getString(MediaStore.EXTRA_MEDIA_FOCUS)
if (mediaFocus == MediaStore.Audio.Artists.ENTRY_CONTENT_TYPE) {
isArtistFocus = true
artist = extras.getString(MediaStore.EXTRA_MEDIA_ARTIST)
} else if (mediaFocus == MediaStore.Audio.Albums.ENTRY_CONTENT_TYPE) {
isAlbumFocus = true
album = extras.getString(MediaStore.EXTRA_MEDIA_ALBUM)
}
// ...

The same goes for UAMP app, I can open an issue and even open PR there once this is confirmed here on this thread.

https://github.com/android/uamp/blob/99e44c1c5106218c62eff552b64bbc12f1883a22/common/src/main/java/com/example/android/uamp/media/library/MusicSource.kt

Comments

at...@google.com <at...@google.com> Jan 3, 2022 04:31AM

Assigned to at...@google.com.

at...@google.com <at...@google.com> #2Jan 4, 2022 05:57AM

This is similar to this bug report as well: https://issuetracker.google.com/issues/172590946

at...@google.com <at...@google.com> #3Apr 1, 2022 05:54AM

Reassigned to ra...@google.com.

Hi Yinglei, re-assigning back to you as you're currently working on exactly this for Snackbars.

ra...@google.com <ra...@google.com> #4Jan 30, 2023 07:19AM

Project: platform/frameworks/support
Branch: androidx-main

commit 506fcdecc2dc257b58c574006d70ea9ce6f0bfda
Author: Yinglei Wang <yingleiw@google.com>
Date: Fri Feb 26 15:58:00 2021

add semantics liveRegion and apply it to snackbar

Snackbar should be marked as live region for accessibility. When talkback
is on, the snackbar is announced when it appears. Also added dismiss
action for the snackbar.

Note that since we are not merging up the tree for subtree change
events, we don't need to do extra work for live region. From android
documentation and discussion with Phil, the throttling delay is fine for
accessibility events from live region.

Relnote: "LiveRegion accessibility API is added.
If node is marked as a live region, the accessibility services
will automatically notify the user about its changes"

Fix:

b/153644625

b/172590946

b/182834687

Test: tested manully with talkback on. Unit tests added.

Change-Id: Idcf6f425b12b005e59ad77fe7430e466132ea87c

M compose/material/material/src/androidAndroidTest/kotlin/androidx/compose/material/SnackbarHostTest.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/SnackbarHost.kt
M compose/ui/ui/api/1.0.0-beta04.txt
M compose/ui/ui/api/current.txt
M compose/ui/ui/api/public_plus_experimental_1.0.0-beta04.txt
M compose/ui/ui/api/public_plus_experimental_current.txt
M compose/ui/ui/api/restricted_1.0.0-beta04.txt
M compose/ui/ui/api/restricted_current.txt
M compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/AndroidComposeViewAccessibilityDelegateCompatTest.kt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/platform/AndroidComposeViewAccessibilityDelegateCompat.android.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/semantics/SemanticsProperties.kt

https://android-review.googlesource.com/1580798

ra...@google.com <ra...@google.com> #5Feb 6, 2023 04:50AM

Please provide the requested information to proceed further. Unfortunately the issue will be closed within 7 days if there is no further update.

da...@soundcloud.com <da...@soundcloud.com> #6Feb 7, 2023 09:32AM

Not sure where to see Assistant version. But it seems this was fixed.
On latest Android 12 I get correct information:
"android.intent.extra.focus -> vnd.android.cursor.item/album"

ra...@google.com <ra...@google.com> #7Feb 8, 2023 05:47AM

Status: Won't Fix (Obsolete)

Thanks for the information. Closing this issue as per above comment .