Compose's compiler plugin breaks when moshi-ir plugin is present [213578515]

Obsolete

Bug

Status Update

No update yet.

Description

za...@gmail.com

created issue #1

Jan 7, 2022 09:44PM

When enabling another compiler plugin on the same project as compose, compose (indirectly) causes a non-descript error to fail the build. In my case, it's using the moshi-ir plugin from here: https://github.com/ZacSweers/MoshiX/tree/main/moshi-ir

Jetpack Compose release version: 1.1.0-rc01 Android Studio Build: N/A command line Kotlin version: 1.6.10

Steps to Reproduce:

Compile a project using both compose and moshi-ir
Observe this failure

e: java.lang.IllegalStateException: IrTypeParameterSymbolImpl is already bound: TYPE_PARAMETER name:T index:0 variance: superTypes:[kotlin.Any?]
        at org.jetbrains.kotlin.ir.symbols.impl.IrBindableSymbolBase.bind(IrPrivateSymbolBase.kt:64)
        at org.jetbrains.kotlin.ir.declarations.impl.IrTypeParameterImpl.<init>(IrTypeParameterImpl.kt:42)
        at org.jetbrains.kotlin.ir.declarations.impl.IrFactoryImpl.createTypeParameter(IrFactoryImpl.kt:227)
        at org.jetbrains.kotlin.ir.util.DeepCopyIrTreeWithSymbols.copyTypeParameter(DeepCopyIrTreeWithSymbols.kt:330)
        at org.jetbrains.kotlin.ir.util.DeepCopyIrTreeWithSymbols.copyTypeParametersFrom(DeepCopyIrTreeWithSymbols.kt:344)
        at org.jetbrains.kotlin.ir.util.DeepCopyIrTreeWithSymbols.visitClass(DeepCopyIrTreeWithSymbols.kt:155)
        at androidx.compose.compiler.plugins.kotlin.lower.DeepCopyIrTreeWithSymbolsPreservingMetadata.visitClass(ComposableTypeRemapper.kt:83)
        at androidx.compose.compiler.plugins.kotlin.lower.DeepCopyIrTreeWithSymbolsPreservingMetadata.visitClass(ComposableTypeRemapper.kt:74)
        at org.jetbrains.kotlin.ir.visitors.IrElementTransformerVoid.visitClass(IrElementTransformerVoid.kt:67)
        at org.jetbrains.kotlin.ir.visitors.IrElementTransformerVoid.visitClass(IrElementTransformerVoid.kt:24)
        at org.jetbrains.kotlin.ir.declarations.IrClass.accept(IrClass.kt:55)
        at org.jetbrains.kotlin.ir.IrElement$DefaultImpls.transform(IrElement.kt:32)
        at org.jetbrains.kotlin.ir.IrElementBase.transform(IrElementBase.kt:19)
        at org.jetbrains.kotlin.ir.util.DeepCopyIrTreeWithSymbols.transformDeclarationsTo(DeepCopyIrTreeWithSymbols.kt:834)
        at org.jetbrains.kotlin.ir.util.DeepCopyIrTreeWithSymbols.visitFile(DeepCopyIrTreeWithSymbols.kt:115)
        at androidx.compose.compiler.plugins.kotlin.lower.DeepCopyIrTreeWithSymbolsPreservingMetadata.visitFile(ComposableTypeRemapper.kt:125)
        at org.jetbrains.kotlin.ir.visitors.IrElementTransformerVoid.visitFile(IrElementTransformerVoid.kt:48)
        at org.jetbrains.kotlin.ir.visitors.IrElementTransformerVoid.visitFile(IrElementTransformerVoid.kt:24)
        at org.jetbrains.kotlin.ir.declarations.impl.IrFileImpl.accept(IrFileImpl.kt:81)
        at org.jetbrains.kotlin.ir.declarations.IrFile.transform(IrFile.kt:52)
        at org.jetbrains.kotlin.ir.declarations.impl.IrModuleFragmentImpl.transformChildren(IrModuleFragmentImpl.kt:45)
        at androidx.compose.compiler.plugins.kotlin.lower.ComposerParamTransformer.lower(ComposerParamTransformer.kt:138)
        at androidx.compose.compiler.plugins.kotlin.ComposeIrGenerationExtension.generate(ComposeIrGenerationExtension.kt:153)
        at org.jetbrains.kotlin.backend.jvm.JvmIrCodegenFactory.convertToIr$lambda-1(JvmIrCodegenFactory.kt:121)
        at org.jetbrains.kotlin.psi2ir.Psi2IrTranslator.generateModuleFragment(Psi2IrTranslator.kt:88)
        at org.jetbrains.kotlin.backend.jvm.JvmIrCodegenFactory.convertToIr(JvmIrCodegenFactory.kt:146)
        at org.jetbrains.kotlin.backend.jvm.JvmIrCodegenFactory.convertToIr$default(JvmIrCodegenFactory.kt:64)
        at org.jetbrains.kotlin.backend.jvm.JvmIrCodegenFactory.generateModule(JvmIrCodegenFactory.kt:59)
        at org.jetbrains.kotlin.codegen.KotlinCodegenFacade.compileCorrectFiles(KotlinCodegenFacade.java:35)
        at org.jetbrains.kotlin.cli.jvm.compiler.KotlinToJVMBytecodeCompiler.generate(KotlinToJVMBytecodeCompiler.kt:331)

moshi-ir simply visits a class and adds a new generated one to the IrFile. As far as I can tell in my internal repro case, there is no compose-related APIs in this subproject nor any files that moshi-IR runs over.

Comments

za...@gmail.com <za...@gmail.com> #2Jan 7, 2022 10:19PM

You need to temporarily add following to your build.gradle:

tasks.withType(KotlinCompile).configureEach {
    kotlinOptions {
        freeCompilerArgs += [
                "-Xjvm-default=all",
        ]
    }
}

Note that in certain circumstances you may want to use all-compatibility instead of all, learn more about that in Jebrain's blogpost.

Starting with kotlin 1.6.20 you won't need touch build.gradle for more information see KT-47000

ch...@google.com <ch...@google.com> #3Jan 7, 2022 11:01PM

Assigned to ch...@google.com.

Which of the build.gradle files am I to add the code above as there are 2 build.gradle files

za...@gmail.com <za...@gmail.com> #4Jan 8, 2022 12:44AM

en el Module.

ch...@google.com <ch...@google.com> #5Jan 10, 2022 05:39PM

I have tried adding the code in various places in my Module level build.gradle but keep receiving the error

Caused by: groovy.lang.MissingPropertyException: Could not get unknown property 'KotlinCompile' for extension 'android' of type com.android.build.gradle.internal.dsl.BaseAppModuleExtension.
	at org.gradle.internal.metaobject.AbstractDynamicObject.getMissingProperty(AbstractDynamicObject.java:85)
	at org.gradle.internal.metaobject.ConfigureDelegate.getProperty(ConfigureDelegate.java:130)

Can you please provide a more detailed example of how to use the temporary code within a Module level build.gradle file?

za...@gmail.com <za...@gmail.com> #6Jan 11, 2022 06:01AM

This is what worked for me. Try adding the code to app level build.gradle file:

android {
   ...
   kotlinOptions {
       ...
       freeCompilerArgs += [
                "-Xjvm-default=all",
        ]
   }
}

za...@gmail.com <za...@gmail.com> #7Jan 11, 2022 04:29PM

deleted

ch...@google.com <ch...@google.com> #8Jan 11, 2022 05:14PM

Status: Won't Fix (Obsolete)

deleted