No allocations counted when benchmarking with the profiler [214253245]

Fixed

Feature Request

Status Update

No update yet.

Description

ml...@google.com

created issue #1

Jan 12, 2022 06:47PM

Version used: 1.1.0-alpha13 Devices/Android versions reproduced on: any

Currently when running benchmarks with the profiler attached (either StackSampling or MethodTracing), it doesn't calculate allocations, therefore devs need to choose between:

profiling their benchmarks
having allocations counted

Both is not possible.

It would be nice to keep allocations counted even if the phase is not profiled.

Comments

ap...@google.com <ap...@google.com> #2Jan 14, 2022 01:32AM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit edaec69025bf0500388102f87b95f097e96be695
Author: Chris Craik <ccraik@google.com>
Date: Thu Jan 13 15:31:16 2022

Link profiler results in Studio output

Fixes: 214440748
Fixes: 214253245

Test: TrivialKotlinBenchmark # with "StackSampling" profiler enabled
Test: ./gradlew benchmark:benchmark-common:cC

Relnote: "Microbenchmark Stack Sampling / Method Tracing Profile
results are now linked in studio output, and do not suppress the
allocation metric."

Change-Id: Idcb65521f8f477be80455c8bbdd846eadd5bc2ce

M benchmark/benchmark-common/src/main/java/androidx/benchmark/BenchmarkState.kt
M benchmark/benchmark-common/src/androidTest/java/androidx/benchmark/InstrumentationResultsTest.kt
M benchmark/benchmark-common/src/main/java/androidx/benchmark/Profiler.kt
M benchmark/benchmark-common/src/androidTest/java/androidx/benchmark/BenchmarkStateTest.kt
M benchmark/benchmark-common/src/main/java/androidx/benchmark/InstrumentationResults.kt

https://android-review.googlesource.com/1949587

Issue 214253245

Description

Issue summary

Comments

ap...@google.com <ap...@google.com> #2Jan 14, 2022 01:32AM

Add comment

Issue metadata