Assigned
Status Update
No update yet.
Comments
ca...@google.com
ca...@google.com
removed the dup; this is possibly about how android spans work on empty strings.
- the calculation in the composable level seemed correct but the layout was not
- it happens for a new line as well
- one problem with both includeFontPadding true/false is that the cursor height is possibly can be visually improved to match the text ascent/descent rather than line top/bottom (might be challenging)
ca...@google.com
I do not fully understand your points, though I was wondering if a similar "trick" to measure "HHHHHHHHHHH" cannot be used here, because if I'm not mistaken the cursor gets drawn by text layout measuring on empty string.
da...@gmail.com
StaticLayout does not call LineHeightSpan's for empty sstring (or the empty final line at the end of the string - a string that ends with "\n")
da...@gmail.com
Project: platform/frameworks/support
Branch: androidx-main
commit b7a67dc25a34b254adbaffd02495b5c6d26ee18c
Author: siyamed <siyamed@google.com>
Date: Thu Jul 28 08:06:35 2022
Fix TextField empty line lineHeight (2)
When a line is empty (including empty text) StaticLayout
does not apply the LineHeightSpans.
This causes the line height to be different for an empty
line compared to a non empty line. The issue becomes more
visible within TextField .
This CL stores adjustment values to report the height and the
last line metrics correctly.
For the other solution option please see aosp/2170504
Performance
There are no performance differences for cases where text
is not empty or does not end with "\n"
The below numbers are for the cases where text is empty or ends with "\n"
+--------+-----------+-----------+------+
| | Before | After | Diff |
+--------+-----------+-----------+------+
| length | ns | ns | ns |
| 0 | 115,835 | 180,161 | 56% |
| 16 | 395,679 | 484,748 | 23% |
| 32 | 513,235 | 590,783 | 15% |
| 64 | 807,133 | 901,896 | 12% |
| 128 | 1,330,733 | 1,421,371 | 7% |
| 256 | 2,338,534 | 2,464,810 | 5% |
+--------+-----------+-----------+------+
Test: Added test
Test: ./gradlew text:text:test
Test: ./gradlew text:text:cAT
Test: ./gradlew compose:ui:ui-text:test
Test: ./gradlew compose:ui:ui-text:cAT
Test: Treehugger
Bug: 236615813
Change-Id: I57f8b6632f569ad06e547cf6ec83df1bc42845c9
M compose/ui/ui-text/lint-baseline.xml
M compose/ui/ui-text/benchmark/src/androidTest/java/androidx/compose/ui/text/benchmark/input/EditProcessorBenchmark.kt
M compose/ui/ui-text/benchmark/src/androidTest/java/androidx/compose/ui/text/benchmark/ParagraphBenchmark.kt
M compose/ui/ui-text/benchmark/src/main/java/androidx/compose/ui/text/benchmark/TextBenchmarkHelper.kt
M compose/ui/ui-text/src/androidAndroidTest/kotlin/androidx/compose/ui/text/ParagraphIntegrationLineHeightStyleTest.kt
M text/text/src/main/java/androidx/compose/ui/text/android/style/LineHeightStyleSpan.kt
A compose/ui/ui-text/benchmark/src/androidTest/java/androidx/compose/ui/text/benchmark/ParagraphWithLineHeightBenchmark.kt
M text/text/src/main/java/androidx/compose/ui/text/android/TextLayout.kt
M compose/ui/ui-text/benchmark/src/androidTest/java/androidx/compose/ui/text/benchmark/TextMeasurerBenchmark.kt
M compose/ui/ui-text/src/androidMain/kotlin/androidx/compose/ui/text/platform/extensions/SpannableExtensions.android.kt
https://android-review.googlesource.com/2168642
Branch: androidx-main
commit b7a67dc25a34b254adbaffd02495b5c6d26ee18c
Author: siyamed <siyamed@google.com>
Date: Thu Jul 28 08:06:35 2022
Fix TextField empty line lineHeight (2)
When a line is empty (including empty text) StaticLayout
does not apply the LineHeightSpans.
This causes the line height to be different for an empty
line compared to a non empty line. The issue becomes more
visible within TextField .
This CL stores adjustment values to report the height and the
last line metrics correctly.
For the other solution option please see aosp/2170504
Performance
There are no performance differences for cases where text
is not empty or does not end with "\n"
The below numbers are for the cases where text is empty or ends with "\n"
+--------+-----------+-----------+------+
| | Before | After | Diff |
+--------+-----------+-----------+------+
| length | ns | ns | ns |
| 0 | 115,835 | 180,161 | 56% |
| 16 | 395,679 | 484,748 | 23% |
| 32 | 513,235 | 590,783 | 15% |
| 64 | 807,133 | 901,896 | 12% |
| 128 | 1,330,733 | 1,421,371 | 7% |
| 256 | 2,338,534 | 2,464,810 | 5% |
+--------+-----------+-----------+------+
Test: Added test
Test: ./gradlew text:text:test
Test: ./gradlew text:text:cAT
Test: ./gradlew compose:ui:ui-text:test
Test: ./gradlew compose:ui:ui-text:cAT
Test: Treehugger
Bug: 236615813
Change-Id: I57f8b6632f569ad06e547cf6ec83df1bc42845c9
M compose/ui/ui-text/lint-baseline.xml
M compose/ui/ui-text/benchmark/src/androidTest/java/androidx/compose/ui/text/benchmark/input/EditProcessorBenchmark.kt
M compose/ui/ui-text/benchmark/src/androidTest/java/androidx/compose/ui/text/benchmark/ParagraphBenchmark.kt
M compose/ui/ui-text/benchmark/src/main/java/androidx/compose/ui/text/benchmark/TextBenchmarkHelper.kt
M compose/ui/ui-text/src/androidAndroidTest/kotlin/androidx/compose/ui/text/ParagraphIntegrationLineHeightStyleTest.kt
M text/text/src/main/java/androidx/compose/ui/text/android/style/LineHeightStyleSpan.kt
A compose/ui/ui-text/benchmark/src/androidTest/java/androidx/compose/ui/text/benchmark/ParagraphWithLineHeightBenchmark.kt
M text/text/src/main/java/androidx/compose/ui/text/android/TextLayout.kt
M compose/ui/ui-text/benchmark/src/androidTest/java/androidx/compose/ui/text/benchmark/TextMeasurerBenchmark.kt
M compose/ui/ui-text/src/androidMain/kotlin/androidx/compose/ui/text/platform/extensions/SpannableExtensions.android.kt
ca...@google.com
Thank you for fixing this. Will be this cherry-picked to 1.2.x release?
Description
Component used: Core-splashscreen Version used: 1.0.0-beta01 Devices/Android versions reproduced on: Pixel 6 / api 31
In core-splashcreen-1.0.0-beta01,
Theme.Splashscreensetandroid:windowLayoutInDisplayCutoutModeparam is set toshortEdge. This flag value is kept after changing to thepostSplashScreenThemewhich is a surprising behavior.A workaround is to set back
android:windowLayoutInDisplayCutoutModeto default in thepostSplashScreenTheme.