Status Update
Comments
jb...@google.com <jb...@google.com>
ap...@google.com <ap...@google.com> #2
jb...@google.com <jb...@google.com> #3
Seems like this is already fixed in master as a side effect of
You'd want to add the snapshot repository to your repositories
block:
maven {
url "https://ci.android/com/builds/submitted/6080026/androidx_snapshot/latest/repository/"
}
then switch to androidx.fragment:fragment-ktx:1.3.0-SNAPSHOT
.
We'll look into cherry picking the changes into Fragment 1.2.0
gs...@gmail.com <gs...@gmail.com> #4
[Deleted User] <[Deleted User]> #5
Great, thanks for confirming.
While there isn't any specific changes needed for this issue (as the issue was already fixed before this bug was filed), I do want to explain what exactly is going to happen from a release process:
First, we'll be cherry picking in the changes needed into a Fragment 1.2.0-rc05 release (it was too late to hit rc04, which already went out earlier today). Namely, these two changes:
https://android-review.googlesource.com/1178750/ https://android-review.googlesource.com/1183079/ (this was the fix for the bug mentioned in , FWIW)comment#3
Secondly, we've added additional testing (in an unrelated, but fortuitously timed effort) specifically to cover this case to ensure this doesn't happen again in
Description
ComponentDialog
was added inDialog
that interacts correctly with theOnBackPressedDispatcher
. We should replace theDialog
inDialogFragment
withComponentDialog
.