Replace deprecated / frozen go linter [218608945]

Bug

Status Update

No update yet.

Description

ad...@collabora.corp-partner.google.com

created issue #1

Feb 9, 2022 12:39PM

During the Go uprev and GOPATH -> modules conversion work, I noticed the Go lint project (built by dev-go/golint ebuild) was deprecated and frozen upstream. For more details see this discussion.

There is no direct replacement, instead tools like go vet and staticcheck.io are recommended as replacements by upstream.

The go linter is used for example in the Go presumbit check hooks and TAST.

It might be a good idea to replace it to avoid unfixable bugs and support new Go languege features like generics which are added starting with Go v1.18.

Comments

bl...@google.com <bl...@google.com> #2Feb 9, 2022 12:43PM

Assigned to de...@google.com.

Thanks for reporting, would you be able to provide a reproducible case for when this incremental error occurs? The task for merging java resources has multiple incremental inputs depending on where the java resource originates - providing a sample project where this issue can be triggered will help the team narrow what task input is impacted. A longer stacktrace of the issue from #1 might also be useful.

ma...@google.com <ma...@google.com> #3Feb 9, 2022 04:35PM

Unfortunately I cannot reproduce it consistently. In fact I don't even know what triggers it (it seems to be some combination of changes).

Like I mentioned above, my hunch is that this is due to having several modules with the same name (impl). The resource in question (impl_debug.kotlin_module) contains the name of the Gradle module and it likely means that there will be conflicts since there are several modules with the same name.

The stack trace looks like this:

org.gradle.api.tasks.TaskExecutionException: Execution failed for task ':app:mergeDebugJavaResource'.	
	at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.lambda$executeIfValid$1(ExecuteActionsTaskExecuter.java:149)	
	at org.gradle.internal.Try$Failure.ifSuccessfulOrElse(Try.java:282)	
	at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.executeIfValid(ExecuteActionsTaskExecuter.java:147)	
	at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.execute(ExecuteActionsTaskExecuter.java:135)	
	at org.gradle.api.internal.tasks.execution.FinalizePropertiesTaskExecuter.execute(FinalizePropertiesTaskExecuter.java:46)	
	at org.gradle.api.internal.tasks.execution.ResolveTaskExecutionModeExecuter.execute(ResolveTaskExecutionModeExecuter.java:51)	
	at org.gradle.api.internal.tasks.execution.SkipTaskWithNoActionsExecuter.execute(SkipTaskWithNoActionsExecuter.java:57)	
	at org.gradle.api.internal.tasks.execution.SkipOnlyIfTaskExecuter.execute(SkipOnlyIfTaskExecuter.java:74)	
	at org.gradle.api.internal.tasks.execution.CatchExceptionTaskExecuter.execute(CatchExceptionTaskExecuter.java:36)	
	at org.gradle.api.internal.tasks.execution.EventFiringTaskExecuter$1.executeTask(EventFiringTaskExecuter.java:77)	
	at org.gradle.api.internal.tasks.execution.EventFiringTaskExecuter$1.call(EventFiringTaskExecuter.java:55)	
	at org.gradle.api.internal.tasks.execution.EventFiringTaskExecuter$1.call(EventFiringTaskExecuter.java:52)	
	at org.gradle.internal.operations.DefaultBuildOperationRunner$CallableBuildOperationWorker.execute(DefaultBuildOperationRunner.java:204)	
	at org.gradle.internal.operations.DefaultBuildOperationRunner$CallableBuildOperationWorker.execute(DefaultBuildOperationRunner.java:199)	
	at org.gradle.internal.operations.DefaultBuildOperationRunner$2.execute(DefaultBuildOperationRunner.java:66)	
	at org.gradle.internal.operations.DefaultBuildOperationRunner$2.execute(DefaultBuildOperationRunner.java:59)	
	at org.gradle.internal.operations.DefaultBuildOperationRunner.execute(DefaultBuildOperationRunner.java:157)	
	at org.gradle.internal.operations.DefaultBuildOperationRunner.execute(DefaultBuildOperationRunner.java:59)	
	at org.gradle.internal.operations.DefaultBuildOperationRunner.call(DefaultBuildOperationRunner.java:53)	
	at org.gradle.internal.operations.DefaultBuildOperationExecutor.call(DefaultBuildOperationExecutor.java:73)	
	at org.gradle.api.internal.tasks.execution.EventFiringTaskExecuter.execute(EventFiringTaskExecuter.java:52)	
	at org.gradle.execution.plan.LocalTaskNodeExecutor.execute(LocalTaskNodeExecutor.java:42)	
	at org.gradle.execution.taskgraph.DefaultTaskExecutionGraph$InvokeNodeExecutorsAction.execute(DefaultTaskExecutionGraph.java:337)	
	at org.gradle.execution.taskgraph.DefaultTaskExecutionGraph$InvokeNodeExecutorsAction.execute(DefaultTaskExecutionGraph.java:324)	
	at org.gradle.execution.taskgraph.DefaultTaskExecutionGraph$BuildOperationAwareExecutionAction.execute(DefaultTaskExecutionGraph.java:317)	
	at org.gradle.execution.taskgraph.DefaultTaskExecutionGraph$BuildOperationAwareExecutionAction.execute(DefaultTaskExecutionGraph.java:303)	
	at org.gradle.execution.plan.DefaultPlanExecutor$ExecutorWorker.execute(DefaultPlanExecutor.java:463)	
	at org.gradle.execution.plan.DefaultPlanExecutor$ExecutorWorker.run(DefaultPlanExecutor.java:380)	
	at org.gradle.internal.concurrent.ExecutorPolicy$CatchAndRecordFailures.onExecute(ExecutorPolicy.java:64)	
	at org.gradle.internal.concurrent.ManagedExecutorImpl$1.run(ManagedExecutorImpl.java:49)	
Caused by: org.gradle.workers.internal.DefaultWorkerExecutor$WorkExecutionException: A failure occurred while executing com.android.build.gradle.internal.tasks.MergeJavaResWorkAction	
	at org.gradle.workers.internal.DefaultWorkerExecutor$WorkItemExecution.waitForCompletion(DefaultWorkerExecutor.java:283)	
	at org.gradle.internal.work.DefaultAsyncWorkTracker.lambda$waitForItemsAndGatherFailures$2(DefaultAsyncWorkTracker.java:130)	
	at org.gradle.internal.Factories$1.create(Factories.java:31)	
	at org.gradle.internal.work.DefaultWorkerLeaseService.withoutLocks(DefaultWorkerLeaseService.java:321)	
	at org.gradle.internal.work.DefaultWorkerLeaseService.withoutLocks(DefaultWorkerLeaseService.java:304)	
	at org.gradle.internal.work.DefaultWorkerLeaseService.withoutLock(DefaultWorkerLeaseService.java:309)	
	at org.gradle.internal.work.DefaultAsyncWorkTracker.waitForItemsAndGatherFailures(DefaultAsyncWorkTracker.java:126)	
	at org.gradle.internal.work.DefaultAsyncWorkTracker.waitForItemsAndGatherFailures(DefaultAsyncWorkTracker.java:92)	
	at org.gradle.internal.work.DefaultAsyncWorkTracker.waitForAll(DefaultAsyncWorkTracker.java:78)	
	at org.gradle.internal.work.DefaultAsyncWorkTracker.waitForCompletion(DefaultAsyncWorkTracker.java:66)	
	at org.gradle.api.internal.tasks.execution.TaskExecution$3.run(TaskExecution.java:250)	
	at org.gradle.internal.operations.DefaultBuildOperationRunner$1.execute(DefaultBuildOperationRunner.java:29)	
	at org.gradle.internal.operations.DefaultBuildOperationRunner$1.execute(DefaultBuildOperationRunner.java:26)	
	at org.gradle.internal.operations.DefaultBuildOperationRunner$2.execute(DefaultBuildOperationRunner.java:66)	
	at org.gradle.internal.operations.DefaultBuildOperationRunner$2.execute(DefaultBuildOperationRunner.java:59)	
	at org.gradle.internal.operations.DefaultBuildOperationRunner.execute(DefaultBuildOperationRunner.java:157)	
	at org.gradle.internal.operations.DefaultBuildOperationRunner.execute(DefaultBuildOperationRunner.java:59)	
	at org.gradle.internal.operations.DefaultBuildOperationRunner.run(DefaultBuildOperationRunner.java:47)	
	at org.gradle.internal.operations.DefaultBuildOperationExecutor.run(DefaultBuildOperationExecutor.java:68)	
	at org.gradle.api.internal.tasks.execution.TaskExecution.executeAction(TaskExecution.java:227)	
	at org.gradle.api.internal.tasks.execution.TaskExecution.executeActions(TaskExecution.java:210)	
	at org.gradle.api.internal.tasks.execution.TaskExecution.executeWithPreviousOutputFiles(TaskExecution.java:193)	
	at org.gradle.api.internal.tasks.execution.TaskExecution.execute(TaskExecution.java:166)	
	at org.gradle.internal.execution.steps.ExecuteStep.executeInternal(ExecuteStep.java:105)	
	at org.gradle.internal.execution.steps.ExecuteStep.access$000(ExecuteStep.java:44)	
	at org.gradle.internal.execution.steps.ExecuteStep$1.call(ExecuteStep.java:59)	
	at org.gradle.internal.execution.steps.ExecuteStep$1.call(ExecuteStep.java:56)	
	at org.gradle.internal.operations.DefaultBuildOperationRunner$CallableBuildOperationWorker.execute(DefaultBuildOperationRunner.java:204)	
	at org.gradle.internal.operations.DefaultBuildOperationRunner$CallableBuildOperationWorker.execute(DefaultBuildOperationRunner.java:199)	
	at org.gradle.internal.operations.DefaultBuildOperationRunner$2.execute(DefaultBuildOperationRunner.java:66)	
	at org.gradle.internal.operations.DefaultBuildOperationRunner$2.execute(DefaultBuildOperationRunner.java:59)	
	at org.gradle.internal.operations.DefaultBuildOperationRunner.execute(DefaultBuildOperationRunner.java:157)	
	at org.gradle.internal.operations.DefaultBuildOperationRunner.execute(DefaultBuildOperationRunner.java:59)	
	at org.gradle.internal.operations.DefaultBuildOperationRunner.call(DefaultBuildOperationRunner.java:53)	
	at org.gradle.internal.operations.DefaultBuildOperationExecutor.call(DefaultBuildOperationExecutor.java:73)	
	at org.gradle.internal.execution.steps.ExecuteStep.execute(ExecuteStep.java:56)	
	at org.gradle.internal.execution.steps.ExecuteStep.execute(ExecuteStep.java:44)	
	at org.gradle.internal.execution.steps.RemovePreviousOutputsStep.execute(RemovePreviousOutputsStep.java:67)	
	at org.gradle.internal.execution.steps.RemovePreviousOutputsStep.execute(RemovePreviousOutputsStep.java:37)	
	at org.gradle.internal.execution.steps.CancelExecutionStep.execute(CancelExecutionStep.java:41)	
	at org.gradle.internal.execution.steps.TimeoutStep.executeWithoutTimeout(TimeoutStep.java:74)	
	at org.gradle.internal.execution.steps.TimeoutStep.execute(TimeoutStep.java:55)	
	at org.gradle.internal.execution.steps.CreateOutputsStep.execute(CreateOutputsStep.java:50)	
	at org.gradle.internal.execution.steps.CreateOutputsStep.execute(CreateOutputsStep.java:28)	
	at org.gradle.internal.execution.steps.CaptureStateAfterExecutionStep.executeDelegateBroadcastingChanges(CaptureStateAfterExecutionStep.java:100)	
	at org.gradle.internal.execution.steps.CaptureStateAfterExecutionStep.execute(CaptureStateAfterExecutionStep.java:72)	
	at org.gradle.internal.execution.steps.CaptureStateAfterExecutionStep.execute(CaptureStateAfterExecutionStep.java:50)	
	at org.gradle.internal.execution.steps.ResolveInputChangesStep.execute(ResolveInputChangesStep.java:40)	
	at org.gradle.internal.execution.steps.ResolveInputChangesStep.execute(ResolveInputChangesStep.java:29)	
	at org.gradle.internal.execution.steps.BuildCacheStep.executeWithoutCache(BuildCacheStep.java:166)	
	at org.gradle.internal.execution.steps.BuildCacheStep.lambda$execute$1(BuildCacheStep.java:70)	
	at org.gradle.internal.Either$Right.fold(Either.java:175)	
	at org.gradle.internal.execution.caching.CachingState.fold(CachingState.java:59)	
	at org.gradle.internal.execution.steps.BuildCacheStep.execute(BuildCacheStep.java:68)	
	at org.gradle.internal.execution.steps.BuildCacheStep.execute(BuildCacheStep.java:46)	
	at org.gradle.internal.execution.steps.StoreExecutionStateStep.execute(StoreExecutionStateStep.java:36)	
	at org.gradle.internal.execution.steps.StoreExecutionStateStep.execute(StoreExecutionStateStep.java:25)	
	at org.gradle.internal.execution.steps.RecordOutputsStep.execute(RecordOutputsStep.java:36)	
	at org.gradle.internal.execution.steps.RecordOutputsStep.execute(RecordOutputsStep.java:22)	
	at org.gradle.internal.execution.steps.SkipUpToDateStep.executeBecause(SkipUpToDateStep.java:91)	
	at org.gradle.internal.execution.steps.SkipUpToDateStep.lambda$execute$2(SkipUpToDateStep.java:55)	
	at org.gradle.internal.execution.steps.SkipUpToDateStep.execute(SkipUpToDateStep.java:55)	
	at org.gradle.internal.execution.steps.SkipUpToDateStep.execute(SkipUpToDateStep.java:37)	
	at org.gradle.internal.execution.steps.ResolveChangesStep.execute(ResolveChangesStep.java:65)	
	at org.gradle.internal.execution.steps.ResolveChangesStep.execute(ResolveChangesStep.java:36)	
	at org.gradle.internal.execution.steps.legacy.MarkSnapshottingInputsFinishedStep.execute(MarkSnapshottingInputsFinishedStep.java:37)	
	at org.gradle.internal.execution.steps.legacy.MarkSnapshottingInputsFinishedStep.execute(MarkSnapshottingInputsFinishedStep.java:27)	
	at org.gradle.internal.execution.steps.ResolveCachingStateStep.execute(ResolveCachingStateStep.java:76)	
	at org.gradle.internal.execution.steps.ResolveCachingStateStep.execute(ResolveCachingStateStep.java:37)	
	at org.gradle.internal.execution.steps.ValidateStep.execute(ValidateStep.java:94)	
	at org.gradle.internal.execution.steps.ValidateStep.execute(ValidateStep.java:49)	
	at org.gradle.internal.execution.steps.CaptureStateBeforeExecutionStep.execute(CaptureStateBeforeExecutionStep.java:71)	
	at org.gradle.internal.execution.steps.CaptureStateBeforeExecutionStep.execute(CaptureStateBeforeExecutionStep.java:45)	
	at org.gradle.internal.execution.steps.SkipEmptyWorkStep.executeWithNonEmptySources(SkipEmptyWorkStep.java:177)	
	at org.gradle.internal.execution.steps.SkipEmptyWorkStep.execute(SkipEmptyWorkStep.java:81)	
	at org.gradle.internal.execution.steps.SkipEmptyWorkStep.execute(SkipEmptyWorkStep.java:53)	
	at org.gradle.internal.execution.steps.RemoveUntrackedExecutionStateStep.execute(RemoveUntrackedExecutionStateStep.java:32)	
	at org.gradle.internal.execution.steps.RemoveUntrackedExecutionStateStep.execute(RemoveUntrackedExecutionStateStep.java:21)	
	at org.gradle.internal.execution.steps.legacy.MarkSnapshottingInputsStartedStep.execute(MarkSnapshottingInputsStartedStep.java:38)	
	at org.gradle.internal.execution.steps.LoadPreviousExecutionStateStep.execute(LoadPreviousExecutionStateStep.java:36)	
	at org.gradle.internal.execution.steps.LoadPreviousExecutionStateStep.execute(LoadPreviousExecutionStateStep.java:23)	
	at org.gradle.internal.execution.steps.CleanupStaleOutputsStep.execute(CleanupStaleOutputsStep.java:75)	
	at org.gradle.internal.execution.steps.CleanupStaleOutputsStep.execute(CleanupStaleOutputsStep.java:41)	
	at org.gradle.internal.execution.steps.AssignWorkspaceStep.lambda$execute$0(AssignWorkspaceStep.java:32)	
	at org.gradle.api.internal.tasks.execution.TaskExecution$4.withWorkspace(TaskExecution.java:287)	
	at org.gradle.internal.execution.steps.AssignWorkspaceStep.execute(AssignWorkspaceStep.java:30)	
	at org.gradle.internal.execution.steps.AssignWorkspaceStep.execute(AssignWorkspaceStep.java:21)	
	at org.gradle.internal.execution.steps.IdentityCacheStep.execute(IdentityCacheStep.java:37)	
	at org.gradle.internal.execution.steps.IdentityCacheStep.execute(IdentityCacheStep.java:27)	
	at org.gradle.internal.execution.steps.IdentifyStep.execute(IdentifyStep.java:47)	
	at org.gradle.internal.execution.steps.IdentifyStep.execute(IdentifyStep.java:34)	
	at org.gradle.internal.execution.impl.DefaultExecutionEngine$1.execute(DefaultExecutionEngine.java:64)	
	at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.executeIfValid(ExecuteActionsTaskExecuter.java:146)	
	at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.execute(ExecuteActionsTaskExecuter.java:135)	
	at org.gradle.api.internal.tasks.execution.FinalizePropertiesTaskExecuter.execute(FinalizePropertiesTaskExecuter.java:46)	
	at org.gradle.api.internal.tasks.execution.ResolveTaskExecutionModeExecuter.execute(ResolveTaskExecutionModeExecuter.java:51)	
	at org.gradle.api.internal.tasks.execution.SkipTaskWithNoActionsExecuter.execute(SkipTaskWithNoActionsExecuter.java:57)	
	at org.gradle.api.internal.tasks.execution.SkipOnlyIfTaskExecuter.execute(SkipOnlyIfTaskExecuter.java:74)	
	at org.gradle.api.internal.tasks.execution.CatchExceptionTaskExecuter.execute(CatchExceptionTaskExecuter.java:36)	
	at org.gradle.api.internal.tasks.execution.EventFiringTaskExecuter$1.executeTask(EventFiringTaskExecuter.java:77)	
	at org.gradle.api.internal.tasks.execution.EventFiringTaskExecuter$1.call(EventFiringTaskExecuter.java:55)	
	at org.gradle.api.internal.tasks.execution.EventFiringTaskExecuter$1.call(EventFiringTaskExecuter.java:52)	
	at org.gradle.internal.operations.DefaultBuildOperationRunner$CallableBuildOperationWorker.execute(DefaultBuildOperationRunner.java:204)	
	at org.gradle.internal.operations.DefaultBuildOperationRunner$CallableBuildOperationWorker.execute(DefaultBuildOperationRunner.java:199)	
	at org.gradle.internal.operations.DefaultBuildOperationRunner$2.execute(DefaultBuildOperationRunner.java:66)	
	at org.gradle.internal.operations.DefaultBuildOperationRunner$2.execute(DefaultBuildOperationRunner.java:59)	
	at org.gradle.internal.operations.DefaultBuildOperationRunner.execute(DefaultBuildOperationRunner.java:157)	
	at org.gradle.internal.operations.DefaultBuildOperationRunner.execute(DefaultBuildOperationRunner.java:59)	
	at org.gradle.internal.operations.DefaultBuildOperationRunner.call(DefaultBuildOperationRunner.java:53)	
	at org.gradle.internal.operations.DefaultBuildOperationExecutor.call(DefaultBuildOperationExecutor.java:73)	
	at org.gradle.api.internal.tasks.execution.EventFiringTaskExecuter.execute(EventFiringTaskExecuter.java:52)	
	at org.gradle.execution.plan.LocalTaskNodeExecutor.execute(LocalTaskNodeExecutor.java:42)	
	at org.gradle.execution.taskgraph.DefaultTaskExecutionGraph$InvokeNodeExecutorsAction.execute(DefaultTaskExecutionGraph.java:337)	
	at org.gradle.execution.taskgraph.DefaultTaskExecutionGraph$InvokeNodeExecutorsAction.execute(DefaultTaskExecutionGraph.java:324)	
	at org.gradle.execution.taskgraph.DefaultTaskExecutionGraph$BuildOperationAwareExecutionAction.execute(DefaultTaskExecutionGraph.java:317)	
	at org.gradle.execution.taskgraph.DefaultTaskExecutionGraph$BuildOperationAwareExecutionAction.execute(DefaultTaskExecutionGraph.java:303)	
	at org.gradle.execution.plan.DefaultPlanExecutor$ExecutorWorker.execute(DefaultPlanExecutor.java:463)	
	at org.gradle.execution.plan.DefaultPlanExecutor$ExecutorWorker.run(DefaultPlanExecutor.java:380)	
	at org.gradle.internal.concurrent.ExecutorPolicy$CatchAndRecordFailures.onExecute(ExecutorPolicy.java:64)	
	at org.gradle.internal.concurrent.ManagedExecutorImpl$1.run(ManagedExecutorImpl.java:49)	
Caused by: java.lang.IllegalStateException: Unexpected combination of states CHANGED, REMOVED for file /path/to/module/build/intermediates/java_res/debug/out/META-INF/impl_debug.kotlin_module	
	at com.android.build.gradle.internal.tasks.IncrementalFileMergerTaskUtils.collectChanges(IncrementalFileMergerTaskUtils.kt:275)	
	at com.android.build.gradle.internal.tasks.IncrementalFileMergerTaskUtils.toInputs(IncrementalFileMergerTaskUtils.kt:229)	
	at com.android.build.gradle.internal.tasks.MergeJavaResWorkAction.run(MergeJavaResWorkAction.kt:68)	
	at com.android.build.gradle.internal.profile.ProfileAwareWorkAction.execute(ProfileAwareWorkAction.kt:74)	
	at org.gradle.workers.internal.DefaultWorkerServer.execute(DefaultWorkerServer.java:63)	
	at org.gradle.workers.internal.NoIsolationWorkerFactory$1$1.create(NoIsolationWorkerFactory.java:66)	
	at org.gradle.workers.internal.NoIsolationWorkerFactory$1$1.create(NoIsolationWorkerFactory.java:62)	
	at org.gradle.internal.classloader.ClassLoaderUtils.executeInClassloader(ClassLoaderUtils.java:100)	
	at org.gradle.workers.internal.NoIsolationWorkerFactory$1.lambda$execute$0(NoIsolationWorkerFactory.java:62)	
	at org.gradle.workers.internal.AbstractWorker$1.call(AbstractWorker.java:44)	
	at org.gradle.workers.internal.AbstractWorker$1.call(AbstractWorker.java:41)	
	at org.gradle.internal.operations.DefaultBuildOperationRunner$CallableBuildOperationWorker.execute(DefaultBuildOperationRunner.java:204)	
	at org.gradle.internal.operations.DefaultBuildOperationRunner$CallableBuildOperationWorker.execute(DefaultBuildOperationRunner.java:199)	
	at org.gradle.internal.operations.DefaultBuildOperationRunner$2.execute(DefaultBuildOperationRunner.java:66)	
	at org.gradle.internal.operations.DefaultBuildOperationRunner$2.execute(DefaultBuildOperationRunner.java:59)	
	at org.gradle.internal.operations.DefaultBuildOperationRunner.execute(DefaultBuildOperationRunner.java:157)	
	at org.gradle.internal.operations.DefaultBuildOperationRunner.execute(DefaultBuildOperationRunner.java:59)	
	at org.gradle.internal.operations.DefaultBuildOperationRunner.call(DefaultBuildOperationRunner.java:53)	
	at org.gradle.internal.operations.DefaultBuildOperationExecutor.call(DefaultBuildOperationExecutor.java:73)	
	at org.gradle.workers.internal.AbstractWorker.executeWrappedInBuildOperation(AbstractWorker.java:41)	
	at org.gradle.workers.internal.NoIsolationWorkerFactory$1.execute(NoIsolationWorkerFactory.java:59)	
	at org.gradle.workers.internal.DefaultWorkerExecutor.lambda$submitWork$0(DefaultWorkerExecutor.java:169)	
	at org.gradle.internal.work.DefaultConditionalExecutionQueue$ExecutionRunner.runExecution(DefaultConditionalExecutionQueue.java:187)	
	at org.gradle.internal.work.DefaultConditionalExecutionQueue$ExecutionRunner.access$700(DefaultConditionalExecutionQueue.java:120)	
	at org.gradle.internal.work.DefaultConditionalExecutionQueue$ExecutionRunner$1.run(DefaultConditionalExecutionQueue.java:162)	
	at org.gradle.internal.Factories$1.create(Factories.java:31)	
	at org.gradle.internal.work.DefaultWorkerLeaseService.withLocks(DefaultWorkerLeaseService.java:249)	
	at org.gradle.internal.work.DefaultWorkerLeaseService.runAsWorkerThread(DefaultWorkerLeaseService.java:109)	
	at org.gradle.internal.work.DefaultWorkerLeaseService.runAsWorkerThread(DefaultWorkerLeaseService.java:114)	
	at org.gradle.internal.work.DefaultConditionalExecutionQueue$ExecutionRunner.runBatch(DefaultConditionalExecutionQueue.java:157)	
	at org.gradle.internal.work.DefaultConditionalExecutionQueue$ExecutionRunner.run(DefaultConditionalExecutionQueue.java:126)	
	... 2 more

gb...@google.com <gb...@google.com> #4Feb 9, 2022 07:40PM

Thanks for the additional information. I have refactored the Java Resource merging incremental handling to better handle source file path roots - so hopefully this is enough to eliminate the possibility of collisions between java resources. However, it would be great to test these changes resolve your issue. My current assumption is that the issue occurs when there is a library structure where there are two modules of the same name nested within two differently named modules such as:

app
foo_lib
  foo
bar_lib
  foo

Could you confirm that this setup is similar in your project or if not, can you please provide your project structure or even a project if possible?

ry...@google.com <ry...@google.com> Feb 9, 2022 09:59PM

Reassigned to ry...@google.com.

ry...@google.com <ry...@google.com> #5Feb 10, 2022 05:31PM

Yes, our setup looks like this:

:features
  :feature1
    :public
    :impl
  :feature2
    :public
    :impl
...

The modules mentioned in the error would always be one of these impl or public modules.

Unfortunately I cannot share our project and even if I could, I don't know how to replicate the issue.

I will say though that since upgrading to the latest AGP 8.2 alpha I have not seen the issue so it's possible that it's already been fixed as a part of another change.

ad...@collabora.corp-partner.google.com <ad...@collabora.corp-partner.google.com> #6Feb 15, 2022 02:38PM

Oops, spoke too soon. It just happened.

Once it happens ever run will trigger it so if you need me to log or try something let me know. Removing the app level build directory fixes the issue.

bl...@google.com <bl...@google.com> #7May 10, 2022 02:42PM

BTW, what is the target release for this fix?

bl...@google.com <bl...@google.com> #8Aug 2, 2022 03:02PM

For now, we've worked around this by adding this to our Kotlin convention plugin:

tasks.withType<KotlinCompile>().configureEach {
    compilerOptions {
        moduleName.set(path.removePrefix(":").replace(":", "_"))
    }
}

gb...@google.com <gb...@google.com> #9Jun 28, 2024 02:50PM

Status: New

Thanks for sharing the workaround. I needed to slightly adapt it to work for us, otherwise kapt and ksp would fail because they'd expect different names for internal symbols.

tasks.withType(org.jetbrains.kotlin.gradle.tasks.KotlinCompilationTask.class).configureEach {
    if (!name.containsIgnoreCase("ksp") && !name.containsIgnoreCase("kapt")) {
       compilerOptions {
       moduleName.set(path.substring(1).replace(":", "_"))
    }
}

ar...@collabora.corp-partner.google.com <ar...@collabora.corp-partner.google.com> #10Aug 30, 2024 03:00PM

Actually, I found a better way to solve this. The default module name is based on the base plugin's archivesName property. So you can do this instead:

base {
    archivesName.set(path.removePrefix(":").replace(":", "_"))
}

ap...@google.com <ap...@google.com> #11Sep 9, 2024 05:49PM

It seems AGP is not correctly excluding kotlin_module files during java resource merging, so we'd expect a collision - although this error message isn't clear.

Until we release we have a fix for the issue, a workaround may be to add packagingOptions { exclude 'META-INF/*.kotlin_module' } to the build.gradle conflicting libraries, so AGP doesn't attempt to merge them.

ap...@google.com <ap...@google.com> #12Sep 16, 2024 11:11AM

Alternatively you can give them unique names e.g.

kotlin {
    compilerOptions {
        moduleName.set(project.path)
    }
}

applied to all projects

ap...@google.com <ap...@google.com> #13Sep 16, 2024 11:11AM

We set the module to the dashified project gradle path. Kinda feel like this should be the default for the module merging issue in general

ap...@google.com <ap...@google.com> #14Sep 16, 2024 11:11AM

In my case, I had similar errors with MergeJavaResourcesTask
But in my case, errors were against for META-INF metadata from Google AutoService instead of kotlin-module

And I did set same workaround with Comment #8, then errors were gone.

ap...@google.com <ap...@google.com> #15Sep 16, 2024 02:10PM

I also had an error from Google AutoService and packagingOptions { exclude 'META-INF/*.kotlin_module' } removes the error in next build but it does not look correct solution. Can someone help me to fix this issue. For my case the error is for some debug source code which we generate using Google AutoService. Should I exclude those files or use pickFirst for them?

ap...@google.com <ap...@google.com> #16Sep 16, 2024 02:11PM

We are currently also facing this issue sporadically. And applying the patch in

https://issuetracker.google.com/issues/284003132#comment8 doesn't seem to fully fix it. Is there any plan to tackle this in the future?

ap...@google.com <ap...@google.com> #17Sep 16, 2024 02:24PM

I have same issue again after Comment #14
I'm not sure, but I'm guessing that error was raised again after applied AGP 8.2

ap...@google.com <ap...@google.com> #18Sep 16, 2024 02:24PM

In my case, module A and module B have implementations of interface Xxx which can be loaded by AutoService.

and MergeJavaResourcesTask was failed of app C while merge META-INF/services/Xxx from module A and module B

ap...@google.com <ap...@google.com> #19Sep 16, 2024 07:34PM

I had previously applied the workaround from #10 to our build, however it caused packaging issues that manifested as runtime crashes. I'll be taking a second look at the workaround to see if I can fix our previous issues with it since we are starting to see this problem happen a lot more frequently. An issue with Anvil has been causing our developers to use --rerun and --rerun-tasks more frequently than usual, which masks the issue here. With the latest beta release of anvil, those options are no longer needed and this bug pops up a lot more frequently. We are using AGP 8.2.2 currently

ap...@google.com <ap...@google.com> #20Sep 20, 2024 11:12AM

With the latest beta release of anvil, those options are no longer needed and this bug pops up a lot more frequently.

It doesn't seem like the latest beta has resolved these issues :/ https://github.com/square/anvil/issues/876

ap...@google.com <ap...@google.com> #21Sep 23, 2024 03:33PM

Have been having the same issue in recent builds, rm -rf app/build is what helped in my case.

ap...@google.com <ap...@google.com> #22Sep 24, 2024 10:20AM

I've managed to get what looks like a reliable reproduction case for this.

ap...@google.com <ap...@google.com> #23Sep 24, 2024 01:48PM

This is mitigated in 22ea772c902a9891a6023ed1ebdc832871775ba6 but I am suspicious there are other lurking issues by inspection and from #comment19

ap...@google.com <ap...@google.com> #24Sep 24, 2024 06:59PM

Filed issue 327603250 to follow up, marking this as closed as the initial issue should no longer directly bite.

ap...@google.com <ap...@google.com> #25Sep 30, 2024 01:48PM

Thank you for your patience while our engineering team worked to resolve this issue. A fix for this issue is now available in:

Android Studio Jellyfish | 2023.3.1 Canary 12
Android Gradle Plugin 8.4.0-alpha12

We encourage you to try the latest update.

If you notice further issues or have questions, please file a new bug report.

Thank you for taking the time to submit feedback — we really appreciate it!

ap...@google.com <ap...@google.com> #26Oct 1, 2024 06:30PM

AGP 8.3 final version was released at today.
Could this fix be applied to AGP 8.3.x patch version?
Or is there another solution that can alleviate this issue?

ap...@google.com <ap...@google.com> #27Oct 2, 2024 10:56AM

Re #comment19 - are you using merge or pickFirst in packagingOptions?

ap...@google.com <ap...@google.com> #28Oct 2, 2024 02:09PM

No, we have some exclude rules but don't use either merge or pickFirst

ap...@google.com <ap...@google.com> #29Oct 8, 2024 07:21AM

The fixes for this issue are now also available in:

Android Studio Iguana | 2023.2.1 Patch 1
Android Gradle Plugin 8.3.1

We encourage you to try the latest update.

If you notice further issues or have questions, please file a new bug report.

ap...@google.com <ap...@google.com> #30Oct 11, 2024 10:09AM

Project: chromiumos/overlays/chromiumos-overlay
Branch: main
Author: Arnaud Ferraris <arnaud.ferraris@collabora.corp-partner.google.com>
Link: https://chromium-review.googlesource.com/5824447

eclass: cros-go: replace golint with staticcheck

Expand for full commit details

eclass: cros-go: replace golint with staticcheck

As `golint` is deprecated, we should switch to using an actually
maintained linter for Go packages. `staticcheck` being one of the
recommended alternatives, use it instead.

This initial iteration enables all default checks except `SA1019` (use
of deprecated features) as it generates too many errors for now. It will
be re-enabled once the first phase of the transition is complete.

Moreover, as multiple packages need to be fixed for staticcheck
compliance, do not error out when a check fails, but print a warning
message including the full list of failed checks in the log.

BUG=b:218608945
TEST=ENABLE_GO_LINT=1 emerge-$BOARD cros-dut (expected to fail)

Change-Id: Ib94dc8e7d6f24e121c00ad6210b9fb76fe13be9c
Signed-off-by: Arnaud Ferraris <arnaud.ferraris@collabora.corp-partner.google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/overlays/chromiumos-overlay/+/5824447
Reviewed-by: Lee Presland <zland@google.com>
Reviewed-by: Jordan Abrahams-Whitehead <ajordanr@google.com>

Files:

M eclass/cros-go.eclass

Hash: 381708cf0d91bad8524c84d11d6051f63acee6ac
Date: Fri Aug 30 17:17:49 2024

ap...@google.com <ap...@google.com> #31Oct 12, 2024 04:34PM

Project: chromiumos/overlays/chromiumos-overlay
Branch: firmware-android-15949.B
Author: Arnaud Ferraris <arnaud.ferraris@collabora.corp-partner.google.com>
Link: https://chromium-review.googlesource.com/5927155

Android Bringup: See http://go/android-fw-sync eclass: cros-go: replace golint with staticcheck

Expand for full commit details

Android Bringup: See http://go/android-fw-sync
 eclass: cros-go: replace golint with staticcheck

As `golint` is deprecated, we should switch to using an actually
maintained linter for Go packages. `staticcheck` being one of the
recommended alternatives, use it instead.

This initial iteration enables all default checks except `SA1019` (use
of deprecated features) as it generates too many errors for now. It will
be re-enabled once the first phase of the transition is complete.

Moreover, as multiple packages need to be fixed for staticcheck
compliance, do not error out when a check fails, but print a warning
message including the full list of failed checks in the log.

BUG=b:218608945
TEST=ENABLE_GO_LINT=1 emerge-$BOARD cros-dut (expected to fail)

(cherry picked from commit 381708cf0d91bad8524c84d11d6051f63acee6ac)

Change-Id: Ib94dc8e7d6f24e121c00ad6210b9fb76fe13be9c
Original-Signed-off-by: Arnaud Ferraris <arnaud.ferraris@collabora.corp-partner.google.com>
Original-Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/overlays/chromiumos-overlay/+/5824447
Original-Reviewed-by: Lee Presland <zland@google.com>
Original-Reviewed-by: Jordan Abrahams-Whitehead <ajordanr@google.com>
GitOrigin-RevId: 381708cf0d91bad8524c84d11d6051f63acee6ac
Cr-Build-Id: 8734289971778225713
Cr-Build-Url: https://cr-buildbucket.appspot.com/build/8734289971778225713
Copybot-Job-Name: android-main-chromiumos-overlay-copybot-downstream
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/overlays/chromiumos-overlay/+/5927155
Tested-by: ChromeOS Prod (Robot) <chromeos-ci-prod@chromeos-bot.iam.gserviceaccount.com>
Reviewed-by: Jonathon Murphy <jpmurphy@google.com>

Files:

M eclass/cros-go.eclass

Hash: 881fd44b2c368ca3d7718519224fe32446fdea52
Date: Fri Aug 30 17:17:49 2024

ap...@google.com <ap...@google.com> #32Oct 21, 2024 03:01PM

Project: chromiumos/platform/tast-tests
Branch: main
Author: Arnaud Ferraris <arnaud.ferraris@collabora.corp-partner.google.com>
Link: https://chromium-review.googlesource.com/5938666

tast-tests: camera: fix linter errors

Expand for full commit details

tast-tests: camera: fix linter errors

As part of b:218608945 `golint` will be replaced with `staticcheck` as
the default Go linter for ChromeOS. As a preliminary step we need to
ensure `staticcheck` passes with current Go packages.

This fixes such errors[1] for Tasts tests of the `camera` group.

[1] Please refer to https://staticcheck.dev/docs/checks/ for details
about each check.

BUG=b:218608945
TEST=staticcheck -checks "inherit,-SA1019" \
    "go.chromium.org/tast-tests/..."

Change-Id: I4f8120ee50484c820a7ffb1c26308c10fde0ee72
Signed-off-by: Arnaud Ferraris <arnaud.ferraris@collabora.corp-partner.google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/tast-tests/+/5938666
Reviewed-by: Seewai Fu <seewaifu@google.com>
Tast-Review: Seewai Fu <seewaifu@google.com>

Files:

M src/go.chromium.org/tast-tests/cros/common/camera/chart/chart.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/camera/camerabox_displaychart.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/camera/cca_service.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/camera/cca_ui_intent.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/camera/cca_ui_preview.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/camera/cca_ui_qrcode.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/camera/cca_ui_record_video.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/camera/cca_ui_record_video_perf.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/camera/cca_ui_stress.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/camera/cca_ui_time_lapse.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/camera/cca_ui_volume_shutter.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/camera/getusermedia/get_user_media.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/camera/hal3/hal3.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/camera/hdrnet_perf.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/camera/manual_control_usb_camera_service.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/camera/media_track_advanced_controls.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/camera/pnp_direct_off_usb_camera_power.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/camera/usb_camera_info.go
M src/go.chromium.org/tast-tests/cros/local/camera/cca/cca.go
M src/go.chromium.org/tast-tests/cros/local/camera/cca/perf.go
M src/go.chromium.org/tast-tests/cros/local/camera/histogramutil/histogramutil.go
M src/go.chromium.org/tast-tests/cros/local/camera/perf/profiler.go
M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/camera/its.go
M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/camera/manual_control_usb_camera.go
M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/camera/pre/its_pre.go
M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/camera/wfc_orientation.go

Hash: 56ef74cdcd4686487fe3043ab3257432fb80f370
Date: Thu Oct 17 17:16:34 2024

ap...@google.com <ap...@google.com> #33Oct 21, 2024 03:02PM

Project: chromiumos/platform/tast-tests
Branch: main
Author: Arnaud Ferraris <arnaud.ferraris@collabora.corp-partner.google.com>
Link: https://chromium-review.googlesource.com/5938665

tast-tests: android, arc: fix linter errors

Expand for full commit details

tast-tests: android, arc: fix linter errors

As part of b:218608945 `golint` will be replaced with `staticcheck` as
the default Go linter for ChromeOS. As a preliminary step we need to
ensure `staticcheck` passes with current Go packages.

This fixes such errors[1] for Tasts tests of the `android` & `arc`
groups.

[1] Please refer to https://staticcheck.dev/docs/checks/ for details
about each check.

BUG=b:218608945
TEST=staticcheck -checks "inherit,-SA1019" \
    "go.chromium.org/tast-tests/..."

Change-Id: Ie4e6fb83fe05afcfa9e6d6da3d0eab3e4eebfc6d
Signed-off-by: Arnaud Ferraris <arnaud.ferraris@collabora.corp-partner.google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/tast-tests/+/5938665
Reviewed-by: Seewai Fu <seewaifu@google.com>
Tast-Review: Seewai Fu <seewaifu@google.com>

Files:

M src/go.chromium.org/tast-tests/cros/common/android/adb/device.go
M src/go.chromium.org/tast-tests/cros/local/arc/activity.go
M src/go.chromium.org/tast-tests/cros/local/arc/apputil/apputil.go
M src/go.chromium.org/tast-tests/cros/local/arc/arc.go
M src/go.chromium.org/tast-tests/cros/local/arc/arcdownload/arcdownload.go
M src/go.chromium.org/tast-tests/cros/local/arc/display.go
M src/go.chromium.org/tast-tests/cros/local/arc/playstore/playstore.go
M src/go.chromium.org/tast-tests/cros/local/arc/pre.go
M src/go.chromium.org/tast-tests/cros/local/arc/snapshot.go
M src/go.chromium.org/tast-tests/cros/local/arc/swap/swap.go
M src/go.chromium.org/tast-tests/cros/local/arc/ui.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/arc/auth_perf.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/arc/cache/cache.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/arc/cache_perf.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/arc/change_app_language.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/arc/check_android_version.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/arc/companion_library.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/arc/default_app_launch_when_arc_is_off.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/arc/disable_arc.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/arc/enable_arc.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/arc/gamepad.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/arc/ghost_window.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/arc/guest_memory_size.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/arc/launcher_apps.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/arc/managed_app_apk_cache.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/arc/managed_play_store_icon.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/arc/mount_obb.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/arc/multidisplay/multidisplay.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/arc/notification.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/arc/notification_experimental.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/arc/oobe_arc.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/arc/oobe_arc_app_open.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/arc/opt_in_after_interruption.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/arc/optin_pause.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/arc/preopt.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/arc/restore_data.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/arc/second_boot.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/arc/standardized_keyboard_keys.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/arc/standardized_touchscreen_scroll.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/arc/standardized_trackpad_scroll.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/arc/standardizedtestutil/testutil.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/arc/suspend_service.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/arc/swap_management.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/arc/verify_settings.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/arc/vm_battery.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/arc/vm_data_migration.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/arc/window_manager_cuj.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/arc/wm/wm_tablet_helper.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/arc/wm_nonresizable_clamshell.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/arc/wm_nonresizable_conversion.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/arc/wm_resizable_conversion.go
M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/arc/adb_over_usb.go
M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/arc/adb_sideload_warning_ui.go
M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/arc/cache_validation.go
M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/arc/data_collector.go
M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/arc/suspend.go

Hash: 5e3383b35b2b5febe18a182a2a1a3fb7575bcc27
Date: Thu Oct 17 17:15:07 2024

ap...@google.com <ap...@google.com> #34Oct 22, 2024 08:56AM

Project: chromiumos/platform/tast-tests
Branch: main
Author: Arnaud Ferraris <arnaud.ferraris@collabora.corp-partner.google.com>
Link: https://chromium-review.googlesource.com/5938667

tast-tests: cellular: fix linter errors

Expand for full commit details

tast-tests: cellular: fix linter errors

As part of b:218608945 `golint` will be replaced with `staticcheck` as
the default Go linter for ChromeOS. As a preliminary step we need to
ensure `staticcheck` passes with current Go packages.

This fixes such errors[1] for Tasts tests of the `cellular` group.

[1] Please refer to https://staticcheck.dev/docs/checks/ for details
about each check.

BUG=b:218608945
TEST=staticcheck -checks "inherit,-SA1019" \
    "go.chromium.org/tast-tests/..."

Change-Id: Ibb23bef543a7f720e79b4f0553b8f0880157fd77
Signed-off-by: Arnaud Ferraris <arnaud.ferraris@collabora.corp-partner.google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/tast-tests/+/5938667
Reviewed-by: Seewai Fu <seewaifu@google.com>
Tast-Review: Seewai Fu <seewaifu@google.com>

Files:

M src/go.chromium.org/tast-tests/cros/common/cellular/label_utils.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/cellular/allow_roaming_policy.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/cellular/autoconnect_to_same_network.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/cellular/carrier_lock_end_to_end_sim_swap.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/cellular/connected_status.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/cellular/download_perf.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/cellular/esim_network_name.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/cellular/migrate_managed_unselected_apn.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/cellular/modem_fw_manifest_installation.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/cellular/perform_smds_operations_with_mojo.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/cellular/policy_install.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/cellular/rename_esim_profile_nickname.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/cellular/shill_callbox_hotspot.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/cellular/shill_custom_apn.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/cellular/shill_safety_dance.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/cellular/stress_disconnect_connect.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/cellular/suspend_resume_connect.go
M src/go.chromium.org/tast-tests/cros/local/cellular/callbox_server.go
M src/go.chromium.org/tast-tests/cros/local/cellular/cellular_helper.go
M src/go.chromium.org/tast-tests/cros/local/cellular/fixture.go
M src/go.chromium.org/tast-tests/cros/local/cellular/roaming_utils.go
M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/cellular/assert_ui_signal_quality.go
M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/cellular/iperf_rx.go
M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/cellular/iperf_tx.go
M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/cellular/module_power.go
M src/go.chromium.org/tast-tests/cros/remote/cellular/callbox/iperf/callbox_iperf_client.go
M src/go.chromium.org/tast-tests/cros/remote/cellular/callbox/iperf/server_result_poller.go
M src/go.chromium.org/tast-tests/cros/remote/cellular/callbox/iperf/test_manager.go
M src/go.chromium.org/tast-tests/cros/remote/cellular/callbox/manager/client.go
M src/go.chromium.org/tast-tests/cros/remote/cellular/modulepower/sweetberry_recorder.go

Hash: e78a401eef59a2962aa2129d3f44a5f56c5f6c8e
Date: Thu Oct 17 17:19:02 2024

ap...@google.com <ap...@google.com> #35Oct 22, 2024 01:23PM

Project: chromiumos/platform/tast-tests
Branch: main
Author: Arnaud Ferraris <arnaud.ferraris@collabora.corp-partner.google.com>
Link: https://chromium-review.googlesource.com/5938669

tast-tests: firmware: fix linter errors

Expand for full commit details

tast-tests: firmware: fix linter errors

As part of b:218608945 `golint` will be replaced with `staticcheck` as
the default Go linter for ChromeOS. As a preliminary step we need to
ensure `staticcheck` passes with current Go packages.

This fixes such errors[1] for Tasts tests of the `firmware` group.

[1] Please refer to https://staticcheck.dev/docs/checks/ for details
about each check.

BUG=b:218608945
TEST=staticcheck -checks "inherit,-SA1019" \
    "go.chromium.org/tast-tests/..."

Change-Id: I1ba1e1cd1aac7203d7df12ed1238757739dcedce
Signed-off-by: Arnaud Ferraris <arnaud.ferraris@collabora.corp-partner.google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/tast-tests/+/5938669
Reviewed-by: Andrew Luo <aluo@chromium.org>
Tast-Review: Seewai Fu <seewaifu@google.com>
Reviewed-by: Seewai Fu <seewaifu@google.com>

Files:

M src/go.chromium.org/tast-tests/cros/common/firmware/bios/image.go
M src/go.chromium.org/tast-tests/cros/common/firmware/bios/image_test.go
M src/go.chromium.org/tast-tests/cros/common/firmware/ti50/tpm.go
M src/go.chromium.org/tast-tests/cros/common/firmware/usb/validate.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/firmware/acvp.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/firmware/flashrom.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/firmware/flashrom_write_protect.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/firmware/fwupd_install_remote_cli.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/firmware/fwupd_install_remote_dbus.go
M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/firmware/boot_time.go
M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/firmware/consecutive_boot.go
M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/firmware/corrupt_both_fw_sig_ab_and_ec.go
M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/firmware/corrupt_both_kernel_copies.go
M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/firmware/corrupt_both_minios_ab.go
M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/firmware/corrupt_both_signed_amdfw_ab.go
M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/firmware/dev_boot_invalid_usb.go
M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/firmware/dev_boot_keyboard_stress.go
M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/firmware/dev_boot_usb.go
M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/firmware/dev_boot_usb_disallowed.go
M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/firmware/ec_cbi_bcfg.go
M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/firmware/ec_cbi_flashrom.go
M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/firmware/ec_charging_state.go
M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/firmware/ec_laptop_mode.go
M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/firmware/ec_reboot_efs2.go
M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/firmware/ec_stress.go
M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/firmware/flash_on_dut.go
M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/firmware/fw_corrupt_recovery_cache.go
M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/firmware/pd_usb_versions.go
M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/firmware/pd_vbus_request.go
M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/firmware/rec_screen_invalid_usb.go
M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/firmware/rec_screen_minios.go
M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/firmware/recovery_cache_boot_keys.go
M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/firmware/screen_wake_tablet_mode.go
M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/firmware/self_signed_boot.go
M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/firmware/suspend_stress.go
M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/firmware/update_version.go
M src/go.chromium.org/tast-tests/cros/remote/firmware/bios/image.go
M src/go.chromium.org/tast-tests/cros/remote/firmware/boot_mode.go
M src/go.chromium.org/tast-tests/cros/remote/firmware/config.go
M src/go.chromium.org/tast-tests/cros/remote/firmware/config_test.go
M src/go.chromium.org/tast-tests/cros/remote/firmware/ectool.go
M src/go.chromium.org/tast-tests/cros/remote/firmware/fingerprint/fingerprint.go
M src/go.chromium.org/tast-tests/cros/remote/firmware/fingerprint/fingerprint_test_images.go
M src/go.chromium.org/tast-tests/cros/remote/firmware/firmware_download_helpers.go
M src/go.chromium.org/tast-tests/cros/remote/firmware/helper.go
M src/go.chromium.org/tast-tests/cros/remote/firmware/reporters/eventlog.go
M src/go.chromium.org/tast-tests/cros/remote/firmware/suspend/suspend.go
M src/go.chromium.org/tast-tests/cros/remote/firmware/ti50/dutcontrol_andreiboard.go
M src/go.chromium.org/tast-tests/cros/remote/firmware/ti50/fixture/devboard.go
M src/go.chromium.org/tast-tests/cros/remote/firmware/ti50/fixture/gsc_initial_factory.go
M src/go.chromium.org/tast-tests/cros/remote/firmware/ti50/fixture/image.go

Hash: 90554acd47978cbf5b4420df4af862910be70566
Date: Thu Oct 17 17:20:13 2024

ap...@google.com <ap...@google.com> #36Oct 22, 2024 01:23PM

Project: chromiumos/platform/tast-tests
Branch: main
Author: Arnaud Ferraris <arnaud.ferraris@collabora.corp-partner.google.com>
Link: https://chromium-review.googlesource.com/5938668

tast-tests: chrome: fix linter errors

Expand for full commit details

tast-tests: chrome: fix linter errors

As part of b:218608945 `golint` will be replaced with `staticcheck` as
the default Go linter for ChromeOS. As a preliminary step we need to
ensure `staticcheck` passes with current Go packages.

This fixes such errors[1] for Tasts tests of the `chrome` group.

[1] Please refer to https://staticcheck.dev/docs/checks/ for details
about each check.

BUG=b:218608945
TEST=staticcheck -checks "inherit,-SA1019" \
    "go.chromium.org/tast-tests/..."

Change-Id: I32acde46e0c88ab1d55e54c61191ef1681d5e602
Signed-off-by: Arnaud Ferraris <arnaud.ferraris@collabora.corp-partner.google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/tast-tests/+/5938668
Reviewed-by: Seewai Fu <seewaifu@google.com>
Tast-Review: Seewai Fu <seewaifu@google.com>

Files:

M src/go.chromium.org/tast-tests/cros/common/chrome/histogram/histogram_test.go
M src/go.chromium.org/tast-tests/cros/local/chrome/apps/galleryapp/galleryapp.go
M src/go.chromium.org/tast-tests/cros/local/chrome/apps/thirdparty/element/element.go
M src/go.chromium.org/tast-tests/cros/local/chrome/apps/thirdparty/googledocs/common.go
M src/go.chromium.org/tast-tests/cros/local/chrome/apps/thirdparty/googledocs/docs.go
M src/go.chromium.org/tast-tests/cros/local/chrome/apps/thirdparty/googledocs/slides.go
M src/go.chromium.org/tast-tests/cros/local/chrome/apps/thirdparty/googlemeet/google_meet.go
M src/go.chromium.org/tast-tests/cros/local/chrome/apps/thirdparty/googlemeet/settings.go
M src/go.chromium.org/tast-tests/cros/local/chrome/apps/thirdparty/zoom/zoom.go
M src/go.chromium.org/tast-tests/cros/local/chrome/ash/shelf.go
M src/go.chromium.org/tast-tests/cros/local/chrome/chrome.go
M src/go.chromium.org/tast-tests/cros/local/chrome/crossdevice/android_fixture.go
M src/go.chromium.org/tast-tests/cros/local/chrome/crossdevice/crossdevicesettings/settings.go
M src/go.chromium.org/tast-tests/cros/local/chrome/crossdevice/smartlock/smartlock_ui.go
M src/go.chromium.org/tast-tests/cros/local/chrome/cuj/fixture.go
M src/go.chromium.org/tast-tests/cros/local/chrome/cuj/metadata_test.go
M src/go.chromium.org/tast-tests/cros/local/chrome/cuj/tab_handler.go
M src/go.chromium.org/tast-tests/cros/local/chrome/cuj/ui.go
M src/go.chromium.org/tast-tests/cros/local/chrome/internal/cdputil/session_test.go
M src/go.chromium.org/tast-tests/cros/local/chrome/internal/chromeproc/chromeproc.go
M src/go.chromium.org/tast-tests/cros/local/chrome/internal/config/config.go
M src/go.chromium.org/tast-tests/cros/local/chrome/internal/login/enroll.go
M src/go.chromium.org/tast-tests/cros/local/chrome/internal/setup/restart.go
M src/go.chromium.org/tast-tests/cros/local/chrome/lacros/util.go
M src/go.chromium.org/tast-tests/cros/local/chrome/metrics/histogram.go
M src/go.chromium.org/tast-tests/cros/local/chrome/option.go
M src/go.chromium.org/tast-tests/cros/local/chrome/uiauto/automation.go
M src/go.chromium.org/tast-tests/cros/local/chrome/uiauto/filesapp/filesapp.go
M src/go.chromium.org/tast-tests/cros/local/chrome/uiauto/holdingspace/holdingspace.go
M src/go.chromium.org/tast-tests/cros/local/chrome/uiauto/imesettings/user_actions.go
M src/go.chromium.org/tast-tests/cros/local/chrome/uiauto/launcher/launcher.go
M src/go.chromium.org/tast-tests/cros/local/chrome/uiauto/mouse/mouse.go
M src/go.chromium.org/tast-tests/cros/local/chrome/uiauto/ossettings/cellular.go
M src/go.chromium.org/tast-tests/cros/local/chrome/uiauto/ossettings/constants.go
M src/go.chromium.org/tast-tests/cros/local/chrome/uiauto/ossettings/ossettings.go
M src/go.chromium.org/tast-tests/cros/local/chrome/uiauto/printpreview/printpreview.go
M src/go.chromium.org/tast-tests/cros/local/chrome/uiauto/quicksettings/quicksettings.go
M src/go.chromium.org/tast-tests/cros/local/chrome/uiauto/scanapp/scanapp.go
M src/go.chromium.org/tast-tests/cros/local/chrome/uiauto/screen_recorder.go
M src/go.chromium.org/tast-tests/cros/local/chrome/uiauto/shortcutcustomization/constants.go
M src/go.chromium.org/tast-tests/cros/local/chrome/uiauto/vctray/vc_tray_container.go
M src/go.chromium.org/tast-tests/cros/local/chrome/uiauto/vkb/vkb.go
M src/go.chromium.org/tast-tests/cros/local/chrome/useractions/user_actions.go

Hash: e0b370f13ab08060ca337656e9655870411c56a0
Date: Thu Oct 17 17:19:34 2024

ap...@google.com <ap...@google.com> #37Oct 22, 2024 07:58PM

Project: chromiumos/platform/tast-tests
Branch: main
Author: Arnaud Ferraris <arnaud.ferraris@collabora.corp-partner.google.com>
Link: https://chromium-review.googlesource.com/5938670

tast-tests: wwcb: fix linter errors

Expand for full commit details

tast-tests: wwcb: fix linter errors 
 
As part of b:218608945 `golint` will be replaced with `staticcheck` as 
the default Go linter for ChromeOS. As a preliminary step we need to 
ensure `staticcheck` passes with current Go packages. 
 
This fixes such errors[1] for Tasts tests of the `wwcb` group. 
 
[1] Please refer to https://staticcheck.dev/docs/checks/ for details 
about each check. 
 
BUG=b:218608945 
TEST=staticcheck -checks "inherit,-SA1019" \ 
    "go.chromium.org/tast-tests/..." 
 
Change-Id: Iccaf384a340b2cfbb66b4d9c3b3e90a0d4c2ef1a 
Signed-off-by: Arnaud Ferraris <arnaud.ferraris@collabora.corp-partner.google.com> 
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/tast-tests/+/5938670 
Tast-Review: Seewai Fu <seewaifu@google.com> 
Reviewed-by: Jason Stanko <jstanko@google.com>

Files:

M src/go.chromium.org/tast-tests/cros/local/bundles/cros/wwcb/display_service.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/wwcb/utils/wwcb_api.go
M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/wwcb/corded_keyboard_functionality_check_after_lock_unlock_screen.go
M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/wwcb/daisy_chain.go
M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/wwcb/external_storage_boot_with_media_connect.go
M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/wwcb/external_storage_format.go
M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/wwcb/external_storage_suspend_and_resume.go
M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/wwcb/utils/command_util.go
M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/wwcb/utils/fixture_util.go
M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/wwcb/utils/keyboard_util.go
M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/wwcb/utils/video_util.go

Hash: dc962b2cff967fafa659b4a2a3a5e9c100443271
Date: Thu Oct 17 17:22:30 2024

ap...@google.com <ap...@google.com> #38Oct 22, 2024 08:02PM

Project: chromiumos/platform/tast-tests
Branch: main
Author: Arnaud Ferraris <arnaud.ferraris@collabora.corp-partner.google.com>
Link: https://chromium-review.googlesource.com/5943013

tast-tests: remote: fix linter errors

Expand for full commit details

tast-tests: remote: fix linter errors 
 
As part of b:218608945 golint will be replaced with staticcheck as 
the default Go linter for ChromeOS. As a preliminary step we need to 
ensure staticcheck passes with current Go packages. 
 
This fixes such errors[1] for code common to multiple remote Tast 
tests with too few changes to justify submitting them separately. 
 
[1] Please refer to https://staticcheck.dev/docs/checks/ for details 
about each check. 
 
BUG=b:218608945 
TEST=staticcheck -checks "inherit,-SA1019" \ 
    "go.chromium.org/tast-tests/..." 
 
Change-Id: I7950922648e81da064d53491ea4a29b192c07377 
Signed-off-by: Arnaud Ferraris <arnaud.ferraris@collabora.corp-partner.google.com> 
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/tast-tests/+/5943013 
Tast-Review: Seewai Fu <seewaifu@google.com> 
Reviewed-by: Seewai Fu <seewaifu@google.com>

Files:

M src/go.chromium.org/tast-tests/cros/remote/fileutils/analysis.go
M src/go.chromium.org/tast-tests/cros/remote/hooks/servo.go
M src/go.chromium.org/tast-tests/cros/remote/log/collector.go
M src/go.chromium.org/tast-tests/cros/remote/memory/mempressure/mempressure.go
M src/go.chromium.org/tast-tests/cros/remote/powercontrol/power_control_helper.go
M src/go.chromium.org/tast-tests/cros/remote/statefulmigration/stateful_migration.go
M src/go.chromium.org/tast-tests/cros/remote/updateutil/lsbrelease.go

Hash: da884af6c7bc7d3967870ae4a6f4043ad7df7928
Date: Thu Oct 17 17:33:32 2024

ap...@google.com <ap...@google.com> #39Oct 22, 2024 08:02PM

Project: chromiumos/platform/tast-tests
Branch: main
Author: Arnaud Ferraris <arnaud.ferraris@collabora.corp-partner.google.com>
Link: https://chromium-review.googlesource.com/5943012

tast-tests: remote: bundles: fix linter errors

Expand for full commit details

tast-tests: remote: bundles: fix linter errors 
 
As part of b:218608945 golint will be replaced with staticcheck as 
the default Go linter for ChromeOS. As a preliminary step we need to 
ensure staticcheck passes with current Go packages. 
 
This fixes such errors[1] for remote Tast tests with too few changes 
to justify submitting them separately. 
 
[1] Please refer to https://staticcheck.dev/docs/checks/ for details 
about each check. 
 
BUG=b:218608945 
TEST=staticcheck -checks "inherit,-SA1019" \ 
    "go.chromium.org/tast-tests/..." 
 
Change-Id: I4fef9108a390ab21d16d987ae97c759f4ab6fd3e 
Signed-off-by: Arnaud Ferraris <arnaud.ferraris@collabora.corp-partner.google.com> 
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/tast-tests/+/5943012 
Tast-Review: Seewai Fu <seewaifu@google.com> 
Reviewed-by: Seewai Fu <seewaifu@google.com>

Files:

M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/autoupdate/oobe_forced_auto_update.go
M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/debugd/packet_capture_wifi.go
M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/labqual/servo_gbb_flags_futility.go
M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/labqual/update_dut_firmware.go
M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/meta/run_cuj.go
M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/meta/run_tests_debugger.go
M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/osperf/tab_open_latency_perf.go
M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/osperf/tab_open_latency_perf_raw.go
M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/remotecommands/fetch_support_packet.go
M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/shimlessrma/rmaweb/ui.go
M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/statefulmigration/vault_compat.go
M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/uwb/cros_to_cros_ranging.go

Hash: cb9e93fab585121c085facee99626ca1e2e849c7
Date: Thu Oct 17 17:33:24 2024

ap...@google.com <ap...@google.com> #40Oct 22, 2024 08:02PM

Project: chromiumos/platform/tast-tests
Branch: main
Author: Arnaud Ferraris <arnaud.ferraris@collabora.corp-partner.google.com>
Link: https://chromium-review.googlesource.com/5943011

tast-tests: common: fix linter errors

Expand for full commit details

tast-tests: common: fix linter errors 
 
As part of b:218608945 `golint` will be replaced with `staticcheck` as 
the default Go linter for ChromeOS. As a preliminary step we need to 
ensure `staticcheck` passes with current Go packages. 
 
This fixes such errors[1] for common Tast tests modules with too few 
changes to justify submitting them separately. 
 
[1] Please refer to https://staticcheck.dev/docs/checks/ for details 
about each check. 
 
BUG=b:218608945 
TEST=staticcheck -checks "inherit,-SA1019" \ 
    "go.chromium.org/tast-tests/..." 
 
Change-Id: I32d09b3730f89afcd6dd39f489e4ef8ede6c3caa 
Signed-off-by: Arnaud Ferraris <arnaud.ferraris@collabora.corp-partner.google.com> 
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/tast-tests/+/5943011 
Tast-Review: Seewai Fu <seewaifu@google.com> 
Reviewed-by: Seewai Fu <seewaifu@google.com>

Files:

M src/go.chromium.org/tast-tests/cros/common/cleanupchecks/listofchecks.go
M src/go.chromium.org/tast-tests/cros/common/fixture/chrome.go
M src/go.chromium.org/tast-tests/cros/common/flashrom/flashrom_library.go
M src/go.chromium.org/tast-tests/cros/common/perf/checkpoint.go
M src/go.chromium.org/tast-tests/cros/common/robotics/arm/amber/arm_data.go
M src/go.chromium.org/tast-tests/cros/common/servers/servers_for_tests.go
M src/go.chromium.org/tast-tests/cros/common/servo/ec_test.go
M src/go.chromium.org/tast-tests/cros/common/servo/servo_pd_console_commands.go
M src/go.chromium.org/tast-tests/cros/common/tape/helper.go
M src/go.chromium.org/tast-tests/cros/common/testexec/testexec.go
M src/go.chromium.org/tast-tests/cros/common/testexec/testexec_test.go
M src/go.chromium.org/tast-tests/cros/common/usbdevice/hid_device_handler.go
M src/go.chromium.org/tast-tests/cros/common/usbdevice/usb.go
M src/go.chromium.org/tast-tests/cros/common/utils/utils.go
M src/go.chromium.org/tast-tests/cros/common/uwb/constants.go
M src/go.chromium.org/tast-tests/cros/common/uwb/firaparams.go
M src/go.chromium.org/tast-tests/cros/common/xmlrpc/xmlrpc.go
M src/go.chromium.org/tast-tests/cros/common/xmlrpc/xmlrpc_test.go

Hash: d4e5c72b646bd733361333ded0fa5bfa0457a52c
Date: Thu Oct 17 17:33:05 2024

ap...@google.com <ap...@google.com> #41Oct 22, 2024 08:02PM

Project: chromiumos/platform/tast-tests
Branch: main
Author: Arnaud Ferraris <arnaud.ferraris@collabora.corp-partner.google.com>
Link: https://chromium-review.googlesource.com/5943010

tast-tests: storage: fix linter errors

Expand for full commit details

tast-tests: storage: fix linter errors 
 
As part of b:218608945 `golint` will be replaced with `staticcheck` as 
the default Go linter for ChromeOS. As a preliminary step we need to 
ensure `staticcheck` passes with current Go packages. 
 
This fixes such errors[1] for Tasts tests of the `storage` group. 
 
[1] Please refer to https://staticcheck.dev/docs/checks/ for details 
about each check. 
 
BUG=b:218608945 
TEST=staticcheck -checks "inherit,-SA1019" \ 
    "go.chromium.org/tast-tests/..." 
 
Change-Id: I7f13e3524e9b661ef279fe5f0d491a094b0e8b3e 
Signed-off-by: Arnaud Ferraris <arnaud.ferraris@collabora.corp-partner.google.com> 
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/tast-tests/+/5943010 
Tast-Review: Seewai Fu <seewaifu@google.com> 
Reviewed-by: Seewai Fu <seewaifu@google.com>

Files:

M src/go.chromium.org/tast-tests/cros/local/bundles/cros/storage/util/trim_util.go
M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/storage/trim.go
M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/storage/util/fio.go
M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/storage/util/fio_result.go
M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/storage/util/nvme.go
M src/go.chromium.org/tast-tests/cros/remote/storage/diskthrottler/diskthrotler_utils.go

Hash: ba608ecc09c88e6e7403b2249dab33654aef24da
Date: Thu Oct 17 17:31:39 2024

ap...@google.com <ap...@google.com> #42Oct 22, 2024 08:02PM

Project: chromiumos/platform/tast-tests
Branch: main
Author: Arnaud Ferraris <arnaud.ferraris@collabora.corp-partner.google.com>
Link: https://chromium-review.googlesource.com/5943009

tast-tests: hps: fix linter errors

Expand for full commit details

tast-tests: hps: fix linter errors 
 
As part of b:218608945 `golint` will be replaced with `staticcheck` as 
the default Go linter for ChromeOS. As a preliminary step we need to 
ensure `staticcheck` passes with current Go packages. 
 
This fixes such errors[1] for Tasts tests of the `hps` group. 
 
[1] Please refer to https://staticcheck.dev/docs/checks/ for details 
about each check. 
 
BUG=b:218608945 
TEST=staticcheck -checks "inherit,-SA1019" \ 
    "go.chromium.org/tast-tests/..." 
 
Change-Id: I399e9fe88986e96163f03a8d5491876a43b1dbae 
Signed-off-by: Arnaud Ferraris <arnaud.ferraris@collabora.corp-partner.google.com> 
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/tast-tests/+/5943009 
Tast-Review: Seewai Fu <seewaifu@google.com> 
Reviewed-by: Seewai Fu <seewaifu@google.com>

Files:

M src/go.chromium.org/tast-tests/cros/common/hps/hpsutil/features.go
M src/go.chromium.org/tast-tests/cros/common/hps/hpsutil/powerlog.go
M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/hps/camerabox_lol_off.go
M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/hps/camerabox_lol_on.go
M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/hps/camerabox_lol_on_mix_presence.go
M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/hps/camerabox_spa.go
M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/hps/gooigi.go

Hash: ae8c93bbb8db8e57edf28077db05395e03ed58da
Date: Thu Oct 17 17:31:35 2024

ap...@google.com <ap...@google.com> #43Oct 22, 2024 08:02PM

Project: chromiumos/platform/tast-tests
Branch: main
Author: Arnaud Ferraris <arnaud.ferraris@collabora.corp-partner.google.com>
Link: https://chromium-review.googlesource.com/5943008

tast-tests: crostini: fix linter errors

Expand for full commit details

tast-tests: crostini: fix linter errors 
 
As part of b:218608945 `golint` will be replaced with `staticcheck` as 
the default Go linter for ChromeOS. As a preliminary step we need to 
ensure `staticcheck` passes with current Go packages. 
 
This fixes such errors[1] for Tasts tests of the `crostini` group. 
 
[1] Please refer to https://staticcheck.dev/docs/checks/ for details 
about each check. 
 
BUG=b:218608945 
TEST=staticcheck -checks "inherit,-SA1019" \ 
    "go.chromium.org/tast-tests/..." 
 
Change-Id: I88a7110c3d9019a389f343c6cad2c8f8065a620c 
Signed-off-by: Arnaud Ferraris <arnaud.ferraris@collabora.corp-partner.google.com> 
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/tast-tests/+/5943008 
Reviewed-by: Seewai Fu <seewaifu@google.com> 
Tast-Review: Seewai Fu <seewaifu@google.com>

Files:

M src/go.chromium.org/tast-tests/cros/local/bundles/cros/crostini/app_vlc.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/crostini/check_users.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/crostini/crostiniapps/firefox.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/crostini/debian_upgrade_alert.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/crostini/drag_drop.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/crostini/mouse_perf.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/crostini/resize_restart.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/crostini/restart_icon.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/crostini/share_folders.go
M src/go.chromium.org/tast-tests/cros/local/crostini/ui/installer.go
M src/go.chromium.org/tast-tests/cros/local/crostini/ui/settings/settings.go
M src/go.chromium.org/tast-tests/cros/local/crostini/ui/sharedfolders/sharedfolders.go

Hash: d0cd1fd271dfe158501eca91a34e61a91b6c20fd
Date: Thu Oct 17 17:31:27 2024

ap...@google.com <ap...@google.com> #44Oct 22, 2024 08:02PM

Project: chromiumos/platform/tast-tests
Branch: main
Author: Arnaud Ferraris <arnaud.ferraris@collabora.corp-partner.google.com>
Link: https://chromium-review.googlesource.com/5943007

tast-tests: platform: fix linter errors

Expand for full commit details

tast-tests: platform: fix linter errors 
 
As part of b:218608945 `golint` will be replaced with `staticcheck` as 
the default Go linter for ChromeOS. As a preliminary step we need to 
ensure `staticcheck` passes with current Go packages. 
 
This fixes such errors[1] for Tasts tests of the `platform` group. 
 
[1] Please refer to https://staticcheck.dev/docs/checks/ for details 
about each check. 
 
BUG=b:218608945 
TEST=staticcheck -checks "inherit,-SA1019" \ 
    "go.chromium.org/tast-tests/..." 
 
Change-Id: I4650cb984c2a43dfbd6b6c597d21e57aeb648978 
Signed-off-by: Arnaud Ferraris <arnaud.ferraris@collabora.corp-partner.google.com> 
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/tast-tests/+/5943007 
Reviewed-by: Seewai Fu <seewaifu@google.com> 
Tast-Review: Seewai Fu <seewaifu@google.com>

Files:

M src/go.chromium.org/tast-tests/cros/local/bundles/cros/platform/crosdisks/utils.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/platform/dlc/util.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/platform/perfetto_chrome_consumer.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/platform/perfetto_trace_based_metrics_service.go
M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/platform/bootup_times.go
M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/platform/cros_hardware_verifier_test.go
M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/platform/perfetto_tbm_traced_probes.go

Hash: 9d282536c01021561f81f5567859ecf9d17c812f
Date: Thu Oct 17 17:30:15 2024

ap...@google.com <ap...@google.com> #45Oct 22, 2024 08:02PM

Project: chromiumos/platform/tast-tests
Branch: main
Author: Arnaud Ferraris <arnaud.ferraris@collabora.corp-partner.google.com>
Link: https://chromium-review.googlesource.com/5943006

tast-tests: secagentd, security: fix linter errors

Expand for full commit details

tast-tests: secagentd, security: fix linter errors 
 
As part of b:218608945 `golint` will be replaced with `staticcheck` as 
the default Go linter for ChromeOS. As a preliminary step we need to 
ensure `staticcheck` passes with current Go packages. 
 
This fixes such errors[1] for Tasts tests of the `secagentd` and 
`security` groups. 
 
[1] Please refer to https://staticcheck.dev/docs/checks/ for details 
about each check. 
 
BUG=b:218608945 
TEST=staticcheck -checks "inherit,-SA1019" \ 
    "go.chromium.org/tast-tests/..." 
 
Change-Id: I5cc73fe342b2efbdfc100fa23d8620f220ca3091 
Signed-off-by: Arnaud Ferraris <arnaud.ferraris@collabora.corp-partner.google.com> 
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/tast-tests/+/5943006 
Reviewed-by: Seewai Fu <seewaifu@google.com> 
Tast-Review: Seewai Fu <seewaifu@google.com>

Files:

M src/go.chromium.org/tast-tests/cros/local/bundles/cros/secagentd/file_events.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/secagentd/network_events.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/secagentd/process_events.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/secagentd/secagentdaffiliation/affiliation.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/secagentd/secagentdprocfsscraper/procfsscraper.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/security/microcode.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/security/minijail_landlock.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/security/ptrace_thread.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/security/safesetid_ensure_policy.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/security/selinux/processes_test_internal.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/security/shared_filesystem_state.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/security/usb_bouncer.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/security/usbguard.go
M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/secagentd/xdr_reporting.go

Hash: 653c428d2e89d14cec5f438b2091008688adae83
Date: Thu Oct 17 17:26:48 2024

ap...@google.com <ap...@google.com> #46Oct 22, 2024 08:02PM

Project: chromiumos/platform/tast-tests
Branch: main
Author: Arnaud Ferraris <arnaud.ferraris@collabora.corp-partner.google.com>
Link: https://chromium-review.googlesource.com/5943005

tast-tests: netperf, network: fix linter errors

Expand for full commit details

tast-tests: netperf, network: fix linter errors 
 
As part of b:218608945 `golint` will be replaced with `staticcheck` as 
the default Go linter for ChromeOS. As a preliminary step we need to 
ensure `staticcheck` passes with current Go packages. 
 
This fixes such errors[1] for Tasts tests of the `netperf` and 
`network` groups. 
 
[1] Please refer to https://staticcheck.dev/docs/checks/ for details 
about each check. 
 
BUG=b:218608945 
TEST=staticcheck -checks "inherit,-SA1019" \ 
    "go.chromium.org/tast-tests/..." 
 
Change-Id: I89d35db55a06d3dff4d79af698ea3531d5f70377 
Signed-off-by: Arnaud Ferraris <arnaud.ferraris@collabora.corp-partner.google.com> 
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/tast-tests/+/5943005 
Tast-Review: Seewai Fu <seewaifu@google.com> 
Reviewed-by: Seewai Fu <seewaifu@google.com>

Files:

M src/go.chromium.org/tast-tests/cros/common/network/ip/runner.go
M src/go.chromium.org/tast-tests/cros/common/network/ip/runner_test.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/netperf/load_gaia.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/netperf/ping.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/network/allow_ca_certificate_management.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/network/allow_client_certificate_management.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/network/arc_create_wifi_in_shill_by_cmd.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/network/cert_settings_page.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/network/config_baseline.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/network/diag/service.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/network/diag_fail_dns_resolver_present.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/network/dns/dns.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/network/dns_proxy_over_vpn.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/network/passpoint/credentials.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/network/shill_captive_portal_properties.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/network/system_proxy_for_system_services.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/network/vpn_mojo_conf.go
M src/go.chromium.org/tast-tests/cros/local/network/arc/util.go
M src/go.chromium.org/tast-tests/cros/local/network/dhcp/packet.go
M src/go.chromium.org/tast-tests/cros/local/network/dhcp/test_server.go
M src/go.chromium.org/tast-tests/cros/local/network/routing/simple_network.go
M src/go.chromium.org/tast-tests/cros/local/network/testhooks/hook.go
M src/go.chromium.org/tast-tests/cros/local/network/testhooks/testhooks.go
M src/go.chromium.org/tast-tests/cros/local/network/virtualnet/dhcpd/dhcpd.go
M src/go.chromium.org/tast-tests/cros/local/network/virtualnet/dnsmasq/dnsmasq.go
M src/go.chromium.org/tast-tests/cros/local/network/virtualnet/radvd/radvd.go
M src/go.chromium.org/tast-tests/cros/local/network/virtualnet/tayga/tayga.go
M src/go.chromium.org/tast-tests/cros/local/network/virtualnet/virtualnet.go
M src/go.chromium.org/tast-tests/cros/local/network/vpn/server_runner.go
M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/network/diag_secure_wifi.go
M src/go.chromium.org/tast-tests/cros/remote/network/cmd/runner.go
M src/go.chromium.org/tast-tests/cros/remote/network/netperf/result_test.go
M src/go.chromium.org/tast-tests/cros/remote/network/netperf/session.go

Hash: 5d06541574e8d8ad4e060e3df3c1cbfc3e834357
Date: Thu Oct 17 17:26:31 2024

ap...@google.com <ap...@google.com> #47Oct 22, 2024 08:02PM

Project: chromiumos/platform/tast-tests
Branch: main
Author: Arnaud Ferraris <arnaud.ferraris@collabora.corp-partner.google.com>
Link: https://chromium-review.googlesource.com/5943004

tast-tests: inputs: fix linter errors

Expand for full commit details

tast-tests: inputs: fix linter errors 
 
As part of b:218608945 `golint` will be replaced with `staticcheck` as 
the default Go linter for ChromeOS. As a preliminary step we need to 
ensure `staticcheck` passes with current Go packages. 
 
This fixes such errors[1] for Tasts tests of the `inputs` group. 
 
[1] Please refer to https://staticcheck.dev/docs/checks/ for details 
about each check. 
 
BUG=b:218608945 
TEST=staticcheck -checks "inherit,-SA1019" \ 
    "go.chromium.org/tast-tests/..." 
 
Change-Id: I4190fc7e1c71753718c7bfe92bdb78ea4c27ef99 
Signed-off-by: Arnaud Ferraris <arnaud.ferraris@collabora.corp-partner.google.com> 
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/tast-tests/+/5943004 
Tast-Review: Seewai Fu <seewaifu@google.com> 
Reviewed-by: Seewai Fu <seewaifu@google.com>

Files:

M src/go.chromium.org/tast-tests/cros/local/bundles/cros/inputs/input_method_system_language.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/inputs/keyboard_service.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/inputs/manual.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/inputs/physical_keyboard_app_compat_citrix.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/inputs/physical_keyboard_input_fields.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/inputs/physical_keyboard_shape_based_chinese_typing.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/inputs/tablet_mode_check.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/inputs/touch_service.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/inputs/virtual_keyboard_login_screen.go
M src/go.chromium.org/tast-tests/cros/local/inputs/fixture/appcompat/arc_fixture.go
M src/go.chromium.org/tast-tests/cros/local/inputs/fixture/appcompat/crosh_fixture.go
M src/go.chromium.org/tast-tests/cros/local/inputs/util/util.go

Hash: 85befd3e5b85ceeee19d09edb3c00868de95a5b9
Date: Thu Oct 17 17:26:02 2024

ap...@google.com <ap...@google.com> #48Oct 22, 2024 08:02PM

Project: chromiumos/platform/tast-tests
Branch: main
Author: Arnaud Ferraris <arnaud.ferraris@collabora.corp-partner.google.com>
Link: https://chromium-review.googlesource.com/5943003

tast-tests: cryptohome: fix linter errors

Expand for full commit details

tast-tests: cryptohome: fix linter errors 
 
As part of b:218608945 `golint` will be replaced with `staticcheck` as 
the default Go linter for ChromeOS. As a preliminary step we need to 
ensure `staticcheck` passes with current Go packages. 
 
This fixes such errors[1] for Tasts tests of the `cryptohome` group. 
 
[1] Please refer to https://staticcheck.dev/docs/checks/ for details 
about each check. 
 
BUG=b:218608945 
TEST=staticcheck -checks "inherit,-SA1019" \ 
    "go.chromium.org/tast-tests/..." 
 
Change-Id: Icf0989f0c2c498efa0b30eae3b370f8da8c2754f 
Signed-off-by: Arnaud Ferraris <arnaud.ferraris@collabora.corp-partner.google.com> 
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/tast-tests/+/5943003 
Tast-Review: Seewai Fu <seewaifu@google.com> 
Reviewed-by: Seewai Fu <seewaifu@google.com>

Files:

M src/go.chromium.org/tast-tests/cros/common/cryptohome/recovery_test_tool.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/cryptohome/file_stability.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/cryptohome/fingerprint_manual.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/cryptohome/mount_perf_with_arc.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/cryptohome/recoverable_key_stores.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/cryptohome/update_password.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/cryptohome/update_recovery.go
M src/go.chromium.org/tast-tests/cros/local/cryptohome/cleanup/cleanup.go
M src/go.chromium.org/tast-tests/cros/local/cryptohome/cryptohome.go
M src/go.chromium.org/tast-tests/cros/local/cryptohome/login_err_msg.go

Hash: e1c1529b5a35353a0f1f6a816d3da43cdfd877fb
Date: Thu Oct 17 17:25:57 2024

ap...@google.com <ap...@google.com> #49Oct 22, 2024 08:02PM

Project: chromiumos/platform/tast-tests
Branch: main
Author: Arnaud Ferraris <arnaud.ferraris@collabora.corp-partner.google.com>
Link: https://chromium-review.googlesource.com/5943002

tast-tests: typec: fix linter errors

Expand for full commit details

tast-tests: typec: fix linter errors 
 
As part of b:218608945 `golint` will be replaced with `staticcheck` as 
the default Go linter for ChromeOS. As a preliminary step we need to 
ensure `staticcheck` passes with current Go packages. 
 
This fixes such errors[1] for Tasts tests of the `typec` group. 
 
[1] Please refer to https://staticcheck.dev/docs/checks/ for details 
about each check. 
 
BUG=b:218608945 
TEST=staticcheck -checks "inherit,-SA1019" \ 
    "go.chromium.org/tast-tests/..." 
 
Change-Id: Idddf55843aacd8965bf73b00606681fd68960c0a 
Signed-off-by: Arnaud Ferraris <arnaud.ferraris@collabora.corp-partner.google.com> 
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/tast-tests/+/5943002 
Reviewed-by: Seewai Fu <seewaifu@google.com> 
Tast-Review: Seewai Fu <seewaifu@google.com>

Files:

M src/go.chromium.org/tast-tests/cros/local/bundles/cros/typec/audio_switch_onboard_speaker_to_hdmi_hotplug.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/typec/external_display_plug_unplug_video_playback.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/typec/hotplug_usb_headset_audio_playback.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/typec/physical_location.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/typec/symlink_to_usb.go
M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/typec/hdmi_display_functionality_after_lid_close_open.go
M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/typec/typec_login.go
M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/typec/typecutils/utils.go
M src/go.chromium.org/tast-tests/cros/remote/typec/mcci/mcci.go

Hash: 4dd19d96dd893bdec2b78bad7cc70da2b5073a36
Date: Thu Oct 17 17:25:45 2024

ap...@google.com <ap...@google.com> #50Oct 22, 2024 08:02PM

Project: chromiumos/platform/tast-tests
Branch: main
Author: Arnaud Ferraris <arnaud.ferraris@collabora.corp-partner.google.com>
Link: https://chromium-review.googlesource.com/5943001

tast-tests: vm: fix linter errors

Expand for full commit details

tast-tests: vm: fix linter errors 
 
As part of b:218608945 `golint` will be replaced with `staticcheck` as 
the default Go linter for ChromeOS. As a preliminary step we need to 
ensure `staticcheck` passes with current Go packages. 
 
This fixes such errors[1] for Tasts tests of the `vm` group. 
 
[1] Please refer to https://staticcheck.dev/docs/checks/ for details 
about each check. 
 
BUG=b:218608945 
TEST=staticcheck -checks "inherit,-SA1019" \ 
    "go.chromium.org/tast-tests/..." 
 
Change-Id: I3e9c823f6b7b86f166d481844c034c97b51bc47e 
Signed-off-by: Arnaud Ferraris <arnaud.ferraris@collabora.corp-partner.google.com> 
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/tast-tests/+/5943001 
Tast-Review: Seewai Fu <seewaifu@google.com> 
Reviewed-by: Seewai Fu <seewaifu@google.com>

Files:

M src/go.chromium.org/tast-tests/cros/local/bundles/cros/vm/audio_alsa_conformance.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/vm/audio_aplay.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/vm/audio_arecord.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/vm/audio_resume_after_cras_restarted.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/vm/audio_streams_conformance.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/vm/fio.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/vm/iperf_test.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/vm/list_slim_rootfs_vm.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/vm/many_files.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/vm/start_crosvm.go
M src/go.chromium.org/tast-tests/cros/local/vm/crosvm.go
M src/go.chromium.org/tast-tests/cros/local/vm/vm.go

Hash: 5d04f96541d4684db8c5eea9d519cde973cd7aa8
Date: Thu Oct 17 17:25:40 2024

ap...@google.com <ap...@google.com> #51Oct 22, 2024 08:02PM

Project: chromiumos/platform/tast-tests
Branch: main
Author: Arnaud Ferraris <arnaud.ferraris@collabora.corp-partner.google.com>
Link: https://chromium-review.googlesource.com/5943000

tast-tests: hwsec: fix linter errors

Expand for full commit details

tast-tests: hwsec: fix linter errors 
 
As part of b:218608945 `golint` will be replaced with `staticcheck` as 
the default Go linter for ChromeOS. As a preliminary step we need to 
ensure `staticcheck` passes with current Go packages. 
 
This fixes such errors[1] for Tasts tests of the `hwsec` group. 
 
[1] Please refer to https://staticcheck.dev/docs/checks/ for details 
about each check. 
 
BUG=b:218608945 
TEST=staticcheck -checks "inherit,-SA1019" \ 
    "go.chromium.org/tast-tests/..." 
 
Change-Id: I3f41c5b003a8096564f73f63c10e5665825b0266 
Signed-off-by: Arnaud Ferraris <arnaud.ferraris@collabora.corp-partner.google.com> 
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/tast-tests/+/5943000 
Reviewed-by: Seewai Fu <seewaifu@google.com> 
Tast-Review: Seewai Fu <seewaifu@google.com>

Files:

M src/go.chromium.org/tast-tests/cros/common/hwsec/attestation_common.go
M src/go.chromium.org/tast-tests/cros/common/hwsec/challenge_response.go
M src/go.chromium.org/tast-tests/cros/common/hwsec/cryptohome_binary.go
M src/go.chromium.org/tast-tests/cros/common/hwsec/cryptohome_client.go
M src/go.chromium.org/tast-tests/cros/common/hwsec/login_data.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/hwsec/chaps_close_all_sessions.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/hwsec/cross_version_test.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/hwsec/cryptohome_bad_perms.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/hwsec/pin_lockout.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/hwsec/pkcs11_events.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/hwsec/util/cross_version_login_data.go
M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/hwsec/chaps_stress.go
M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/hwsec/cryptohome_mount_perf.go
M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/hwsec/webauthn_attestation.go

Hash: cfc2d6216aac0cdba4312413bddf9a7b36503d87
Date: Thu Oct 17 17:25:35 2024

ap...@google.com <ap...@google.com> #52Oct 22, 2024 08:02PM

Project: chromiumos/platform/tast-tests
Branch: main
Author: Arnaud Ferraris <arnaud.ferraris@collabora.corp-partner.google.com>
Link: https://chromium-review.googlesource.com/5938679

tast-tests: video: fix linter errors

Expand for full commit details

tast-tests: video: fix linter errors 
 
As part of b:218608945 `golint` will be replaced with `staticcheck` as 
the default Go linter for ChromeOS. As a preliminary step we need to 
ensure `staticcheck` passes with current Go packages. 
 
This fixes such errors[1] for Tasts tests of the `video` group. 
 
[1] Please refer to https://staticcheck.dev/docs/checks/ for details 
about each check. 
 
BUG=b:218608945 
TEST=staticcheck -checks "inherit,-SA1019" \ 
    "go.chromium.org/tast-tests/..." 
 
Change-Id: Ia176ae3a55388a68fe4c973d19a907008095b373 
Signed-off-by: Arnaud Ferraris <arnaud.ferraris@collabora.corp-partner.google.com> 
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/tast-tests/+/5938679 
Tast-Review: Seewai Fu <seewaifu@google.com> 
Reviewed-by: Seewai Fu <seewaifu@google.com>

Files:

M src/go.chromium.org/tast-tests/cros/local/bundles/cros/video/encode/accel_video.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/video/encode_accel_test.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/video/image_processor_perf.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/video/platform_encoding.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/video/playback/suspend.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/video/vulkan_overlay_adaptor_perf.go

Hash: 5829405aa48bc225073bad46f6db0f57485ecae4
Date: Thu Oct 17 17:25:28 2024

ap...@google.com <ap...@google.com> #53Oct 22, 2024 08:02PM

Project: chromiumos/platform/tast-tests
Branch: main
Author: Arnaud Ferraris <arnaud.ferraris@collabora.corp-partner.google.com>
Link: https://chromium-review.googlesource.com/5938678

tast-tests: gscdevboard: fix linter errors

Expand for full commit details

tast-tests: gscdevboard: fix linter errors 
 
As part of b:218608945 `golint` will be replaced with `staticcheck` as 
the default Go linter for ChromeOS. As a preliminary step we need to 
ensure `staticcheck` passes with current Go packages. 
 
This fixes such errors[1] for Tasts tests of the `gscdevboard` group. 
 
[1] Please refer to https://staticcheck.dev/docs/checks/ for details 
about each check. 
 
BUG=b:218608945 
TEST=staticcheck -checks "inherit,-SA1019" \ 
    "go.chromium.org/tast-tests/..." 
 
Change-Id: I3e22b0750943e16bac909fef560fd96e00e4c755 
Signed-off-by: Arnaud Ferraris <arnaud.ferraris@collabora.corp-partner.google.com> 
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/tast-tests/+/5938678 
Tast-Review: Seewai Fu <seewaifu@google.com> 
Reviewed-by: Seewai Fu <seewaifu@google.com>

Files:

M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/gscdevboard/cr50_ap_ro_verification_clear_result.go
M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/gscdevboard/cr50_rbox_buffer_output.go
M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/gscdevboard/gsc_ec_reset.go
M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/gscdevboard/gsc_factory_config.go
M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/gscdevboard/gsc_factory_update.go
M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/gscdevboard/gsc_fwmp.go
M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/gscdevboard/gsc_i2c_bridge.go
M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/gscdevboard/gsc_pcr_restore.go
M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/gscdevboard/gsc_tpm_i2c_corners.go
M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/gscdevboard/gsc_uart_forward.go
M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/gscdevboard/gsc_uart_throughput.go
M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/gscdevboard/ti50_ap_ro_verification.go
M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/gscdevboard/ti50_ccd_update.go
M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/gscdevboard/ti50_efs2.go
M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/gscdevboard/ti50_rbox.go
M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/gscdevboard/utils/ti50_devboard_helper.go

Hash: 65578fcc817d361043d9852ffc8d24125b5e2b55
Date: Thu Oct 17 17:25:13 2024

ap...@google.com <ap...@google.com> #54Oct 22, 2024 08:02PM

Project: chromiumos/platform/tast-tests
Branch: main
Author: Arnaud Ferraris <arnaud.ferraris@collabora.corp-partner.google.com>
Link: https://chromium-review.googlesource.com/5938677

tast-tests: power: fix linter errors

Expand for full commit details

tast-tests: power: fix linter errors 
 
As part of b:218608945 `golint` will be replaced with `staticcheck` as 
the default Go linter for ChromeOS. As a preliminary step we need to 
ensure `staticcheck` passes with current Go packages. 
 
This fixes such errors[1] for Tasts tests of the `power` group. 
 
[1] Please refer to https://staticcheck.dev/docs/checks/ for details 
about each check. 
 
BUG=b:218608945 
TEST=staticcheck -checks "inherit,-SA1019" \ 
    "go.chromium.org/tast-tests/..." 
 
Change-Id: Id5644fa498177b5c4b7f4f63bf4f0980a16831a7 
Signed-off-by: Arnaud Ferraris <arnaud.ferraris@collabora.corp-partner.google.com> 
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/tast-tests/+/5938677 
Tast-Review: Seewai Fu <seewaifu@google.com> 
Reviewed-by: Seewai Fu <seewaifu@google.com>

Files:

M src/go.chromium.org/tast-tests/cros/common/power/power_dashboard.go
M src/go.chromium.org/tast-tests/cros/common/power/servod_metrics.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/power/battery_service.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/power/example_histogram.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/power/gaming_app.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/power/idle.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/power/socialapp/element.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/power/video_suspend.go
M src/go.chromium.org/tast-tests/cros/local/power/charge/charge_control.go
M src/go.chromium.org/tast-tests/cros/local/power/cooling_device.go
M src/go.chromium.org/tast-tests/cros/local/power/metrics/cpuidle_metrics.go
M src/go.chromium.org/tast-tests/cros/local/power/metrics/gpu_usage_metrics.go
M src/go.chromium.org/tast-tests/cros/local/power/metrics/sysfs_battery_metrics.go
M src/go.chromium.org/tast-tests/cros/local/power/recorder.go
M src/go.chromium.org/tast-tests/cros/local/power/setup/fixture.go
M src/go.chromium.org/tast-tests/cros/local/power/setup/setup_bluetooth.go
M src/go.chromium.org/tast-tests/cros/local/power/setup/setup_charge_limit.go
M src/go.chromium.org/tast-tests/cros/local/power/setup/setup_network.go
M src/go.chromium.org/tast-tests/cros/local/power/setup/setup_screen_backlight.go
M src/go.chromium.org/tast-tests/cros/local/power/util/power_util.go
M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/power/suspend_consumption.go

Hash: 9628df4899a70eb10deacb857d3c43f377694005
Date: Thu Oct 17 17:25:04 2024

ap...@google.com <ap...@google.com> #55Oct 22, 2024 08:02PM

Project: chromiumos/platform/tast-tests
Branch: main
Author: Arnaud Ferraris <arnaud.ferraris@collabora.corp-partner.google.com>
Link: https://chromium-review.googlesource.com/5938676

tast-tests: policy: fix linter errors

Expand for full commit details

tast-tests: policy: fix linter errors 
 
As part of b:218608945 `golint` will be replaced with `staticcheck` as 
the default Go linter for ChromeOS. As a preliminary step we need to 
ensure `staticcheck` passes with current Go packages. 
 
This fixes such errors[1] for Tasts tests of the `policy` group. 
 
[1] Please refer to https://staticcheck.dev/docs/checks/ for details 
about each check. 
 
BUG=b:218608945 
TEST=staticcheck -checks "inherit,-SA1019" \ 
    "go.chromium.org/tast-tests/..." 
 
Change-Id: I561456881109e60dd4fe3f0e1688cac55125bf90 
Signed-off-by: Arnaud Ferraris <arnaud.ferraris@collabora.corp-partner.google.com> 
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/tast-tests/+/5938676 
Reviewed-by: Seewai Fu <seewaifu@google.com> 
Tast-Review: Seewai Fu <seewaifu@google.com>

Files:

M src/go.chromium.org/tast-tests/cros/common/policy/fakedms/fakedms.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/policy/autofill_credit_card_enabled.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/policy/autofillpayments/autofill_credit_card_enabled.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/policy/block_third_party_cookies.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/policy/calendarintegration/calendar_integration.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/policy/device_ephemeral_users_enabled.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/policy/disable_3dapis.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/policy/edit_bookmarks_enabled.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/policy/nearbyshare/nearby_share_setup.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/policy/network_request_monitor.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/policy/remotedesktop/remote_desktop.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/policy/reporting_chrome_restart.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/policy/reporting_cpu_info.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/policy/reporting_display_dbus.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/policy/reporting_heartbeat_local.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/policy/reporting_input_info.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/policy/reporting_login_logout_policy.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/policy/reporting_memory_info.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/policy/reporting_network_telemetry.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/policy/reporting_privacy_screen_info.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/policy/reporting_runtime_counters_telemetry.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/policy/reporting_usb_events.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/policy/tape_enrolled_login.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/policy/traffic_annotation_url_keyed_data_collection.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/policy/user_avatar_image.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/policy/webauthn_factors.go
M src/go.chromium.org/tast-tests/cros/local/policyutil/externaldata/server_test.go
M src/go.chromium.org/tast-tests/cros/local/policyutil/fixtures/tape.go
M src/go.chromium.org/tast-tests/cros/local/policyutil/verify.go
M src/go.chromium.org/tast-tests/cros/local/typecutils/utils.go
M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/policy/auto_update_disabled_invalidation.go
M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/policy/heartbeat_reporting.go
M src/go.chromium.org/tast-tests/cros/remote/policyutil/enrolled_fixture.go

Hash: 9b060329e86b50579233c3f5d7334e8f50431893
Date: Thu Oct 17 17:24:55 2024

ap...@google.com <ap...@google.com> #56Oct 22, 2024 08:03PM

Project: chromiumos/platform/tast-tests
Branch: main
Author: Arnaud Ferraris <arnaud.ferraris@collabora.corp-partner.google.com>
Link: https://chromium-review.googlesource.com/5938675

tast-tests: graphics: fix linter errors

Expand for full commit details

tast-tests: graphics: fix linter errors 
 
As part of b:218608945 `golint` will be replaced with `staticcheck` as 
the default Go linter for ChromeOS. As a preliminary step we need to 
ensure `staticcheck` passes with current Go packages. 
 
This fixes such errors[1] for Tasts tests of the `graphics` group. 
 
[1] Please refer to https://staticcheck.dev/docs/checks/ for details 
about each check. 
 
BUG=b:218608945 
TEST=staticcheck -checks "inherit,-SA1019" \ 
    "go.chromium.org/tast-tests/..." 
 
Change-Id: I90783f1097a97c0acae8586fd22de2af6ae8557f 
Signed-off-by: Arnaud Ferraris <arnaud.ferraris@collabora.corp-partner.google.com> 
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/tast-tests/+/5938675 
Tast-Review: Seewai Fu <seewaifu@google.com> 
Reviewed-by: Seewai Fu <seewaifu@google.com>

Files:

M src/go.chromium.org/tast-tests/cros/local/bundles/cros/graphics/chameleon_check_display_after_suspend.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/graphics/deqp.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/graphics/gl_api_check.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/graphics/hardware_probe.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/graphics/hw_overlays.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/graphics/idle.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/graphics/kernel_config.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/graphics/rounded_display.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/graphics/screenshot_service.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/graphics/swap_bench.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/graphics/vt_switch.go
M src/go.chromium.org/tast-tests/cros/local/graphics/chameleon.go
M src/go.chromium.org/tast-tests/cros/local/graphics/deqprunner/expectations.go
M src/go.chromium.org/tast-tests/cros/local/graphics/dri.go
M src/go.chromium.org/tast-tests/cros/local/graphics/fixture.go
M src/go.chromium.org/tast-tests/cros/local/graphics/glbench/cros_config.go
M src/go.chromium.org/tast-tests/cros/local/graphics/glbench/crostini_config.go
M src/go.chromium.org/tast-tests/cros/local/graphics/perf.go
M src/go.chromium.org/tast-tests/cros/local/graphics/pmtest.go
M src/go.chromium.org/tast-tests/cros/local/graphics/syslog_checker_test.go
M src/go.chromium.org/tast-tests/cros/local/graphics/trace/comm/comm.go
M src/go.chromium.org/tast-tests/cros/local/graphics/trace/trace_replay.go
M src/go.chromium.org/tast-tests/cros/local/graphics/vkbench/cros_config.go
M src/go.chromium.org/tast-tests/cros/local/graphics/vkbench/vkbench.go
M src/go.chromium.org/tast-tests/cros/remote/graphics/fixture.go

Hash: b40b06217669277e9ddcc58c4d2ea3e0eca8a9f4
Date: Thu Oct 17 17:24:49 2024

ap...@google.com <ap...@google.com> #57Oct 22, 2024 08:03PM

Project: chromiumos/platform/tast-tests
Branch: main
Author: Arnaud Ferraris <arnaud.ferraris@collabora.corp-partner.google.com>
Link: https://chromium-review.googlesource.com/5938674

tast-tests: audio: fix linter errors

Expand for full commit details

tast-tests: audio: fix linter errors 
 
As part of b:218608945 `golint` will be replaced with `staticcheck` as 
the default Go linter for ChromeOS. As a preliminary step we need to 
ensure `staticcheck` passes with current Go packages. 
 
This fixes such errors[1] for Tasts tests of the `audio` group. 
 
[1] Please refer to https://staticcheck.dev/docs/checks/ for details 
about each check. 
 
BUG=b:218608945 
TEST=staticcheck -checks "inherit,-SA1019" \ 
    "go.chromium.org/tast-tests/..." 
 
Change-Id: Id002b5e08f881e0e2d104072fa6fb3ccd749e58f 
Signed-off-by: Arnaud Ferraris <arnaud.ferraris@collabora.corp-partner.google.com> 
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/tast-tests/+/5938674 
Tast-Review: Seewai Fu <seewaifu@google.com> 
Reviewed-by: Yu-Hsuan Hsu <yuhsuan@chromium.org>

Files:

M src/go.chromium.org/tast-tests/cros/local/audio/audio_latency_toolkit_fixture.go
M src/go.chromium.org/tast-tests/cros/local/audio/chameleon_fixture.go
M src/go.chromium.org/tast-tests/cros/local/audio/util.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/audio/alsa_conformance.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/audio/checking_audio_formats.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/audio/cras_loopback_capture_timestamp.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/audio/cras_recording_correctness.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/audio/lock_unlock_playback.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/audio/loopback/lifecycle/capture_post_mix.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/audio/loopback/lifecycle/checker.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/audio/loopback/lifecycle/lifecycle.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/audio/soundcardinit/utils.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/audio/stress_audio_playback_onboard_speaker.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/audio/usb_volume_granularity.go
M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/audio/reboot_fixture.go

Hash: 8a970d73317729b68bf88b301b679712cd1cef48
Date: Thu Oct 17 17:24:36 2024

ap...@google.com <ap...@google.com> #58Oct 22, 2024 08:03PM

Project: chromiumos/platform/tast-tests
Branch: main
Author: Arnaud Ferraris <arnaud.ferraris@collabora.corp-partner.google.com>
Link: https://chromium-review.googlesource.com/5938673

tast-tests: bluetooth: fix linter errors

Expand for full commit details

tast-tests: bluetooth: fix linter errors 
 
As part of b:218608945 `golint` will be replaced with `staticcheck` as 
the default Go linter for ChromeOS. As a preliminary step we need to 
ensure `staticcheck` passes with current Go packages. 
 
This fixes such errors[1] for Tasts tests of the `bluetooth` group. 
 
[1] Please refer to https://staticcheck.dev/docs/checks/ for details 
about each check. 
 
BUG=b:218608945 
TEST=staticcheck -checks "inherit,-SA1019" \ 
    "go.chromium.org/tast-tests/..." 
 
Change-Id: I5e7ef3b34ee71174f4f33942ab994e7a52a53995 
Signed-off-by: Arnaud Ferraris <arnaud.ferraris@collabora.corp-partner.google.com> 
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/tast-tests/+/5938673 
Tast-Review: Seewai Fu <seewaifu@google.com> 
Reviewed-by: Seewai Fu <seewaifu@google.com>

Files:

M src/go.chromium.org/tast-tests/cros/local/bluetooth/bluez/agent.go
M src/go.chromium.org/tast-tests/cros/local/bluetooth/facade/floss/pairing_observer.go
M src/go.chromium.org/tast-tests/cros/local/bluetooth/floss/bluetooth_callback.go
M src/go.chromium.org/tast-tests/cros/local/bluetooth/floss/bluetooth_connection_callback.go
M src/go.chromium.org/tast-tests/cros/local/bluetooth/floss/dbus.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/bluetooth/enable_disable_bluetooth_with_audio_play.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/bluetooth/oobe_hid_bluetooth_service.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/bluetooth/pair_new_device_from_bluetooth_settings.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/bluetooth/pair_new_device_from_os_settings.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/bluetooth/toggle_bluetooth_from_bluetooth_settings.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/bluetooth/toggle_bluetooth_from_os_settings.go
M src/go.chromium.org/tast-tests/cros/remote/bluetooth/btpeer_provider.go
M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/bluetooth/device_battery.go
M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/bluetooth/hid_device_functionality_check.go
M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/bluetooth/nbs_warning.go
M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/bluetooth/passive_scan_power.go
M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/bluetooth/simple_btpeer_pair.go

Hash: 69ebe5f1f0cd0c075133b999c8779ba81072b5a4
Date: Thu Oct 17 17:24:30 2024

ap...@google.com <ap...@google.com> #59Oct 22, 2024 08:03PM

Project: chromiumos/platform/tast-tests
Branch: main
Author: Arnaud Ferraris <arnaud.ferraris@collabora.corp-partner.google.com>
Link: https://chromium-review.googlesource.com/5938672

tast-tests: ui: fix linter errors

Expand for full commit details

tast-tests: ui: fix linter errors 
 
As part of b:218608945 `golint` will be replaced with `staticcheck` as 
the default Go linter for ChromeOS. As a preliminary step we need to 
ensure `staticcheck` passes with current Go packages. 
 
This fixes such errors[1] for Tasts tests of the `ui` group. 
 
[1] Please refer to https://staticcheck.dev/docs/checks/ for details 
about each check. 
 
BUG=b:218608945 
TEST=staticcheck -checks "inherit,-SA1019" \ 
    "go.chromium.org/tast-tests/..." 
 
Change-Id: Id4ba77dcd4417353a2afeed30c72043d1da63d74 
Signed-off-by: Arnaud Ferraris <arnaud.ferraris@collabora.corp-partner.google.com> 
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/tast-tests/+/5938672 
Tast-Review: Seewai Fu <seewaifu@google.com> 
Reviewed-by: Seewai Fu <seewaifu@google.com>

Files:

M src/go.chromium.org/tast-tests/cros/local/bundles/cros/ui/automation_service.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/ui/check_virtual_keyboard_service.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/ui/chrome_crash_loop_v2.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/ui/conference/googlemeet.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/ui/conference/run.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/ui/conference/zoomserver/zoomserver.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/ui/cujrunner/runner.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/ui/everydaymultitaskingcuj/everyday_multi_tasking_cuj.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/ui/gallerycuj/gallery_cuj.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/ui/gallerycuj/utils.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/ui/keyboard_binding.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/ui/launcher_page_switch_perf.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/ui/login_perf.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/ui/overview_perf.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/ui/productivitycuj/microsoft_web.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/ui/screen_recorder_service.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/ui/tabswitchperf/tab_switch_perf.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/ui/youtube_stream_hdmi_display.go
M src/go.chromium.org/tast-tests/cros/local/ui/chrome_service.go
M src/go.chromium.org/tast-tests/cros/local/ui/cujrecorder/recorder.go
M src/go.chromium.org/tast-tests/cros/local/ui/googlesheetscuj/google_sheets_cuj.go
M src/go.chromium.org/tast-tests/cros/local/ui/meetcuj/meet_cuj.go
M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/ui/screen_recorder_service_grpc_stream.go

Hash: 4be13cc6d7e6e870296dce637b88986ce61acfed
Date: Thu Oct 17 17:23:45 2024

ap...@google.com <ap...@google.com> #60Oct 22, 2024 08:03PM

Project: chromiumos/platform/tast-tests
Branch: main
Author: Arnaud Ferraris <arnaud.ferraris@collabora.corp-partner.google.com>
Link: https://chromium-review.googlesource.com/5938671

tast-tests: wifi, wificell: fix linter errors

Expand for full commit details

tast-tests: wifi, wificell: fix linter errors 
 
As part of b:218608945 `golint` will be replaced with `staticcheck` as 
the default Go linter for ChromeOS. As a preliminary step we need to 
ensure `staticcheck` passes with current Go packages. 
 
This fixes such errors[1] for Tasts tests of the `wifi` and `wificell` 
groups. 
 
[1] Please refer to https://staticcheck.dev/docs/checks/ for details 
about each check. 
 
BUG=b:218608945 
TEST=staticcheck -checks "inherit,-SA1019" \ 
    "go.chromium.org/tast-tests/..." 
 
Change-Id: Iad64f20243fcad437572608f3d058d22e6e295b5 
Signed-off-by: Arnaud Ferraris <arnaud.ferraris@collabora.corp-partner.google.com> 
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/tast-tests/+/5938671 
Tast-Review: Seewai Fu <seewaifu@google.com> 
Reviewed-by: Jordan Abrahams-Whitehead <ajordanr@google.com> 
Reviewed-by: Seewai Fu <seewaifu@google.com>

Files:

M src/go.chromium.org/tast-tests/cros/common/wifi/iw/runner_test.go
M src/go.chromium.org/tast-tests/cros/common/wifi/p2p/p2p.go
M src/go.chromium.org/tast-tests/cros/common/wifi/security/wpa/config.go
M src/go.chromium.org/tast-tests/cros/common/wifi/wpacli/runner.go
M src/go.chromium.org/tast-tests/cros/common/wifi/wpacli/runner_test.go
M src/go.chromium.org/tast-tests/cros/common/wifi/wpacli/wpa_monitor.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/wifi/check_intel_sar_table.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/wifi/check_mtk_mtcl.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/wifi/shill_service.go
M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/wifi/ax_simple_connect.go
M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/wifi/bss_tm_request.go
M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/wifi/channel_hop.go
M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/wifi/connect_mbo.go
M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/wifi/connect_randomize_mac.go
M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/wifi/connect_to_wifi_with_ui.go
M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/wifi/csa_leave_channel.go
M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/wifi/gtk.go
M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/wifi/mar_bssid_roam.go
M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/wifi/mar_ssid_roam.go
M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/wifi/mbo_assoc_disallow.go
M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/wifi/mlo_network_wifi_perf.go
M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/wifi/mtbf.go
M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/wifi/network_wifi_perf.go
M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/wifi/p2p_concurrency_func.go
M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/wifi/policy_blocked_wifi.go
M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/wifi/roam_ft.go
M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/wifi/sap_perf.go
M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/wifi/scan_and_connect_6ghz.go
M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/wifi/simple_connect_test.go
M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/wifi/suspend_stress.go
M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/wifi/wifiutil/conn_util.go
M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/wifi/wifiutil/cont_util.go
M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/wifi/wifiutil/mar_util.go
M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/wifi/wifiutil/perf_util.go
M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/wifi/wifiutil/roam_util.go
M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/wifi/wifiutil/tdls_util.go
M src/go.chromium.org/tast-tests/cros/remote/wifi/iw/event_watcher_test.go
M src/go.chromium.org/tast-tests/cros/remote/wificell/dhcp/server.go
M src/go.chromium.org/tast-tests/cros/remote/wificell/fixture.go
M src/go.chromium.org/tast-tests/cros/remote/wificell/hostapd/config.go
M src/go.chromium.org/tast-tests/cros/remote/wificell/hostapd/server.go
M src/go.chromium.org/tast-tests/cros/remote/wificell/http/server.go
M src/go.chromium.org/tast-tests/cros/remote/wificell/router/ax/router.go
M src/go.chromium.org/tast-tests/cros/remote/wificell/router/common/ifacemanager.go
M src/go.chromium.org/tast-tests/cros/remote/wificell/router/legacy/router.go
M src/go.chromium.org/tast-tests/cros/remote/wificell/router/mtk/router.go
M src/go.chromium.org/tast-tests/cros/remote/wificell/router/mtk/wireless/server.go
M src/go.chromium.org/tast-tests/cros/remote/wificell/router/ubuntu/router.go
M src/go.chromium.org/tast-tests/cros/remote/wificell/test_fixture.go

Hash: 8413f42720930cb690a0d47c383561541da0ed75
Date: Thu Oct 17 17:23:01 2024

ap...@google.com <ap...@google.com> #61Oct 24, 2024 11:30AM

Project: chromiumos/platform/tast-tests
Branch: main
Author: Arnaud Ferraris <arnaud.ferraris@collabora.corp-partner.google.com>
Link: https://chromium-review.googlesource.com/5943014

tast-tests: local: bundles: fix linter errors

Expand for full commit details

tast-tests: local: bundles: fix linter errors 
 
As part of b:218608945 golint will be replaced with staticcheck as 
the default Go linter for ChromeOS. As a preliminary step we need to 
ensure staticcheck passes with current Go packages. 
 
This fixes such errors[1] for local Tast tests with too few changes 
to justify submitting them separately. 
 
[1] Please refer to https://staticcheck.dev/docs/checks/ for details 
about each check. 
 
BUG=b:218608945 
TEST=staticcheck -checks "inherit,-SA1019" \ 
    "go.chromium.org/tast-tests/..." 
 
Change-Id: Ia21186a0f04b688db0ae56e35a14974058aeb685 
Signed-off-by: Arnaud Ferraris <arnaud.ferraris@collabora.corp-partner.google.com> 
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/tast-tests/+/5943014 
Tast-Review: Seewai Fu <seewaifu@google.com> 
Reviewed-by: Seewai Fu <seewaifu@google.com> 
Commit-Queue: ChromeOS Auto Retry <chromeos-auto-retry@chromeos-bot.iam.gserviceaccount.com>

Files:

M src/go.chromium.org/tast-tests/cros/local/bundles/cros/a11y/chromeos_read_aloud_power.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/a11y/chromevox_toggle_on_shortcut.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/a11y/fullscreen_magnifier.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/a11y/smoke.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/apps/launch_help_app.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/appsplatform/webapk.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/assistant/time_query.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/assistant/wifi_queries.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/autoupdate/update_service.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/benchmark/pcmark_work_android_app.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/biod/bio_crypto_init_success.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/bruschetta/usb_storage.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/calendar/button_clicks.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/calendar/oobe.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/calendar/scroll_up_and_down.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/calendar/show_events.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/crash/sender.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/crash/service_failure.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/crash/suspend_failure.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/crash/user.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/crosca/generate_meet_code.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/crosca/meet_call.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/crosca/video_streaming.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/crosh/display_debug.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/crospts/ptsworld/cros_fixture.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/crospts/ptsworld/metrics/results.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/debugd/perf_tool.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/demomode/feature_aware_device.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/dlp/data_leak_prevention_rules_list_privacy_screen.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/enterpriseconnectors/helpers/helpers.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/factory/toolkit/installer.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/filemanager/bulk_pinning_hosted_available_offline.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/filemanager/bulk_pinning_lvm_cache_removal_shows_notification.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/filemanager/bulk_pinning_storage_usage.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/filemanager/drivefs_blob_download_offline.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/filemanager/drivefs_google_doc.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/filemanager/odfs_stay_in_m365_pwa.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/gamepad/ds3.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/gamepad/ds4.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/hardware/iio/iio.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/health/monitor_bluetooth_event_bluez.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/health/monitor_bluetooth_event_floss.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/health/monitor_event_startup.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/health/monitor_thunderbolt_event.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/health/monitor_usb_event.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/health/probe_tpm_info.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/health/utils/utils_test.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/holdingspace/download.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/holdingspace/print_to_pdf.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/intel/arc_install_uninstall_app.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/intel/record_audio.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/intel/transition_to_tablet_mode.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/intel/verify_video_contents.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/kiosk/device_weekly_scheduled_suspend.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/kiosk/kiosk_service.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/launcher/answer_cards.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/launcher/bubble_launch_app.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/launcher/open_tab_search.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/launcher/remove_continue_section_task.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/launcher/search_autocomplete.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/launcher/swipe_toggle_launcher.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/login/open_password_manager.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/login/open_settings.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/meet/oobe_expected_ui.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/meet/oobe_timezone.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/meet/video_quality.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/notifications/app_permission_os_settings.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/peripherals/launch_app_from_accelerator.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/peripherals/launch_app_from_launcher.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/peripherals/launch_app_from_settings.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/personalization/select_keyboard_backlight.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/printer/add_test.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/printer/hardware_print_combinations.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/printer/print_extension.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/printer/print_finishing_features.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/privacyhub/privacyhubutil/camera.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/privacyhub/privacyhubutil/settings.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/projector/enabled_policy.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/quickanswers/enable_from_settings.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/quickstart/welcome_screen_pin_no_account.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/scanner/enumerate_ipp_usb.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/scanner/install_dlc.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/session/ownership_api.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/session/ownership_taken.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/settings/device_mouse_action_customization.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/settings/device_mouse_keyboard_event_customization.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/settings/device_simulate_right_click.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/skyvault/screenshot_google_drive.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/skyvault/screenshot_onedrive.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/system/proc_stat.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/taskmanager/end_process.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/testenv/verify_proxy_arc.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/tracing/linuxperf/linux_perf_service.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/u2fd/webauthn_service.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/videoconferencing/effectshtml/effects_html.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/videoconferencing/fakeextension/fake_extension.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/videoconferencing/live_caption_tab_pwa.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/wallpaper/set_and_clear_guest.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/wilco/ec_rtc.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/wmp/admin_templates_launch.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/wmp/capture_mode_entry_points.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/wmp/desks_templates_launch.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/wmp/night_light_color_temperature.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/wmp/night_light_schedule.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/wmp/overview_drag_window_to_new_desk.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/wmp/pip.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/wmp/split_view_tablet_mode.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/wmp/virtual_desks_basic.go

Hash: f1823f3f71376ababb6ee50f20118e6647cb6878
Date: Thu Oct 17 17:33:51 2024

ap...@google.com <ap...@google.com> #62Oct 24, 2024 11:30AM

Project: chromiumos/platform/tast-tests
Branch: main
Author: Arnaud Ferraris <arnaud.ferraris@collabora.corp-partner.google.com>
Link: https://chromium-review.googlesource.com/5943015

tast-tests: local: fix linter errors

Expand for full commit details

tast-tests: local: fix linter errors 
 
As part of b:218608945 golint will be replaced with staticcheck as 
the default Go linter for ChromeOS. As a preliminary step we need to 
ensure staticcheck passes with current Go packages. 
 
This fixes such errors[1] for code common to multiple local Tast tests 
with too few changes to justify submitting them separately. 
 
[1] Please refer to https://staticcheck.dev/docs/checks/ for details 
about each check. 
 
BUG=b:218608945 
TEST=staticcheck -checks "inherit,-SA1019" \ 
    "go.chromium.org/tast-tests/..." 
 
Change-Id: Ic2da2c6350a525770b25ea25ba05af6a0bd752d5 
Signed-off-by: Arnaud Ferraris <arnaud.ferraris@collabora.corp-partner.google.com> 
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/tast-tests/+/5943015 
Reviewed-by: Seewai Fu <seewaifu@google.com> 
Tast-Review: Seewai Fu <seewaifu@google.com> 
Commit-Queue: ChromeOS Auto Retry <chromeos-auto-retry@chromeos-bot.iam.gserviceaccount.com>

Files:

M src/go.chromium.org/tast-tests/cros/local/a11y/automation_test.go
M src/go.chromium.org/tast-tests/cros/local/a11y/chromevox/chromevox.go
M src/go.chromium.org/tast-tests/cros/local/accountmanager/fixture.go
M src/go.chromium.org/tast-tests/cros/local/actionlogger/action_logger.go
M src/go.chromium.org/tast-tests/cros/local/assistant/assistant.go
M src/go.chromium.org/tast-tests/cros/local/bruschetta/fixture.go
M src/go.chromium.org/tast-tests/cros/local/certpageutils/cert_page_utils.go
M src/go.chromium.org/tast-tests/cros/local/cpu/idle.go
M src/go.chromium.org/tast-tests/cros/local/crash/crash.go
M src/go.chromium.org/tast-tests/cros/local/crash/crash_test.go
M src/go.chromium.org/tast-tests/cros/local/crash/fixture.go
M src/go.chromium.org/tast-tests/cros/local/croshealthd/diag.go
M src/go.chromium.org/tast-tests/cros/local/debugd/debugd.go
M src/go.chromium.org/tast-tests/cros/local/faillog/faillog.go
M src/go.chromium.org/tast-tests/cros/local/filesystem/xattr.go
M src/go.chromium.org/tast-tests/cros/local/guestos/display.go
M src/go.chromium.org/tast-tests/cros/local/hostapd/monitor.go
M src/go.chromium.org/tast-tests/cros/local/https/https.go
M src/go.chromium.org/tast-tests/cros/local/input/ioctl.go
M src/go.chromium.org/tast-tests/cros/local/input/touch.go
M src/go.chromium.org/tast-tests/cros/local/kernel/kernel_utils.go
M src/go.chromium.org/tast-tests/cros/local/kioskmode/fixtures/kiosk.go
M src/go.chromium.org/tast-tests/cros/local/kioskmode/kiosk_mode.go
M src/go.chromium.org/tast-tests/cros/local/media/arc/video/accel_video.go
M src/go.chromium.org/tast-tests/cros/local/media/pre/chrome_video.go
M src/go.chromium.org/tast-tests/cros/local/media/webrtc/peer_connection.go
M src/go.chromium.org/tast-tests/cros/local/memory/crosvm_fincore.go
M src/go.chromium.org/tast-tests/cros/local/memory/kernelmeter/kernelmeter.go
M src/go.chromium.org/tast-tests/cros/local/memory/memoryuser/android_task.go
M src/go.chromium.org/tast-tests/cros/local/memory/memoryuser/memory_stress_task.go
M src/go.chromium.org/tast-tests/cros/local/memory/mempressure/mempressure.go
M src/go.chromium.org/tast-tests/cros/local/memory/smaps_rollup.go
M src/go.chromium.org/tast-tests/cros/local/meta/fixture.go
M src/go.chromium.org/tast-tests/cros/local/mgs/mgs.go
M src/go.chromium.org/tast-tests/cros/local/modemfwd/modemfwd.go
M src/go.chromium.org/tast-tests/cros/local/modemmanager/bearer.go
M src/go.chromium.org/tast-tests/cros/local/modemmanager/modem.go
M src/go.chromium.org/tast-tests/cros/local/mtbf/youtube/youtube_app.go
M src/go.chromium.org/tast-tests/cros/local/mtbf/youtube/youtube_web.go
M src/go.chromium.org/tast-tests/cros/local/multivm/metrics_shell.go
M src/go.chromium.org/tast-tests/cros/local/multivm/pre.go
M src/go.chromium.org/tast-tests/cros/local/nebraska/options.go
M src/go.chromium.org/tast-tests/cros/local/networkui/netconfig/cros_network_config.go
M src/go.chromium.org/tast-tests/cros/local/perf/gpu_mem.go
M src/go.chromium.org/tast-tests/cros/local/perf/mem_tracker.go
M src/go.chromium.org/tast-tests/cros/local/perf/memory.go
M src/go.chromium.org/tast-tests/cros/local/perfutil/run.go
M src/go.chromium.org/tast-tests/cros/local/playbilling/testapp.go
M src/go.chromium.org/tast-tests/cros/local/profiler/perf.go
M src/go.chromium.org/tast-tests/cros/local/profiler/procstat.go
M src/go.chromium.org/tast-tests/cros/local/profiler/profiler.go
M src/go.chromium.org/tast-tests/cros/local/saveddesks/saveddesks.go
M src/go.chromium.org/tast-tests/cros/local/screenshot/capture.go
M src/go.chromium.org/tast-tests/cros/local/shill/service.go
M src/go.chromium.org/tast-tests/cros/local/starfish/shim.go
M src/go.chromium.org/tast-tests/cros/local/sysutil/mountinfo.go
M src/go.chromium.org/tast-tests/cros/local/terminalapp/terminalapp.go
M src/go.chromium.org/tast-tests/cros/local/testenv/proxy/mitmproxy.go
M src/go.chromium.org/tast-tests/cros/local/testenv/proxy/option.go
M src/go.chromium.org/tast-tests/cros/local/upstart/upstart.go
M src/go.chromium.org/tast-tests/cros/local/usbip/server.go
M src/go.chromium.org/tast-tests/cros/local/uwb/dbus_client.go
M src/go.chromium.org/tast-tests/cros/local/videoconferencing/fixture/media_fixtures.go

Hash: 5434a31c80e899e80f6a4ff205c23ebb64bd9336
Date: Thu Oct 17 17:33:56 2024

ap...@google.com <ap...@google.com> #63Oct 24, 2024 01:49PM

Project: chromiumos/platform/dev-util
Branch: main
Author: Arnaud Ferraris <arnaud.ferraris@collabora.corp-partner.google.com>
Link: https://chromium-review.googlesource.com/5953690

test: servod: fix linter errors

Expand for full commit details

test: servod: fix linter errors 
 
As part of b:218608945 `golint` will be replaced with `staticcheck` as 
the default Go linter for ChromeOS. As a preliminary step we need to 
ensure `staticcheck` passes with current Go packages. 
 
This fixes the following errors[1] for test/servod (`cros-servod`): 
* ST1005 (incorrectly formatted error strings) 
 
[1] Please refer to https://staticcheck.dev/docs/checks/ for details 
about each check. 
 
BUG=b:218608945 
TEST=staticcheck -checks "inherit,-SA1019" \ 
    "go.chromium.org/chromiumos/test/servod/..." 
 
Change-Id: Ib55fae0d67a3f99c9b5e06c3cf5feb835d15c0f6 
Signed-off-by: Arnaud Ferraris <arnaud.ferraris@collabora.corp-partner.google.com> 
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/dev-util/+/5953690 
Reviewed-by: Seewai Fu <seewaifu@google.com> 
Reviewed-by: Kshitij Pancholi <panchok@google.com>

Files:

M src/go.chromium.org/chromiumos/test/servod/cmd/servodserver/servodserver.go

Hash: ec5de28c24a9f28ea048733afd5e9148eeefe509
Date: Wed Oct 23 16:24:37 2024

ap...@google.com <ap...@google.com> #64Oct 28, 2024 11:33AM

Project: chromiumos/platform/dev-util
Branch: main
Author: Arnaud Ferraris <arnaud.ferraris@collabora.corp-partner.google.com>
Link: https://chromium-review.googlesource.com/5953691

test: execution: fix linter errors

Expand for full commit details

test: execution: fix linter errors 
 
As part of b:218608945 `golint` will be replaced with `staticcheck` as 
the default Go linter for ChromeOS. As a preliminary step we need to 
ensure `staticcheck` passes with current Go packages. 
 
This fixes the following errors[1] for test/execution (`cros-test`): 
* S1028 (use fmt.Errorf instead of errors.New(fmt.Sprintf)) 
* ST1005 (incorrectly formatted error strings) 
* U1000 (unused type/const/struct field) 
 
[1] Please refer to https://staticcheck.dev/docs/checks/ for details 
about each check. 
 
BUG=b:218608945 
TEST=staticcheck -checks "inherit,-SA1019" \ 
    "go.chromium.org/chromiumos/test/execution/..." 
 
Change-Id: I272f89f39d9d2b6d0276603887c061617d568a94 
Signed-off-by: Arnaud Ferraris <arnaud.ferraris@collabora.corp-partner.google.com> 
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/dev-util/+/5953691 
Reviewed-by: Seewai Fu <seewaifu@google.com> 
Reviewed-by: Varun Srivastav <varunsrivastav@google.com>

Files:

M src/go.chromium.org/chromiumos/test/execution/cmd/cros-test/internal/driver/mobly_driver.go
M src/go.chromium.org/chromiumos/test/execution/cmd/cros-test/internal/driver/tradefed_driver.go
M src/go.chromium.org/chromiumos/test/execution/cmd/cros-test/internal/driver/tradefed_results.go

Hash: e940f8fe19bb6b5f1614370deed66fc899f93232
Date: Wed Oct 23 17:42:32 2024

ap...@google.com <ap...@google.com> #65Oct 29, 2024 09:02AM

Project: chromiumos/platform/dev-util
Branch: main
Author: Arnaud Ferraris <arnaud.ferraris@collabora.corp-partner.google.com>
Link: https://chromium-review.googlesource.com/5824643

test: ctpv2: fix linter errors

Expand for full commit details

test: ctpv2: fix linter errors 
 
As part of b:218608945 `golint` will be replaced with `staticcheck` as 
the default Go linter for ChromeOS. As a preliminary step we need to 
ensure `staticcheck` passes with current Go packages. 
 
This fixes the following errors[1] for test/ctpv2 (`cros-ctp2-filters`): 
* S1025 (unnecessary use of fmt.Sprintf) 
* S1038 (use of Print(fmt.Sprintf()) instad of Printf()) 
* SA4006 (assigned but unused variable) 
* ST1005 (incorrectly formatted error strings) 
* U1000 (unused type/function/struct field) 
 
[1] Please refer to https://staticcheck.dev/docs/checks/ for details 
about each check. 
 
BUG=b:218608945 
TEST=staticcheck -checks "inherit,-SA1019" \ 
    "go.chromium.org/chromiumos/test/ctpv2/..." 
 
Change-Id: I64a03f499821fb20a904f84ed9e3efedf98bc3aa 
Signed-off-by: Arnaud Ferraris <arnaud.ferraris@collabora.corp-partner.google.com> 
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/dev-util/+/5824643 
Reviewed-by: Azizur Rahman <azrahman@google.com> 
Reviewed-by: Varun Srivastav <varunsrivastav@google.com> 
Reviewed-by: Seewai Fu <seewaifu@google.com>

Files:

M src/go.chromium.org/chromiumos/test/ctpv2/common/server_template/main.go
D src/go.chromium.org/chromiumos/test/ctpv2/provision_request_generators/provision-filter/bq_interface.go
M src/go.chromium.org/chromiumos/test/ctpv2/provision_request_generators/provision-filter/main.go
M src/go.chromium.org/chromiumos/test/ctpv2/test_finder_filter/main.go

Hash: a5e04c8f9511a4596ddf6224306ddfbb08905e20
Date: Fri Aug 30 17:56:27 2024

ap...@google.com <ap...@google.com> #66Nov 22, 2024 02:51PM

Project: chromiumos/platform/dev-util
Branch: main
Author: Arnaud Ferraris <arnaud.ferraris@collabora.corp-partner.google.com>
Link: https://chromium-review.googlesource.com/6039764

test: publish: fix linter errors

Expand for full commit details

test: publish: fix linter errors 
 
As part of b:218608945 `golint` will be replaced with `staticcheck` as 
the default Go linter for ChromeOS. As a preliminary step we need to 
ensure `staticcheck` passes with current Go packages. 
 
This fixes such errors[1] for this package. 
 
[1] Please refer to https://staticcheck.dev/docs/checks/ for details 
about each check. 
 
BUG=b:218608945 
TEST=staticcheck -checks "inherit,-SA1019" \ 
    "go.chromium.org/chromiumos/test/publish/..." 
 
Change-Id: If449dbfef9cc3fd37efdde44259c5fd445ad2d59 
Signed-off-by: Arnaud Ferraris <arnaud.ferraris@collabora.corp-partner.google.com> 
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/dev-util/+/6039764 
Reviewed-by: Seewai Fu <seewaifu@google.com> 
Reviewed-by: Allen Xie <zhihuixie@google.com>

Files:

M src/go.chromium.org/chromiumos/test/publish/libs/rdb_lib/rdb_lib.go

Hash: b9a553888860ad51815be285c4e1288619b1a397
Date: Thu Nov 21 16:27:27 2024

ap...@google.com <ap...@google.com> #67Nov 23, 2024 01:38PM

Project: chromiumos/platform/tast-tests
Branch: main
Author: Arnaud Ferraris <arnaud.ferraris@collabora.corp-partner.google.com>
Link: https://chromium-review.googlesource.com/6039906

tast-tests: common: fix linter errors

Expand for full commit details

tast-tests: common: fix linter errors 
 
As part of b:218608945 `golint` will be replaced with `staticcheck` as 
the default Go linter for ChromeOS. As a preliminary step we need to 
ensure `staticcheck` passes with current Go packages. 
 
This fixes such errors[1] for common Tast tests modules. 
 
[1] Please refer to https://staticcheck.dev/docs/checks/ for details 
about each check. 
 
BUG=b:218608945 
TEST=staticcheck -checks "inherit,-SA1019" \ 
    "go.chromium.org/tast-tests/..." 
 
Change-Id: Iaf27581a14c191c9101940a3fbd4337f808c1819 
Signed-off-by: Arnaud Ferraris <arnaud.ferraris@collabora.corp-partner.google.com> 
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/tast-tests/+/6039906 
Reviewed-by: George Burgess <gbiv@chromium.org> 
Reviewed-by: Seewai Fu <seewaifu@google.com> 
Tast-Review: Seewai Fu <seewaifu@google.com>

Files:

M src/go.chromium.org/tast-tests/cros/common/power/servod_metrics.go

Hash: f15e8227840ddc40585a6ca8814d128754bc4378
Date: Fri Nov 22 13:05:42 2024

ap...@google.com <ap...@google.com> #68Nov 25, 2024 03:03PM

Project: chromiumos/platform/tast-tests
Branch: main
Author: Arnaud Ferraris <arnaud.ferraris@collabora.corp-partner.google.com>
Link: https://chromium-review.googlesource.com/6039907

tast-tests: remote: fix linter errors

Expand for full commit details

tast-tests: remote: fix linter errors 
 
As part of b:218608945 `golint` will be replaced with `staticcheck` as 
the default Go linter for ChromeOS. As a preliminary step we need to 
ensure `staticcheck` passes with current Go packages. 
 
This fixes such errors[1] for remote Tast tests. 
 
[1] Please refer to https://staticcheck.dev/docs/checks/ for details 
about each check. 
 
BUG=b:218608945 
TEST=staticcheck -checks "inherit,-SA1019" \ 
    "go.chromium.org/tast-tests/..." 
 
Change-Id: I09b2660356a0d3c4f167d4c92031e9976bee4104 
Signed-off-by: Arnaud Ferraris <arnaud.ferraris@collabora.corp-partner.google.com> 
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/tast-tests/+/6039907 
Reviewed-by: George Burgess <gbiv@chromium.org> 
Reviewed-by: Seewai Fu <seewaifu@google.com> 
Tast-Review: Seewai Fu <seewaifu@google.com>

Files:

M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/gscdevboard/gsc_ccd_programming.go
M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/gscdevboard/gsc_rollback_bits.go
M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/power/suspend_perf.go
M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/vdi/signature_pad.go
M src/go.chromium.org/tast-tests/cros/remote/compliance/fixture.go

Hash: d7e4deebb95c0c7fb11d66379a5b6ed84e0d6f0f
Date: Fri Nov 22 13:07:51 2024

ap...@google.com <ap...@google.com> #69Nov 26, 2024 11:11PM

Project: chromiumos/platform/tast-tests
Branch: main
Author: Arnaud Ferraris <arnaud.ferraris@collabora.corp-partner.google.com>
Link: https://chromium-review.googlesource.com/6048890

tast-tests: fix linter errors

Expand for full commit details

tast-tests: fix linter errors 
 
As part of b:218608945 `golint` will be replaced with `staticcheck` as 
the default Go linter for ChromeOS. As a preliminary step we need to 
ensure `staticcheck` passes with current Go packages. 
 
This fixes such errors[1] for Tast tests. 
 
[1] Please refer to https://staticcheck.dev/docs/checks/ for details 
about each check. 
 
BUG=b:218608945 
TEST=staticcheck -checks "inherit,-SA1019" \ 
    "go.chromium.org/tast-tests/..." 
 
Change-Id: Ide0960e169307d537bb8f76f898f58f8a36a4b4b 
Signed-off-by: Arnaud Ferraris <arnaud.ferraris@collabora.corp-partner.google.com> 
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/tast-tests/+/6048890 
Reviewed-by: Jordan Abrahams-Whitehead <ajordanr@google.com> 
Commit-Queue: ChromeOS Auto Retry <chromeos-auto-retry@chromeos-bot.iam.gserviceaccount.com> 
Tast-Review: Seewai Fu <seewaifu@google.com> 
Tested-by: Jordan Abrahams-Whitehead <ajordanr@google.com> 
Reviewed-by: Seewai Fu <seewaifu@google.com>

Files:

M src/go.chromium.org/tast-tests/cros/common/servo/servo_pd_console_commands.go
M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/bluetooth/nbs_warning.go
M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/firmware/csme_fw_update.go
M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/gscdevboard/gsc_rollback_bits.go
M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/power/suspend_perf.go

Hash: 6984c8ac89a0db8647d95827b2b7337cdbbd32d3
Date: Tue Nov 26 16:06:02 2024

ap...@google.com <ap...@google.com> #70Nov 26, 2024 11:11PM

Project: chromiumos/platform/tast-tests
Branch: main
Author: Arnaud Ferraris <arnaud.ferraris@collabora.corp-partner.google.com>
Link: https://chromium-review.googlesource.com/6039908

tast-tests: local: fix linter errors

Expand for full commit details

tast-tests: local: fix linter errors 
 
As part of b:218608945 `golint` will be replaced with `staticcheck` as 
the default Go linter for ChromeOS. As a preliminary step we need to 
ensure `staticcheck` passes with current Go packages. 
 
This fixes such errors[1] for local Tast tests. 
 
[1] Please refer to https://staticcheck.dev/docs/checks/ for details 
about each check. 
 
BUG=b:218608945 
TEST=staticcheck -checks "inherit,-SA1019" \ 
    "go.chromium.org/tast-tests/..." 
 
Change-Id: I4cc6fa90e2ef27257d088462fccd359c508ec795 
Signed-off-by: Arnaud Ferraris <arnaud.ferraris@collabora.corp-partner.google.com> 
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/tast-tests/+/6039908 
Reviewed-by: Jordan Abrahams-Whitehead <ajordanr@google.com> 
Commit-Queue: ChromeOS Auto Retry <chromeos-auto-retry@chromeos-bot.iam.gserviceaccount.com> 
Reviewed-by: Seewai Fu <seewaifu@google.com> 
Tast-Review: Seewai Fu <seewaifu@google.com>

Files:

M src/go.chromium.org/tast-tests/cros/local/annotations/annotations.go
M src/go.chromium.org/tast-tests/cros/local/assistant/fixture.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/cellular/carrier_lock_end_to_end_sim_swap.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/firmware/fwupd/dbus.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/hwsec/pin_lockout.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/kiosk/crash_recovery.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/network/allowlist_service.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/network/routing_connection_pinning.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/secagentd/fileeventsimpl/impl.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/u2fd/webauthn_service.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/ui/chromecrash/crash.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/wmp/pip.go
M src/go.chromium.org/tast-tests/cros/local/cellular/fixture.go
M src/go.chromium.org/tast-tests/cros/local/chrome/browser/tabs.go
M src/go.chromium.org/tast-tests/cros/local/media/pre/chrome_video.go
M src/go.chromium.org/tast-tests/cros/local/ui/mahicuj/mahiutil/util.go

Hash: f6bfddc2c04408913bf3cae82750e24c5ba6a4c3
Date: Fri Nov 22 13:09:24 2024

ap...@google.com <ap...@google.com> #71Nov 27, 2024 09:07AM

Project: chromiumos/chromite
Branch: main
Author: Arnaud Ferraris <arnaud.ferraris@collabora.corp-partner.google.com>
Link: https://chromium-review.googlesource.com/6050183

service: use staticcheck for linting Go code

Expand for full commit details

service: use staticcheck for linting Go code 
 
As `golint` is deprecated, we should switch to using an actually 
maintained linter for Go packages. `staticcheck` being one of the 
recommended alternatives, use it instead. 
 
This change also includes fixes to the `lint_package` script so it 
adapts to the service API changes. 
 
BUG=b:218608945 
TEST=lint_package -b $BOARD dev-util/cros-test 
 
Change-Id: I2b5b764c48791ef0ee50373f81274d9ed4aff3f2 
Signed-off-by: Arnaud Ferraris <arnaud.ferraris@collabora.corp-partner.google.com> 
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/chromite/+/6050183 
Reviewed-by: Bob Haarman <inglorion@chromium.org> 
Reviewed-by: Jordan Abrahams-Whitehead <ajordanr@google.com>

Files:

M api/controller/toolchain.py
M scripts/lint_package.py
M service/toolchain.py
M service/toolchain_unittest.py

Hash: 9dbf13df03aac1c3909cda0d1bddb47d96efcea9
Date: Tue Nov 26 19:01:01 2024

ap...@google.com <ap...@google.com> #72Nov 27, 2024 11:09AM

Project: chromiumos/chromite
Branch: main
Author: Arnaud Ferraris <arnaud.ferraris@collabora.corp-partner.google.com>
Link: https://chromium-review.googlesource.com/6050184

cli: cros lint: use staticcheck as the Go linter

Expand for full commit details

cli: cros lint: use staticcheck as the Go linter 
 
As `golint` is deprecated, we should switch to using an actually 
maintained linter for Go packages. `staticcheck` being one of the 
recommended alternatives, use it instead. 
 
BUG=b:218608945 
TEST=cros lint -b $BOARD <.go files> 
 
Change-Id: I0e6fe331acde9da1c31256cfdd3293af37a24508 
Signed-off-by: Arnaud Ferraris <arnaud.ferraris@collabora.corp-partner.google.com> 
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/chromite/+/6050184 
Reviewed-by: Sergey Frolov <sfrolov@google.com> 
Reviewed-by: Jordan Abrahams-Whitehead <ajordanr@google.com>

Files:

M cli/cros/cros_lint.py

Hash: e63a669d041240d6f18a6fa104f9b51da59fc4d9
Date: Tue Nov 26 19:01:12 2024

ap...@google.com <ap...@google.com> #73Nov 27, 2024 06:12PM

Project: website
Branch: main
Author: Arnaud Ferraris <arnaud.ferraris@collabora.corp-partner.google.com>
Link: https://chromium-review.googlesource.com/6054278

go-in-chromium-os: acknowledge Go linter changes

Expand for full commit details

go-in-chromium-os: acknowledge Go linter changes 
 
As `golint` is not maintained anymore and has therefore been replaced 
with `staticcheck` as the default Go linter in ChromeOS, ensure we 
mention the latter in developer's documentation. 
 
BUG=b:218608945 
TEST=None 
 
Change-Id: Ib40c5440ceeb10582ebe924664f03f571f2a92e9 
Signed-off-by: Arnaud Ferraris <arnaud.ferraris@collabora.corp-partner.google.com> 
Reviewed-on: https://chromium-review.googlesource.com/c/website/+/6054278 
Commit-Queue: Douglas Anderson <dianders@chromium.org> 
Reviewed-by: Douglas Anderson <dianders@chromium.org>

Files:

M site/chromium-os/developer-guide/go-in-chromium-os/index.md

Hash: c1c9a8528bb8c871e24471ac87024577b3c48e8a
Date: Wed Nov 27 11:50:37 2024

ap...@google.com <ap...@google.com> #74Nov 28, 2024 05:59PM

Project: chromiumos/platform/tast
Branch: main
Author: Arnaud Ferraris <arnaud.ferraris@collabora.corp-partner.google.com>
Link: https://chromium-review.googlesource.com/6054717

docs: mention staticcheck as the main Go linter

Expand for full commit details

docs: mention staticcheck as the main Go linter 
 
As `golint` is not maintained anymore and has therefore been replaced 
with `staticcheck` as the default Go linter in ChromeOS, ensure we 
mention the latter in developer's documentation. 
 
BUG=b:218608945 
TEST=None 
 
Change-Id: I97e1fc1945a83f7c2a1a32b1a69624a32f53ee06 
Signed-off-by: Arnaud Ferraris <arnaud.ferraris@collabora.corp-partner.google.com> 
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/tast/+/6054717 
Tested-by: Seewai Fu <seewaifu@google.com> 
Commit-Queue: Jordan Abrahams-Whitehead <ajordanr@google.com> 
Reviewed-by: Seewai Fu <seewaifu@google.com> 
Reviewed-by: Jordan Abrahams-Whitehead <ajordanr@google.com>

Files:

M docs/code_reviews.md
M docs/writing_tests.md

Hash: 5b04a631ac7fe541f87e29c167a340eb7f3a9c3a
Date: Wed Nov 27 12:19:43 2024

ap...@google.com <ap...@google.com> #75Nov 29, 2024 06:15PM

Project: chromiumos/platform/dev-util
Branch: main
Author: Arnaud Ferraris <arnaud.ferraris@collabora.corp-partner.google.com>
Link: https://chromium-review.googlesource.com/6039763

test: execution: fix linter errors

Expand for full commit details

test: execution: fix linter errors 
 
As part of b:218608945 `golint` will be replaced with `staticcheck` as 
the default Go linter for ChromeOS. As a preliminary step we need to 
ensure `staticcheck` passes with current Go packages. 
 
This fixes such errors[1] for this package. 
 
[1] Please refer to https://staticcheck.dev/docs/checks/ for details 
about each check. 
 
BUG=b:218608945 
TEST=staticcheck -checks "inherit,-SA1019" \ 
    "go.chromium.org/chromiumos/test/execution/..." 
 
Change-Id: Ib416ccf5339bc94dffc418fcfc8bab1d87cd5e5f 
Signed-off-by: Arnaud Ferraris <arnaud.ferraris@collabora.corp-partner.google.com> 
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/dev-util/+/6039763 
Reviewed-by: Seewai Fu <seewaifu@google.com> 
Reviewed-by: Allen Xie <zhihuixie@google.com>

Files:

M src/go.chromium.org/chromiumos/test/execution/cmd/cros-test/internal/driver/tradefed_driver.go
M src/go.chromium.org/chromiumos/test/execution/cmd/cros-test/internal/driver/tradefed_results.go

Hash: 41e67f4c1c26e1f2611575f6c32e0252a9810fec
Date: Wed Oct 30 12:46:57 2024

ap...@google.com <ap...@google.com> #76Dec 3, 2024 02:15AM

Project: chromiumos/infra/ide
Branch: main
Author: Arnaud Ferraris <arnaud.ferraris@collabora.corp-partner.google.com>
Link: https://chromium-review.googlesource.com/6054011

cros/tast lint: use staticcheck as the default Go linter

Expand for full commit details

cros/tast lint: use staticcheck as the default Go linter 
 
As `golint` is not maintained anymore, it has been replaced with 
`staticcheck` as the default Go linter used by `cros lint`. Acknowledge 
this by ensuring code comments and function names reflect the actual 
linter being used. 
 
This change also updates the related unit test accordingly: 
`staticcheck` compiles the source files first, so the test Go code must 
be self-contained and not use undefined types. 
 
BUG=b:218608945 
TEST=None 
 
Change-Id: I627da26edc4ea8c968457b8747b081f4e1c64f5a 
Signed-off-by: Arnaud Ferraris <arnaud.ferraris@collabora.corp-partner.google.com> 
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/infra/ide/+/6054011 
Reviewed-by: Grace Cham <hscham@chromium.org> 
Commit-Queue: Grace Cham <hscham@chromium.org> 
Reviewed-by: Keigo Oka <oka@chromium.org> 
Tested-by: Keigo Oka <oka@chromium.org>

Files:

M chromiumide/shared/app/features/lint/cros_lint_config.ts
M chromiumide/shared/app/features/lint/tast_lint_config.ts
M chromiumide/shared/app/features/lint/util.ts
M chromiumide/src/test/integration/features/lint.test.ts

Hash: 1d67e404f00065c68fbb18841f021daa737219d1
Date: Wed Nov 27 12:03:09 2024

ap...@google.com <ap...@google.com> #77Dec 3, 2024 09:25PM

Project: chromiumos/third_party/toolchain-utils
Branch: main
Author: Arnaud Ferraris <arnaud.ferraris@collabora.corp-partner.google.com>
Link: https://chromium-review.googlesource.com/6054597

githooks: check-presubmit: use staticcheck as the Go linter

Expand for full commit details

githooks: check-presubmit: use staticcheck as the Go linter 
 
As `golint` is not maintained anymore, it has been replaced with 
`staticcheck` as the default Go linter in ChromeOS. We should therefore 
use the latter in git hooks as well. 
 
BUG=b:218608945 
TEST=manual check 
 
Change-Id: I53bdf5e6637a3cb783298e0e75db7ffe2f5fe2f3 
Signed-off-by: Arnaud Ferraris <arnaud.ferraris@collabora.corp-partner.google.com> 
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/6054597 
Reviewed-by: Saketh Pothireddy <spothire@google.com> 
Commit-Queue: Jordan Abrahams-Whitehead <ajordanr@google.com> 
Reviewed-by: Jordan Abrahams-Whitehead <ajordanr@google.com>

Files:

M toolchain_utils_githooks/check-presubmit.py

Hash: 8a472a3cf2c5c56728b444eb1d6ae87fbde76f9a
Date: Wed Nov 27 12:07:59 2024

ap...@google.com <ap...@google.com> #78Dec 3, 2024 09:40PM

Project: chromiumos/platform/tremplin
Branch: main
Author: Arnaud Ferraris <arnaud.ferraris@collabora.corp-partner.google.com>
Link: https://chromium-review.googlesource.com/6062823

tremplin: replace use of deprecated modules/functions

Expand for full commit details

tremplin: replace use of deprecated modules/functions 
 
This change ensures `tremplin` no longer uses deprecated modules and/or 
functions. Most of the changes relate to `io/ioutil`, deprecated since 
Go 1.16[1], with equivalent functions/variables being implemented in 
the `io` and `os` modules. 
 
The only other change involves using `grpc.WithContextDialer()` instead 
of the deprecated `grpc.WithDialer()`[2]. 
 
[1] https://pkg.go.dev/io/ioutil 
[2] https://pkg.go.dev/google.golang.org/grpc#WithDialer 
 
BUG=b:218608945 
TEST=staticcheck "chromiumos/tremplin/..." 
 
Change-Id: I552074e12b619bad4dcb87c5afe62dec5fccb3c6 
Signed-off-by: Arnaud Ferraris <arnaud.ferraris@collabora.corp-partner.google.com> 
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/tremplin/+/6062823 
Reviewed-by: Daniel Verkamp <dverkamp@chromium.org> 
Commit-Queue: Jordan Abrahams-Whitehead <ajordanr@google.com> 
Reviewed-by: Jordan Abrahams-Whitehead <ajordanr@google.com>

Files:

M src/chromiumos/tremplin/instance_file_server.go
M src/chromiumos/tremplin/lxd_helper.go
M src/chromiumos/tremplin/main.go
M src/chromiumos/tremplin/passwd_db.go
M src/chromiumos/tremplin/passwd_db_test.go
M src/chromiumos/tremplin/start_lxd.go
M src/chromiumos/tremplin/stop_lxd.go
M src/chromiumos/tremplin/tremplin.go
M src/chromiumos/tremplin/upgrade_container_test.go
M src/chromiumos/tremplin/version.go

Hash: bcd6f500b92618e2f7d63733f6f803f9aca68372
Date: Mon Dec 02 16:31:11 2024

ap...@google.com <ap...@google.com> #79Dec 4, 2024 12:15AM

Project: chromiumos/platform/graphics
Branch: main
Author: Arnaud Ferraris <arnaud.ferraris@collabora.corp-partner.google.com>
Link: https://chromium-review.googlesource.com/6059836

graphics-utils-go: fix deprecation issues

Expand for full commit details

graphics-utils-go: fix deprecation issues 
 
The `io/ioutil` module has been deprecated since Go 1.16[1], with 
equivalent functions/variables being implemented in the `io` and `os` 
modules. 
 
Likewise, `github.com/golang/protobuf` and its various sub-modules is 
now deprecated and replaced with `google.golang.org/protobuf`[2]. 
 
[1] https://pkg.go.dev/io/ioutil 
[2] https://pkg.go.dev/github.com/golang/protobuf 
 
BUG=b:218608945 
TEST=staticcheck "go.chromium.org/chromiumos/graphics-utils-go/..." 
 
Change-Id: I7dc8d10bcda9639f2fce25275474d09cc982ac7f 
Signed-off-by: Arnaud Ferraris <arnaud.ferraris@collabora.corp-partner.google.com> 
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/graphics/+/6059836 
Reviewed-by: Jao-ke Chin-Lee <jchinlee@google.com> 
Reviewed-by: Jordan Abrahams-Whitehead <ajordanr@google.com> 
Commit-Queue: Jordan Abrahams-Whitehead <ajordanr@google.com>

Files:

M src/go.chromium.org/chromiumos/graphics-utils-go/hardware_probe/cmd/hardware_probe/gpu_info.go
M src/go.chromium.org/chromiumos/graphics-utils-go/hardware_probe/cmd/hardware_probe/main.go
M src/go.chromium.org/chromiumos/graphics-utils-go/hardware_probe/cmd/hardware_probe/pci_vga_info.go
M src/go.chromium.org/chromiumos/graphics-utils-go/platform_decoding/cmd/validate/main.go
M src/go.chromium.org/chromiumos/graphics-utils-go/trace_profiling/cmd/gen_db_result/Makefile
M src/go.chromium.org/chromiumos/graphics-utils-go/trace_profiling/cmd/gen_db_result/common/utils.go
M src/go.chromium.org/chromiumos/graphics-utils-go/trace_profiling/cmd/harvest/utils/device_info_tool.go
M src/go.chromium.org/chromiumos/graphics-utils-go/trace_replay/cmd/trace_replay/main.go

Hash: 70332bc6f9e1aad6fb0724307e428c88f5b8d84e
Date: Fri Nov 29 14:44:02 2024

ap...@google.com <ap...@google.com> #80Dec 4, 2024 12:29AM

Project: chromiumos/platform/tast
Branch: main
Author: Arnaud Ferraris <arnaud.ferraris@collabora.corp-partner.google.com>
Link: https://chromium-review.googlesource.com/6055045

core: replace deprecated "terminal" module

Expand for full commit details

core: replace deprecated "terminal" module 
 
`golang.org/x/crypto/ssh/terminal` has been deprecated[1] and replaced 
by `golang.org/x/term`. Ensure we use the latter. 
 
[1] https://go.googlesource.com/crypto/+/refs/heads/master/ssh/terminal/terminal.go#8 
 
BUG=b:218608945 
TEST=staticcheck "go.chromium.org/tast/..." 
 
Change-Id: Id5efd580e2a722388d66f44043997dc78094bb5b 
Signed-off-by: Arnaud Ferraris <arnaud.ferraris@collabora.corp-partner.google.com> 
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/tast/+/6055045 
Reviewed-by: Saketh Pothireddy <spothire@google.com> 
Commit-Queue: Jordan Abrahams-Whitehead <ajordanr@google.com> 
Reviewed-by: Seewai Fu <seewaifu@google.com>

Files:

M src/go.chromium.org/tast/core/cmd/tast/internal/display/term.go
M src/go.chromium.org/tast/core/cmd/tast/main.go
M src/go.chromium.org/tast/core/ssh/conn.go

Hash: 7bae7901f572dbeb08dcdd19acba651d0ff8d13b
Date: Fri Nov 29 12:29:00 2024

ap...@google.com <ap...@google.com> #81Dec 4, 2024 11:36AM

Project: chromiumos/platform2
Branch: main
Author: Arnaud Ferraris <arnaud.ferraris@collabora.corp-partner.google.com>
Link: https://chromium-review.googlesource.com/6058514

chromeos-dbus-bindings: replace deprecated "ioutil" module

Expand for full commit details

chromeos-dbus-bindings: replace deprecated "ioutil" module 
 
The `io/ioutil` module has been deprecated since Go 1.16[1], with 
equivalent functions/variables being implemented in the `io` and `os` 
modules. 
 
Ensure we stop using `ioutil` functions by replacing those calls with 
their `io`/`os` counterparts. 
 
[1] https://pkg.go.dev/io/ioutil 
 
BUG=b:218608945 
TEST=staticcheck "go.chromium.org/chromiumos/dbusbindings/..." 
 
Change-Id: I627cc9154bd65087607fbf4c17339f04f35df5a2 
Signed-off-by: Arnaud Ferraris <arnaud.ferraris@collabora.corp-partner.google.com> 
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/6058514 
Reviewed-by: Eric Caruso <ejcaruso@chromium.org> 
Reviewed-by: Jordan Abrahams-Whitehead <ajordanr@google.com>

Files:

M chromeos-dbus-bindings/go/src/go.chromium.org/chromiumos/dbusbindings/cmd/generator/main.go
M chromeos-dbus-bindings/go/src/go.chromium.org/chromiumos/dbusbindings/serviceconfig/config.go

Hash: 97f602693e9f48b98a5bdca862d2ee6f3cd0bced
Date: Fri Nov 29 14:36:20 2024

ap...@google.com <ap...@google.com> #82Dec 10, 2024 08:31AM

Project: chromiumos/platform/tast-tests
Branch: main
Author: Arnaud Ferraris <arnaud.ferraris@collabora.corp-partner.google.com>
Link: https://chromium-review.googlesource.com/6074523

tast-tests: fix linter errors

Expand for full commit details

tast-tests: fix linter errors 
 
As part of b:218608945 `golint` will be replaced with `staticcheck` as 
the default Go linter for ChromeOS. As a preliminary step we need to 
ensure `staticcheck` passes with current Go packages. 
 
This fixes such errors[1] for Tast tests. 
 
[1] Please refer to https://staticcheck.dev/docs/checks/ for details 
about each check. 
 
BUG=b:218608945 
TEST=staticcheck -checks "inherit,-SA1019" \ 
    "go.chromium.org/tast-tests/..." 
 
Change-Id: I76d11dbee4eeb387029404b0a43431a62d7de48f 
Signed-off-by: Arnaud Ferraris <arnaud.ferraris@collabora.corp-partner.google.com> 
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/tast-tests/+/6074523 
Tast-Review: Seewai Fu <seewaifu@google.com> 
Reviewed-by: George Burgess <gbiv@chromium.org> 
Reviewed-by: Seewai Fu <seewaifu@google.com>

Files:

M src/go.chromium.org/tast-tests/cros/local/bundles/cros/ui/conference/run.go
M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/gscdevboard/gsc_ccd_straps.go

Hash: c0f51c720595eb211eff2a9708093587d386d683
Date: Mon Dec 09 14:50:46 2024

ap...@google.com <ap...@google.com> #83Dec 10, 2024 11:56AM

Project: chromiumos/platform/dev-util
Branch: main
Author: Arnaud Ferraris <arnaud.ferraris@collabora.corp-partner.google.com>
Link: https://chromium-review.googlesource.com/6077709

test: publish: fix linter errors

Expand for full commit details

test: publish: fix linter errors 
 
As part of b:218608945 `golint` will be replaced with `staticcheck` as 
the default Go linter for ChromeOS. As a preliminary step we need to 
ensure `staticcheck` passes with current Go packages. 
 
This fixes the following errors[1] for test/publish (`cros-publish`): 
* ST1005 (incorrectly formatted error strings) 
 
[1] Please refer to https://staticcheck.dev/docs/checks/ for details 
about each check. 
 
BUG=b:218608945 
TEST=staticcheck -checks "inherit,-SA1019" \ 
    "go.chromium.org/chromiumos/test/publish/..." 
 
Change-Id: I5f41536e259b08a3007c10e32f8f1e873e9f4fb1 
Signed-off-by: Arnaud Ferraris <arnaud.ferraris@collabora.corp-partner.google.com> 
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/dev-util/+/6077709 
Reviewed-by: Seewai Fu <seewaifu@google.com> 
Reviewed-by: Allen Xie <zhihuixie@google.com>

Files:

M src/go.chromium.org/chromiumos/test/publish/cmd/gcs-publish/service/xts_archiver.go
M src/go.chromium.org/chromiumos/test/publish/cmd/gcs-publish/service/xts_archiver_test.go

Hash: b8a753dcfe5cb877d6f68a7e52c13a81f8f0af2a
Date: Mon Dec 09 14:34:53 2024

ap...@google.com <ap...@google.com> #84Dec 16, 2024 10:05AM

Project: chromiumos/platform/tast-tests
Branch: main
Author: Arnaud Ferraris <arnaud.ferraris@collabora.corp-partner.google.com>
Link: https://chromium-review.googlesource.com/6093668

tast-tests: fix remaining linter errors

Expand for full commit details

tast-tests: fix remaining linter errors 
 
As part of b:218608945 `golint` will be replaced with `staticcheck` as 
the default Go linter for ChromeOS. As a preliminary step we need to 
ensure `staticcheck` passes with current Go packages. 
 
This fixes such errors[1] for Tast tests. 
 
[1] Please refer to https://staticcheck.dev/docs/checks/ for details 
about each check. 
 
BUG=b:218608945 
TEST=staticcheck -checks "inherit,-SA1019" \ 
    "go.chromium.org/tast-tests/..." 
 
Change-Id: I16faf3c0049341483b3124093efff15529f08d69 
Signed-off-by: Arnaud Ferraris <arnaud.ferraris@collabora.corp-partner.google.com> 
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/tast-tests/+/6093668 
Tast-Review: Seewai Fu <seewaifu@google.com> 
Reviewed-by: Seewai Fu <seewaifu@google.com> 
Reviewed-by: George Burgess <gbiv@chromium.org>

Files:

M src/go.chromium.org/tast-tests/cros/local/bundles/cros/video/draw_on_canvas_test.go
M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/wifi/bss_tm_request.go

Hash: 388272b80f7f42f0c0905f9203c0e7283207450b
Date: Wed Dec 11 11:13:58 2024

ap...@google.com <ap...@google.com> #85Dec 17, 2024 01:53AM

Project: chromiumos/platform/tast
Branch: main
Author: Arnaud Ferraris <arnaud.ferraris@collabora.corp-partner.google.com>
Link: https://chromium-review.googlesource.com/6055047

core: replace deprecated protobuf-related modules

Expand for full commit details

core: replace deprecated protobuf-related modules 
 
`github.com/golang/protobuf` and its sub-modules has been deprecated 
and superseded by `google.golang.org/protobuf`[1]. Drop all use of the 
old modules and switch to using only the latter. 
 
[1] https://pkg.go.dev/github.com/golang/protobuf 
 
BUG=b:218608945 
TEST=staticcheck "go.chromium.org/tast/..." 
 
Change-Id: Idd454f3321fc239d88cc5e37e33870fce8342593 
Signed-off-by: Arnaud Ferraris <arnaud.ferraris@collabora.corp-partner.google.com> 
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/tast/+/6055047 
Reviewed-by: Jordan Abrahams-Whitehead <ajordanr@google.com> 
Reviewed-by: Seewai Fu <seewaifu@google.com>

Files:

M docs/codelab_4.md
M src/go.chromium.org/tast/core/cmd/tast/internal/run/driver/dut_info_test.go
M src/go.chromium.org/tast/core/cmd/tast/internal/run/driver/list_tests_test.go
M src/go.chromium.org/tast/core/cmd/tast/internal/run/driver/run_tests.go
M src/go.chromium.org/tast/core/cmd/tast/internal/run/run.go
M src/go.chromium.org/tast/core/internal/bundle/args.go
M src/go.chromium.org/tast/core/internal/bundle/args_test.go
M src/go.chromium.org/tast/core/internal/bundle/fixture_service.go
M src/go.chromium.org/tast/core/internal/bundle/fixture_service_test.go
M src/go.chromium.org/tast/core/internal/bundle/legacyjson/compat.go
M src/go.chromium.org/tast/core/internal/bundle/run_tests.go
M src/go.chromium.org/tast/core/internal/devserver/tlw.go
M src/go.chromium.org/tast/core/internal/fakedutserver/fake_dut_server.go
M src/go.chromium.org/tast/core/internal/fakedutserver/fake_dut_server_test.go
M src/go.chromium.org/tast/core/internal/faketlw/faketlw.go
M src/go.chromium.org/tast/core/internal/faketlw/faketlw_test.go
M src/go.chromium.org/tast/core/internal/minidriver/processor/handler_passthrough.go
M src/go.chromium.org/tast/core/internal/minidriver/processor/preprocessor.go
M src/go.chromium.org/tast/core/internal/minidriver/processor/processor_test.go
M src/go.chromium.org/tast/core/internal/minidriver/run_tests.go
M src/go.chromium.org/tast/core/internal/protocol/protocoltest/protocoltest.go
M src/go.chromium.org/tast/core/internal/rpc/protobuf_raw.go
M src/go.chromium.org/tast/core/internal/rpc/protobuf_raw_test.go
M src/go.chromium.org/tast/core/internal/rpc/rpc_test.go
M src/go.chromium.org/tast/core/internal/run/fakereports/fake_reports.go
M src/go.chromium.org/tast/core/internal/run/reporting/rpc.go
M src/go.chromium.org/tast/core/internal/run/resultsjson/resultsjson.go
M src/go.chromium.org/tast/core/internal/testing/state_test.go
M src/go.chromium.org/tast/core/internal/testing/test_instance.go
M src/go.chromium.org/tast/core/internal/testing/test_instance_test.go
M src/go.chromium.org/tast/core/internal/timing/timing.go
M src/go.chromium.org/tast/core/internal/timing/timing_test.go

Hash: ba2a67ab16801ed14172cd4860381dae008c7042
Date: Fri Nov 29 13:23:33 2024

ap...@google.com <ap...@google.com> #86Dec 17, 2024 09:14AM

Project: chromiumos/platform/dev-util
Branch: main
Author: Arnaud Ferraris <arnaud.ferraris@collabora.corp-partner.google.com>
Link: https://chromium-review.googlesource.com/5953692

test: provision: fix linter errors

Expand for full commit details

test: provision: fix linter errors 
 
As part of b:218608945 `golint` will be replaced with `staticcheck` as 
the default Go linter for ChromeOS. As a preliminary step we need to 
ensure `staticcheck` passes with current Go packages. 
 
This fixes the following errors[1] for test/provision (`cros-provision`): 
* S1002 (comparison with boolean constant) 
* S1016 (manually copying of struct fields) 
* S1017 (use strings.TrimPrefix instead of manual trimming) 
* SA1006 (Printf with no dynamic argument) 
* SA1024 (string cutset containing duplicate characters) 
* SA1029 (inappropriate key in call to context.WithValue) 
* SA4006 (assigned but unused variable) 
* SA4009 (function argument overwritten before first use) 
* ST1005 (incorrectly formatted error strings) 
* ST1011 (poorly chosen name for variable of type time.Duration) 
* U1000 (unused type/const/struct field) 
 
[1] Please refer to https://staticcheck.dev/docs/checks/ for details 
about each check. 
 
BUG=b:218608945 
TEST=staticcheck -checks "inherit,-SA1019" \ 
    "go.chromium.org/chromiumos/test/provision/..." 
 
Change-Id: Id10692c7d0ac1c174a3d6076f4f3d9a00b4f1b1a 
Signed-off-by: Arnaud Ferraris <arnaud.ferraris@collabora.corp-partner.google.com> 
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/dev-util/+/5953692 
Reviewed-by: Varun Srivastav <varunsrivastav@google.com> 
Reviewed-by: Jordan Abrahams-Whitehead <ajordanr@google.com>

Files:

M src/go.chromium.org/chromiumos/test/provision/cmd/cros-provision/main.go
M src/go.chromium.org/chromiumos/test/provision/cmd/provisionserver/bootstrap/services/ashservice/ashservice.go
M src/go.chromium.org/chromiumos/test/provision/cmd/provisionserver/bootstrap/services/ashservice/installstate.go
M src/go.chromium.org/chromiumos/test/provision/cmd/provisionserver/bootstrap/services/ashservice/preparestate.go
M src/go.chromium.org/chromiumos/test/provision/cmd/provisionserver/bootstrap/services/crosservice/crosservice.go
M src/go.chromium.org/chromiumos/test/provision/cmd/provisionserver/bootstrap/services/crosservice/installstate.go
M src/go.chromium.org/chromiumos/test/provision/cmd/provisionserver/bootstrap/services/crosservice/postinstallstate.go
M src/go.chromium.org/chromiumos/test/provision/cmd/provisionserver/bootstrap/services/crosservice/provisiondlcstate.go
M src/go.chromium.org/chromiumos/test/provision/cmd/provisionserver/bootstrap/services/crosservice/verifystate.go
M src/go.chromium.org/chromiumos/test/provision/v2/android-provision/cli/abstract_command.go
M src/go.chromium.org/chromiumos/test/provision/v2/android-provision/cli/cli_command.go
M src/go.chromium.org/chromiumos/test/provision/v2/android-provision/common/constants.go
M src/go.chromium.org/chromiumos/test/provision/v2/android-provision/state-machine/commands/cleanup_command.go
M src/go.chromium.org/chromiumos/test/provision/v2/android-provision/state-machine/commands/cleanup_command_test.go
M src/go.chromium.org/chromiumos/test/provision/v2/android-provision/state-machine/commands/copy_data_command.go
M src/go.chromium.org/chromiumos/test/provision/v2/android-provision/state-machine/commands/copy_data_command_test.go
M src/go.chromium.org/chromiumos/test/provision/v2/android-provision/state-machine/commands/extract_zip_command.go
M src/go.chromium.org/chromiumos/test/provision/v2/android-provision/state-machine/commands/extract_zip_command_test.go
M src/go.chromium.org/chromiumos/test/provision/v2/android-provision/state-machine/commands/reboot_helpers.go
M src/go.chromium.org/chromiumos/test/provision/v2/android-provision/state-machine/os_fetch_state.go
M src/go.chromium.org/chromiumos/test/provision/v2/android-provision/state-machine/os_install_state.go
M src/go.chromium.org/chromiumos/test/provision/v2/android-provision/state-machine/package_fetch_state.go
M src/go.chromium.org/chromiumos/test/provision/v2/android-provision/state-machine/package_install_state.go
M src/go.chromium.org/chromiumos/test/provision/v2/android-provision/state-machine/post_install_state.go
M src/go.chromium.org/chromiumos/test/provision/v2/android-provision/state-machine/prepare_state.go
M src/go.chromium.org/chromiumos/test/provision/v2/cros-fw-provision/cros_fw_provision_test.go
M src/go.chromium.org/chromiumos/test/provision/v2/cros-provision/cli/abstract_command.go
M src/go.chromium.org/chromiumos/test/provision/v2/cros-provision/cros_provision_test.go
M src/go.chromium.org/chromiumos/test/provision/v2/cros-provision/state-machine/commands/check_install_needed.go
M src/go.chromium.org/chromiumos/test/provision/v2/cros-provision/state-machine/commands/verify_firmware_command.go
M src/go.chromium.org/chromiumos/test/provision/v2/cros-provision/state-machine/commands/wait_for_dut_to_stabilize_command.go
M src/go.chromium.org/chromiumos/test/provision/v2/cros-provision/state-machine/commands/wait_for_kernel_sticky.go
M src/go.chromium.org/chromiumos/test/provision/v2/cros-provision/state-machine/init_state.go
M src/go.chromium.org/chromiumos/test/provision/v2/cros-provision/state-machine/install_state.go
M src/go.chromium.org/chromiumos/test/provision/v2/cros-provision/state-machine/post_install_state.go
M src/go.chromium.org/chromiumos/test/provision/v2/cros-provision/state-machine/pre_init_state.go
M src/go.chromium.org/chromiumos/test/provision/v2/cros-provision/state-machine/provision_dlc_state.go
M src/go.chromium.org/chromiumos/test/provision/v2/cros-provision/state-machine/reset_device_state.go
M src/go.chromium.org/chromiumos/test/provision/v2/cros-provision/state-machine/update_firmware_state.go
M src/go.chromium.org/chromiumos/test/provision/v2/cros-provision/state-machine/verify_state.go
M src/go.chromium.org/chromiumos/test/provision/v2/vm-provision/main.go
M src/go.chromium.org/chromiumos/test/provision/v2/vm-provision/vm_leaser_rpc.go

Hash: dc46ac5c370facd868983cba1d9bd2bebc0592cf
Date: Wed Oct 23 17:49:57 2024

ap...@google.com <ap...@google.com> #87Dec 17, 2024 11:32AM

Project: chromiumos/platform/dev-util
Branch: main
Author: Arnaud Ferraris <arnaud.ferraris@collabora.corp-partner.google.com>
Link: https://chromium-review.googlesource.com/6088128

lro, lroold: replace deprecated protobuf-related modules

Expand for full commit details

lro, lroold: replace deprecated protobuf-related modules 
 
`github.com/golang/protobuf` and its sub-modules has been deprecated 
and superseded by `google.golang.org/protobuf`[1]. Drop all use of the 
old modules and switch to using only the latter. 
 
[1] https://pkg.go.dev/github.com/golang/protobuf 
 
BUG=b:218608945 
TEST=staticcheck -checks SA1019 "go.chromium.org/chromiumos/lro/..." 
 
Change-Id: I0c3957e36ac32d24e81ba88c43724a35c1ecae7b 
Signed-off-by: Arnaud Ferraris <arnaud.ferraris@collabora.corp-partner.google.com> 
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/dev-util/+/6088128 
Reviewed-by: George Engelbrecht <engeg@google.com> 
Reviewed-by: George Burgess <gbiv@chromium.org> 
Reviewed-by: Jesse McGuire <jessemcguire@google.com>

Files:

M src/go.chromium.org/chromiumos/lro/manager.go
M src/go.chromium.org/chromiumos/lroold/manager.go

Hash: 84291f9040389b21e2a4f4701e78ba7c4b1968a6
Date: Fri Dec 13 16:51:03 2024

ap...@google.com <ap...@google.com> #88Dec 17, 2024 05:29PM

Project: chromiumos/infra/recipes
Branch: main
Author: Arnaud Ferraris <arnaud.ferraris@collabora.corp-partner.google.com>
Link: https://chromium-review.googlesource.com/6053929

recipes: use staticcheck as the Go linter

Expand for full commit details

recipes: use staticcheck as the Go linter 
 
As `golint` is deprecated, we should switch to using an actually 
maintained linter for Go packages. `staticcheck` being one of the 
recommended alternatives, use it instead. 
 
BUG=b:218608945 
TEST=None 
 
Change-Id: I6fd578c74a4b022a53f3a4f982b9d4aa665c5be2 
Signed-off-by: Arnaud Ferraris <arnaud.ferraris@collabora.corp-partner.google.com> 
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/infra/recipes/+/6053929 
Reviewed-by: Dhanya Ganesh <dhanyaganesh@chromium.org> 
Reviewed-by: Bob Haarman <inglorion@chromium.org>

Files:

M recipes/build_linters.py

Hash: 877d2a3cc301ffe320e2eec9142271212ea92fdd
Date: Wed Nov 27 10:56:04 2024

ap...@google.com <ap...@google.com> #89Dec 17, 2024 08:28PM

Project: chromiumos/overlays/chromiumos-overlay
Branch: main
Author: Arnaud Ferraris <arnaud.ferraris@collabora.corp-partner.google.com>
Link: https://chromium-review.googlesource.com/6038263

eclass: cros-go: error out on staticcheck issues

Expand for full commit details

eclass: cros-go: error out on staticcheck issues 
 
`staticcheck` has been used as a replacement for `golint` for some time 
now, and all packages for which it reported issues have been fixed or 
have pending CLs. 
 
We can therefore now enforce `staticcheck` compliance by erroring out 
if it detects any issue. 
 
BUG=b:218608945 
TEST=ENABLE_GO_LINT=1 emerge-$BOARD cros-provision (expected to fail) 
 
Cq-Depend: chromium:5953692, chromium:6093668 
Change-Id: I5d4ee1bed3b68cd6f0c818867c99dfafdcb88082 
Signed-off-by: Arnaud Ferraris <arnaud.ferraris@collabora.corp-partner.google.com> 
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/overlays/chromiumos-overlay/+/6038263 
Reviewed-by: Alex Klein <saklein@chromium.org> 
Reviewed-by: Bob Haarman <inglorion@chromium.org>

Files:

M eclass/cros-go.eclass

Hash: b11635a4da49219c559817e50e7c938fb1f54ebd
Date: Fri Nov 22 14:04:02 2024

ap...@google.com <ap...@google.com> #90Dec 18, 2024 02:19AM

Project: chromiumos/overlays/chromiumos-overlay
Branch: firmware-android-15949.B
Author: Arnaud Ferraris <arnaud.ferraris@collabora.corp-partner.google.com-copybot-pick>
Link: https://chromium-review.googlesource.com/6102913

eclass: cros-go: error out on staticcheck issues Android Bringup: See http://go/android-fw-sync

Expand for full commit details

eclass: cros-go: error out on staticcheck issues 
Android Bringup: See http://go/android-fw-sync 
 
`staticcheck` has been used as a replacement for `golint` for some time 
now, and all packages for which it reported issues have been fixed or 
have pending CLs. 
 
We can therefore now enforce `staticcheck` compliance by erroring out 
if it detects any issue. 
 
BUG=b:218608945 
TEST=ENABLE_GO_LINT=1 emerge-$BOARD cros-provision (expected to fail) 
 
(cherry picked from commit b11635a4da49219c559817e50e7c938fb1f54ebd) 
 
Cq-Depend: chromium:5953692, chromium:6093668 
Change-Id: I5d4ee1bed3b68cd6f0c818867c99dfafdcb88082 
Original-Signed-off-by: Arnaud Ferraris <arnaud.ferraris@collabora.corp-partner.google.com> 
Original-Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/overlays/chromiumos-overlay/+/6038263 
Original-Reviewed-by: Alex Klein <saklein@chromium.org> 
Original-Reviewed-by: Bob Haarman <inglorion@chromium.org> 
GitOrigin-RevId: b11635a4da49219c559817e50e7c938fb1f54ebd 
Cr-Build-Id: 8728269976375238033 
Cr-Build-Url: https://cr-buildbucket.appspot.com/build/8728269976375238033 
Copybot-Job-Name: android-main-chromiumos-overlay-copybot-downstream 
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/overlays/chromiumos-overlay/+/6102913 
Tested-by: ChromeOS Prod (Robot) <chromeos-ci-prod@chromeos-bot.iam.gserviceaccount.com> 
Commit-Queue: Jonathon Murphy <jpmurphy@google.com> 
Reviewed-by: Jonathon Murphy <jpmurphy@google.com>

Files:

M eclass/cros-go.eclass

Hash: f0f0eda48a00f8e26010da5d2d359cb16b84d241
Date: Fri Nov 22 14:04:02 2024

ap...@google.com <ap...@google.com> #91Dec 20, 2024 08:10AM

Project: chromiumos/platform/tast-tests
Branch: main
Author: Arnaud Ferraris <arnaud.ferraris@collabora.corp-partner.google.com>
Link: https://chromium-review.googlesource.com/6097133

tast-tests: replace deprecated protobuf-related modules

Expand for full commit details

tast-tests: replace deprecated protobuf-related modules 
 
`github.com/golang/protobuf` and its sub-modules has been deprecated 
and superseded by `google.golang.org/protobuf`[1]. Drop all use of the 
old modules and switch to using only the latter. 
 
[1] https://pkg.go.dev/github.com/golang/protobuf 
 
BUG=b:218608945 
TEST=staticcheck -checks SA1019 "go.chromium.org/tast-tests/..." 
 
Change-Id: I55bd3857714ba707d264cc3cba9843bd84a68cb0 
Signed-off-by: Arnaud Ferraris <arnaud.ferraris@collabora.corp-partner.google.com> 
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/tast-tests/+/6097133 
Tast-Review: Alexander Hartl <alexanderhartl@google.com> 
Reviewed-by: Seewai Fu <seewaifu@google.com> 
Reviewed-by: Alexander Hartl <alexanderhartl@google.com>

Files:

M src/go.chromium.org/tast-tests/cros/common/hwsec/attestation_common.go
M src/go.chromium.org/tast-tests/cros/common/hwsec/challenge_response.go
M src/go.chromium.org/tast-tests/cros/common/hwsec/cryptohome_client.go
M src/go.chromium.org/tast-tests/cros/common/hwsec/helpers.go
M src/go.chromium.org/tast-tests/cros/common/policy/defs_test.go
M src/go.chromium.org/tast-tests/cros/local/arc/dumpsys.go
M src/go.chromium.org/tast-tests/cros/local/arc/perfetto/perfetto.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/ad/kerberos/kerberos.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/ad/kerberos_daemon.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/baserpc/file_system_service.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/crash/serializer.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/feedback/user_feedback_service.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/firmware/serial_port_service.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/hwsec/attestation.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/hwsec/attestation_delete_keys.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/hwsec/attestation_no_external_server.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/hwsec/fixture/attestation_fixture.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/network/link_monitor_ethernet.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/platform/perfetto_chrome_consumer.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/platform/perfetto_chrome_producer.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/policy/plugin_vm_data_collection_allowed.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/policy/reporting_cpu_info.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/policy/reporting_input_info.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/policy/reporting_memory_info.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/policy/reporting_network_telemetry.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/policy/reporting_privacy_screen_info.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/policy/reporting_runtime_counters_telemetry.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/policy/reporting_unuploaded_crash_events.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/policy/reporting_uploaded_crash_events.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/policy/reporting_usb_events.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/runtimeprobe/probe_function.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/security/boot_lockbox_service.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/session/multi_user_policy.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/session/ownership_taken.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/session/user_policy_keys.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/ui/stack_sampled_metrics_v2.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/wilco/powerd_policies.go
M src/go.chromium.org/tast-tests/cros/local/cellular/modem_manifests_helper.go
M src/go.chromium.org/tast-tests/cros/local/chrome/chrome.go
M src/go.chromium.org/tast-tests/cros/local/chrome/internal/cdputil/session.go
M src/go.chromium.org/tast-tests/cros/local/chrome/nearbyshare/nearbysnippet/snippet.go
M src/go.chromium.org/tast-tests/cros/local/cryptohome/fake_auth_stack_manager.go
M src/go.chromium.org/tast-tests/cros/local/cryptohome/login_err_msg.go
M src/go.chromium.org/tast-tests/cros/local/cryptohome/user_data_auth.go
M src/go.chromium.org/tast-tests/cros/local/dbusutil/proto.go
M src/go.chromium.org/tast-tests/cros/local/erpserver/erpserver.go
M src/go.chromium.org/tast-tests/cros/local/mlservice/fake_adaptive_charging_ml_service.go
M src/go.chromium.org/tast-tests/cros/local/network/patchpanel_client/patchpanel_client.go
M src/go.chromium.org/tast-tests/cros/local/power/power_manager_emitter.go
M src/go.chromium.org/tast-tests/cros/local/printscanmgr/printscanmgr.go
M src/go.chromium.org/tast-tests/cros/local/scanner/lorgnette/dbus.go
M src/go.chromium.org/tast-tests/cros/local/session/ownership.go
M src/go.chromium.org/tast-tests/cros/local/session/session_manager.go
M src/go.chromium.org/tast-tests/cros/local/tracing/utils.go
M src/go.chromium.org/tast-tests/cros/local/u2fd/u2f_daemon.go
M src/go.chromium.org/tast-tests/cros/local/vm/concierge.go
M src/go.chromium.org/tast-tests/cros/local/vm/util.go
M src/go.chromium.org/tast-tests/cros/local/vm/vm.go
M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/arc/suspend.go
M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/featured/store_interface_early_boot.go
M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/platform/cros_hardware_verifier.go
M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/platform/perfetto/traces.go
M src/go.chromium.org/tast-tests/cros/remote/dutfs/dutfs.go
M src/go.chromium.org/tast-tests/cros/remote/firmware/serial/remote_port_opener.go
M src/go.chromium.org/tast-tests/cros/remote/updateutil/updateutil.go

Hash: b6b468e055f5645a7fe92433953e0dceb86e287d
Date: Mon Dec 16 15:46:13 2024

ap...@google.com <ap...@google.com> #92Jan 10, 2025 08:34AM

Project: chromiumos/platform/tast-tests
Branch: main
Author: Arnaud Ferraris <arnaud.ferraris@collabora.corp-partner.google.com>
Link: https://chromium-review.googlesource.com/6097132

tast-tests: replace deprecated "ioutil" module

Expand for full commit details

tast-tests: replace deprecated "ioutil" module 
 
The `io/ioutil` module has been deprecated since Go 1.16[1], with 
equivalent functions/variables being implemented in the `io` and `os` 
modules. 
 
Ensure we stop using `ioutil` functions by replacing those calls with 
their `io`/`os` counterparts. 
 
[1] https://pkg.go.dev/io/ioutil 
 
BUG=b:218608945 
TEST=staticcheck -checks SA1019 "go.chromium.org/tast-tests/..." 
 
Change-Id: I0a93cca638175a71db0c626f3b83d9b470933add 
Signed-off-by: Arnaud Ferraris <arnaud.ferraris@collabora.corp-partner.google.com> 
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/tast-tests/+/6097132 
Reviewed-by: Seewai Fu <seewaifu@google.com> 
Tast-Review: Jacek Siuda <jsiuda@google.com> 
Tast-Review: Seewai Fu <seewaifu@google.com> 
Reviewed-by: Victor Gabriel Savu <vsavu@google.com> 
Reviewed-by: Jacek Siuda <jsiuda@google.com>

Files:

M src/go.chromium.org/tast-tests/cros/common/android/adb/file.go
M src/go.chromium.org/tast-tests/cros/common/android/adb/vendor_keys.go
M src/go.chromium.org/tast-tests/cros/common/android/mobly/snippet_client.go
M src/go.chromium.org/tast-tests/cros/common/android/ui/device.go
M src/go.chromium.org/tast-tests/cros/common/bond/bond.go
M src/go.chromium.org/tast-tests/cros/common/chrome/extension/util.go
M src/go.chromium.org/tast-tests/cros/common/chrome/extension/util_test.go
M src/go.chromium.org/tast-tests/cros/common/crypto/certificate/cert_util.go
M src/go.chromium.org/tast-tests/cros/common/cryptohome/recovery_test_tool.go
M src/go.chromium.org/tast-tests/cros/common/cswitch/tqc_helper.go
M src/go.chromium.org/tast-tests/cros/common/firmware/bios/cbfs_test.go
M src/go.chromium.org/tast-tests/cros/common/firmware/bios/image.go
M src/go.chromium.org/tast-tests/cros/common/genparams/params.go
M src/go.chromium.org/tast-tests/cros/common/genparams/params_test.go
M src/go.chromium.org/tast-tests/cros/common/hps/hpsutil/firmware.go
M src/go.chromium.org/tast-tests/cros/common/hwsec/attestation_common.go
M src/go.chromium.org/tast-tests/cros/common/perf/checkpoint_test.go
M src/go.chromium.org/tast-tests/cros/common/policy/reportingutil/reporting_util.go
M src/go.chromium.org/tast-tests/cros/common/tape/jwt_token_source.go
M src/go.chromium.org/tast-tests/cros/common/usbutils/device_speed.go
M src/go.chromium.org/tast-tests/cros/common/usbutils/display_helper.go
M src/go.chromium.org/tast-tests/cros/common/wifi/arping/runner.go
M src/go.chromium.org/tast-tests/cros/common/wifi/security/eap/config.go
M src/go.chromium.org/tast-tests/cros/common/wificell/router/fileutil.go
M src/go.chromium.org/tast-tests/cros/common/xmlrpc/xmlrpc.go
M src/go.chromium.org/tast-tests/cros/local/a11y/pdfocr/pdfocr.go
M src/go.chromium.org/tast-tests/cros/local/annotations/annotations.go
M src/go.chromium.org/tast-tests/cros/local/arc/arc.go
M src/go.chromium.org/tast-tests/cros/local/arc/diagnose_test.go
M src/go.chromium.org/tast-tests/cros/local/arc/dumpsys.go
M src/go.chromium.org/tast-tests/cros/local/arc/optin/optin.go
M src/go.chromium.org/tast-tests/cros/local/arc/perfetto/perfetto.go
M src/go.chromium.org/tast-tests/cros/local/audio/loopback_latency.go
M src/go.chromium.org/tast-tests/cros/local/bruschetta/fixture.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/apps/launch_help_app_on_managed_device.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/apps/sharesheet.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/apps/system_web_apps_reinstall.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/appsplatform/webapk.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/arc/arccrash/build_prop.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/arc/build_properties.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/arc/cache/cache.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/arc/containermount/containermount.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/arc/cpu_set.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/arc/cxx_crash.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/arc/dex_opt_cache_sevice.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/arc/download_manager.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/arc/downloads.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/arc/drivefs.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/arc/enable_external_storage.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/arc/fio.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/arc/gameperformance/gameperformance.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/arc/gmscore_cache_service.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/arc/hwoverlay_tablet.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/arc/image_drop_from_downloads.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/arc/image_paste_from_downloads.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/arc/managed_app_install_logging.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/arc/many_files.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/arc/midi_client.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/arc/minicontainer/minicontainer.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/arc/mount_obb.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/arc/mtp.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/arc/multidisplay/multidisplay.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/arc/my_files.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/arc/nethelper/nethelper.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/arc/perf_boot_service.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/arc/perfboot/perfboot.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/arc/play_auto_install.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/arc/play_files.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/arc/play_store_persistent.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/arc/power_perf_service.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/arc/print.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/arc/removablemedia/removable_media.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/arc/restore_data.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/arc/roblox_uncompress_obb_perf.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/arc/selinux_violation.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/arc/sharesheet.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/arc/suspend_service.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/arc/tts_cache_service.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/arc/vm_data_migration.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/assistant/simple_queries.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/assistant/text_queries.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/assistant/time_query.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/assistant/unsupported_setting_queries.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/audio/cyclic_bench.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/autoupdate/update_service.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/baserpc/faillog_service.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/baserpc/file_system_service.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/baserpc/file_system_service_test.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/benchmark/lmbench.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/cellular/download_perf.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/cellular/modemfwd_fallback_to_rootfs_failed_to_install_dlc.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/cellular/mtu.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/cellular/shill_validate_profile.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/cellular/smoke.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/crash/auth_failure.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/crash/crash/crash.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/crash/cryptohome_recovery_failure.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/crash/ephemeral.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/crash/kernel_ath_error.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/crash/kernel_kfence.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/crash/kernel_log_collector.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/crash/kernel_warning.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/crash/mount_failure.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/crash/mount_vault_failure.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/crash/reporter_crash.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/crash/rust.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/crash/seccomp.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/crash/selinux_violation.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/crash/serializer.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/crash/service_failure.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/crash/suspend_failure.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/crash/udev.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/crash/unclean_shutdown_collector.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/crash/user.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/crosca/video_streaming.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/crostini/app_gedit_filesharing.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/crostini/app_gedit_unshare_folder.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/crostini/cleanupfolder/cleanupFolder.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/crostini/crash_reporter.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/crostini/drag_drop.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/crostini/fs_corruption.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/crostini/launcher.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/crostini/no_access_to_downloads.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/crostini/oom_event.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/crostini/share_downloads_add_files.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/crostini/share_drive.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/crostini/share_folder_zip_file.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/crostini/sshfs_mount.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/cryptohome/file_stability.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/cryptohome/recovery_opt_out.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/cryptohome/sequential_consistency.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/cryptohome/update_password.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/cryptohome/update_recovery.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/debugd/core_scheduler.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/debugd/drm_trace_tool.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/debugd/packet_capture.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/debugd/parse_printer_uris.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/debugd/perf_tool.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/debugd/printer.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/dlp/data_leak_prevention_rules_list_clipboard_ext.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/dlp/files/files.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/documentscanapi/advanced_scan.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/documentscanapi/scan.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/enterpriseconnectors/testrunners/test_download.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/enterpriseconnectors/testrunners/test_file_attached.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/enterpriseconnectors/testrunners/test_file_transfer.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/example/chrome_extension.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/example/data_files.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/example/ui_faillog.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/factory/toolkit/installer.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/featured/feature_library_late_boot.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/feedback/sys_info_pii.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/feedback/user_feedback_service.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/filemanager/drag_drop.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/filemanager/drivefs_search.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/filemanager/freeze_fuse_service.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/filemanager/mtp_copy_from_phone.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/filemanager/mtp_copy_to_phone.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/filemanager/send_to_trash.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/filemanager/smb.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/filemanager/smb_file_operations.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/filemanager/smb_from_settings.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/filemanager/smb_password.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/filemanager/ui_perf.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/firmware/acvp.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/firmware/flashrom.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/firmware/flashrom_perf.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/firmware/fpmcu_unittest.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/firmware/fwupd_plugin_startup.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/firmware/fwupd_powerd_update_check.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/firmware/gsctool.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/graphics/smoke.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/hammerd/triggered_on_boot.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/hardware/disk_errors.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/hardware/iio/buffer.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/hardware/iio/iio.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/health/probe_cpu_info.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/health/probe_memory_info.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/health/utils/utils.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/holdingspace/files_app_context_menu_pin_and_unpin.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/holdingspace/files_app_drag_and_drop.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/hwsec/fixture/fixture.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/hwsec/login.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/hwsec/pkcs11_init_under_errors.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/hwsec/tpm_contest.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/hwsec/util/cross_version_login_data.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/inputs/manual.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/inputs/quick_insert_cuj.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/intel/hdmi_adapter_suspend_resume.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/intel/security_verify_type1_hdcp.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/intel/system_independent_notifications.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/kdump/probe_kernel_limits.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/kernel/bloat.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/kernel/cpu_cgroup.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/kernel/limits.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/kernel/perf_callgraph.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/kernel/stack_entropy.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/labqual/internal_storage.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/launcher/app_list_sort_smoke.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/launcher/create_and_fill_folder.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/launcher/install_arc_app_with_app_list_sorted.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/launcher/remove_apps_from_folder.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/launcher/remove_continue_section_task.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/logs/bootid_logger.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/logs/log_rotate.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/memory/stress.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/meta/artifact_files.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/meta/local_kernel_panic.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/meta/local_vars.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/nacl/pnacl.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/network/cert_settings_page.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/network/certutil/certutil.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/network/default_profile.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/network/dns/dns.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/network/eap/ap.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/network/passpoint/ap.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/network/passpoint_arc_dialog.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/network/shill_init_scripts_login_multi_profile.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/network/shillscript/shillscript.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/network/test_arc_connectivity_app_service.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/network/traffic_counters.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/network/wiredhostapd/server.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/ocr/generate_searchable_pdf_from_image.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/palmrejection/palm_touch.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/personalization/select_rainbow_mode.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/platform/bootperf/bootchart_util.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/platform/bootperf/metrics_util.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/platform/crosdisks/sshfs.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/platform/crosdisks/utils.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/platform/dlc/util.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/platform/partition_sizes.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/platform/perf_etm.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/platform/perfetto_chrome_consumer.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/platform/report_disk_usage.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/platform/spaced.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/platform/tpm_responsive.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/platform/verity/verity.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/policy/block_third_party_cookies.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/policy/device_auto_update_time_restrictions.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/policy/device_dock_mac_address_source.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/policy/disable_screenshots_extension.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/policy/download_restrictions.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/policy/extension_policy.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/policy/file_system_read_write/file_system_read_write.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/policy/not_enterprise_owned.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/policy/policy_service.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/policy/prompt_for_download_location.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/policy/ready_error_log.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/power/adaptive_charging.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/power/browsing.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/power/check_status.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/power/cpufreq_conf.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/power/suspend.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/printer/add_http_printer.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/printer/add_http_printer_printscanmgr.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/printer/expired_cert.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/printer/fake/printer.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/printer/ghostscript/runtest.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/printer/gnutls.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/printer/hardware_print_combinations.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/printer/ippprint/ippprint.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/printer/known_problem_files.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/printer/lpprint/lpprint.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/printer/multi_function_printer.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/printer/parse_printer_uris.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/printer/print_extension.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/printer/print_ippusb.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/printer/print_usb.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/printer/printscanmgr.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/printer/rastertoescpos.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/printer/test_ppds.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/rgbkbd/capslock_color_change_prevented_for_zoned_keyboards.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/rgbkbd/capslock_rgb_state_updates.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/scanapp/hardware_all_combinations.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/scanapp/hardware_randomized_combinations.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/scanapp/scanning/scanning.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/scanner/adf_justification.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/scanner/advanced_scan.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/scanner/scan_escl_ipp.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/sched/core_sched_tag.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/secagentd/secagentdprocfsscraper/procfsscraper.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/security/cpu_vulnerabilities.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/security/exec_stack.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/security/filesetup/filesetup.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/security/firewall.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/security/hard_link_restrictions.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/security/log_perms.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/security/microcode.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/security/minijail.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/security/module_locking.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/security/mount_symlink.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/security/mprotect.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/security/openfds/test.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/security/ptrace_process.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/security/root_ca.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/security/run_oci.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/security/sandboxing/process_utils.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/security/seccomp/policy_generator_test.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/security/selinux/file_label_utils.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/security/selinux/processes_helper.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/security/selinux_audit_basic.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/security/selinux_files_arc.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/security/selinux_files_data_dir.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/security/selinux_validity.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/security/stateful_partition_hardening.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/security/symlink_restrictions.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/security/system_dirs.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/security/usb_bouncer.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/session/ownership_api.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/session/ownership_not_retaken.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/session/ownership_retaken.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/session/remote_ownership.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/shimlessrma/app_service.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/storage/util/common.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/storage/util/disk_info.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/storage/util/power_control.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/storage/util/power_control_test.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/storage/util/trim_util_test.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/telemetryextension/fixture/fixture.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/telemetryextension/hp_compliance.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/telemetryextension/platform_api_memory_info.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/telemetryextension/platform_api_vpd_info.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/typec/charging_through_typec.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/typec/physical_location.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/typec/symlink_to_usb.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/typec/tbt_data_transfer_after_hotplug.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/typec/tbt_display_video_playback_stress.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/typec/tbt_dock_gatkex_usb4.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/typec/tbt_hotplug_unplug.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/typec/thunderbolt_dock_station_functionality.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/typec/typecutils/device_speed.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/typec/usb4_gatkex_card_display_functionality.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/typec/usb4_hotplug_unplug.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/typec/usb_storage_functionality.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/typec/usb_transfer.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/typec/usb_type_a_functionality_check.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/u2fd/webauthn_service.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/ui/chrome_crash_early.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/ui/chrome_crash_logged_in.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/ui/chromecrash/crash.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/ui/cujrunner/runner.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/ui/gallerycuj/utils.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/ui/quickcheckcuj/quick_check_cuj.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/ui/screen_recorder_service.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/ui/webui_js_errors.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/usb/gather_ports_data.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/video/data/tools/decodertest/generate_json_for_decodertest.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/video/data/tools/encodertest/generate_json_for_encodertest.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/video/image_processor_perf.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/video/platform/encoding.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/video/platform_encoding.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/video/platform_libyuv_perftest.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/video/platform_v4l2.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/video/vulkan_overlay_adaptor_perf.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/video/webcodecs/decode.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/vm/audio_alsa_conformance.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/vm/audio_aplay.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/vm/audio_arecord.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/vm/audio_resume_after_cras_restarted.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/vm/fio.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/vm/iperf.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/vm/many_files.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/vm/start_crosvm.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/vm/vhost_user_net.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/vm/virtiofs.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/webrtc/mediarecorder/media_recorder.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/webrtc/mediarecorder/media_recorder_test.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/wifi/caps.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/wifi/caps_80211ac.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/wifi/check_intel_sar_table.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/wifi/check_mtk_mtcl.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/wifi/concurrency_caps.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/wifi/driver.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/wifi/he_caps.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/wifi/iwlwifirescan/rescan.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/wifi/regdb/regdb.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/wifi/sap_caps.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/wifi/shill_service.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/wifi/udev_rename.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/wifi/wpa_validity.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/wilco/powerd_policies.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/wmp/admin_templates_launch.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/wwcb/display_service.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/wwcb/utils/wwcb_api.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/wwcb/utils/wwcb_verify.go
M src/go.chromium.org/tast-tests/cros/local/camera/cca/cca.go
M src/go.chromium.org/tast-tests/cros/local/cellular/cellular_helper.go
M src/go.chromium.org/tast-tests/cros/local/cellular/cellular_helper_utils.go
M src/go.chromium.org/tast-tests/cros/local/chrome/apps/common.go
M src/go.chromium.org/tast-tests/cros/local/chrome/ash/fixture.go
M src/go.chromium.org/tast-tests/cros/local/chrome/ash/launcher.go
M src/go.chromium.org/tast-tests/cros/local/chrome/crossdevice/android_setup.go
M src/go.chromium.org/tast-tests/cros/local/chrome/crossdevice/fixture.go
M src/go.chromium.org/tast-tests/cros/local/chrome/cuj/fixture.go
M src/go.chromium.org/tast-tests/cros/local/chrome/internal/cdputil/session.go
M src/go.chromium.org/tast-tests/cros/local/chrome/internal/cdputil/session_test.go
M src/go.chromium.org/tast-tests/cros/local/chrome/internal/extension/files.go
M src/go.chromium.org/tast-tests/cros/local/chrome/internal/extension/test_extension.go
M src/go.chromium.org/tast-tests/cros/local/chrome/internal/setup/preflight.go
M src/go.chromium.org/tast-tests/cros/local/chrome/internal/setup/restart.go
M src/go.chromium.org/tast-tests/cros/local/chrome/jslog/jslog_test.go
M src/go.chromium.org/tast-tests/cros/local/chrome/localstate/localstate.go
M src/go.chromium.org/tast-tests/cros/local/chrome/metrics/histogram_test.go
M src/go.chromium.org/tast-tests/cros/local/chrome/nearbyshare/nearbyfixture/fixture.go
M src/go.chromium.org/tast-tests/cros/local/chrome/nearbyshare/nearbytestutils/nearbytestutils.go
M src/go.chromium.org/tast-tests/cros/local/chrome/reuse.go
M src/go.chromium.org/tast-tests/cros/local/chrome/uiauto/debug.go
M src/go.chromium.org/tast-tests/cros/local/chrome/uiauto/launcher/launcher.go
M src/go.chromium.org/tast-tests/cros/local/chrome/uiauto/screen_recorder.go
M src/go.chromium.org/tast-tests/cros/local/chrome/uiauto/vkb/handwriting.go
M src/go.chromium.org/tast-tests/cros/local/chrome/uiauto/vkb/handwriting_test.go
M src/go.chromium.org/tast-tests/cros/local/cpu/package.go
M src/go.chromium.org/tast-tests/cros/local/crash/add.go
M src/go.chromium.org/tast-tests/cros/local/crash/crash.go
M src/go.chromium.org/tast-tests/cros/local/crash/crash_test.go
M src/go.chromium.org/tast-tests/cros/local/crash/dmp_test.go
M src/go.chromium.org/tast-tests/cros/local/crash/filter.go
M src/go.chromium.org/tast-tests/cros/local/crash/fixture.go
M src/go.chromium.org/tast-tests/cros/local/crash/fixture_test.go
M src/go.chromium.org/tast-tests/cros/local/crash/sender.go
M src/go.chromium.org/tast-tests/cros/local/crosdisks/loopback.go
M src/go.chromium.org/tast-tests/cros/local/croshealthd/telem.go
M src/go.chromium.org/tast-tests/cros/local/crostini/post.go
M src/go.chromium.org/tast-tests/cros/local/disk/drop_caches.go
M src/go.chromium.org/tast-tests/cros/local/disk/fill.go
M src/go.chromium.org/tast-tests/cros/local/erpserver/erpserver.go
M src/go.chromium.org/tast-tests/cros/local/filesnapshot/snapshot.go
M src/go.chromium.org/tast-tests/cros/local/firmware/fp_updater.go
M src/go.chromium.org/tast-tests/cros/local/firmware/utils.go
M src/go.chromium.org/tast-tests/cros/local/graphics/chameleon.go
M src/go.chromium.org/tast-tests/cros/local/graphics/deqp_parser.go
M src/go.chromium.org/tast-tests/cros/local/graphics/deqprunner/expectations.go
M src/go.chromium.org/tast-tests/cros/local/graphics/dri.go
M src/go.chromium.org/tast-tests/cros/local/graphics/fps.go
M src/go.chromium.org/tast-tests/cros/local/graphics/glbench/glbench.go
M src/go.chromium.org/tast-tests/cros/local/graphics/perf.go
M src/go.chromium.org/tast-tests/cros/local/graphics/syslog_checker.go
M src/go.chromium.org/tast-tests/cros/local/graphics/syslog_checker_test.go
M src/go.chromium.org/tast-tests/cros/local/graphics/trace/trace_replay.go
M src/go.chromium.org/tast-tests/cros/local/graphics/utils.go
M src/go.chromium.org/tast-tests/cros/local/graphics/utils_test.go
M src/go.chromium.org/tast-tests/cros/local/gtest/gtest.go
M src/go.chromium.org/tast-tests/cros/local/gtest/gtest_test.go
M src/go.chromium.org/tast-tests/cros/local/gtest/report.go
M src/go.chromium.org/tast-tests/cros/local/gtest/report_test.go
M src/go.chromium.org/tast-tests/cros/local/guestos/apps/vscode.go
M src/go.chromium.org/tast-tests/cros/local/hermes/hermes.go
M src/go.chromium.org/tast-tests/cros/local/hostapd/hostapd.go
M src/go.chromium.org/tast-tests/cros/local/https/https.go
M src/go.chromium.org/tast-tests/cros/local/hwsec/attestation_local_va.go
M src/go.chromium.org/tast-tests/cros/local/hwsec/dictionary_attack.go
M src/go.chromium.org/tast-tests/cros/local/hwsec/pca_agent_client.go
M src/go.chromium.org/tast-tests/cros/local/input/device.go
M src/go.chromium.org/tast-tests/cros/local/input/virtual.go
M src/go.chromium.org/tast-tests/cros/local/media/arc/video/accel_video.go
M src/go.chromium.org/tast-tests/cros/local/media/arc/video/arc_accel_video.go
M src/go.chromium.org/tast-tests/cros/local/media/arc/video/perf.go
M src/go.chromium.org/tast-tests/cros/local/media/arc/video/perf_test.go
M src/go.chromium.org/tast-tests/cros/local/media/binsetup/binsetup.go
M src/go.chromium.org/tast-tests/cros/local/media/cpu/cpu.go
M src/go.chromium.org/tast-tests/cros/local/media/encoding/quality.go
M src/go.chromium.org/tast-tests/cros/local/media/encoding/temp_file.go
M src/go.chromium.org/tast-tests/cros/local/media/logging/log_helper.go
M src/go.chromium.org/tast-tests/cros/local/media/vm/vm.go
M src/go.chromium.org/tast-tests/cros/local/memory/arc/dumpsys_meminfo.go
M src/go.chromium.org/tast-tests/cros/local/memory/arc/vmstat.go
M src/go.chromium.org/tast-tests/cros/local/memory/crosvm_fincore.go
M src/go.chromium.org/tast-tests/cros/local/memory/kernelmeter/kernelmeter.go
M src/go.chromium.org/tast-tests/cros/local/memory/kernelmeter/kernelstats.go
M src/go.chromium.org/tast-tests/cros/local/memory/memoryuser/vm_task.go
M src/go.chromium.org/tast-tests/cros/local/memory/psi_stats.go
M src/go.chromium.org/tast-tests/cros/local/memory/smaps_rollup.go
M src/go.chromium.org/tast-tests/cros/local/memory/zone_info.go
M src/go.chromium.org/tast-tests/cros/local/memory/zram_mm_stat.go
M src/go.chromium.org/tast-tests/cros/local/memory/zram_stats.go
M src/go.chromium.org/tast-tests/cros/local/minidump/minidump.go
M src/go.chromium.org/tast-tests/cros/local/mlbenchmark/common_helper.go
M src/go.chromium.org/tast-tests/cros/local/modemfwd/modemfwd.go
M src/go.chromium.org/tast-tests/cros/local/nebraska/nebraska.go
M src/go.chromium.org/tast-tests/cros/local/nebraska/options.go
M src/go.chromium.org/tast-tests/cros/local/netexport/net_export.go
M src/go.chromium.org/tast-tests/cros/local/network/dhcp/packet_test.go
M src/go.chromium.org/tast-tests/cros/local/network/virtualnet/radvd/radvd.go
M src/go.chromium.org/tast-tests/cros/local/network/vpn/server.go
M src/go.chromium.org/tast-tests/cros/local/network/vpn/server_runner.go
M src/go.chromium.org/tast-tests/cros/local/network/vpn/util.go
M src/go.chromium.org/tast-tests/cros/local/perf/thermal.go
M src/go.chromium.org/tast-tests/cros/local/playbilling/fixture.go
M src/go.chromium.org/tast-tests/cros/local/policyutil/externaldata/server_test.go
M src/go.chromium.org/tast-tests/cros/local/policyutil/fixtures/fakedms.go
M src/go.chromium.org/tast-tests/cros/local/power/metrics/cpu_freq.go
M src/go.chromium.org/tast-tests/cros/local/power/metrics/cpuidle_metrics.go
M src/go.chromium.org/tast-tests/cros/local/power/metrics/sysfs_battery_metrics.go
M src/go.chromium.org/tast-tests/cros/local/power/metrics/thermal_metrics.go
M src/go.chromium.org/tast-tests/cros/local/power/setup/setup_screen_backlight.go
M src/go.chromium.org/tast-tests/cros/local/power/suspend/suspend.go
M src/go.chromium.org/tast-tests/cros/local/power/thermal_state.go
M src/go.chromium.org/tast-tests/cros/local/printing/document/compare.go
M src/go.chromium.org/tast-tests/cros/local/printing/ippusbbridge/scanner.go
M src/go.chromium.org/tast-tests/cros/local/printing/ippusbbridge/util.go
M src/go.chromium.org/tast-tests/cros/local/printing/lp/cups.go
M src/go.chromium.org/tast-tests/cros/local/printing/usbprinter/setup.go
M src/go.chromium.org/tast-tests/cros/local/profiler/perf.go
M src/go.chromium.org/tast-tests/cros/local/profiler/perf_test.go
M src/go.chromium.org/tast-tests/cros/local/resourced/utils/utils.go
M src/go.chromium.org/tast-tests/cros/local/rgbkbd/util.go
M src/go.chromium.org/tast-tests/cros/local/screenshot/capture.go
M src/go.chromium.org/tast-tests/cros/local/screenshot/differ.go
M src/go.chromium.org/tast-tests/cros/local/session/ownership.go
M src/go.chromium.org/tast-tests/cros/local/smb/fixture.go
M src/go.chromium.org/tast-tests/cros/local/smb/server.go
M src/go.chromium.org/tast-tests/cros/local/syslog/read_logs_since_boot.go
M src/go.chromium.org/tast-tests/cros/local/syslog/reader_test.go
M src/go.chromium.org/tast-tests/cros/local/sysutil/hwmon.go
M src/go.chromium.org/tast-tests/cros/local/sysutil/mountinfo.go
M src/go.chromium.org/tast-tests/cros/local/testenv/proxy/mitmproxy.go
M src/go.chromium.org/tast-tests/cros/local/tracing/utils.go
M src/go.chromium.org/tast-tests/cros/local/typecutils/display_helper.go
M src/go.chromium.org/tast-tests/cros/local/typecutils/utils.go
M src/go.chromium.org/tast-tests/cros/local/uhid/device_nodes.go
M src/go.chromium.org/tast-tests/cros/local/ui/cujrecorder/recorder.go
M src/go.chromium.org/tast-tests/cros/local/uidetection/util.go
M src/go.chromium.org/tast-tests/cros/local/usbutil/usb.go
M src/go.chromium.org/tast-tests/cros/local/vdi/fixtures/fixturehelper.go
M src/go.chromium.org/tast-tests/cros/local/vm/concierge.go
M src/go.chromium.org/tast-tests/cros/local/vm/vm.go
M src/go.chromium.org/tast-tests/cros/local/wifi/debug.go
M src/go.chromium.org/tast-tests/cros/local/wifi/intelfwextractor/intel_fw_extractor.go
M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/arc/cache_validation.go
M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/camera/pre/its_pre.go
M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/cellular/dynamic_sar.go
M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/crash/early_crash.go
M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/crash/ec_crash.go
M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/crash/ec_safe_mode.go
M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/crash/kernel_crash.go
M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/feedback/user_feedback_service_grpc.go
M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/hwsec/cryptohome_tpm_live_tests.go
M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/kernel/pstore_console_ramoops.go
M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/meta/remote_artifact_files.go
M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/meta/remote_vars.go
M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/meta/run_tests.go
M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/meta/run_tests_remote_fixture.go
M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/meta/tastrun/run.go
M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/network/allowlist/utils.go
M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/network/ethernet_speed.go
M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/osperf/tab_open_latency_perf.go
M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/platform/boot_perf.go
M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/platform/cros_hardware_verifier.go
M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/platform/perfetto/traces.go
M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/storage/stress.go
M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/syzcorpus/repros.go
M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/syzcorpus/syzutils/utils.go
M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/syzkaller/wrapper.go
M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/typec/hdmi_display_functionality_after_lid_close_open.go
M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/typec/suspend_resume_display_functionality_after_wake.go
M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/typec/suspend_resume_usb4_plug_unplug.go
M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/typec/suspend_resume_with_tbt_alt_mode.go
M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/typec/tbt_passive_active_cable.go
M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/wwcb/utils/ippower_util.go
M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/wwcb/utils/validate_image_util.go
M src/go.chromium.org/tast-tests/cros/remote/cros/nearbyshare/fixture.go
M src/go.chromium.org/tast-tests/cros/remote/dutfs/dutfs.go
M src/go.chromium.org/tast-tests/cros/remote/firmware/bios/image.go
M src/go.chromium.org/tast-tests/cros/remote/firmware/boot_mode.go
M src/go.chromium.org/tast-tests/cros/remote/firmware/config.go
M src/go.chromium.org/tast-tests/cros/remote/firmware/fingerprint/fingerprint.go
M src/go.chromium.org/tast-tests/cros/remote/firmware/helper.go
M src/go.chromium.org/tast-tests/cros/remote/firmware/ti50/dutcontrol_andreiboard.go
M src/go.chromium.org/tast-tests/cros/remote/firmware/ti50/fixture/devboard.go
M src/go.chromium.org/tast-tests/cros/remote/osperf/osperf.go
M src/go.chromium.org/tast-tests/cros/remote/updateutil/paygen.go
M src/go.chromium.org/tast-tests/cros/remote/updateutil/updateutil.go
M src/go.chromium.org/tast-tests/cros/remote/wificell/framesender/sender.go

Hash: 77fe32a6620ed39d699d9be220232dd321385693
Date: Fri Dec 13 17:39:56 2024

ap...@google.com <ap...@google.com> #93Jan 10, 2025 11:28AM

Project: chromiumos/platform/dev-util
Branch: main
Author: Arnaud Ferraris <arnaud.ferraris@collabora.corp-partner.google.com>
Link: https://chromium-review.googlesource.com/6088129

test: replace deprecated protobuf-related modules

Expand for full commit details

test: replace deprecated protobuf-related modules 
 
`github.com/golang/protobuf` and its sub-modules has been deprecated 
and superseded by `google.golang.org/protobuf`[1]. Drop all use of the 
old modules and switch to using only the latter. 
 
[1] https://pkg.go.dev/github.com/golang/protobuf 
 
BUG=b:218608945 
TEST=staticcheck -checks SA1019 "go.chromium.org/chromiumos/test/..." 
 
Change-Id: I649b0c140c71b20f8793f8dd09ab536482c043cb 
Signed-off-by: Arnaud Ferraris <arnaud.ferraris@collabora.corp-partner.google.com> 
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/dev-util/+/6088129 
Reviewed-by: Seewai Fu <seewaifu@google.com> 
Reviewed-by: George Burgess <gbiv@chromium.org>

Files:

M src/go.chromium.org/chromiumos/test/check/cmd/cros_test_ready/main.go
M src/go.chromium.org/chromiumos/test/dut/cmd/cros-dut/cli/dutserver.go
M src/go.chromium.org/chromiumos/test/lab/local/cmd/inventoryserver/inventoryserver.go
M src/go.chromium.org/chromiumos/test/lab/local/cmd/inventoryserver/inventoryserver_test.go
M src/go.chromium.org/chromiumos/test/local-cft/internal/services/cros-provision-service.go
M src/go.chromium.org/chromiumos/test/local-cft/internal/services/cros-tool-runner-service.go
M src/go.chromium.org/chromiumos/test/post_process/cmd/post-process/main.go
M src/go.chromium.org/chromiumos/test/pre_process/cmd/pre-process/main.go
M src/go.chromium.org/chromiumos/test/pre_process/cmd/pre-process/main_test.go
M src/go.chromium.org/chromiumos/test/provision/cmd/cros-provision/main.go
M src/go.chromium.org/chromiumos/test/provision/cmd/provisionserver/provisionserver_cli.go
M src/go.chromium.org/chromiumos/test/provision/v2/android-provision/cli/cli_command.go
M src/go.chromium.org/chromiumos/test/provision/v2/ash-provision/cli/cli_command.go
M src/go.chromium.org/chromiumos/test/provision/v2/cros-provision/cli/cli_command.go
M src/go.chromium.org/chromiumos/test/publish/cmd/publishserver/publishserver_cli.go
M src/go.chromium.org/chromiumos/test/test_finder/main_test.go
M src/go.chromium.org/chromiumos/test/test_finder/test_finder.go
M src/go.chromium.org/chromiumos/test/util/metadata/read.go
M src/go.chromium.org/chromiumos/test/util/metadata/read_test.go

Hash: c70bb3ce9c9527873aa8a24ca95dbade44d53e36
Date: Fri Dec 13 17:03:18 2024

ap...@google.com <ap...@google.com> #94Jan 13, 2025 09:58AM

Project: chromiumos/platform/tast-tests
Branch: main
Author: Arnaud Ferraris <arnaud.ferraris@collabora.corp-partner.google.com>
Link: https://chromium-review.googlesource.com/6097131

tast-tests: fix improper uses of math/rand

Expand for full commit details

tast-tests: fix improper uses of math/rand 
 
Changes in the `math/rand` modules have led to deprecation of the 
`Seed()` and `Read()` functions. The former is now unneeded as the 
module is seeded randomly on startup (since Go 1.20); the latter should 
be replaced with the equivalent function from the `crypto/rand` module. 
 
There are still some cases where `rand.Seed()` can be used though, when 
e.g. it is called with a fixed value in order to generate a 
deterministic sequence of results. In those cases, it is better to 
create a new `rand.Source` and use it instead of the global generator. 
 
See https://pkg.go.dev/math/rand for details. 
 
BUG=b:218608945 
TEST=staticcheck -checks SA1019 "go.chromium.org/tast-tests/..." 
 
Change-Id: Ic1253cc613ee816ae5fae63076925c96f527e38c 
Signed-off-by: Arnaud Ferraris <arnaud.ferraris@collabora.corp-partner.google.com> 
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/tast-tests/+/6097131 
Tast-Review: Seewai Fu <seewaifu@google.com> 
Reviewed-by: Seewai Fu <seewaifu@google.com> 
Reviewed-by: George Burgess <gbiv@chromium.org>

Files:

M src/go.chromium.org/tast-tests/cros/common/cros/nearbyshare/nearbyutils.go
M src/go.chromium.org/tast-tests/cros/common/storage/files/file_info.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/apps/system_web_apps_reinstall.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/network/traffic_counters.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/scanapp/scanning/scanning.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/storage/util/trim_util.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/taskmanager/default_ui_and_functionality.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/taskmanager/end_process.go
M src/go.chromium.org/tast-tests/cros/local/chrome/cuj/get_drive_url.go
M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/security/boot_lockbox.go
M src/go.chromium.org/tast-tests/cros/remote/wificell/hostapd/config.go
M src/go.chromium.org/tast-tests/cros/remote/wificell/test_fixture.go

Hash: f12a838ae6bafa352ff20bfdd99d60942d1284ba
Date: Fri Dec 13 17:30:45 2024

ap...@google.com <ap...@google.com> #95Jan 13, 2025 03:52PM

Project: chromiumos/platform/tast-tests
Branch: main
Author: Arnaud Ferraris <arnaud.ferraris@collabora.corp-partner.google.com>
Link: https://chromium-review.googlesource.com/6097135

tast-tests: fix misc deprecation issues

Expand for full commit details

tast-tests: fix misc deprecation issues 
 
This change fixes the remaining, one-off deprecation issues as reported 
by `staticcheck`: 
* replace deprecated `strings.Title()`[1] with `cases.Title().String()` 
* use literal `image.Point` instead of deprecated variable image.ZP[2] 
* drop tests on the always-true `CloseTargetReply.Success`[3] 
* replace deprecated `GBBFlag_FORCE_DEV_BOOT_FASTBOOT_FULL_CAP` in unit 
  test function 
* drop support for deprecated "Android Kiosk App" account type[4] 
 
[1] https://pkg.go.dev/strings#Title 
[2] https://pkg.go.dev/image#Point 
[3] https://github.com/mafredri/cdp/blob/main/protocol/target/command.go#L69 
[4] https://chromium.googlesource.com/chromium/src/components/policy/proto/+/refs/heads/main/chrome_device_policy.proto#569 
 
BUG=b:218608945 
TEST=staticcheck -checks SA1019 "go.chromium.org/tast-tests/..." 
 
Change-Id: Iae6a312a18680e813b42326cb3533f1284ba58ef 
Signed-off-by: Arnaud Ferraris <arnaud.ferraris@collabora.corp-partner.google.com> 
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/tast-tests/+/6097135 
Reviewed-by: Seewai Fu <seewaifu@google.com> 
Tast-Review: Seewai Fu <seewaifu@google.com> 
Reviewed-by: George Burgess <gbiv@chromium.org>

Files:

M src/go.chromium.org/tast-tests/cros/common/firmware/gbb_flags_test.go
M src/go.chromium.org/tast-tests/cros/common/policy/defs.go
M src/go.chromium.org/tast-tests/cros/common/policy/defs_helper.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/inputs/quick_insert_power.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/wifi/shill_service.go
M src/go.chromium.org/tast-tests/cros/local/chrome/internal/cdputil/conn.go
M src/go.chromium.org/tast-tests/cros/local/chrome/internal/cdputil/session.go
M src/go.chromium.org/tast-tests/cros/local/crostini/params.go
M src/go.chromium.org/tast-tests/cros/local/screenshot/differ.go

Hash: f05bf78e79ce3eee017a6237d1dd70b1708ca739
Date: Mon Dec 16 16:20:48 2024

ap...@google.com <ap...@google.com> #96Jan 13, 2025 05:23PM

Project: chromiumos/platform/tast-tests
Branch: main
Author: Arnaud Ferraris <arnaud.ferraris@collabora.corp-partner.google.com>
Link: https://chromium-review.googlesource.com/6148653

tast-tests: fix linter errors

Expand for full commit details

tast-tests: fix linter errors 
 
As part of b:218608945 `golint` will be replaced with `staticcheck` as 
the default Go linter for ChromeOS. As a preliminary step we need to 
ensure `staticcheck` passes with current Go packages. 
 
This fixes such errors[1] for local Tast tests. 
 
[1] Please refer to https://staticcheck.dev/docs/checks/ for details 
about each check. 
 
BUG=b:218608945 
TEST=staticcheck -checks "inherit,-SA1019" \ 
    "go.chromium.org/tast-tests/..." 
 
Change-Id: I76e1fc81e17847582dcc138e0243b8dbf938c206 
Signed-off-by: Arnaud Ferraris <arnaud.ferraris@collabora.corp-partner.google.com> 
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/tast-tests/+/6148653 
Commit-Queue: George Burgess <gbiv@chromium.org> 
Reviewed-by: George Burgess <gbiv@chromium.org> 
Tast-Review: Seewai Fu <seewaifu@google.com> 
Commit-Queue: Seewai Fu <seewaifu@google.com> 
Reviewed-by: Seewai Fu <seewaifu@google.com>

Files:

M src/go.chromium.org/tast-tests/cros/local/bluetooth/facade/floss/facade.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/bluetooth/bluetooth_service.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/mantis/fixture/fixture.go
M src/go.chromium.org/tast-tests/cros/local/chrome/apps/thirdparty/element/element.go

Hash: 7aea8c147e9194b5a6f8f1c22d4e57e65a1b8c7c
Date: Tue Jan 07 12:55:15 2025

ap...@google.com <ap...@google.com> #97Jan 17, 2025 08:46AM

[Details redacted due to bug visibility]

Change-Id: Ia4e84789d608c358a7fe4b9a92df5990dc60a94a

https://chrome-internal-review.googlesource.com/7959746

ap...@google.com <ap...@google.com> #98Jan 17, 2025 10:50AM

Project: chromiumos/platform/dev-util
Branch: main
Author: Arnaud Ferraris <arnaud.ferraris@collabora.corp-partner.google.com>
Link: https://chromium-review.googlesource.com/6088130

test: execution: replace deprecated protobuf-related modules

Expand for full commit details

test: execution: replace deprecated protobuf-related modules 
 
`github.com/golang/protobuf` and its sub-modules has been deprecated 
and superseded by `google.golang.org/protobuf`[1]. Drop all use of the 
old modules and switch to using only the latter. 
 
[1] https://pkg.go.dev/github.com/golang/protobuf 
 
BUG=b:218608945 
TEST=staticcheck -checks SA1019 \ 
    "go.chromium.org/chromiumos/test/execution/..." 
 
Change-Id: I6a757f47224e4382a916873c189c854686b016bb 
Signed-off-by: Arnaud Ferraris <arnaud.ferraris@collabora.corp-partner.google.com> 
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/dev-util/+/6088130 
Reviewed-by: George Burgess <gbiv@chromium.org> 
Reviewed-by: Allen Xie <zhihuixie@google.com>

Files:

M src/go.chromium.org/chromiumos/test/execution/cmd/cros-test/cli/testexecserver.go
M src/go.chromium.org/chromiumos/test/execution/cmd/cros-test/cli/testexecserver_test.go
M src/go.chromium.org/chromiumos/test/execution/cmd/cros-test/internal/common/helpers.go
M src/go.chromium.org/chromiumos/test/execution/cmd/cros-test/internal/common/helpers_test.go
M src/go.chromium.org/chromiumos/test/execution/cmd/cros-test/internal/common/tko_results_test.go
M src/go.chromium.org/chromiumos/test/execution/cmd/cros-test/internal/tastrpc/reports.go
M src/go.chromium.org/chromiumos/test/execution/cmd/cros-test/internal/tastrpc/reports_test.go
M src/go.chromium.org/chromiumos/test/execution/cmd/cros-test/internal/tautoresults/tautoresults.go
M src/go.chromium.org/chromiumos/test/execution/cmd/cros-test/internal/tautoresults/tautoresults_test.go

Hash: 049467601499dfc6ddb079521900c3980dcf9cca
Date: Fri Dec 13 17:08:43 2024

ap...@google.com <ap...@google.com> #99Jan 22, 2025 02:04AM

Project: chromiumos/platform/tast-tests
Branch: main
Author: Arnaud Ferraris <arnaud.ferraris@collabora.corp-partner.google.com>
Link: https://chromium-review.googlesource.com/6179960

tast-tests: factor in dictation-related constants

Expand for full commit details

tast-tests: factor in dictation-related constants 
 
Dictation-related constants were defined under the corresponding local 
bundle then symlinked to the corresponding remote bundle. This is 
improper as it conflicts with the internal tooling (e.g. the linter 
reports "unused item" errors both when checking local and remote tests). 
 
Factor those constants/variables under the "common" tree, which is a 
more appropriate location for such code. 
 
BUG=b:218608945 
TEST=staticcheck -checks SA1019 "go.chromium.org/tast-tests/..." 
 
Change-Id: Ic860527c5208e35df6cef83fcd49f244b73bea31 
Signed-off-by: Arnaud Ferraris <arnaud.ferraris@collabora.corp-partner.google.com> 
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/tast-tests/+/6179960 
Reviewed-by: Seewai Fu <seewaifu@google.com> 
Tast-Review: Seewai Fu <seewaifu@google.com> 
Commit-Queue: ChromeOS Auto Retry <chromeos-auto-retry@chromeos-bot.iam.gserviceaccount.com> 
Reviewed-by: Michael Checo <michaelcheco@google.com>

Files:

A src/go.chromium.org/tast-tests/cros/common/dictation/OWNERS
M src/go.chromium.org/tast-tests/cros/common/dictation/constants.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/peripherals/dictation/dictation_support.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/peripherals/periph_service.go
M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/peripherals/dictation.go
D src/go.chromium.org/tast-tests/cros/remote/bundles/cros/peripherals/dictation/constants.go
M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/peripherals/dictation/test_params.go

Hash: b1c784e0e4de981cf53facde29bd20ecd7e9dbdd
Date: Thu Jan 16 15:50:51 2025

ap...@google.com <ap...@google.com> #100Jan 22, 2025 05:19PM

Project: chromiumos/platform/tast-tests
Branch: main
Author: Arnaud Ferraris <arnaud.ferraris@collabora.corp-partner.google.com>
Link: https://chromium-review.googlesource.com/6179959

tast-tests: fix remaining linter errors

Expand for full commit details

tast-tests: fix remaining linter errors 
 
As part of b:218608945 `golint` will be replaced with `staticcheck` as 
the default Go linter for ChromeOS. As a preliminary step we need to 
ensure `staticcheck` passes with current Go packages. 
 
This fixes such errors[1] for local Tast tests. 
 
[1] Please refer to https://staticcheck.dev/docs/checks/ for details 
about each check. 
 
BUG=b:218608945 
TEST=staticcheck -checks "inherit,-SA1019" \ 
    "go.chromium.org/tast-tests/..." 
 
Change-Id: Ia16ae1c5eb18175196e0f9b40146921777d013c7 
Signed-off-by: Arnaud Ferraris <arnaud.ferraris@collabora.corp-partner.google.com> 
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/tast-tests/+/6179959 
Tast-Review: Seewai Fu <seewaifu@google.com> 
Reviewed-by: George Burgess <gbiv@chromium.org> 
Reviewed-by: Seewai Fu <seewaifu@google.com>

Files:

M src/go.chromium.org/tast-tests/cros/local/bundles/cros/usb/fixture/fixture.go
M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/wwcb/utils/api/camera_helper.go
D src/go.chromium.org/tast-tests/cros/remote/bundles/cros/wwcb/utils/topology/allion_connection_manager.go
M src/go.chromium.org/tast-tests/cros/remote/bundles/cros/wwcb/utils/topology/fixture.go

Hash: 9a8163afd86b6283dffe5f1b1ac6ab0cb27dd2bf
Date: Thu Jan 16 15:55:10 2025

ap...@google.com <ap...@google.com> #101Jan 23, 2025 03:16PM

Project: chromiumos/platform/tast-tests
Branch: main
Author: Arnaud Ferraris <arnaud.ferraris@collabora.corp-partner.google.com>
Link: https://chromium-review.googlesource.com/6097134

tast-tests: replace deprecated audio.LoadAloop() with fixture

Expand for full commit details

tast-tests: replace deprecated audio.LoadAloop() with fixture 
 
As mentioned in `cros/local/audio/aloop.go`, `LoadAloop()` is deprecated 
and `fixture.AloopLoaded` should be used instead. 
 
BUG=b:218608945 
TEST=staticcheck -checks SA1019 "go.chromium.org/tast-tests/..." 
 
Change-Id: Id8449b5f9015456b44ffa141bd084f51e9d2ffc0 
Signed-off-by: Arnaud Ferraris <arnaud.ferraris@collabora.corp-partner.google.com> 
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/tast-tests/+/6097134 
Reviewed-by: Li-Yu Yu <aaronyu@google.com> 
Tast-Review: Li-Yu Yu <aaronyu@google.com> 
Reviewed-by: Seewai Fu <seewaifu@google.com>

Files:

M src/go.chromium.org/tast-tests/cros/local/bundles/cros/arc/audio/loopback.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/arc/audio_loopback_correctness.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/arc/audio_loopback_correctness_test.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/arc/audio_oboetester_glitch.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/arc/audio_oboetester_latency.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/audio/checking_audio_formats.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/audio/playback_audio_controls.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/audio/ui_input.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/crostini/app_vlc.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/crostini/params_test.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/kiosk/device_set_volume.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/projector/creation_flow.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/projector/local_playback.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/projector/new_screencast_button_condition.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/projector/saved_file_to_default_folder.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/vm/audio_loopback_latency.go
M src/go.chromium.org/tast-tests/cros/local/chrome/projector/projector.go
M src/go.chromium.org/tast-tests/cros/local/crostini/params.go
M src/go.chromium.org/tast-tests/cros/local/input/voice/audio.go
M src/go.chromium.org/tast-tests/cros/local/inputs/testserver/test_server.go

Hash: 3c852750c56d446d2063067f9b206352c65b8195
Date: Mon Dec 16 16:01:25 2024

ap...@google.com <ap...@google.com> #102Jan 28, 2025 10:28AM

Project: chromiumos/platform/dev-util
Branch: main
Author: Arnaud Ferraris <arnaud.ferraris@collabora.corp-partner.google.com>
Link: https://chromium-review.googlesource.com/6088131

test: replace deprecated "ioutil" module

Expand for full commit details

test: replace deprecated "ioutil" module 
 
The `io/ioutil` module has been deprecated since Go 1.16[1], with 
equivalent functions/variables being implemented in the `io` and `os` 
modules. 
 
Ensure we stop using `ioutil` functions by replacing those calls with 
their `io`/`os` counterparts. 
 
[1] https://pkg.go.dev/io/ioutil 
 
BUG=b:218608945 
TEST=staticcheck -checks SA1019 "go.chromium.org/chromium/test/..." 
 
Change-Id: I9d6c7afa7013f5f9546805991f1ee7784a272f0c 
Signed-off-by: Arnaud Ferraris <arnaud.ferraris@collabora.corp-partner.google.com> 
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/dev-util/+/6088131 
Reviewed-by: George Burgess <gbiv@chromium.org> 
Reviewed-by: Allen Xie <zhihuixie@google.com>

Files:

M src/go.chromium.org/chromiumos/test/dut/cmd/cros-dut/dutssh/ssh_keys.go
M src/go.chromium.org/chromiumos/test/execution/cmd/cros-test/cli/testexecserver_test.go
M src/go.chromium.org/chromiumos/test/execution/cmd/cros-test/internal/driver/tast_driver.go
M src/go.chromium.org/chromiumos/test/execution/cmd/cros-test/internal/driver/tast_driver_test.go
M src/go.chromium.org/chromiumos/test/execution/cmd/cros-test/internal/tautoresults/tautoresults.go
M src/go.chromium.org/chromiumos/test/execution/cmd/cros-test/internal/tautoresults/tautoresults_test.go
M src/go.chromium.org/chromiumos/test/lab/local/cmd/inventoryserver/inventoryserver.go
M src/go.chromium.org/chromiumos/test/lab/local/cmd/inventoryserver/inventoryserver_test.go
M src/go.chromium.org/chromiumos/test/local-cft/internal/services/cros-provision-service.go
M src/go.chromium.org/chromiumos/test/local-cft/internal/services/helper.go
M src/go.chromium.org/chromiumos/test/pre_process/cmd/pre-process/main_test.go
M src/go.chromium.org/chromiumos/test/provision/v2/vm-provision/vm_leaser_rpc.go
M src/go.chromium.org/chromiumos/test/publish/cmd/publishserver/tests/publishserver_test.go
M src/go.chromium.org/chromiumos/test/test_finder/main_test.go
M src/go.chromium.org/chromiumos/test/util/common/common.go
M src/go.chromium.org/chromiumos/test/util/metadata/read.go
M src/go.chromium.org/chromiumos/test/util/metadata/read_test.go

Hash: 53192364919227d79c78a26f3bbf94a77641be9c
Date: Fri Dec 13 17:12:32 2024

ap...@google.com <ap...@google.com> #103Jan 28, 2025 02:34PM

Project: chromiumos/platform/tast-tests
Branch: main
Author: Arnaud Ferraris <arnaud.ferraris@collabora.corp-partner.google.com>
Link: https://chromium-review.googlesource.com/6097136

tast-tests: replace "crastestclient" with new "crastests" where possible

Expand for full commit details

tast-tests: replace "crastestclient" with new "crastests" where possible 
 
The `cras_test_client` utility has been deprecated[1]. As a consequence, 
create a new `crastests` module that relies on the recommended 
`cras_tests` and use it in replacement of `crastestclient` wherever it's 
possible. 
 
`crastestclient` remains used for features not implemented in 
`cras_tests` yet. 
 
[1] https://chromium.googlesource.com/chromiumos/third_party/adhd/+/refs/heads/main/cras/deprecated/cras_test_client/README.md 
 
BUG=b:218608945 
TEST=staticcheck -checks SA1019 "go.chromium.org/tast-tests/..." 
 
Change-Id: I13a1ec529f8cfb5e3eb26a595862b3f680fea3da 
Signed-off-by: Arnaud Ferraris <arnaud.ferraris@collabora.corp-partner.google.com> 
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/tast-tests/+/6097136 
Reviewed-by: Seewai Fu <seewaifu@google.com> 
Reviewed-by: Li-Yu Yu <aaronyu@google.com> 
Tast-Review: Seewai Fu <seewaifu@google.com>

Files:

M src/go.chromium.org/tast-tests/cros/local/a11y/a11y.go
M src/go.chromium.org/tast-tests/cros/local/a11y/dictation/dictation.go
M src/go.chromium.org/tast-tests/cros/local/ambient/ambient.go
A src/go.chromium.org/tast-tests/cros/local/audio/crastests/cras_tests.go
A src/go.chromium.org/tast-tests/cros/local/audio/crastests/doc.go
A src/go.chromium.org/tast-tests/cros/local/audio/crastests/mute.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/a11y/chromevox_hint.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/a11y/chromevox_toggle_on_shortcut.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/a11y/google_tts_smoke.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/a11y/tts_extension_settings.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/arc/a11y/a11y.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/arc/audio_oboetester_glitch.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/audio/cras_loopback_capture_timestamp.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/audio/cras_noise_cancellation_power.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/audio/cras_perf.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/audio/cras_playback_power.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/audio/cras_record_with_hotword.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/audio/cras_recording_correctness.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/audio/cras_suspend_stress.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/audio/echo_ref_device.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/audio/floop_device_switch.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/audio/floop_record_stress.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/audio/local_audio_playback.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/audio/ui_input.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/audio/withchameleon/cros_port.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/crostini/app_vlc.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/intel/play_h264_av1_on_external_display.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/kiosk/tts_extension_settings.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/policy/enable_a11y_image_labels.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/typec/thunderbolt_dock_station_functionality.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/video/play/play.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/video/playback_perf.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/webrtc/getdisplaymedia/get_display_media.go
M src/go.chromium.org/tast-tests/cros/local/camera/cca/fixture.go
M src/go.chromium.org/tast-tests/cros/local/camera/cca/util.go
M src/go.chromium.org/tast-tests/cros/local/chrome/cuj/fixture.go
M src/go.chromium.org/tast-tests/cros/local/input/voice/audio.go
M src/go.chromium.org/tast-tests/cros/local/media/pre/chrome_video_stress.go
M src/go.chromium.org/tast-tests/cros/local/ui/videocuj/video_cuj.go
M src/go.chromium.org/tast-tests/cros/local/ui/windowarrangementcuj/run.go

Hash: 0ba44acaac6c2fbab422117a27c154f6c9e2bc95
Date: Mon Dec 16 16:21:24 2024

ap...@google.com <ap...@google.com> #104Feb 3, 2025 11:02AM

Project: chromiumos/platform/dev-util
Branch: main
Author: Arnaud Ferraris <arnaud.ferraris@collabora.corp-partner.google.com>
Link: https://chromium-review.googlesource.com/6110506

test: execution: fix linter errors

Expand for full commit details

test: execution: fix linter errors 
 
As part of b:218608945 `golint` will be replaced with `staticcheck` as 
the default Go linter for ChromeOS. As a preliminary step we need to 
ensure `staticcheck` passes with current Go packages. 
 
This fixes the following errors[1] for test/execution (`cros-test`): 
* U1000 (unused type/const/struct field) 
 
[1] Please refer to https://staticcheck.dev/docs/checks/ for details 
about each check. 
 
BUG=b:218608945 
TEST=staticcheck -checks "inherit,-SA1019" \ 
    "go.chromium.org/chromiumos/test/execution/..." 
 
Change-Id: Ic29cf6695acf24c1637f86fea8d6f2fee34efb37 
Signed-off-by: Arnaud Ferraris <arnaud.ferraris@collabora.corp-partner.google.com> 
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/dev-util/+/6110506 
Reviewed-by: Allen Xie <zhihuixie@google.com> 
Reviewed-by: George Burgess <gbiv@chromium.org>

Files:

M src/go.chromium.org/chromiumos/test/execution/cmd/cros-test/internal/driver/mobly_driver.go

Hash: 145d1279a50e4f593a129bbc0c58226504ab63df
Date: Fri Dec 20 15:56:49 2024

ap...@google.com <ap...@google.com> #105Feb 5, 2025 07:10PM

Project: chromiumos/platform/tast-tests
Branch: main
Author: Arnaud Ferraris <arnaud.ferraris@collabora.corp-partner.google.com>
Link: https://chromium-review.googlesource.com/6219270

tast-tests: fix remaining linter errors

Expand for full commit details

tast-tests: fix remaining linter errors 
 
As part of b:218608945 `golint` will be replaced with `staticcheck` as 
the default Go linter for ChromeOS. As a preliminary step we need to 
ensure `staticcheck` passes with current Go packages. 
 
This fixes such errors[1] for local Tast tests. 
 
[1] Please refer to https://staticcheck.dev/docs/checks/ for details 
about each check. 
 
BUG=b:218608945 
TEST=staticcheck -checks "inherit,-SA1019" \ 
    "go.chromium.org/tast-tests/..." 
 
Change-Id: Ib6063f3c31c496b508cfcc067c779a292de39964 
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/tast-tests/+/6219270 
Tested-by: Arnaud Ferraris <arnaud.ferraris@collabora.corp-partner.google.com> 
Auto-Submit: Arnaud Ferraris <arnaud.ferraris@collabora.corp-partner.google.com> 
Tast-Review: Jacek Siuda <jsiuda@google.com> 
Reviewed-by: Jacek Siuda <jsiuda@google.com> 
Tast-Review: Seewai Fu <seewaifu@google.com> 
Reviewed-by: Seewai Fu <seewaifu@google.com> 
Commit-Queue: Seewai Fu <seewaifu@google.com>

Files:

M src/go.chromium.org/tast-tests/cros/local/bundles/cros/arc/companion_library.go
M src/go.chromium.org/tast-tests/cros/local/bundles/cros/cryptohome/pin_lockout_on_lock_screen.go
M src/go.chromium.org/tast-tests/cros/remote/wificell/test_fixture.go

Hash: 3c810c4be0c341b39d460d54b15ef10619bb52a9
Date: Thu Jan 30 14:40:39 2025

ap...@google.com <ap...@google.com> #106Feb 19, 2025 08:23PM

Project: chromiumos/platform/tast-tests
Branch: main
Author: Arnaud Ferraris <arnaud.ferraris@collabora.corp-partner.google.com>
Link: https://chromium-review.googlesource.com/6277286

tast-tests: fix new linter errors

Expand for full commit details

tast-tests: fix new linter errors 
 
As part of b:218608945 `golint` will be replaced with `staticcheck` as 
the default Go linter for ChromeOS. As a preliminary step we need to 
ensure `staticcheck` passes with current Go packages. 
 
This fixes such errors[1] for local Tast tests. 
 
[1] Please refer to https://staticcheck.dev/docs/checks/ for details 
about each check. 
 
BUG=b:218608945 
TEST=staticcheck -checks "inherit,-SA1019" \ 
    "go.chromium.org/tast-tests/..." 
 
Change-Id: I6e6d782e5305a1cbccda01185c0f6fc73a7bfc21 
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/tast-tests/+/6277286 
Tested-by: Arnaud Ferraris <arnaud.ferraris@collabora.corp-partner.google.com> 
Commit-Queue: ChromeOS Auto Retry <chromeos-auto-retry@chromeos-bot.iam.gserviceaccount.com> 
Auto-Submit: Arnaud Ferraris <arnaud.ferraris@collabora.corp-partner.google.com> 
Reviewed-by: George Burgess <gbiv@chromium.org> 
Reviewed-by: Seewai Fu <seewaifu@google.com> 
Tast-Review: Seewai Fu <seewaifu@google.com>

Files:

M src/go.chromium.org/tast-tests/cros/local/bundles/cros/intel/pci_transition_check.go
M src/go.chromium.org/tast-tests/cros/local/vdi/apps/citrix/foot_pedal.go

Hash: 232aa2a21814127b646d9427f7001d49c4d796ec
Date: Mon Feb 17 18:07:13 2025

Issue 218608945

Description

Issue summary

Comments

bl...@google.com <bl...@google.com> #2Feb 9, 2022 12:43PM

ma...@google.com <ma...@google.com> #3Feb 9, 2022 04:35PM

gb...@google.com <gb...@google.com> #4Feb 9, 2022 07:40PM

ry...@google.com <ry...@google.com> Feb 9, 2022 09:59PM

ry...@google.com <ry...@google.com> #5Feb 10, 2022 05:31PM

ad...@collabora.corp-partner.google.com <ad...@collabora.corp-partner.google.com> #6Feb 15, 2022 02:38PM

bl...@google.com <bl...@google.com> #7May 10, 2022 02:42PM

bl...@google.com <bl...@google.com> #8Aug 2, 2022 03:02PM

gb...@google.com <gb...@google.com> #9Jun 28, 2024 02:50PM

ar...@collabora.corp-partner.google.com <ar...@collabora.corp-partner.google.com> #10Aug 30, 2024 03:00PM

ap...@google.com <ap...@google.com> #11Sep 9, 2024 05:49PM

ap...@google.com <ap...@google.com> #12Sep 16, 2024 11:11AM

ap...@google.com <ap...@google.com> #13Sep 16, 2024 11:11AM

ap...@google.com <ap...@google.com> #14Sep 16, 2024 11:11AM

ap...@google.com <ap...@google.com> #15Sep 16, 2024 02:10PM

ap...@google.com <ap...@google.com> #16Sep 16, 2024 02:11PM

ap...@google.com <ap...@google.com> #17Sep 16, 2024 02:24PM

ap...@google.com <ap...@google.com> #18Sep 16, 2024 02:24PM

ap...@google.com <ap...@google.com> #19Sep 16, 2024 07:34PM

ap...@google.com <ap...@google.com> #20Sep 20, 2024 11:12AM

ap...@google.com <ap...@google.com> #21Sep 23, 2024 03:33PM

ap...@google.com <ap...@google.com> #22Sep 24, 2024 10:20AM

ap...@google.com <ap...@google.com> #23Sep 24, 2024 01:48PM

ap...@google.com <ap...@google.com> #24Sep 24, 2024 06:59PM

ap...@google.com <ap...@google.com> #25Sep 30, 2024 01:48PM

ap...@google.com <ap...@google.com> #26Oct 1, 2024 06:30PM

ap...@google.com <ap...@google.com> #27Oct 2, 2024 10:56AM

ap...@google.com <ap...@google.com> #28Oct 2, 2024 02:09PM

ap...@google.com <ap...@google.com> #29Oct 8, 2024 07:21AM

ap...@google.com <ap...@google.com> #30Oct 11, 2024 10:09AM

ap...@google.com <ap...@google.com> #31Oct 12, 2024 04:34PM

ap...@google.com <ap...@google.com> #32Oct 21, 2024 03:01PM

ap...@google.com <ap...@google.com> #33Oct 21, 2024 03:02PM

ap...@google.com <ap...@google.com> #34Oct 22, 2024 08:56AM

ap...@google.com <ap...@google.com> #35Oct 22, 2024 01:23PM

ap...@google.com <ap...@google.com> #36Oct 22, 2024 01:23PM

ap...@google.com <ap...@google.com> #37Oct 22, 2024 07:58PM

ap...@google.com <ap...@google.com> #38Oct 22, 2024 08:02PM

ap...@google.com <ap...@google.com> #39Oct 22, 2024 08:02PM

ap...@google.com <ap...@google.com> #40Oct 22, 2024 08:02PM

ap...@google.com <ap...@google.com> #41Oct 22, 2024 08:02PM

ap...@google.com <ap...@google.com> #42Oct 22, 2024 08:02PM

ap...@google.com <ap...@google.com> #43Oct 22, 2024 08:02PM

ap...@google.com <ap...@google.com> #44Oct 22, 2024 08:02PM

ap...@google.com <ap...@google.com> #45Oct 22, 2024 08:02PM

ap...@google.com <ap...@google.com> #46Oct 22, 2024 08:02PM

ap...@google.com <ap...@google.com> #47Oct 22, 2024 08:02PM

ap...@google.com <ap...@google.com> #48Oct 22, 2024 08:02PM

ap...@google.com <ap...@google.com> #49Oct 22, 2024 08:02PM

ap...@google.com <ap...@google.com> #50Oct 22, 2024 08:02PM

ap...@google.com <ap...@google.com> #51Oct 22, 2024 08:02PM

ap...@google.com <ap...@google.com> #52Oct 22, 2024 08:02PM

ap...@google.com <ap...@google.com> #53Oct 22, 2024 08:02PM

ap...@google.com <ap...@google.com> #54Oct 22, 2024 08:02PM

ap...@google.com <ap...@google.com> #55Oct 22, 2024 08:02PM

ap...@google.com <ap...@google.com> #56Oct 22, 2024 08:03PM

ap...@google.com <ap...@google.com> #57Oct 22, 2024 08:03PM

ap...@google.com <ap...@google.com> #58Oct 22, 2024 08:03PM

ap...@google.com <ap...@google.com> #59Oct 22, 2024 08:03PM

ap...@google.com <ap...@google.com> #60Oct 22, 2024 08:03PM

ap...@google.com <ap...@google.com> #61Oct 24, 2024 11:30AM

ap...@google.com <ap...@google.com> #62Oct 24, 2024 11:30AM

ap...@google.com <ap...@google.com> #63Oct 24, 2024 01:49PM

ap...@google.com <ap...@google.com> #64Oct 28, 2024 11:33AM

ap...@google.com <ap...@google.com> #65Oct 29, 2024 09:02AM

ap...@google.com <ap...@google.com> #66Nov 22, 2024 02:51PM

ap...@google.com <ap...@google.com> #67Nov 23, 2024 01:38PM

ap...@google.com <ap...@google.com> #68Nov 25, 2024 03:03PM

ap...@google.com <ap...@google.com> #69Nov 26, 2024 11:11PM

ap...@google.com <ap...@google.com> #70Nov 26, 2024 11:11PM

ap...@google.com <ap...@google.com> #71Nov 27, 2024 09:07AM

ap...@google.com <ap...@google.com> #72Nov 27, 2024 11:09AM

ap...@google.com <ap...@google.com> #73Nov 27, 2024 06:12PM

ap...@google.com <ap...@google.com> #74Nov 28, 2024 05:59PM

ap...@google.com <ap...@google.com> #75Nov 29, 2024 06:15PM

ap...@google.com <ap...@google.com> #76Dec 3, 2024 02:15AM