Fixed

Bug

Status Update

No update yet.

Description

au...@google.com

created issue #1

Feb 11, 2022 10:30PM

DESCRIBE THE ISSUE IN DETAIL: Android lint NewApi regression, we get new false positives when upgrading AGP 7.3.0-alpha01 -> 7.3.0-alpha02

STEPS TO REPRODUCE:

Source class class @RequiresApi(23)

Expected

No issues

Actual

Failure with:

> Task :core:core:lintDebug FAILED
/ssd/ssd5/androidx-main/frameworks/support/core/core/src/androidTest/java/androidx/core/view/WindowInsetsControllerCompatActivityTest.kt:390: Error: Field requires API level 23 (current min is 21): scenario [NewApi]
        scenario.onActivity {
        ~~~~~~~~
/ssd/ssd5/androidx-main/frameworks/support/core/core/src/androidTest/java/androidx/core/view/WindowInsetsControllerCompatActivityTest.kt:390: Error: Field requires API level 23 (current min is 21): scenario [NewApi]
        scenario.onActivity {
        ~~~~~~~~
/ssd/ssd5/androidx-main/frameworks/support/core/core/src/androidTest/java/androidx/core/view/WindowInsetsControllerCompatActivityTest.kt:391: Error: Field requires API level 23 (current min is 21): windowInsetsController [NewApi]
            windowInsetsController.systemBarsBehavior =
            ~~~~~~~~~~~~~~~~~~~~~~
/ssd/ssd5/androidx-main/frameworks/support/core/core/src/androidTest/java/androidx/core/view/WindowInsetsControllerCompatActivityTest.kt:391: Error: Field requires API level 23 (current min is 21): windowInsetsController [NewApi]
            windowInsetsController.systemBarsBehavior =
            ~~~~~~~~~~~~~~~~~~~~~~
/ssd/ssd5/androidx-main/frameworks/support/core/core/src/androidTest/java/androidx/core/view/WindowInsetsControllerCompatActivityTest.kt:394: Error: Field requires API level 23 (current min is 21): scenario [NewApi]
        val decorView = scenario.withActivity { window.decorView }
                        ~~~~~~~~
/ssd/ssd5/androidx-main/frameworks/support/core/core/src/androidTest/java/androidx/core/view/WindowInsetsControllerCompatActivityTest.kt:394: Error: Field requires API level 23 (current min is 21): scenario [NewApi]
        val decorView = scenario.withActivity { window.decorView }
                        ~~~~~~~~

Studio Build: n/a
Version of Gradle Plugin: 7.3.0-alpha01
Version of Gradle: 7.4
Version of Java: 11
OS: linux

Comments

sa...@google.com <sa...@google.com> Feb 11, 2022 10:58PM

Assigned to an...@google.com.

tn...@google.com <tn...@google.com> #2Feb 12, 2022 01:07AM

Reassigned to tn...@google.com.

Interestingly I see this happening in the IDE when running ./studiow in the tree, which is Studio Chipmunk alpha 07 (see screenshot). I wonder if this is related to Kotlin (which I'm guessing has been updated in Chipmunk IDE, but probably only arrived with the recent 1.6 drop in dolphin.

Screen Shot 2022-02-11 at 5.06.07 PM.png

421 KB

View

Download

tn...@google.com <tn...@google.com> #3Feb 12, 2022 01:11AM

Actually no, I can boil it down to just the below. It looks like the issue is that the local @SdkSuppress annotation on the method makes lint think the minSdkVersion is 21, but when it dereferences the field it looks at its declaration being in a class (this class) as 23.

import androidx.annotation.RequiresApi
import androidx.test.filters.SdkSuppress

@SdkSuppress(minSdkVersion = 23)
@RequiresApi(23)
class Test {
    private var scenario: Any? = null
    @SdkSuppress(minSdkVersion = 21, maxSdkVersion = 29) 
    fun test() {
        scenario?.toString()
    }
}

tn...@google.com <tn...@google.com> #4Feb 12, 2022 01:26AM

Lint gets confused here because when it reaches an outer annotation specifying an API level (@TargetSdk, @RequiresApi, @SdkSuppress) it assumes that's the highest requirement -- it doesn't keep looking outwards.

Here we have a @SdkSuppress(minSdkVersion=21) inside an outer class marked @SdkSuppress(minSdkVersion=23). That seems redundant; should lint flag this and suggest you remove this annotation? Well, for all the plain @SdkSuppress annotations in the file anyway which doesn't specify a maxSdkVersion.

Here, when we see a maxSdkVersion lower than the outer class minSdkVersion, we should suggest the method itself should never be called and can be deleted, right?

tn...@google.com <tn...@google.com> #5Feb 14, 2022 06:32PM

I have a fix for this in https://googleplex-android-review.git.corp.google.com/c/platform/tools/base/+/16871556

This does not seem like a new issue. My unit test that I added for that CL fails not just in 7.3 but in 7.2 and even 7.1 as well.

tn...@google.com <tn...@google.com> #6Feb 15, 2022 06:03PM

Marked as fixed.

Fixed by https://cs.android.com/android-studio/platform/tools/base/+/35502406b502d1d164efce1d4f1a2d3fbf1476ce

de...@google.com <de...@google.com> #7Mar 2, 2022 12:49AM

Thank you for your patience while our engineering team worked to resolve this issue. A fix for this issue is now available in:

Android Studio Dolphin Canary 4 (2021.3.1.4)
Android Gradle Plugin 7.3.0-alpha04

We encourage you to try the latest update.

If you notice further issues or have questions, please file a new bug report.

Thank you for taking the time to submit feedback — we really appreciate it!