Fixed
Status Update
No update yet.
Comments
ap...@google.com
This is currently also affecting a TextField as it has a blinking cursor. This means any text field that is on the screen will block our synchronization.
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit ba279a0fd4cb3df553cc80cfec23353fba8c0411
Author: Jelle Fresen <jellefresen@google.com>
Date: Wed Jun 10 15:07:39 2020
Disable blinking cursor in tests by default
The blinking cursor is a poster child example of an infinite animation.
As long as we don't have a solution in place to properly deal with
infinite animations, we disable the blinking cursor in tests to avoid
tests from timing out just because there is a TextField that has focus
in the test.
I moved the TextField tests for the cursor to a separate test class, so
we can explicitly enable (and manually control) the blinking cursor for
thoses tests.
Bug: 151940543
Test: ./gradlew ui:ui-foundation:cC ui:ui-material:cC ui:ui-test:cC
Change-Id: I12984b8f43f6b587aa5cd9aabeaea96309e9086b
M ui/ui-foundation/src/androidTest/java/androidx/ui/foundation/SoftwareKeyboardTest.kt
A ui/ui-foundation/src/androidTest/java/androidx/ui/foundation/TextFieldCursorTest.kt
M ui/ui-foundation/src/androidTest/java/androidx/ui/foundation/TextFieldOnValueChangeTextFieldValueTest.kt
M ui/ui-foundation/src/androidTest/java/androidx/ui/foundation/TextFieldTest.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/TextField.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/FilledTextFieldTest.kt
M ui/ui-test/api/0.1.0-dev14.txt
M ui/ui-test/api/api_lint.ignore
M ui/ui-test/api/current.txt
M ui/ui-test/api/public_plus_experimental_0.1.0-dev14.txt
M ui/ui-test/api/public_plus_experimental_current.txt
M ui/ui-test/api/restricted_0.1.0-dev14.txt
M ui/ui-test/api/restricted_current.txt
M ui/ui-test/src/androidTest/java/androidx/ui/test/TextActionsTest.kt
M ui/ui-test/src/main/java/androidx/ui/test/ComposeTestRule.kt
M ui/ui-test/src/main/java/androidx/ui/test/android/AndroidComposeTestRule.kt
https://android-review.googlesource.com/1329004
https://goto.google.com/android-sha1/ba279a0fd4cb3df553cc80cfec23353fba8c0411
Branch: androidx-master-dev
commit ba279a0fd4cb3df553cc80cfec23353fba8c0411
Author: Jelle Fresen <jellefresen@google.com>
Date: Wed Jun 10 15:07:39 2020
Disable blinking cursor in tests by default
The blinking cursor is a poster child example of an infinite animation.
As long as we don't have a solution in place to properly deal with
infinite animations, we disable the blinking cursor in tests to avoid
tests from timing out just because there is a TextField that has focus
in the test.
I moved the TextField tests for the cursor to a separate test class, so
we can explicitly enable (and manually control) the blinking cursor for
thoses tests.
Bug: 151940543
Test: ./gradlew ui:ui-foundation:cC ui:ui-material:cC ui:ui-test:cC
Change-Id: I12984b8f43f6b587aa5cd9aabeaea96309e9086b
M ui/ui-foundation/src/androidTest/java/androidx/ui/foundation/SoftwareKeyboardTest.kt
A ui/ui-foundation/src/androidTest/java/androidx/ui/foundation/TextFieldCursorTest.kt
M ui/ui-foundation/src/androidTest/java/androidx/ui/foundation/TextFieldOnValueChangeTextFieldValueTest.kt
M ui/ui-foundation/src/androidTest/java/androidx/ui/foundation/TextFieldTest.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/TextField.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/FilledTextFieldTest.kt
M ui/ui-test/api/0.1.0-dev14.txt
M ui/ui-test/api/api_lint.ignore
M ui/ui-test/api/current.txt
M ui/ui-test/api/public_plus_experimental_0.1.0-dev14.txt
M ui/ui-test/api/public_plus_experimental_current.txt
M ui/ui-test/api/restricted_0.1.0-dev14.txt
M ui/ui-test/api/restricted_current.txt
M ui/ui-test/src/androidTest/java/androidx/ui/test/TextActionsTest.kt
M ui/ui-test/src/main/java/androidx/ui/test/ComposeTestRule.kt
M ui/ui-test/src/main/java/androidx/ui/test/android/AndroidComposeTestRule.kt
ap...@google.com
This bug was referenced by a recent CL that changed the Android API surface area.
The Android API Council <http://go/android-api-council > regularly reviews API changes for
consistency and sustainability, and we've just added this bug to our hotlist of pending reviews.
We'll wait until you mark this bug as 'Fixed' before starting our review, but please reach out
if you'd like us to review it sooner.
CHANGES TO ui/ui-test/api/current.txt
http://goto.google.com/android-api-diff/support/cur/pkg/androidx.ui.test
http://goto.google.com/android-api-diff/support/cur/clz/androidx.ui.test.ComposeTestRuleKt
http://goto.google.com/android-api-diff/support/cur/pkg/androidx.ui.test.android
http://goto.google.com/android-api-diff/support/cur/clz/androidx.ui.test.android.AndroidComposeTestCaseSetup
http://goto.google.com/android-api-diff/support/cur/clz/androidx.ui.test.android.AndroidComposeTestRuleKt
CHANGES TO ui/ui-test/api/public_plus_experimental_current.txt
http://goto.google.com/android-api-diff/support/cur/pkg/androidx.ui.test
http://goto.google.com/android-api-diff/support/cur/clz/androidx.ui.test.ComposeTestRuleKt
http://goto.google.com/android-api-diff/support/cur/pkg/androidx.ui.test.android
http://goto.google.com/android-api-diff/support/cur/clz/androidx.ui.test.android.AndroidComposeTestCaseSetup
http://goto.google.com/android-api-diff/support/cur/clz/androidx.ui.test.android.AndroidComposeTestRuleKt
The links above may take several days to start working. Generated fromhttp://go/support-current.txt/ba279a0fd4cb3df553cc80cfec23353fba8c0411
[Gerrit:http://android-review.googlesource.com/1329004 ]
[API-Approvers:pavlis@google.com]
[LIBRARY_API_REVIEW_TAG:ui/ui-test/api/0.1.0-dev14.txt]
The Android API Council <
consistency and sustainability, and we've just added this bug to our hotlist of pending reviews.
We'll wait until you mark this bug as 'Fixed' before starting our review, but please reach out
if you'd like us to review it sooner.
CHANGES TO ui/ui-test/api/current.txt
CHANGES TO ui/ui-test/api/public_plus_experimental_current.txt
The links above may take several days to start working. Generated from
[Gerrit:
[API-Approvers:pavlis@google.com]
[LIBRARY_API_REVIEW_TAG:ui/ui-test/api/0.1.0-dev14.txt]
ap...@google.com
Hi Jelle. Is this fixed or is there still more work to do? Thanks!
ap...@google.com
Hi Jelle. Can you please update this by eod Tues so that we can close the iteration. Thanks.
ap...@google.com
Sorry, removed it from the dev14 hotlist
ap...@google.com
A workaround that can be used if you encounter this problem in one of your tests, is to pause the clock at the beginning of the test and advance it manually whenever you need to move forward in the animations that are currently running:
@get:Rule
val composeTestRule = createComposeRule()
val clockTestRule get() = composeTestRule.clockTestRule
@Test
fun test() {
clockTestRule.pauseClock()
// ...
runOnIdle {
clockTestRule.advanceClock(1000)
}
// ...
}
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit f0649b27c6df6fa151202e3f23913998805fb398
Author: Jelle Fresen <jellefresen@google.com>
Date: Tue Jan 26 12:06:58 2021
Add isInfinite to Animation and VectorizedAnimationSpec
Will be used to facilitate special handling of infinte animations in
tests, so the test framework won't await these animations indefinitely.
Bug: 151940543
Test: IsInfiniteTest.kt
Relnote: "Added `Animation.isInfinite` and
`VectorizedAnimationSpec.isInfinite` that signal if an animation is
infinite or not. This can be used in implementations of animations to
have special handling of such animations. For example, a special \"time
remaining\" message can be shown, or during tests the animation can be
cancelled to prevent waiting for idleness indefinitely."
Change-Id: Iebb05e9d158b4fe81d037ab28e113da4926c50cd
M compose/animation/animation-core/api/current.txt
M compose/animation/animation-core/api/public_plus_experimental_current.txt
M compose/animation/animation-core/api/restricted_current.txt
M compose/animation/animation-core/src/commonMain/kotlin/androidx/compose/animation/core/Animation.kt
M compose/animation/animation-core/src/commonMain/kotlin/androidx/compose/animation/core/VectorizedAnimationSpec.kt
A compose/animation/animation-core/src/test/java/androidx/compose/animation/core/IsInfiniteTest.kt
https://android-review.googlesource.com/1560508
Branch: androidx-main
commit f0649b27c6df6fa151202e3f23913998805fb398
Author: Jelle Fresen <jellefresen@google.com>
Date: Tue Jan 26 12:06:58 2021
Add isInfinite to Animation and VectorizedAnimationSpec
Will be used to facilitate special handling of infinte animations in
tests, so the test framework won't await these animations indefinitely.
Bug: 151940543
Test: IsInfiniteTest.kt
Relnote: "Added `Animation.isInfinite` and
`VectorizedAnimationSpec.isInfinite` that signal if an animation is
infinite or not. This can be used in implementations of animations to
have special handling of such animations. For example, a special \"time
remaining\" message can be shown, or during tests the animation can be
cancelled to prevent waiting for idleness indefinitely."
Change-Id: Iebb05e9d158b4fe81d037ab28e113da4926c50cd
M compose/animation/animation-core/api/current.txt
M compose/animation/animation-core/api/public_plus_experimental_current.txt
M compose/animation/animation-core/api/restricted_current.txt
M compose/animation/animation-core/src/commonMain/kotlin/androidx/compose/animation/core/Animation.kt
M compose/animation/animation-core/src/commonMain/kotlin/androidx/compose/animation/core/VectorizedAnimationSpec.kt
A compose/animation/animation-core/src/test/java/androidx/compose/animation/core/IsInfiniteTest.kt
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit ae92240e2b212a7c0cfbccdd716efa84f3da34f2
Author: Jelle Fresen <jellefresen@google.com>
Date: Thu Jan 28 17:15:52 2021
Cancel infinite animations in tests
Infinite animations are now started through withInfiniteAnimation, which
checks the InfiniteAnimationPolicy and applies it if present when
withFrameNanos or withFrameMillis is called.
ComposeTestRule installs an InfiniteAnimationPolicy in the
applyCoroutineContext that cancels the coroutine when that policy is
applied.
This enables us to remove special handling of demos with infinite
animations in DemoTest, and we can now remove blinkingCursorEnabled.
Fixes: 151940543
Bug: 168695905
Test: ./gradlew compose:animation:animation-core:test && \
./gradlew compose:animation:animation-core:cC && \
./gradlew compose:ui:ui-test:cC
Relnote: "Introduced an `InfiniteAnimationPolicy` coroutine context
element that will be applied in infinite animations. By default no
policy is installed, except when running tests with `ComposeTestRule`."
Change-Id: I50ec421d7db495459a61c9282dbc2bfbc1f1ad02
M compose/animation/animation-core/api/current.txt
M compose/animation/animation-core/api/public_plus_experimental_current.txt
M compose/animation/animation-core/api/restricted_current.txt
M compose/animation/animation-core/src/androidAndroidTest/kotlin/androidx/compose/animation/core/InfiniteTransitionTest.kt
A compose/animation/animation-core/src/commonMain/kotlin/androidx/compose/animation/core/InfiniteAnimationPolicy.kt
M compose/animation/animation-core/src/commonMain/kotlin/androidx/compose/animation/core/InfiniteTransition.kt
M compose/animation/animation-core/src/commonMain/kotlin/androidx/compose/animation/core/SuspendAnimation.kt
A compose/animation/animation-core/src/test/java/androidx/compose/animation/core/InfiniteAnimationPolicyTest.kt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/textfield/TextFieldCursorTest.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/TextFieldCursor.kt
M compose/integration-tests/demos/src/androidTest/java/androidx/compose/integration/demos/test/DemoTest.kt
M compose/integration-tests/src/main/java/androidx/ui/integration/test/core/text/TextFieldToggleTextTestCase.kt
M compose/ui/ui-test-junit4/src/androidMain/kotlin/androidx/compose/ui/test/junit4/AndroidComposeTestRule.kt
A compose/ui/ui-test/src/androidAndroidTest/kotlin/androidx/compose/ui/test/InfiniteAnimationTest.kt
https://android-review.googlesource.com/1563734
Branch: androidx-main
commit ae92240e2b212a7c0cfbccdd716efa84f3da34f2
Author: Jelle Fresen <jellefresen@google.com>
Date: Thu Jan 28 17:15:52 2021
Cancel infinite animations in tests
Infinite animations are now started through withInfiniteAnimation, which
checks the InfiniteAnimationPolicy and applies it if present when
withFrameNanos or withFrameMillis is called.
ComposeTestRule installs an InfiniteAnimationPolicy in the
applyCoroutineContext that cancels the coroutine when that policy is
applied.
This enables us to remove special handling of demos with infinite
animations in DemoTest, and we can now remove blinkingCursorEnabled.
Fixes: 151940543
Bug: 168695905
Test: ./gradlew compose:animation:animation-core:test && \
./gradlew compose:animation:animation-core:cC && \
./gradlew compose:ui:ui-test:cC
Relnote: "Introduced an `InfiniteAnimationPolicy` coroutine context
element that will be applied in infinite animations. By default no
policy is installed, except when running tests with `ComposeTestRule`."
Change-Id: I50ec421d7db495459a61c9282dbc2bfbc1f1ad02
M compose/animation/animation-core/api/current.txt
M compose/animation/animation-core/api/public_plus_experimental_current.txt
M compose/animation/animation-core/api/restricted_current.txt
M compose/animation/animation-core/src/androidAndroidTest/kotlin/androidx/compose/animation/core/InfiniteTransitionTest.kt
A compose/animation/animation-core/src/commonMain/kotlin/androidx/compose/animation/core/InfiniteAnimationPolicy.kt
M compose/animation/animation-core/src/commonMain/kotlin/androidx/compose/animation/core/InfiniteTransition.kt
M compose/animation/animation-core/src/commonMain/kotlin/androidx/compose/animation/core/SuspendAnimation.kt
A compose/animation/animation-core/src/test/java/androidx/compose/animation/core/InfiniteAnimationPolicyTest.kt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/textfield/TextFieldCursorTest.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/TextFieldCursor.kt
M compose/integration-tests/demos/src/androidTest/java/androidx/compose/integration/demos/test/DemoTest.kt
M compose/integration-tests/src/main/java/androidx/ui/integration/test/core/text/TextFieldToggleTextTestCase.kt
M compose/ui/ui-test-junit4/src/androidMain/kotlin/androidx/compose/ui/test/junit4/AndroidComposeTestRule.kt
A compose/ui/ui-test/src/androidAndroidTest/kotlin/androidx/compose/ui/test/InfiniteAnimationTest.kt
ap...@google.com
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit 75331425fcf02b5fb681a796a369a11325a86154
Author: Sergey Vasilinets <sergeyv@google.com>
Date: Mon Jun 27 23:56:01 2022
Use correct WorkSpec in SystemForegroundDispatcher
Database can potentially have newer version of worker,
so we should rely on the spec of running worker instead.
Test: SystemForegroundDispatcherTest
bug: 219446409
Change-Id: I6144f1e604996407d51a92c1fb7e9a6c64577a92
M work/work-runtime/src/androidTest/java/androidx/work/impl/foreground/SystemForegroundDispatcherTest.kt
M work/work-runtime/src/main/java/androidx/work/impl/foreground/SystemForegroundDispatcher.java
M work/work-runtime/src/main/java/androidx/work/impl/Processor.java
M work/work-runtime/src/main/java/androidx/work/impl/WorkerWrapper.java
https://android-review.googlesource.com/2137872
Branch: androidx-main
commit 75331425fcf02b5fb681a796a369a11325a86154
Author: Sergey Vasilinets <sergeyv@google.com>
Date: Mon Jun 27 23:56:01 2022
Use correct WorkSpec in SystemForegroundDispatcher
Database can potentially have newer version of worker,
so we should rely on the spec of running worker instead.
Test: SystemForegroundDispatcherTest
bug: 219446409
Change-Id: I6144f1e604996407d51a92c1fb7e9a6c64577a92
M work/work-runtime/src/androidTest/java/androidx/work/impl/foreground/SystemForegroundDispatcherTest.kt
M work/work-runtime/src/main/java/androidx/work/impl/foreground/SystemForegroundDispatcher.java
M work/work-runtime/src/main/java/androidx/work/impl/Processor.java
M work/work-runtime/src/main/java/androidx/work/impl/WorkerWrapper.java
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit bc2bc2a8efff9d46a2a070c4b11067b46a24279b
Author: Sergey Vasilinets <sergeyv@google.com>
Date: Wed Jun 29 12:11:20 2022
Read tags along with WorkSpec in Processor
Otherwise due to the race, tags can be inconsistent
with the rest of properties of worker.
Test: WorkUpdateTest
bug: 219446409
Change-Id: Ieca7c5e1650a5ca16c643ca0b800a7ad2c984951
M work/work-multiprocess/src/androidTest/java/androidx/work/multiprocess/RemoteListenableWorkerTest.kt
M work/work-runtime/src/androidTest/java/androidx/work/WorkUpdateTest.kt
M work/work-runtime/src/androidTest/java/androidx/work/impl/WorkContinuationImplTest.java
M work/work-runtime/src/androidTest/java/androidx/work/impl/ControlledWorkerWrapperTest.kt
M work/work-runtime/src/androidTest/java/androidx/work/impl/workers/ConstraintTrackingWorkerTest.java
M work/work-runtime/src/androidTest/java/androidx/work/impl/WorkerWrapperTest.java
M work/work-runtime/src/androidTest/java/androidx/work/impl/foreground/WorkerWrapperForegroundTest.kt
M work/work-runtime/src/main/java/androidx/work/impl/WorkerWrapper.java
M work/work-runtime/src/main/java/androidx/work/impl/Processor.java
M work/work-multiprocess/src/androidTest/java/androidx/work/multiprocess/RemoteCoroutineWorkerTest.kt
https://android-review.googlesource.com/2139532
Branch: androidx-main
commit bc2bc2a8efff9d46a2a070c4b11067b46a24279b
Author: Sergey Vasilinets <sergeyv@google.com>
Date: Wed Jun 29 12:11:20 2022
Read tags along with WorkSpec in Processor
Otherwise due to the race, tags can be inconsistent
with the rest of properties of worker.
Test: WorkUpdateTest
bug: 219446409
Change-Id: Ieca7c5e1650a5ca16c643ca0b800a7ad2c984951
M work/work-multiprocess/src/androidTest/java/androidx/work/multiprocess/RemoteListenableWorkerTest.kt
M work/work-runtime/src/androidTest/java/androidx/work/WorkUpdateTest.kt
M work/work-runtime/src/androidTest/java/androidx/work/impl/WorkContinuationImplTest.java
M work/work-runtime/src/androidTest/java/androidx/work/impl/ControlledWorkerWrapperTest.kt
M work/work-runtime/src/androidTest/java/androidx/work/impl/workers/ConstraintTrackingWorkerTest.java
M work/work-runtime/src/androidTest/java/androidx/work/impl/WorkerWrapperTest.java
M work/work-runtime/src/androidTest/java/androidx/work/impl/foreground/WorkerWrapperForegroundTest.kt
M work/work-runtime/src/main/java/androidx/work/impl/WorkerWrapper.java
M work/work-runtime/src/main/java/androidx/work/impl/Processor.java
M work/work-multiprocess/src/androidTest/java/androidx/work/multiprocess/RemoteCoroutineWorkerTest.kt
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit b75f2a988f93a687bd95c87ebdb6ec1d486c4f3c
Author: Sergey Vasilinets <sergeyv@google.com>
Date: Thu Jul 07 16:39:25 2022
Preserve lastEnqueueTime during the update
Test: WorkUpdateTest
bug: 219446409
Change-Id: Ifdc6a4c105ee2c53b2538265f933fd02634e85c5
M work/work-runtime/src/androidTest/java/androidx/work/WorkUpdateTest.kt
M work/work-runtime/src/main/java/androidx/work/impl/WorkerUpdater.kt
https://android-review.googlesource.com/2148159
Branch: androidx-main
commit b75f2a988f93a687bd95c87ebdb6ec1d486c4f3c
Author: Sergey Vasilinets <sergeyv@google.com>
Date: Thu Jul 07 16:39:25 2022
Preserve lastEnqueueTime during the update
Test: WorkUpdateTest
bug: 219446409
Change-Id: Ifdc6a4c105ee2c53b2538265f933fd02634e85c5
M work/work-runtime/src/androidTest/java/androidx/work/WorkUpdateTest.kt
M work/work-runtime/src/main/java/androidx/work/impl/WorkerUpdater.kt
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit 3258084eefb45350a75e43d86798f2e757ba49a3
Author: Sergey Vasilinets <sergeyv@google.com>
Date: Mon Jul 11 17:26:07 2022
Use ConstraintTrackingWorker in WorkManager.update
Test: WorkUpdateTest
bug: 219446409
Change-Id: Icbb073c77b5f529cb599d11ad74f4f8899eddbb4
M work/work-runtime/src/androidTest/java/androidx/work/WorkUpdateTest.kt
A work/work-runtime/src/main/java/androidx/work/impl/utils/EnqueueUtils.kt
M work/work-runtime/src/main/java/androidx/work/impl/utils/EnqueueRunnable.java
M work/work-runtime/src/main/java/androidx/work/impl/WorkerUpdater.kt
https://android-review.googlesource.com/2149993
Branch: androidx-main
commit 3258084eefb45350a75e43d86798f2e757ba49a3
Author: Sergey Vasilinets <sergeyv@google.com>
Date: Mon Jul 11 17:26:07 2022
Use ConstraintTrackingWorker in WorkManager.update
Test: WorkUpdateTest
bug: 219446409
Change-Id: Icbb073c77b5f529cb599d11ad74f4f8899eddbb4
M work/work-runtime/src/androidTest/java/androidx/work/WorkUpdateTest.kt
A work/work-runtime/src/main/java/androidx/work/impl/utils/EnqueueUtils.kt
M work/work-runtime/src/main/java/androidx/work/impl/utils/EnqueueRunnable.java
M work/work-runtime/src/main/java/androidx/work/impl/WorkerUpdater.kt
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit 4110a2f8612edcd105a72640d43b9c9ae00e727d
Author: Sergey Vasilinets <sergeyv@google.com>
Date: Fri Jul 08 15:52:39 2022
Introduce ExistingPeriodicWorkPolicy.Update
It is very similar to previously existing
ExistingPeriodicWorkPolicy.REPLACE.
Test: WorkManagerImplTest + integration test-app
Relnote: "`ExistingPeriodicWorkPolicy.UPDATE` was
added. This policy allows to update a periodic work
by the name. It is similar existing `REPLACE`, but
is less intrusive: it doesn't cancel a worker if it
is currently running, it preserves enqueue time, so
initial delay and period are calculated from original
enqueue time, rather than update time. `REPLACE` was
deprecated to decrease a confusion between very similarly
named `REPLACE`and `UPDATE`. If you still want to keep
previous semantics of `REPLACE`,
newly added `CANCEL_AND_REENQUEUE` identical to `REPLACE`
can be used."
bug: 219446409
Change-Id: I985edc2cf7ac7c316932185f3fd0a3ca6660f2dc
M work/work-multiprocess/src/main/java/androidx/work/multiprocess/RemoteWorkManagerImpl.java
M work/work-multiprocess/src/main/java/androidx/work/multiprocess/RemoteWorkManagerClient.java
M work/work-runtime/api/public_plus_experimental_current.txt
M work/work-runtime/src/main/aidl/androidx/work/multiprocess/IWorkManagerImpl.aidl
M work/work-runtime/api/current.txt
M work/integration-tests/testapp/src/main/res/layout/activity_main.xml
M work/work-runtime/src/main/java/androidx/work/impl/WorkerUpdater.kt
M work/work-runtime/src/main/java/androidx/work/impl/model/WorkTagDao.kt
M work/work-runtime/api/restricted_current.txt
M work/integration-tests/testapp/src/main/java/androidx/work/integration/testapp/MainActivity.java
M work/work-runtime/src/androidTest/java/androidx/work/impl/WorkManagerImplTest.java
M work/work-runtime/src/main/java/androidx/work/impl/WorkManagerImpl.java
M work/work-runtime/src/main/java/androidx/work/ExistingPeriodicWorkPolicy.kt
M work/work-runtime/src/main/java/androidx/work/impl/utils/EnqueueRunnable.java
M work/integration-tests/testapp/src/main/java/androidx/work/integration/testapp/RemoteService.kt
M work/integration-tests/testapp/src/main/res/values/donottranslate-strings.xml
https://android-review.googlesource.com/2149093
Branch: androidx-main
commit 4110a2f8612edcd105a72640d43b9c9ae00e727d
Author: Sergey Vasilinets <sergeyv@google.com>
Date: Fri Jul 08 15:52:39 2022
Introduce ExistingPeriodicWorkPolicy.Update
It is very similar to previously existing
ExistingPeriodicWorkPolicy.REPLACE.
Test: WorkManagerImplTest + integration test-app
Relnote: "`ExistingPeriodicWorkPolicy.UPDATE` was
added. This policy allows to update a periodic work
by the name. It is similar existing `REPLACE`, but
is less intrusive: it doesn't cancel a worker if it
is currently running, it preserves enqueue time, so
initial delay and period are calculated from original
enqueue time, rather than update time. `REPLACE` was
deprecated to decrease a confusion between very similarly
named `REPLACE`and `UPDATE`. If you still want to keep
previous semantics of `REPLACE`,
newly added `CANCEL_AND_REENQUEUE` identical to `REPLACE`
can be used."
bug: 219446409
Change-Id: I985edc2cf7ac7c316932185f3fd0a3ca6660f2dc
M work/work-multiprocess/src/main/java/androidx/work/multiprocess/RemoteWorkManagerImpl.java
M work/work-multiprocess/src/main/java/androidx/work/multiprocess/RemoteWorkManagerClient.java
M work/work-runtime/api/public_plus_experimental_current.txt
M work/work-runtime/src/main/aidl/androidx/work/multiprocess/IWorkManagerImpl.aidl
M work/work-runtime/api/current.txt
M work/integration-tests/testapp/src/main/res/layout/activity_main.xml
M work/work-runtime/src/main/java/androidx/work/impl/WorkerUpdater.kt
M work/work-runtime/src/main/java/androidx/work/impl/model/WorkTagDao.kt
M work/work-runtime/api/restricted_current.txt
M work/integration-tests/testapp/src/main/java/androidx/work/integration/testapp/MainActivity.java
M work/work-runtime/src/androidTest/java/androidx/work/impl/WorkManagerImplTest.java
M work/work-runtime/src/main/java/androidx/work/impl/WorkManagerImpl.java
M work/work-runtime/src/main/java/androidx/work/ExistingPeriodicWorkPolicy.kt
M work/work-runtime/src/main/java/androidx/work/impl/utils/EnqueueRunnable.java
M work/integration-tests/testapp/src/main/java/androidx/work/integration/testapp/RemoteService.kt
M work/integration-tests/testapp/src/main/res/values/donottranslate-strings.xml
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit 8e22db3e7a62008ab0c4c07ac3f682e0c1cc4dbf
Author: Sergey Vasilinets <sergeyv@google.com>
Date: Mon Aug 08 15:39:16 2022
Add WorkerParameters.getGeneration
Relnote: """
`WorkerParameters.getGeneration()` was added that returns
a generation of a worker. A worker has multiple generations, if it was updated via
`WorkManager.updateWork` or `WorkManager.enqueueUniquePeriodicWork` using
`ExistingPeriodicWorkPolicy.UPDATE`.
This worker can possibly be of an older generation rather than latest known,
if an update has happened while this worker is running."""
bug: 219446409
Test: WorkUpdateTest#updateWorkerParameterGeneration
Change-Id: I128a9838067f3a1722a9460f52ef58fb0f98136c
M work/work-runtime/src/androidTest/java/androidx/work/WorkUpdateTest.kt
M work/work-multiprocess/src/main/java/androidx/work/multiprocess/parcelable/ParcelableWorkerParameters.java
M work/work-rxjava2/src/test/java/androidx/work/RxWorkerTest.kt
M work/work-runtime/src/androidTest/java/androidx/work/impl/workers/ConstraintTrackingWorkerTest.java
M work/work-rxjava3/src/test/java/androidx/work/rxjava3/RxForegroundInfoTest.kt
M work/work-runtime/src/androidTest/java/androidx/work/impl/WorkerWrapperTest.java
M work/work-rxjava3/src/test/java/androidx/work/rxjava3/RxWorkerTest.kt
M work/work-rxjava3/src/test/java/androidx/work/rxjava3/SetCompletableProgressTest.kt
M work/work-runtime/api/public_plus_experimental_current.txt
M work/work-runtime/src/main/java/androidx/work/impl/WorkerWrapper.java
M work/work-runtime-ktx/src/androidTest/java/androidx/work/CoroutineWorkerTest.kt
M work/work-testing/src/main/java/androidx/work/testing/TestListenableWorkerBuilder.java
M work/work-runtime/api/current.txt
M work/work-runtime/src/main/java/androidx/work/impl/WorkerUpdater.kt
M work/work-rxjava2/src/test/java/androidx/work/RxForegroundInfoTest.kt
M work/work-runtime/api/restricted_current.txt
M work/work-multiprocess/src/androidTest/java/androidx/work/multiprocess/RemoteListenableWorkerTest.kt
M work/work-runtime/src/androidTest/java/androidx/work/DefaultWorkerFactoryTest.java
M work/work-runtime/src/androidTest/java/androidx/work/DelegatingWorkerFactoryTest.kt
M work/work-rxjava2/src/test/java/androidx/work/SetCompletableProgressTest.kt
M work/work-runtime/src/androidTest/java/androidx/work/WorkForegroundRunnableTest.kt
M work/work-runtime/src/main/java/androidx/work/WorkerParameters.java
https://android-review.googlesource.com/2177783
Branch: androidx-main
commit 8e22db3e7a62008ab0c4c07ac3f682e0c1cc4dbf
Author: Sergey Vasilinets <sergeyv@google.com>
Date: Mon Aug 08 15:39:16 2022
Add WorkerParameters.getGeneration
Relnote: """
`WorkerParameters.getGeneration()` was added that returns
a generation of a worker. A worker has multiple generations, if it was updated via
`WorkManager.updateWork` or `WorkManager.enqueueUniquePeriodicWork` using
`ExistingPeriodicWorkPolicy.UPDATE`.
This worker can possibly be of an older generation rather than latest known,
if an update has happened while this worker is running."""
bug: 219446409
Test: WorkUpdateTest#updateWorkerParameterGeneration
Change-Id: I128a9838067f3a1722a9460f52ef58fb0f98136c
M work/work-runtime/src/androidTest/java/androidx/work/WorkUpdateTest.kt
M work/work-multiprocess/src/main/java/androidx/work/multiprocess/parcelable/ParcelableWorkerParameters.java
M work/work-rxjava2/src/test/java/androidx/work/RxWorkerTest.kt
M work/work-runtime/src/androidTest/java/androidx/work/impl/workers/ConstraintTrackingWorkerTest.java
M work/work-rxjava3/src/test/java/androidx/work/rxjava3/RxForegroundInfoTest.kt
M work/work-runtime/src/androidTest/java/androidx/work/impl/WorkerWrapperTest.java
M work/work-rxjava3/src/test/java/androidx/work/rxjava3/RxWorkerTest.kt
M work/work-rxjava3/src/test/java/androidx/work/rxjava3/SetCompletableProgressTest.kt
M work/work-runtime/api/public_plus_experimental_current.txt
M work/work-runtime/src/main/java/androidx/work/impl/WorkerWrapper.java
M work/work-runtime-ktx/src/androidTest/java/androidx/work/CoroutineWorkerTest.kt
M work/work-testing/src/main/java/androidx/work/testing/TestListenableWorkerBuilder.java
M work/work-runtime/api/current.txt
M work/work-runtime/src/main/java/androidx/work/impl/WorkerUpdater.kt
M work/work-rxjava2/src/test/java/androidx/work/RxForegroundInfoTest.kt
M work/work-runtime/api/restricted_current.txt
M work/work-multiprocess/src/androidTest/java/androidx/work/multiprocess/RemoteListenableWorkerTest.kt
M work/work-runtime/src/androidTest/java/androidx/work/DefaultWorkerFactoryTest.java
M work/work-runtime/src/androidTest/java/androidx/work/DelegatingWorkerFactoryTest.kt
M work/work-rxjava2/src/test/java/androidx/work/SetCompletableProgressTest.kt
M work/work-runtime/src/androidTest/java/androidx/work/WorkForegroundRunnableTest.kt
M work/work-runtime/src/main/java/androidx/work/WorkerParameters.java
dr...@gmail.com
I like the ability introduced in 2.8.0-alpha03 to update an existing work request, particularly a periodic work request.
I see that there is a new ExistingPeriodicWorkPolicy.UPDATE type as well as a new WorkManager.updateWork() method.
Can I ask: what is the difference between setting up a new work request and calling enqueueUniquePeriodicWork()ExistingPeriodicWorkPolicy.UPDATE as the work policy), versus calling updateWork()
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit cb25671d1f6f60aa0baf13e39a66496b28540915
Author: Sergey Vasilinets <sergeyv@google.com>
Date: Thu Aug 11 15:21:26 2022
Add generation to WorkerInfo
Relnote: """
`WorkerInfo.getGeneration()` was added that returns
a generation of a worker. A worker has multiple generations, if it was updated via
`WorkManager.updateWork` or `WorkManager.enqueueUniquePeriodicWork` using
`ExistingPeriodicWorkPolicy.UPDATE`.
If the worker is currently running, it can possibly be of an older generation rather than
returned by this methof if an update has happened during an execution of this worker."""
bug: 219446409
Test: WorkUpdateTest
Change-Id: I665c5d480700dd682d1268ee88be124783fca70f
M work/work-multiprocess/src/main/java/androidx/work/multiprocess/parcelable/ParcelableWorkInfo.java
M work/work-runtime/api/restricted_current.txt
M work/work-runtime/src/androidTest/java/androidx/work/impl/WorkManagerImplTest.java
M work/work-runtime/src/androidTest/java/androidx/work/WorkUpdateTest.kt
M work/work-runtime/src/main/java/androidx/work/impl/model/WorkSpec.kt
M work/work-runtime/src/main/java/androidx/work/impl/model/WorkSpecDao.kt
M work/work-multiprocess/src/androidTest/java/androidx/work/multiprocess/ParcelableWorkInfoTest.kt
M work/work-runtime/api/public_plus_experimental_current.txt
M work/work-runtime/src/main/java/androidx/work/WorkInfo.java
M work/work-runtime/api/current.txt
https://android-review.googlesource.com/2183459
Branch: androidx-main
commit cb25671d1f6f60aa0baf13e39a66496b28540915
Author: Sergey Vasilinets <sergeyv@google.com>
Date: Thu Aug 11 15:21:26 2022
Add generation to WorkerInfo
Relnote: """
`WorkerInfo.getGeneration()` was added that returns
a generation of a worker. A worker has multiple generations, if it was updated via
`WorkManager.updateWork` or `WorkManager.enqueueUniquePeriodicWork` using
`ExistingPeriodicWorkPolicy.UPDATE`.
If the worker is currently running, it can possibly be of an older generation rather than
returned by this methof if an update has happened during an execution of this worker."""
bug: 219446409
Test: WorkUpdateTest
Change-Id: I665c5d480700dd682d1268ee88be124783fca70f
M work/work-multiprocess/src/main/java/androidx/work/multiprocess/parcelable/ParcelableWorkInfo.java
M work/work-runtime/api/restricted_current.txt
M work/work-runtime/src/androidTest/java/androidx/work/impl/WorkManagerImplTest.java
M work/work-runtime/src/androidTest/java/androidx/work/WorkUpdateTest.kt
M work/work-runtime/src/main/java/androidx/work/impl/model/WorkSpec.kt
M work/work-runtime/src/main/java/androidx/work/impl/model/WorkSpecDao.kt
M work/work-multiprocess/src/androidTest/java/androidx/work/multiprocess/ParcelableWorkInfoTest.kt
M work/work-runtime/api/public_plus_experimental_current.txt
M work/work-runtime/src/main/java/androidx/work/WorkInfo.java
M work/work-runtime/api/current.txt
se...@google.com
na...@google.com
This bug was linked in a change in the following release(s):
androidx.work:work-multiprocess:2.8.0-alpha04androidx.work:work-rxjava2:2.8.0-alpha04androidx.work:work-rxjava3:2.8.0-alpha04
ka...@gmail.com
#1
Description
WM should provide an ability to update
WorkSpecin non-intrusive way, meaning:Currently it is impossible to implement outside of WM, because we don't expose enqueue time.