AppCompatEditText no longer respect clickable attribute set in xml [221094907]

Fixed

Bug

Status Update

No update yet.

Description

vo...@gmail.com

created issue #1

Feb 23, 2022 10:16PM

After switching from appcompat v1.3.1 to v1.4.1 we have noticed change in behavior for AppCompatEditText, specifically setting clickable=false from xml no longer have any effect.

Affected version: appcomapt v1.4.1

Steps to reproduce:

Create AppCompatEditText in xml
Set android:clickable="false"
Run the app and either check layout inspector or connect debugger to check isClickable()

Actual behavior:

AppCompatEditText is clickable even though clickable is set to false

Expect Behavior:

AppCompatEditText should respect clickable attribute set from xml.

Additional information:

After looking through the changes to appcompat library, looks like the issue been introduced in:

Add EmojiCompat to AppCompatEditText https://android.googlesource.com/platform/frameworks/support/+/ab8e5e277ffc64b639933b7669fb3945c7f130db

With this change we are now calling

super.setKeyListener(wrappedKeyListener);

from the constructor, which would call

android.widget.TextView#fixFocusableAndClickableSettings

Which in turn would make view clickable again:

private void fixFocusableAndClickableSettings() {
    if (mMovement != null || (mEditor != null && mEditor.mKeyListener != null)) {
        setFocusable(FOCUSABLE);
        setClickable(true);
        setLongClickable(true);
    } else {
        setFocusable(FOCUSABLE_AUTO);
        setClickable(false);
        setLongClickable(false);
    }
}

Comments

al...@google.com <al...@google.com> Feb 23, 2022 10:38PM

Reassigned to se...@google.com.

se...@google.com <se...@google.com> #2Mar 3, 2022 11:01PM

Accepted by se...@google.com.

Hi Doudera,

Thank you for reporting this issue. It is working as intended. This is because the state of CameraControl follows Camera. Once the Camera is closed, all settings will be restored, just like the settings of the focus area and zoom level. The app can restore the torch state by resetting torch at the time of activity onResume.

se...@google.com <se...@google.com> #3Mar 3, 2022 11:53PM

Hello,

thank you for the fast reply. The behaviour is unexpected to me because if you have the same code as before and just add logging like this:

camera = cameraProvider.bindToLifecycle(
this, cameraSelector, preview, imageCapture, imageAnalyzer)
.apply {
Log.d(TAG, "Enabling torch after binding") // <-- called everytime it returns to Activity so next statement should be applied
cameraControl.enableTorch(true)
}

The log is always called even when returning to Activity so I suppose it should be applied. Why it is not applied when it is called?

Unfortunately, I cannot make it work even with your hint. I tried to add camera?.cameraControl?.enableTorch(true) to onResume() but without any effect. Can you please describe more how to reset torch state onResume().

As you said the same happens with setZoomRatio() etc.

Thank you, Martin

vo...@gmail.com <vo...@gmail.com> #4Mar 4, 2022 12:33AM

Hi Doudera, Thank you for the detail description. It sounds like some problem in the code. I will investigate it more.

ap...@google.com <ap...@google.com> #5Mar 4, 2022 07:13PM

Marked as fixed.

From the log, it shows the camera state

-> open -> enable torch -> close -> open

The torch was gone because it restarted the camera.

It needs to investigate more about why it open/close so frequently.

Issue 221094907