Status Update
No update yet.
Comments
ga...@google.com
Connie, do you think we can just remove it? And recommend ModalBottomSheet or BottomSheetScaffold instead?
jb...@google.com
ga...@google.com
I think it's worth noting in M2 that ModalBottomSheet is a layout while bottomdrawer functions more as a truly modal object, even though it does not have perfect dialog-like functionality. For the usecase recommended (bottom app bar menus), BottomDrawer seems like a better fit than ModalBottomSheetLayout. However in M3 it makes sense to explicitly use ModalBottomSheet once implemented.
Wdyt Matvei?
ma...@gmail.com
I think it's worth noting in M2 that ModalBottomSheet is a layout while bottomdrawer functions more as a truly modal object
Could you comment on that? What's the actual difference in the behaviour?
mg...@gmail.com
Bottom Drawer is an atomic component that can be placed on top of content on the screen while ModalBottomSheet is a layout that wraps around all the screen content and places accordingly. BottomDrawer is much more of a splashable component in M2 and asking users to migrate BottomDrawer uses may be cumbersome.
nu...@nurenyx.ai
Ok, sounds good. I'm happy to keep it if you think it brings value to m2 users.
If we are not removing it, we need to make it stable in this case.
mg...@gmail.com
Found some outstanding bugs I will look into before deciding to promote, especially the swipeable migrations which will likely update the API
he...@gmail.com
Given the planned work to migrate the swipeable logic of bottomdrawer, this API should remain experimental. Closing for now.
nu...@nurenyx.ai
If these are still experimental, please keep this bug open and just target the next release
nu...@nurenyx.ai
Where can i find the respective hotlist for the next release?
ga...@google.com
Fwiw the major difference between modal sheets and bottom drawer is that the drawer can be opened by swiping on the full container. If we don't intend to introduce a bottom drawer in M3, maybe we can explore how to adapt the ModalBottomSheet API for this feature in the future.
nu...@nurenyx.ai
Bumping to P1 as it is been a long while since we need to land this.
lu...@old.stilingue.com.br
This is an out-of-SLO bug that is assigned to me. Moving to Matvei to ensure that it is looked at.
nu...@nurenyx.ai
Jossi is on it already.
ga...@google.com
Branch: androidx-main
commit 63b8ceee3645b3d78a2c372f01390937bf14c8bd
Author: Jossi Wolf <jossiwolf@google.com>
Date: Wed Nov 29 15:17:04 2023
[M2] Stabilize BottomDrawer
Relnote: BottomDrawer has been promoted from experimental to stable. BottomDrawerState now exposes the progress as a function, allowing to query progress between specific targets. BottomDrawerState now allows customizing the animation spec, and confirmStateChange is not a trailing lambda anymore.
Fixes: 261423850
Test: Existing tests, bottomDrawer_progress
Change-Id: I9c029340ea69a755ad0cd8f46b8fcdc76422c41c
M compose/material/material/api/current.txt
M compose/material/material/api/restricted_current.txt
M compose/material/material/src/androidInstrumentedTest/kotlin/androidx/compose/material/DrawerTest.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/Drawer.kt
lu...@old.stilingue.com.br
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.compose.material:material:1.7.0-alpha03androidx.compose.material:material-android:1.7.0-alpha03androidx.compose.material:material-desktop:1.7.0-alpha03
ga...@google.com
The Engineering Team is already aware of your feedback, please expect updates in this case.
Thanks.
ca...@lendlease.cloud
I just want to add my voice to the concerns raised here. The "--no-launch-browser" switch is a really useful feature and removing it will add extra steps to my development workflow. It was mentioned above that the change is being made to improve security, but it is not clear how that is the case. If we can just leave the "--no-launch-browser" in place or get a better understanding of how removing this improves security, it would be appreciated.
For context: I run a container "
Thanks,
se...@sap.com
ja...@simpli.fi
gl...@zoominfo.com
ch...@gmail.com
ca...@lendlease.cloud
- the "--no-launch-browser" switch no longer gives a deprecation warning and continues to work the way it always did. That's awesome - much appreciated to the Google devs!
So anyone using the "--no-browser" switch, just change to "--no-launch-browser" and you should be good to go AFAIK.
dg...@atb.com
Is there another issue that I can reference to track which version had it addressed?
va...@google.com
su...@google.com
Hello,
Thank you for your cooperation.
This functionality is added to the CLI. For more context you can follow
Thank you for your trust and continued support to improve Google Cloud Platform products.
Description
Prior to Google Cloud CLI 377.0.0, running this command without an available browser resulted in a cut-and-pastable URL:
gcloud auth login
Something like this:
Go to the following link in your browser:
Enter verification code: <REDACTED>
Now, it returns this instead:
You are authorizing gcloud CLI without access to a web browser. Please run the following command on a machine with a web browser and copy its output back here. Make sure the installed gcloud version is 372.0.0 or newer.
gcloud auth login --remote-bootstrap="
Documentation [
Current workaround is to use gcloud auth login --no-launch-browser, this will result in the expected behavior. However, this flag is deprecate and will be removed in v383.0.0
Steps to reproduce:
Log in to a machine with no web browser, and be sure $DISPLAY env is not set
Ensure gcloud version is 377.0.0
run gcloud auth login
Note the output requires the command to be run on another machine with a browser
run gcloud auth login --no-browser
Note the output matches the command without the --no-browser flag
run gcloud auth login --no-launch-browser
Note the output is as expected.