Ensure visible entries is populated correctly [225394514]

Fixed

Bug

Status Update

No update yet.

Description

jb...@google.com

created issue #1

Mar 18, 2022 08:35PM

The visibleEntries stateFlow that is currently offered as an experimental API on NavController is populated based on the current lifecycle state of the entry. This means that it considers the hostLifecycleState of the entry when determining whether entries should be part of the list.

Because of this, when the navController is first created, depending on the lifecycle state when you call setGraph, it is possible for the visibleEntries to be empty until after the first navigate call. Also, if the hostLifecycle state is forced down, as in the case of using nested NavHost with different NavControllers in navigation-compose, entries are immediately removed from the list of visible entries although they might still be visible because of animations.

We should visible visible entries so that is always contains any entry that actually should be considered visible.

Comments

ap...@google.com <ap...@google.com> #2Mar 28, 2022 10:00PM

Putting this into scaffold makes it work. See b/268432129 with another issue (scaffold is there).

ap...@google.com <ap...@google.com> #3Mar 28, 2022 10:00PM

Project: platform/frameworks/support
Branch: androidx-main

commit 46eea23c96f45f0ee1e57d8aef2f1375507b0dec
Author: José Figueroa Santos <serniebanders@google.com>
Date: Tue Apr 11 14:38:58 2023

[M3][ModalBottomSheet] Enable edge to edge functionality for ModalBottomSheet

Bug: 274872542
Bug: 272973615
Bug: 272334475
Bug: 268432129
Bug: 275849044
Bug: 275486106
Bug: 268433162
RelNote: Add window insets parameter to ModalBottomSheet.
RelNote: Scrim for ModalBottomSheet may now be drawn behind status bar with windowInsets set to zero
RelNote: Updated default ModalBottomSheet functionality to stay outside of system bars including navigation
RelNote: Status bar inset handling is provided by drag handle in edge-to-edge mode.
RelNote: BottomSheetDefaults includes window insets for BottomSheetWindow.
Test: Parameterizes existing tests to work with and without edgeToEdge enabled.
Test: Manual EdgeToEdge testing on various devices and android APIs
Change-Id: I312008e48573ebd21326f77216be0bcd0372aa78

M compose/material3/material3/api/public_plus_experimental_current.txt
M compose/material3/material3/samples/src/main/java/androidx/compose/material3/samples/BottomSheetSamples.kt
M compose/material3/material3/src/androidAndroidTest/kotlin/androidx/compose/material3/ModalBottomSheetTest.kt
M compose/material3/material3/src/androidMain/kotlin/androidx/compose/material3/ModalBottomSheet.android.kt
M compose/material3/material3/src/androidMain/kotlin/androidx/compose/material3/Strings.android.kt
M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/SheetDefaults.kt

https://android-review.googlesource.com/2531428

ap...@google.com <ap...@google.com> #4Mar 29, 2022 06:02PM

New windows drawn by AbstractComposeView such as popups, dialogs, and ModalBottomSheet do not inherit insets provided when fitSystemWindows=false. The following change once landed provides a windowInsets param which can be set to 0 to provide an edge-to-edge experience, or other windowInsetPaddings.

jb...@google.com <jb...@google.com> #5Mar 29, 2022 09:38PM

Marked as fixed.

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.compose.material3:material3:1.2.0-alpha02
androidx.compose.material3:material3-android:1.2.0-alpha02

Issue 225394514

Description

Issue summary

Comments

ap...@google.com <ap...@google.com> #2Mar 28, 2022 10:00PM

ap...@google.com <ap...@google.com> #3Mar 28, 2022 10:00PM

ap...@google.com <ap...@google.com> #4Mar 29, 2022 06:02PM

jb...@google.com <jb...@google.com> #5Mar 29, 2022 09:38PM

Add comment

Issue metadata