ScrollableTabRow - Allow for customizing minTabWidth and add separate property for tabPadding [226665301]

Fixed

Feature Request

Status Update

No update yet.

Description

mc...@gmail.com

created issue #1

Mar 28, 2022 04:11PM

Jetpack Compose version: 1.2.0-alpha06 Jetpack Compose component used: ScrollableTabRow Android Studio Build: Android Studio Bumblebee | 2021.1.1 Patch 2 Build #AI-211.7628.21.2111.8193401 Kotlin version: 1.6.10

Our design system requires custom tab padding between tabs and for the tab minimum width to be customized. Within the ScrollableTabRow, every tab has a constraint around a hard-coded minimum tab width, which disallows us from using the standard ScrollableTabRow composable.

See the line:

val minTabWidth = ScrollableTabRowMinimumTabWidth.roundToPx()

I'm proposing that minTabWidth either be provided as an optional parameter on the ScrollableTabRow composable with an ability to not have a constraint set or that it hooks into the modifier.

I'm also proposing that we have a separate, new tabPadding parameter so that we can customize the left and right padding of the view that is composed for the Tab. Currently, this is being created by the ScrollableTabRow for us and there is no way for us to customize it. It would be beneficial to allow developers to customize this.

Comments

re...@lunabee.com <re...@lunabee.com> #2Sep 2, 2022 09:40AM

AGP should migrate to the new API in KGP that allows lazy compiler plugin options specification. Since KGP 1.7.0 there is an API that can be used.

cl...@gmail.com <cl...@gmail.com> #3Oct 23, 2023 07:45AM

This issue will be fixed in AGP 7.4.0-beta03 and 8.0.0-alpha03.

Change: https://android.googlesource.com/platform/tools/base/+/b0f0b8c1de84edb328ae3a31769fa349e04e2be3

an...@gmail.com <an...@gmail.com> #4Apr 13, 2024 06:27AM

can I help resolve this issue?

sa...@persgroep.net <sa...@persgroep.net> #5Jan 15, 2025 12:31PM

Any progress on this?

se...@google.com <se...@google.com> Feb 19, 2025 04:17PM

Accepted by se...@google.com.

ap...@google.com <ap...@google.com> #6Feb 26, 2025 06:33PM

Project: platform/frameworks/support
Branch: androidx-main
Author: Jose Figueroa <serniebanders@google.com>
Link: https://android-review.googlesource.com/3501214

[Tabs] Expose minimum scrollable tab width and remove experimental tags for Primary/Secondary variants

Expand for full commit details

[Tabs] Expose minimum scrollable tab width and remove experimental tags for Primary/Secondary variants 
 
Bug: 226665301 
RelNote: "Scrollable tab row's minimum tab width is now a parameter. Primary and Secondary tab row variants are no longer experimental." 
Test: Update unit test tolerance. Manual testing. 
Change-Id: If6f15c267353bf23a8faaa486bd52ed2a61dd29b

Files:

M compose/material3/material3/api/current.txt
M compose/material3/material3/api/restricted_current.txt
M compose/material3/material3/bcv/native/current.txt
M compose/material3/material3/src/androidInstrumentedTest/kotlin/androidx/compose/material3/TabTest.kt
M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/TabRow.kt

Hash: c1ca7e200b4e3c0ae14d4c59ac954ed1a0fd03f5
Date: Wed Feb 19 11:48:55 2025

se...@google.com <se...@google.com> Feb 26, 2025 06:34PM

Marked as fixed.

na...@google.com <na...@google.com> #7Mar 12, 2025 06:13PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.compose.material3:material3:1.4.0-alpha10
androidx.compose.material3:material3-android:1.4.0-alpha10
androidx.compose.material3:material3-jvmstubs:1.4.0-alpha10
androidx.compose.material3:material3-linuxx64stubs:1.4.0-alpha10