ScrollableTabRow - Allow for customizing minTabWidth and add separate property for tabPadding [226665301]

Fixed

Feature Request

Status Update

No update yet.

Description

mc...@gmail.com

created issue #1

Mar 28, 2022 04:11PM

Jetpack Compose version: 1.2.0-alpha06 Jetpack Compose component used: ScrollableTabRow Android Studio Build: Android Studio Bumblebee | 2021.1.1 Patch 2 Build #AI-211.7628.21.2111.8193401 Kotlin version: 1.6.10

Our design system requires custom tab padding between tabs and for the tab minimum width to be customized. Within the ScrollableTabRow, every tab has a constraint around a hard-coded minimum tab width, which disallows us from using the standard ScrollableTabRow composable.

See the line:

val minTabWidth = ScrollableTabRowMinimumTabWidth.roundToPx()

I'm proposing that minTabWidth either be provided as an optional parameter on the ScrollableTabRow composable with an ability to not have a constraint set or that it hooks into the modifier.

I'm also proposing that we have a separate, new tabPadding parameter so that we can customize the left and right padding of the view that is composed for the Tab. Currently, this is being created by the ScrollableTabRow for us and there is no way for us to customize it. It would be beneficial to allow developers to customize this.

Comments

re...@lunabee.com <re...@lunabee.com> #2Sep 2, 2022 09:40AM

Hi,

Thank you for your feedback. Could you help provide logs when the issue occurs and if possible a code snippet of the part that uses CameraX, it will help us find the root cause.

A quick question: does this issue occur on other devices, or only on Samsung Galaxy M55.

cl...@gmail.com <cl...@gmail.com> #3Oct 23, 2023 07:45AM

Hey,
attaching the logs.
The issue is only reproducible of M55. We have not met this on any other.

an...@gmail.com <an...@gmail.com> #4Apr 13, 2024 06:27AM

Thank you,

CameraX uses OpenGL for sharing stream between Preview and VideoCapture to provide use case combinations beyond device's native capabilities. When using Preview + ImageAnalysis or Preview + VideoCapture, the device capabilities are usually not exceeded, so stream sharing is not used. So this could be a device specified issue related to OpenGL.

We will attempt to acquire the reported device model for testing.

sa...@persgroep.net <sa...@persgroep.net> #5Jan 15, 2025 12:31PM

Thanks for the update,
Yes I'm aware that stream sharing is not a hardware supported feature.
Please let me know if we could assist in any way to solve the issue.

se...@google.com <se...@google.com> Feb 19, 2025 04:17PM

Accepted by se...@google.com.

ap...@google.com <ap...@google.com> #6Feb 26, 2025 06:33PM

Hey guys,
Is there any update on this? Were you able to find the phone? Could we assist here somehow?

se...@google.com <se...@google.com> Feb 26, 2025 06:34PM

Marked as fixed.

na...@google.com <na...@google.com> #7Mar 12, 2025 06:13PM

Thank you for your kind reply! I think we will receive the phone in a while and we will update if we find anything.