Fixed
Status Update
Comments
re...@lunabee.com <re...@lunabee.com> #2
Hi all, I've implemented custom navigator to provide with Navigation Shared Elements transition ability https://github.com/lion4ik/aac-navigation-shared-elements-transition
cl...@gmail.com <cl...@gmail.com> #3
Is there any info if it's planned to be implemented?
an...@gmail.com <an...@gmail.com> #4
Support for shared elements for both activities and fragments has been added in https://android-review.googlesource.com/c/platform/frameworks/support/+/752138 through the introduction of a general purpose Navigator.Extras interface, providing a way to send a specific Navigator extra information at runtime (such as the Views you want included in shared element transitions).
This means for activity destinations, you can now provide any ActivityOptionsCompat instance you want alongside your navigate() call. For fragment destinations, you provide a map of shared elements. Documentation will be provided for both of these use cases.
This will be available in 1.0.0-alpha06.
This means for activity destinations, you can now provide any ActivityOptionsCompat instance you want alongside your navigate() call. For fragment destinations, you provide a map of shared elements. Documentation will be provided for both of these use cases.
This will be available in 1.0.0-alpha06.
sa...@persgroep.net <sa...@persgroep.net> #5
Yes, it's worked in 1.0.0-alpha06, but only in forward direction...
Component used: Navigation
Version used: 1.0.0-alpha06
Devices/Android versions reproduced on: All
Fragment one: RecyclerView (GridLayoutManager). Transition name to ImageView is assigned in Adapter from model's name (unique)
Fragment two: Detail Fragment with ImageView and some text data. Transition name retrieved from argument's bundle.
Forward shared transition works excellent, but when I press "back" button there is no transition at all.
In NavHostActivity: override fun onSupportNavigateUp() = findNavController(R.id.nav_host_fragment).navigateUp()
In old paradigm
fragmentManager
.beginTransaction()
.addSharedElement(sharedImageView, transitionName)
all worked fine.
Component used: Navigation
Version used: 1.0.0-alpha06
Devices/Android versions reproduced on: All
Fragment one: RecyclerView (GridLayoutManager). Transition name to ImageView is assigned in Adapter from model's name (unique)
Fragment two: Detail Fragment with ImageView and some text data. Transition name retrieved from argument's bundle.
Forward shared transition works excellent, but when I press "back" button there is no transition at all.
In NavHostActivity: override fun onSupportNavigateUp() = findNavController(R.id.nav_host_fragment).navigateUp()
In old paradigm
fragmentManager
.beginTransaction()
.addSharedElement(sharedImageView, transitionName)
all worked fine.
se...@google.com <se...@google.com>
ap...@google.com <ap...@google.com> #6
se...@google.com <se...@google.com>
na...@google.com <na...@google.com> #7
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.compose.material3:material3:1.4.0-alpha10
androidx.compose.material3:material3-android:1.4.0-alpha10
androidx.compose.material3:material3-jvmstubs:1.4.0-alpha10
androidx.compose.material3:material3-linuxx64stubs:1.4.0-alpha10
Description
Jetpack Compose version: 1.2.0-alpha06 Jetpack Compose component used: ScrollableTabRow Android Studio Build: Android Studio Bumblebee | 2021.1.1 Patch 2 Build #AI-211.7628.21.2111.8193401 Kotlin version: 1.6.10
Our design system requires custom tab padding between tabs and for the tab minimum width to be customized. Within the
ScrollableTabRow
, every tab has a constraint around a hard-coded minimum tab width, which disallows us from using the standardScrollableTabRow
composable.See the line:
I'm proposing that
minTabWidth
either be provided as an optional parameter on theScrollableTabRow
composable with an ability to not have a constraint set or that it hooks into the modifier.I'm also proposing that we have a separate, new
tabPadding
parameter so that we can customize the left and right padding of the view that is composed for the Tab. Currently, this is being created by theScrollableTabRow
for us and there is no way for us to customize it. It would be beneficial to allow developers to customize this.