Status Update
Comments
au...@google.com <au...@google.com> #2
i donnot understand why is the data the same?
sp...@google.com <sp...@google.com> #3
je...@google.com <je...@google.com> #4
What steps are needed to reproduce this issue? Frequency of occurrence?
Which Android build are you using? (e.g. AP4A.241205.013.A1)
Which device did you use to reproduce this issue?
Can you confirm if this issue is reproducible on a Pixel/Nexus device?
Please provide a sample project or apk to reproduce the issue. Also mention the steps to be followed for reproducing the issue with the given sample project or apk.
Android bug report (to be captured after reproducing the issue)
For steps to capture a bug report, please refer:
Alternate method
Navigate to “Developer options”, ensure “USB debugging” is enabled, then enable “Bug report shortcut”. Capture bug report by holding the power button and selecting the “Take bug report” option.
Note: Please upload the bug report and screenshot to google drive and share the folder to android-bugreport@google.com, then share the link here.
sp...@google.com <sp...@google.com> #5
Please provide the requested information to proceed further. Unfortunately the issue will be closed within 7 days if there is no further update.
sp...@google.com <sp...@google.com> #6
for example,we hava 100 users.
20 users returned the same location information, longitude is 121.474000 and latitude is 31.230001。
30 users returned the same location information, longitude is 122.474000 and latitude is 32.230001。
15 users returned the same location information, longitude is 120.474000 and latitude is 30.230001。
as for Android build,all versions have it.
I dont reprodouce this issue.
what may be the cause of this issue?please
da...@google.com <da...@google.com> #7
We have shared this with our product and engineering team and will update this issue with more information as it becomes available.
sp...@google.com <sp...@google.com> #8
Thanks for reporting this issue.
COARSE_LOCATION typically takes location information from the nearby cell tower. If many users are near the same cell tower, each of those users will be given the same position. Using a FINE position will give much more detailed information.
Also, in certain areas, for privacy reasons, a less-exact location will be given, and that less-exact location might be identical for many users. Again, a fine-location configuration will return more precise location data.
da...@google.com <da...@google.com> #9
We believe with reference to the above comment, your query has been answered, hence closing the bug. Please feel free to re-open the issue in the future if desired.
em...@google.com <em...@google.com> #10
sp...@google.com <sp...@google.com> #11
Thanks, Emre!
Based on #10, it seems AGP's current behavior makes sense.
Regardless of whether we keep or change the default behavior, it makes sense to me to add an API to either (1) enable/disable stripping per variant / component or (2) set the "local strip mode" per variant / component.
sp...@google.com <sp...@google.com> #13
This was discussed at the AGP API meeting on Feb 1. There was no consensus about the API, but there was consensus that AS should support debugging, whether the android test APK is stripped or not.
With that in mind, I wrote
As it turns out, all of the following cases of debugging android tests are already broken, regardless of whether the test APK native libraries are stripped:
- Error when trying to debug android test of library from ASIssue 268213434 - connected test fails if androidTestImplementation dependency on android native libraryIssue 268083076 - Unable to debug androidTest-specific native codeIssue 268223043
The good news is that we can merge
au...@google.com <au...@google.com> #14
Any updates here? Could we make progress on this? We still have massively large APKs due to not doing any stripping on camke made binaries
sp...@google.com <sp...@google.com> #15
A fix on the AGP side is here:
Emre, now that
em...@google.com <em...@google.com> #16
After the change I did in app.androidTest
module or the app.main
module (as opposed to the app
holder module), and propagate that throughout the native debugger in Android Studio.
However, when we get the module dependencies to collect symbols in app.main
module.
There can be other places where we call facet.getMainModule()
which we might need to update.
Before looking into this, it would be nice to create a simple test app that demonstrates the problem.
au...@google.com <au...@google.com> #17
androidx-main has several projects that hit this, you can just look for cmake usage in build.gradle files.
sp...@google.com <sp...@google.com> #18
Before looking into this, it would be nice to create a simple test app that demonstrates the problem.
Would it make sense to go ahead and merge
em...@google.com <em...@google.com> #19
The test app from
A more complex test app would have:
- An 'app' module with native code.
- A 'lib' module with native code.
- An app-to-lib
androidTestImplementation
dependency.
And, test cases:
- Run instrumented test of 'app' module, verify:
a. hit native breakpoints in 'app' module
b. hit native breakpoints in 'lib' module - Run instrumented test of 'lib' module, verify:
a. hit native breakpoints in 'lib' module.
Current Status (studio-main, around Hedgehog canary 3):
- The following tests pass: 1(a), 2(a)
- The following tests fail: 1(b)
I prepared ag/23066587, which also makes 1(b) pass. I need to add some integration tests to that change.
spollom@ Feel free to submit your ag/21235820.
sp...@google.com <sp...@google.com> #20
Thanks, Emre!
sp...@google.com <sp...@google.com> #21
spollom@ Feel free to submit your ag/21235820.
Just merged it.
em...@google.com <em...@google.com> #22
I just merged ag/23066587, which should fix the debugger for 1(b) in comment19. Adding integration tests is still WIP, it's done but is flaky due to some unexpected resource leaks.
au...@google.com <au...@google.com> #23
Is it too risky to cp this to 8.1.0?
sp...@google.com <sp...@google.com> #24
hs...@gmail.com <hs...@gmail.com> #26
Could someone share in which version of AGP this issue is (planned to be) fixed?
em...@google.com <em...@google.com> #27
The fix is in 8.2.0 and newer. It's currently in beta, but a stable version will be available soon.
Description
Currently,
AndroidTest.packaging.jniLibs.keepDebugSymbols
has no effect on native library stripping in androidTest APKs... native libraries are packaged unstripped regardless.Proposal: For androidTest APKs, AGP should continue to package unstripped native libraries by default, but ifAndroidTest.packaging.jniLibs.keepDebugSymbols
contains any patterns, only the matching native libraries should be packaged unstripped.See Issue 228627720 for context.
Edit: See #3 for new proposal.