Fixed

Bug

Status Update

No update yet.

Description

py...@gmail.com

created issue #1

Apr 12, 2022 09:54PM

Answers for bug triage

Are you an Android developer? YES
Which Android Developer Preview build are you using? sdk_gphone64_arm64-userdebug Tiramisu TPP2.220218.008 8250781 dev-keys
Is this a regression from Android 12? YES
What device are you using? Android Emulator
What are the steps to reproduce the problem? Enable LeakCanary, start then destroy an activity (e.g. press back). Do this a bunch of times, until LeakCanary shows you a leak.
Issue Category: Framework (platform)

What's going on

WindowOnBackInvokedDispatcher$OnBackInvokedCallbackWrapper stub instances are held in memory by native refs (as is normal with any IPC call). The IPC call in question is IWindowSession.setOnBackInvokedCallback(). WindowOnBackInvokedDispatcher$OnBackInvokedCallbackWrapper.mCallback is therefore also held in memory, and it references a ViewRootImpl anonymous impl of that callback, therefore leaking the entire view hierarchy long after the view root was detached.

Leak trace

┬───
│ GC Root: Global variable in native code
│
├─ android.window.WindowOnBackInvokedDispatcher$OnBackInvokedCallbackWrapper instance
│    Leaking: UNKNOWN
│    Retaining 481.7 kB in 927 objects
│    ↓ WindowOnBackInvokedDispatcher$OnBackInvokedCallbackWrapper.mCallback
│                                                                 ~~~~~~~~~
├─ android.view.ViewRootImpl$7 instance
│    Leaking: UNKNOWN
│    Retaining 480.9 kB in 920 objects
│    Anonymous class implementing android.view.OnBackInvokedCallback
│    ↓ ViewRootImpl$7.this$0
│                     ~~~~~~
├─ android.view.ViewRootImpl instance
│    Leaking: YES (ViewRootImpl#mView is null)
│    Retaining 480.9 kB in 919 objects
│    mContext instance of android.view.ContextThemeWrapper, wrapping activity com.squareup.ui.main.MainActivity with mDestroyed = false
│    mWindowAttributes.mTitle = "com.squareup.invoicesapp.eng/com.squareup.ui.main.MainActivity"
│    mWindowAttributes.type = 2
│    ↓ ViewRootImpl.mFallbackEventHandler
├─ com.android.internal.policy.PhoneFallbackEventHandler instance
│    Leaking: YES (ViewRootImpl↑ is leaking)
│    Retaining 464.7 kB in 527 objects
│    mContext instance of android.view.ContextThemeWrapper, wrapping activity com.squareup.ui.main.MainActivity with mDestroyed = false
│    ↓ PhoneFallbackEventHandler.mView
╰→ com.android.internal.policy.DecorView instance
     Leaking: YES (ObjectWatcher was watching this because com.android.internal.policy.DecorView received View#onDetachedFromWindow() callback)
     Retaining 464.7 kB in 526 objects
     key = 5fc8110b-b762-4970-9242-bd2bafd0cced
     watchDurationMillis = 16234
     retainedDurationMillis = 11233
     View not part of a window view hierarchy
     View.mAttachInfo is null (view detached)
     View.mWindowAttachCount = 1
     mContext instance of android.view.ContextThemeWrapper, wrapping activity com.squareup.ui.main.MainActivity with mDestroyed = false

Heap Dump

Heap dump uploaded to drive (access limited to android-bugreport@google.com): https://drive.google.com/file/d/1q4DloxTA32UmNeMwEKW2I62VDHbBl-uk/view?usp=sharing

Fix

The fix is most likely to set OnBackInvokedCallbackWrapper.mCallback to null on unregister.

Twitter thread

Come say hi! https://twitter.com/Piwai/status/1513977972293730304

Comments

au...@google.com <au...@google.com> #2Apr 13, 2022 03:43AM

Assigned to ca...@google.com.

You need to temporarily add following to your build.gradle:

tasks.withType(KotlinCompile).configureEach {
    kotlinOptions {
        freeCompilerArgs += [
                "-Xjvm-default=all",
        ]
    }
}

Note that in certain circumstances you may want to use all-compatibility instead of all, learn more about that in Jebrain's blogpost.

Starting with kotlin 1.6.20 you won't need touch build.gradle for more information see KT-47000

ca...@google.com <ca...@google.com> #3Apr 13, 2022 08:40AM

Which of the build.gradle files am I to add the code above as there are 2 build.gradle files

py...@gmail.com <py...@gmail.com> #4Apr 14, 2022 06:10AM

en el Module.

ca...@google.com <ca...@google.com> #5Apr 14, 2022 07:13AM

I have tried adding the code in various places in my Module level build.gradle but keep receiving the error

Caused by: groovy.lang.MissingPropertyException: Could not get unknown property 'KotlinCompile' for extension 'android' of type com.android.build.gradle.internal.dsl.BaseAppModuleExtension.
	at org.gradle.internal.metaobject.AbstractDynamicObject.getMissingProperty(AbstractDynamicObject.java:85)
	at org.gradle.internal.metaobject.ConfigureDelegate.getProperty(ConfigureDelegate.java:130)

Can you please provide a more detailed example of how to use the temporary code within a Module level build.gradle file?

ca...@google.com <ca...@google.com> #6Apr 14, 2022 07:14AM

Marked as fixed.

This is what worked for me. Try adding the code to app level build.gradle file:

android {
   ...
   kotlinOptions {
       ...
       freeCompilerArgs += [
                "-Xjvm-default=all",
        ]
   }
}

py...@gmail.com <py...@gmail.com> #7Apr 14, 2022 06:12PM

deleted

IssueTracker

WindowOnBackInvokedDispatcher$OnBackInvokedCallbackWrapper stub leaks detached ViewRootImpl

Status Update

Description

Answers for bug triage

What's going on

Leak trace

Heap Dump

Fix

Twitter thread

Comments

au...@google.com <au...@google.com> #2Apr 13, 2022 03:43AM

ca...@google.com <ca...@google.com> #3Apr 13, 2022 08:40AM

py...@gmail.com <py...@gmail.com> #4Apr 14, 2022 06:10AM

ca...@google.com <ca...@google.com> #5Apr 14, 2022 07:13AM

ca...@google.com <ca...@google.com> #6Apr 14, 2022 07:14AM

py...@gmail.com <py...@gmail.com> #7Apr 14, 2022 06:12PM

Issue 229007483

Description

Answers for bug triage

What's going on

Leak trace

Heap Dump

Fix

Twitter thread

Issue summary

Comments

au...@google.com <au...@google.com> #2Apr 13, 2022 03:43AM

ca...@google.com <ca...@google.com> #3Apr 13, 2022 08:40AM

py...@gmail.com <py...@gmail.com> #4Apr 14, 2022 06:10AM

ca...@google.com <ca...@google.com> #5Apr 14, 2022 07:13AM

ca...@google.com <ca...@google.com> #6Apr 14, 2022 07:14AM

py...@gmail.com <py...@gmail.com> #7Apr 14, 2022 06:12PM

Add comment

Issue metadata