Status Update
Comments
an...@google.com <an...@google.com>
mo...@google.com <mo...@google.com> #2
Branch: androidx-main
commit 392d5beb3bb6f5b82439fe53986c3c818aef5075
Author: Nader Jawad <njawad@google.com>
Date: Thu Apr 11 14:05:41 2024
Updated GraphicsLayer outline APIs to consume floats.
Relnote: "Updated GraphicsLayer outline APIs to consume float
parameters instead of int.
Removed UnsetOffset/UnsetSize IntSize sentinel values in favor
of already exising Unspecified constants on float based Offset
and Size inline classes"
Fixes: 333863462
Test: Re-ran graphicsLayer tests
Change-Id: I2fb03296a009ad4957a59905b97b6f21355cb8ba
M compose/ui/ui-graphics/api/current.txt
M compose/ui/ui-graphics/api/restricted_current.txt
M compose/ui/ui-graphics/samples/src/main/java/androidx/compose/ui/graphics/samples/GraphicsLayerSamples.kt
M compose/ui/ui-graphics/src/androidInstrumentedTest/kotlin/androidx/compose/ui/graphics/layer/AndroidGraphicsLayerTest.kt
M compose/ui/ui-graphics/src/androidMain/kotlin/androidx/compose/ui/graphics/layer/AndroidGraphicsLayer.android.kt
M compose/ui/ui-graphics/src/commonMain/kotlin/androidx/compose/ui/graphics/layer/GraphicsLayer.kt
M compose/ui/ui-graphics/src/desktopMain/kotlin/androidx/compose/ui/graphics/layer/GraphicsLayer.desktop.kt
M compose/ui/ui-graphics/src/desktopTest/kotlin/androidx/compose/ui/graphics/layer/DesktopGraphicsLayerTest.kt
va...@google.com <va...@google.com> #3
An equivalent feature request on the accompanist side is
This is also heavily related to Window
instance, since there is a separate Window
within Dialog
. Current accompanist/systemuicontroller
logic looks like
@Composable
fun rememberSystemUiController(
window: Window? = findWindow(),
): SystemUiController { /* ... */ }
@Composable
private fun findWindow(): Window? =
(LocalView.current.parent as? DialogWindowProvider)?.window
?: LocalView.current.context.findWindow()
private tailrec fun Context.findWindow(): Window? =
when (this) {
is Activity -> window
is ContextWrapper -> baseContext.findWindow()
else -> null
}
mo...@google.com <mo...@google.com> #4
I haven't been able to make this work on R and below. Alex, do you know if this is just my problem or if it is a known issue?
va...@google.com <va...@google.com> #5
I think the soft input mode also needs to be adjustResize
due to IME compatability.
So in addition to calling WindowCompat.setDecorFitsSystemWindows(window, false)
on the Dialog
's Window
, you also need to call window.setSoftInputMode(WindowManager.LayoutParams.SOFT_INPUT_ADJUST_RESIZE)
on the Dialog
's Window
.
ap...@google.com <ap...@google.com> #6
Branch: androidx-main
commit 6148d601d58a8529e532cfc00602173570d352fc
Author: George Mount <mount@google.com>
Date: Wed Jul 20 11:45:05 2022
Support WindowInsets in Dialogs
Fixes: 229378542
Dialogs were not supporting WindowInsets.
Relnote: "Added DialogProperties.decorFitsSystemWindows property
to allow Dialogs to support WindowInsets."
Test: new test, manual tests
Change-Id: I577429919e87610107d6fd476538d8904866b5ce
A compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/window/ActivityWithInsets.kt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/window/AndroidDialog.android.kt
M compose/ui/ui/src/androidAndroidTest/AndroidManifest.xml
A compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/window/DialogWithInsetsTest.kt
M compose/ui/ui/src/androidMain/res/values/styles.xml
M compose/ui/ui/api/public_plus_experimental_current.txt
rh...@gmail.com <rh...@gmail.com> #7
ha...@ziprecruiter.com <ha...@ziprecruiter.com> #8
"I need to add the ability for a Dialog to setDecorFitsSystemWindows(false)"
can this be added for the popup composable as well please?
I'd like to get the ime height using it and don't want to set that to false on my fragment as it'll cause so many other issues and adjustments i'd need to make
if you have any advice there for me i'd take it
mo...@google.com <mo...@google.com> #9
WindowInsetsCompat
can give you the IME height if you aren't in compose. WindowInsets.ime
can give you the IME height if you're using compose. I don't normally recommend accessing the IME's size during composition because the IME size changes after composition, but before layout, so if the IME changes size, it will only be available in composition on the following frame.
Description
Jetpack Compose version: 1.2.0-alpha07
Below code should align
TextField
in the center of space left after keyboard appearance(when it's on the screen)On API 32 Emulator sometimes it works fine, and sometimes it doesn't - I wasn't being able to figure out the difference. On API 27 Emulator it never works -
imePadding
is ignored. Works fine outside of theDialog
Accompanist version of
imePadding
works fine on both devices.