Fixed
Status Update
No update yet.
Comments
so...@google.com
Thank you for the quick fix.
Is there an ETA for the next release?
Is there an ETA for the next release?
se...@google.com
2.2.0-rc01 should be out this week.
se...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit a1957df3709a06f4e6482fb0e4d39ded4f230a70
Author: Rahul Ravikumar <rahulrav@google.com>
Date: Mon Jul 29 09:48:05 2019
Workaround NPE in PersistableBundle.getExtras().
Test: Existing unit tests pass. Ran integration test app.
Fixes:
Change-Id: I0b48e0009a7d83c343a3d26112b94c057470c281
M work/workmanager/src/main/java/androidx/work/impl/background/systemjob/SystemJobService.java
https://android-review.googlesource.com/1092870
https://goto.google.com/android-sha1/a1957df3709a06f4e6482fb0e4d39ded4f230a70
Branch: androidx-master-dev
commit a1957df3709a06f4e6482fb0e4d39ded4f230a70
Author: Rahul Ravikumar <rahulrav@google.com>
Date: Mon Jul 29 09:48:05 2019
Workaround NPE in PersistableBundle.getExtras().
Test: Existing unit tests pass. Ran integration test app.
Fixes:
Change-Id: I0b48e0009a7d83c343a3d26112b94c057470c281
M work/workmanager/src/main/java/androidx/work/impl/background/systemjob/SystemJobService.java
se...@google.com
bu...@google.com
Hi. I've received your bug and will wait until https://android-review.googlesource.com/2153805 is closed and then unCc myself.
bu...@google.com
Hi. I've received your bug and will wait until https://android-review.googlesource.com/2153805 is closed and then assign the bug to seanmcq@google.com and unCc myself.
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit 15ef5cb171dd7b91555fda17a41a12029b60f320
Author: Sean McQuillan <seanmcq@google.com>
Date: Thu Jul 14 16:11:33 2022
Draw background in EmojiSpan
TextLine draws ReplacementSpans prior to configuring BackgroundSpans,
in a separate for loop. As a result, replacement spans don't honor surrounding
backgrounds.
Change EmojiSpan to apply background itself, as if TextLayout had correctly
rastered behind the replacement span or updated the TextPaint with bgColor.
Test: ./gradlew :e2:e2:cAT
Bug:
Relnote: "Emoji2 will now correctly draw backgrounds from BackgroundSpan."
Change-Id: Ide6a8542179a2676cefc16dcf3f3d43e6f376de6
M emoji2/emoji2/src/androidTest/java/androidx/emoji2/text/EmojiSpanTest.java
M samples/SupportEmojiDemos/src/main/java/com/example/android/support/text/emoji/MainFragment.java
M emoji2/emoji2/src/main/java/androidx/emoji2/text/TypefaceEmojiSpan.java
M samples/SupportEmojiDemos/src/main/java/com/example/android/support/text/emoji/ConfigLayout.java
https://android-review.googlesource.com/2153805
Branch: androidx-main
commit 15ef5cb171dd7b91555fda17a41a12029b60f320
Author: Sean McQuillan <seanmcq@google.com>
Date: Thu Jul 14 16:11:33 2022
Draw background in EmojiSpan
TextLine draws ReplacementSpans prior to configuring BackgroundSpans,
in a separate for loop. As a result, replacement spans don't honor surrounding
backgrounds.
Change EmojiSpan to apply background itself, as if TextLayout had correctly
rastered behind the replacement span or updated the TextPaint with bgColor.
Test: ./gradlew :e2:e2:cAT
Bug:
Relnote: "Emoji2 will now correctly draw backgrounds from BackgroundSpan."
Change-Id: Ide6a8542179a2676cefc16dcf3f3d43e6f376de6
M emoji2/emoji2/src/androidTest/java/androidx/emoji2/text/EmojiSpanTest.java
M samples/SupportEmojiDemos/src/main/java/com/example/android/support/text/emoji/MainFragment.java
M emoji2/emoji2/src/main/java/androidx/emoji2/text/TypefaceEmojiSpan.java
M samples/SupportEmojiDemos/src/main/java/com/example/android/support/text/emoji/ConfigLayout.java
se...@google.com
na...@google.com
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.emoji2:emoji2:1.3.0-alpha01
Description
Version used:
Devices/Android versions reproduced on:
If this is a bug in the library, we would appreciate if you could attach:
- Sample project to trigger the issue.
- A screenrecord or screenshots showing the issue (if UI related).
SpannableString name = new SpannableString("Test š«š«š« emoji");
name.setSpan(new BackgroundColorSpan(Color.RED), 0, name.length(), Spannable.SPAN_EXCLUSIVE_EXCLUSIVE);
Textview tv = findViewbyId(R.id.text)
tv.setText(name);