Status Update
Comments
wh...@gmail.com <wh...@gmail.com> #2
Branch: main
commit 2d2a166471b7a50f374167b625f18d8e39080f06
Author: Søren Gjesse <sgjesse@google.com>
Date: Mon Apr 19 12:53:20 2021
Backport android.util.SparseArray#set
For Android S android.util.SparseArray#set was added as an alias for
android.util.SparseArray#put.
Bug: 185547135
Change-Id: I6b3558921a14fc3e0ac7766db8c6b6e614d0c236
M src/main/java/com/android/tools/r8/graph/DexItemFactory.java
M src/main/java/com/android/tools/r8/ir/desugar/BackportedMethodRewriter.java
A src/main/java/com/android/tools/r8/ir/desugar/backports/SparseArrayMethodRewrites.java
M src/test/java/com/android/tools/r8/desugar/backports/AbstractBackportTest.java
A src/test/java/com/android/tools/r8/desugar/backports/SparseArrayBackportTest.java
ba...@google.com <ba...@google.com>
ba...@google.com <ba...@google.com> #3
Just did a sanity check with Android Studio compiling the following code:
val sa = SparseArray<String>(1)
sa[0] = "Hello, world!"
println("Value is ${sa[0]}")
Using compileSdkVersion "android-S"
with this change:
invoke-virtual {v5, v4, v3}, Landroid/util/SparseArray;->put(ILjava/lang/Object;)V
Using compileSdkVersion "android-S"
without this change:
invoke-virtual {v5, v4, v3}, Landroid/util/SparseArray;->set(ILjava/lang/Object;)V
Using import androidx.core.util.set
with either compileSdkVersion "android-S"
or compileSdkVersion 30
:
invoke-virtual {v5, v4, v3}, Landroid/util/SparseArray;->put(ILjava/lang/Object;)V
With compileSdkVersion "android-S"
import androidx.core.util.set
is also marked as unused import.
wh...@gmail.com <wh...@gmail.com> #4
Hi Googler,
Does this fix apply to the unit test build?
When I build and run my App on a device with API level 25, it works properly.
But my test fails by NoSuchMethedError
.
'void android.util.SparseArray.set(int, java.lang.Object)'
java.lang.NoSuchMethodError: 'void android.util.SparseArray.set(int, java.lang.Object)'
The attached is a sample project.
If you run the test SparseArrayIssueTest#addItemWithSet
, you will find this error.
Could you have a look? Thank you.
wh...@gmail.com <wh...@gmail.com> #5
Units tests running via Robolectric will not get the backport rewrite from set
method is not rewritten to put
.
The good news is that Android S support is landing in Robolectric, so if you update the dependency to
testImplementation 'org.robolectric:robolectric:4.7-alpha-2'
and also add the following to the app build.gradle
(see
android {
testOptions {
unitTests.includeAndroidResources true
}
}
The you can run the test for API level 31, by either annotating the test with @org.robolectric.annotation.Config(sdk = [31])
or setting sdk=31
in robolectric.properties
. Alternatively set targetSdk
to 31
in build.gradle
and then you don't need neither the annotation nor robolectric.properties
as by default Robolectric will run on targetSdk
.
ba...@google.com <ba...@google.com> #6
Opened
jc...@gmail.com <jc...@gmail.com> #7
wh...@gmail.com <wh...@gmail.com> #8
(Note: It is the build when sending this report. For exact build reference, please see the attached bugreport.)
RCS not connected to server: RegistrationState CONFIGURATION_UPDATED, reason UNKNOWNUNKNOWN
Transport: Chat API w/ RCS
ACS url:
PCSCF:
Sub Id: 1
SIM Slot: 1
SIM Carrier: Google Fi
SIM Number: +18034027012
Rcs Apk: cs.apk
Etouffee provisioned: true
Debugging information
Google Play services
com.google.android.gms
Version 222855044 (22.28.55 (190400-462241085))
System App (Updated)
Android System WebView
com.google.android.webview
Version 506012934 (103.0.5060.129)
System App (Updated)
Network operator: Google Fi
SIM operator: Google Fi
Filed by Android Beta Feedback. Version (Updated): 2.27-betterbug.external_20220615_RC01
To learn more about our feedback process, please visit
em...@gmail.com <em...@gmail.com> #9
I had this issue while running Andriod 13 Beta. I am currently running Android version 13 (TP1A.220624.014), and messages version messages.android_20220811_01 _RCO0.phone.op enbeta dynamic. My phone is a Pixel 5 and I am using Google Fi in SIM slot 2.
mi...@gmail.com <mi...@gmail.com> #10
Pixel 5 on Android 13. Chat features will connect on mobile data but stuck on connecting when on wifi.
se...@gmail.com <se...@gmail.com> #11
co...@gmail.com <co...@gmail.com> #12
bb...@gmail.com <bb...@gmail.com> #13
ba...@google.com <ba...@google.com> #14
We are actively working on this issue.
ka...@gmail.com <ka...@gmail.com> #15
dj...@gmail.com <dj...@gmail.com> #16
mo...@gmail.com <mo...@gmail.com> #17
da...@gmail.com <da...@gmail.com> #18
Pixel 6 Pro on Android 13. Chat features will connect on mobile data but stuck on connecting when on wifi. Have a friend with a Pixel 4 XL on Android 13 but his stays connected when getting on my wifi network.
ba...@google.com <ba...@google.com> #19
The issue reported here has been fixed and it will be available in a future release.
Description
(Note: It is the build when sending this report. For exact build reference, please see the attached bugreport.)
What type of Android issue is this? Messaging
When did this happen?
May 23, 2022 11:53 AM GMT-04:00
What steps would let us observe this issue?
1. After leaving WiFi at my home Google messages no longer connects to chat services.
2. States connection pending until I reconnect to WiFi
What did you expect to happen?
Chat services would work
What actually happened?
Never connected
How often has this happened?
Every time
What was the effect of this issue on your device usage, such as lost time or work?
Moderate
Debugging information
Google Play services
com.google.android.gms
Version 221819044 (22.18.19 (190400-449480960))
System App (Updated)
Android System WebView
com.google.android.webview
Version 495151533 (101.0.4951.15)
System App (Updated)
Network operator: Google Fi
SIM operator: Google Fi
Filed by Android Beta Feedback. Version (Updated): 2.25-betterbug.external_20220328_RC02
To learn more about our feedback process, please visit