[Logcat V2] We need better support for values that include spaces [233968698]

Fixed

Bug

No update yet.

ad...@google.com

created issue #1

May 26, 2022 04:21AM

Currently, the user needs to escape spaces (e.g. message:741ms\ so\ far). This isn't really intuitive. Some possible ideas:

Use double quotes " " to wrap entries with spaces (currently doesn’t work)
Hit enter to escape entering a value. That is, after entering a key, user keeps typing until they hit enter, at which point the cursor would move out of the green highlight.

Wed May 25 2022 21:18:27 GMT-0700 (Pacific Daylight Time).png

27 KB

Wed May 25 2022 21:19:31 GMT-0700 (Pacific Daylight Time).png

9.6 KB

Quoting does work but requires a space between the key and the value:

message: "741ms so far"

message: '741ms so far'

I'm going to try to fix but it might not be trivial due to how the Lexer is written.

One option is to change message:"foo bar" to message: "foo bar" before parsing but I'll try a proper fix as well.

I believe I have a proper fix for this.

Marked as fixed, reassigned to aa...@google.com.

Issue 233968698