AGP 7.2 com.android.test module unable to access com.android.app module's test fixture classes [234629577]

Fixed

Bug

Status Update

No update yet.

Description

mc...@ebay.com

created issue #1

Jun 1, 2022 11:09PM

DESCRIBE THE ISSUE IN DETAIL:

Sample project attached.

The issue appears to be that app modules which leverage test fixtures to share code with com.android.test modules fails to be correctly included into the test APK. This causes the com.android.test module tests to crash with NoClassDefFoundErrors.

If the com.android.test module refers to a library module's test fixture then this appears to work ok.

AndroidStudio can see the classes from the app module's test fixture correctly.

This is causing heartache due to AS Chipmunk being based upon a version of IntelliJ that treats source files referenced by more than one project module as an error, causing our previous approach of using manual source set definitions referring to the test fixture source to no longer work well. Thus, we might be stuck on Bumblebee/7.1 until this gets fixed.

STEPS TO REPRODUCE:

Unpack the sample project
run ./gradlew :appTests:connectedCheck
Observe that logcat contains the following error:

06-01 15:52:14.206 24305 24329 I TestRunner: started: appFixture(bug.repro.testfixturerepro.TestModuleTest)
06-01 15:52:14.212 24305 24329 E TestRunner: failed: appFixture(bug.repro.testfixturerepro.TestModuleTest)
06-01 15:52:14.212 24305 24329 E TestRunner: ----- begin exception -----
06-01 15:52:14.217 24305 24329 E TestRunner: java.lang.NoClassDefFoundError: Failed resolution of: Lbug/repro/testfixturerepro/AppTestFixture;
06-01 15:52:14.217 24305 24329 E TestRunner: 	at bug.repro.testfixturerepro.TestModuleTest.appFixture(TestModuleTest.java:10)
06-01 15:52:14.217 24305 24329 E TestRunner: 	at java.lang.reflect.Method.invoke(Native Method)
06-01 15:52:14.217 24305 24329 E TestRunner: 	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)
06-01 15:52:14.217 24305 24329 E TestRunner: 	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
06-01 15:52:14.217 24305 24329 E TestRunner: 	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)
06-01 15:52:14.217 24305 24329 E TestRunner: 	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
06-01 15:52:14.217 24305 24329 E TestRunner: 	at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
06-01 15:52:14.217 24305 24329 E TestRunner: 	at org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100)
06-01 15:52:14.217 24305 24329 E TestRunner: 	at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366)
06-01 15:52:14.217 24305 24329 E TestRunner: 	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103)
06-01 15:52:14.217 24305 24329 E TestRunner: 	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63)
06-01 15:52:14.217 24305 24329 E TestRunner: 	at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)
06-01 15:52:14.217 24305 24329 E TestRunner: 	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)
06-01 15:52:14.217 24305 24329 E TestRunner: 	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)
06-01 15:52:14.217 24305 24329 E TestRunner: 	at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)
06-01 15:52:14.217 24305 24329 E TestRunner: 	at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293)
06-01 15:52:14.217 24305 24329 E TestRunner: 	at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
06-01 15:52:14.217 24305 24329 E TestRunner: 	at org.junit.runners.ParentRunner.run(ParentRunner.java:413)
06-01 15:52:14.217 24305 24329 E TestRunner: 	at org.junit.runners.Suite.runChild(Suite.java:128)
06-01 15:52:14.217 24305 24329 E TestRunner: 	at org.junit.runners.Suite.runChild(Suite.java:27)
06-01 15:52:14.217 24305 24329 E TestRunner: 	at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)
06-01 15:52:14.217 24305 24329 E TestRunner: 	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)
06-01 15:52:14.217 24305 24329 E TestRunner: 	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)
06-01 15:52:14.217 24305 24329 E TestRunner: 	at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)
06-01 15:52:14.217 24305 24329 E TestRunner: 	at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293)
06-01 15:52:14.217 24305 24329 E TestRunner: 	at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
06-01 15:52:14.217 24305 24329 E TestRunner: 	at org.junit.runners.ParentRunner.run(ParentRunner.java:413)
06-01 15:52:14.217 24305 24329 E TestRunner: 	at org.junit.runner.JUnitCore.run(JUnitCore.java:137)
06-01 15:52:14.217 24305 24329 E TestRunner: 	at org.junit.runner.JUnitCore.run(JUnitCore.java:115)
06-01 15:52:14.217 24305 24329 E TestRunner: 	at androidx.test.internal.runner.TestExecutor.execute(TestExecutor.java:56)
06-01 15:52:14.217 24305 24329 E TestRunner: 	at androidx.test.runner.AndroidJUnitRunner.onStart(AndroidJUnitRunner.java:444)
06-01 15:52:14.217 24305 24329 E TestRunner: 	at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:2248)
06-01 15:52:14.217 24305 24329 E TestRunner: Caused by: java.lang.ClassNotFoundException: Didn't find class "bug.repro.testfixturerepro.AppTestFixture" on path: DexPathList[[zip file "/system/framework/android.test.runner.jar", zip file "/system/framework/android.test.mock.jar", zip file "/system/framework/android.test.base.jar", zip file "/data/app/~~DlczcewOeyCvPpX1NvM82A==/bug.repro.testfixturerepro.exttests-rgzMVn5WFKtZtXXkJdDUhA==/base.apk", zip file "/data/app/~~utYPoeAE68PHed57CQyxdA==/bug.repro.testfixturerepro-XWa-cxCF8fB28kD8XmHDWA==/base.apk"],nativeLibraryDirectories=[/data/app/~~DlczcewOeyCvPpX1NvM82A==/bug.repro.testfixturerepro.exttests-rgzMVn5WFKtZtXXkJdDUhA==/lib/arm64, /data/app/~~utYPoeAE68PHed57CQyxdA==/bug.repro.testfixturerepro-XWa-cxCF8fB28kD8XmHDWA==/lib/arm64, /system/lib64, /system_ext/lib64]]
06-01 15:52:14.217 24305 24329 E TestRunner: 	at dalvik.system.BaseDexClassLoader.findClass(BaseDexClassLoader.java:218)
06-01 15:52:14.217 24305 24329 E TestRunner: 	at java.lang.ClassLoader.loadClass(ClassLoader.java:379)
06-01 15:52:14.217 24305 24329 E TestRunner: 	at java.lang.ClassLoader.loadClass(ClassLoader.java:312)
06-01 15:52:14.217 24305 24329 E TestRunner: 	... 32 more
06-01 15:52:14.217 24305 24329 E TestRunner: ----- end exception -----
06-01 15:52:14.232 24305 24329 I TestRunner: finished: appFixture(bug.repro.testfixturerepro.TestModuleTest)

Studio Build: Chipmunk | 2021.2.1 Patch 1 Version of Gradle Plugin: 7.2.1 Version of Gradle: 7.4.2 (repro project uses 7.3.3) Version of Java: 11.0.14 (Azul Systems, Inc. 11.0.14+9-LTS) OS: Mac OS X 12.4 aarch64

TestFixtureRepro.tar.gz

97 KB

Download

Comments

sm...@google.com <sm...@google.com> Jun 2, 2022 07:04AM

Assigned to je...@google.com.

sm...@google.com <sm...@google.com> Jun 2, 2022 05:10PM

Reassigned to je...@google.com.

mc...@ebay.com <mc...@ebay.com> #2Jun 2, 2022 07:26PM

Another thing which may cause issues with testFixtures use in com.android.test modules:

Test fixture configurations by default include a dependency upon the project they are defined in. Although the render doesn't indicate the classifiers, a gradle dependencies dump in the attached project demonstrates this:

+--- project :sampleLib
|    \--- project :sampleLib (*)

In the com.android.test modules this would result in the production code being included (also) in the test implementation dependencies which would cause the production classes to wind up in the test APK. This would result in class duplication which would then cause split- classloader issues during test execution.

If this can't be resolved on the AGP side, the following pattern might suffice as a workaround:

    implementation testFixtures(project(":sampleLib")) {
        exclude module: 'sampleLib'
    }

Mentioning this here because I'm not sure where the line of responsibility would fall in this scenario...

sm...@google.com <sm...@google.com> Jun 3, 2022 03:37PM

Reassigned to am...@google.com.

mc...@ebay.com <mc...@ebay.com> #3Jun 3, 2022 03:45PM

One last addition: Although the repro project doesn't manifest this, our non-reduced project seems to have issues with the com.android.test module seeing dependency library test fixture code as well. i.e., take my library module's test fixture then this appears to work ok with a grain of salt...

am...@google.com <am...@google.com> #4Jun 13, 2022 05:09PM

Marked as fixed.

Thanks for the detailed report. This was happening due to a problem with dependencies subtraction in the test project. Both issues that you've mentioned are now fixed and will land in AGP 7.3 beta 5 and 7.4 alpha 6.

mc...@ebay.com <mc...@ebay.com> #5Jun 14, 2022 04:25PM

Thanks for the update. Is there any hope of getting it back-ported to the 7.2 lineage? We've got some users who are wanting access to the compose updates in AS Chipmunk and this is a blocker for us to get there.

am...@google.com <am...@google.com> #6Jun 20, 2022 04:15PM

Unfortunately it's too late now to have this in a 7.2 batch release. However, 7.3 release candidate should be released within couple of weeks and stabilized within a month.

mc...@ebay.com <mc...@ebay.com> #7Jun 21, 2022 02:40PM

Ok, thanks for the update.

de...@google.com <de...@google.com> #8Jul 7, 2022 11:09PM

Thank you for your patience while our engineering team worked to resolve this issue. A fix for this issue is now available in:

Android Studio Dolphin Beta 5 (2021.3.1.14)
Android Gradle Plugin 7.3.0-beta05

We encourage you to try the latest update.

If you notice further issues or have questions, please file a new bug report.

Thank you for taking the time to submit feedback — we really appreciate it!