Android lint permission check flakily crashing [236262744]

Fixed

Bug

Status Update

No update yet.

Description

au...@google.com

created issue #1

Jun 16, 2022 04:07PM

The new output:
  > Task :support-content-demos:lintReportDebug
  Unexpected failure during lint analysis (this is a bug in lint or one of the libraries it depends on)
  
  Message: lateinit property module has not been initialized
  
  The crash seems to involve the detector `com.android.tools.lint.checks.PermissionErrorDetector`.
  You can try disabling it with something like this:
      android {
          lint {
              disable "CustomPermissionTypo", "KnownPermissionError", "PermissionNamingConvention", "ReservedSystemPermission", "SystemPermissionTypo"
          }
      }
  
  Stack: `UninitializedPropertyAccessException:CliTraceHolder.getModule(CliTrace.kt:25)←CliKotlinAsJavaSupport.findClassOrObjectDeclarations(CliKotlinAsJavaSupport.kt:119)←JavaElementFinder.findClassesAndObjects(JavaElementFinder.kt:62)←JavaElementFinder.findClasses(JavaElementFinder.kt:47)←JavaElementFinder.findClass(JavaElementFinder.kt:36)←JavaPsiFacadeImpl.doFindClass(JavaPsiFacadeImpl.java:91)←JavaPsiFacadeImpl.findClass(JavaPsiFacadeImpl.java:69)←DefaultJavaEvaluator.findClass(DefaultJavaEvaluator.kt:99)←PermissionErrorDetector$Companion.computePlatformPermissions(PermissionErrorDetector.kt:463)←PermissionErrorDetector$Companion.getPlatformPermissions(PermissionErrorDetector.kt:453)←PermissionErrorDetector$Companion.findAlmostPlatformPermission(PermissionErrorDetector.kt:342)←PermissionErrorDetector.reportPermissionUsageIncidents(PermissionErrorDetector.kt:191)←PermissionErrorDetector.checkDocument$reportOrAddPermissionUsages(PermissionErrorDetector.kt:78)←PermissionErrorDetector.checkDocument(PermissionErrorDetector.kt:91)←PermissionErrorDetector.checkMergedProject(PermissionErrorDetector.kt:58)←LintDriver.processMergedProjects(LintDriver.kt:676)←LintCliClient.mergeState(LintCliClient.kt:616)←LintDriver$LintClientWrapper.mergeState(LintDriver.kt:2952)←LintDriver$mergeOnly$1.invoke(LintDriver.kt:483)←LintDriver$mergeOnly$1.invoke(LintDriver.kt:478)←LintDriver.doAnalyze(LintDriver.kt:522)←LintDriver.doAnalyze$default(LintDriver.kt:493)←LintDriver.mergeOnly(LintDriver.kt:478)←LintCliClient$mergeOnly$1.invoke(LintCliClient.kt:262)←LintCliClient$mergeOnly$1.invoke(LintCliClient.kt:260)←LintCliClient.run(LintCliClient.kt:290)←LintCliClient.mergeOnly(LintCliClient.kt:260)←Main.run(Main.java:1677)←Main.run(Main.java:281)←GeneratedMethodAccessor2566.invoke(null:-1)←DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)←Method.invoke(Method.java:566)←AndroidLintWorkAction.invokeLintMainRunMethod(AndroidLintWorkAction.kt:99)←AndroidLintWorkAction.runLint(AndroidLintWorkAction.kt:88)←AndroidLintWorkAction.execute(AndroidLintWorkAction.kt:65)←DefaultWorkerServer.execute(DefaultWorkerServer.java:63)←NoIsolationWorkerFactory$1$1.create(NoIsolationWorkerFactory.java:66)←NoIsolationWorkerFactory$1$1.create(NoIsolationWorkerFactory.java:62)←ClassLoaderUtils.executeInClassloader(ClassLoaderUtils.java:97)←NoIsolationWorkerFactory$1.lambda$execute$0(NoIsolationWorkerFactory.java:62)←AbstractWorker$1.call(AbstractWorker.java:44)←AbstractWorker$1.call(AbstractWorker.java:41)←DefaultBuildOperationRunner$CallableBuildOperationWorker.execute(DefaultBuildOperationRunner.java:204)←DefaultBuildOperationRunner$CallableBuildOperationWorker.execute(DefaultBuildOperationRunner.java:199)←DefaultBuildOperationRunner$2.execute(DefaultBuildOperationRunner.java:66)←DefaultBuildOperationRunner$2.execute(DefaultBuildOperationRunner.java:59)←DefaultBuildOperationRunner.execute(DefaultBuildOperationRunner.java:157)←DefaultBuildOperationRunner.execute(DefaultBuildOperationRunner.java:59)←DefaultBuildOperationRunner.call(DefaultBuildOperationRunner.java:53)←DefaultBuildOperationExecutor.call(DefaultBuildOperationExecutor.java:73)←AbstractWorker.executeWrappedInBuildOperation(AbstractWorker.java:41)←NoIsolationWorkerFactory$1.execute(NoIsolationWorkerFactory.java:59)←DefaultWorkerExecutor.lambda$submitWork$2(DefaultWorkerExecutor.java:205)←FutureTask.run(FutureTask.java:264)←DefaultConditionalExecutionQueue$ExecutionRunner.runExecution(DefaultConditionalExecutionQueue.java:187)←DefaultConditionalExecutionQueue$ExecutionRunner.access$700(DefaultConditionalExecutionQueue.java:120)←DefaultConditionalExecutionQueue$ExecutionRunner$1.run(DefaultConditionalExecutionQueue.java:162)←Factories$1.create(Factories.java:31)←DefaultWorkerLeaseService.withLocks(DefaultWorkerLeaseService.java:249)←DefaultWorkerLeaseService.runAsWorkerThread(DefaultWorkerLeaseService.java:109)←DefaultWorkerLeaseService.runAsWorkerThread(DefaultWorkerLeaseService.java:114)←DefaultConditionalExecutionQueue$ExecutionRunner.runBatch(DefaultConditionalExecutionQueue.java:157)←DefaultConditionalExecutionQueue$ExecutionRunner.run(DefaultConditionalExecutionQueue.java:126)←Executors$RunnableAdapter.call(Executors.java:515)←FutureTask.run(FutureTask.java:264)←ExecutorPolicy$CatchAndRecordFailures.onExecute(ExecutorPolicy.java:64)←ManagedExecutorImpl$1.run(ManagedExecutorImpl.java:48)←ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)←ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)←Thread.run(Thread.java:829)`
  
  > Task :support-content-demos:lintReportDebug
  kotlin.UninitializedPropertyAccessException: lateinit property module has not been initialized
  	at org.jetbrains.kotlin.cli.jvm.compiler.CliTraceHolder.getModule(CliTrace.kt:25)
  	at org.jetbrains.kotlin.cli.jvm.compiler.CliKotlinAsJavaSupport.findClassOrObjectDeclarations(CliKotlinAsJavaSupport.kt:119)
  	at org.jetbrains.kotlin.asJava.finder.JavaElementFinder.findClassesAndObjects(JavaElementFinder.kt:62)
  	at org.jetbrains.kotlin.asJava.finder.JavaElementFinder.findClasses(JavaElementFinder.kt:47)
  	at org.jetbrains.kotlin.asJava.finder.JavaElementFinder.findClass(JavaElementFinder.kt:36)
  	at com.intellij.psi.impl.JavaPsiFacadeImpl.doFindClass(JavaPsiFacadeImpl.java:91)
  	at com.intellij.psi.impl.JavaPsiFacadeImpl.findClass(JavaPsiFacadeImpl.java:69)
  	at com.android.tools.lint.helpers.DefaultJavaEvaluator.findClass(DefaultJavaEvaluator.kt:99)
  	at com.android.tools.lint.checks.PermissionErrorDetector$Companion.computePlatformPermissions(PermissionErrorDetector.kt:463)
  	at com.android.tools.lint.checks.PermissionErrorDetector$Companion.getPlatformPermissions(PermissionErrorDetector.kt:453)
  	at com.android.tools.lint.checks.PermissionErrorDetector$Companion.findAlmostPlatformPermission(PermissionErrorDetector.kt:342)
  	at com.android.tools.lint.checks.PermissionErrorDetector.reportPermissionUsageIncidents(PermissionErrorDetector.kt:191)
  	at com.android.tools.lint.checks.PermissionErrorDetector.checkDocument$reportOrAddPermissionUsages(PermissionErrorDetector.kt:78)
  	at com.android.tools.lint.checks.PermissionErrorDetector.checkDocument(PermissionErrorDetector.kt:91)
  	at com.android.tools.lint.checks.PermissionErrorDetector.checkMergedProject(PermissionErrorDetector.kt:58)
  	at com.android.tools.lint.client.api.LintDriver.processMergedProjects(LintDriver.kt:676)
  	at com.android.tools.lint.LintCliClient.mergeState(LintCliClient.kt:616)
  	at com.android.tools.lint.client.api.LintDriver$LintClientWrapper.mergeState(LintDriver.kt:2952)
  	at com.android.tools.lint.client.api.LintDriver$mergeOnly$1.invoke(LintDriver.kt:483)
  	at com.android.tools.lint.client.api.LintDriver$mergeOnly$1.invoke(LintDriver.kt:478)
  	at com.android.tools.lint.client.api.LintDriver.doAnalyze$default(LintDriver.kt:493)
  	at com.android.tools.lint.client.api.LintDriver.mergeOnly(LintDriver.kt:478)
  	at com.android.tools.lint.LintCliClient$mergeOnly$1.invoke(LintCliClient.kt:262)
  	at com.android.tools.lint.LintCliClient$mergeOnly$1.invoke(LintCliClient.kt:260)
  	at com.android.tools.lint.LintCliClient.mergeOnly(LintCliClient.kt:260)
  kotlin.UninitializedPropertyAccessException: lateinit property module has not been initialized
  	at org.jetbrains.kotlin.cli.jvm.compiler.CliTraceHolder.getModule(CliTrace.kt:25)
  	at org.jetbrains.kotlin.cli.jvm.compiler.CliKotlinAsJavaSupport.findClassOrObjectDeclarations(CliKotlinAsJavaSupport.kt:119)
  	at org.jetbrains.kotlin.asJava.finder.JavaElementFinder.findClassesAndObjects(JavaElementFinder.kt:62)
  	at org.jetbrains.kotlin.asJava.finder.JavaElementFinder.findClasses(JavaElementFinder.kt:47)
  	at org.jetbrains.kotlin.asJava.finder.JavaElementFinder.findClass(JavaElementFinder.kt:36)
  	at com.intellij.psi.impl.JavaPsiFacadeImpl.doFindClass(JavaPsiFacadeImpl.java:91)
  	at com.intellij.psi.impl.JavaPsiFacadeImpl.findClass(JavaPsiFacadeImpl.java:69)
  	at com.android.tools.lint.helpers.DefaultJavaEvaluator.findClass(DefaultJavaEvaluator.kt:99)
  	at com.android.tools.lint.checks.PermissionErrorDetector$Companion.computePlatformPermissions(PermissionErrorDetector.kt:463)
  	at com.android.tools.lint.checks.PermissionErrorDetector$Companion.getPlatformPermissions(PermissionErrorDetector.kt:453)
  	at com.android.tools.lint.checks.PermissionErrorDetector$Companion.findAlmostPlatformPermission(PermissionErrorDetector.kt:342)
  	at com.android.tools.lint.checks.PermissionErrorDetector.reportPermissionUsageIncidents(PermissionErrorDetector.kt:191)
  	at com.android.tools.lint.checks.PermissionErrorDetector.checkDocument$reportOrAddPermissionUsages(PermissionErrorDetector.kt:78)
  	at com.android.tools.lint.checks.PermissionErrorDetector.checkDocument(PermissionErrorDetector.kt:91)
  	at com.android.tools.lint.checks.PermissionErrorDetector.checkMergedProject(PermissionErrorDetector.kt:58)
  	at com.android.tools.lint.client.api.LintDriver.processMergedProjects(LintDriver.kt:676)
  	at com.android.tools.lint.LintCliClient.mergeState(LintCliClient.kt:616)
  	at com.android.tools.lint.client.api.LintDriver$LintClientWrapper.mergeState(LintDriver.kt:2952)
  	at com.android.tools.lint.client.api.LintDriver$mergeOnly$1.invoke(LintDriver.kt:483)
  	at com.android.tools.lint.client.api.LintDriver$mergeOnly$1.invoke(LintDriver.kt:478)
  	at com.android.tools.lint.client.api.LintDriver.doAnalyze$default(LintDriver.kt:493)
  	at com.android.tools.lint.client.api.LintDriver.mergeOnly(LintDriver.kt:478)
  	at com.android.tools.lint.LintCliClient$mergeOnly$1.invoke(LintCliClient.kt:262)
  	at com.android.tools.lint.LintCliClient$mergeOnly$1.invoke(LintCliClient.kt:260)
  	at com.android.tools.lint.LintCliClient.mergeOnly(LintCliClient.kt:260)
  
... 73 lines skipped ...
  If you can fix these messages, do so.

We no longer have empty kotlin files, so it is not b/233355652

Studio Build: n/a
Version of Gradle Plugin: 7.4.0-alpha04
Version of Gradle: 7.5-rc-2
Version of Java: 11
OS: linux

Comments

au...@google.com <au...@google.com> #2Jun 16, 2022 04:20PM

https://ci.android.com/builds/pending/P36373783/androidx_incremental/latest/view/logs/build_error.log

au...@google.com <au...@google.com> #3Jun 16, 2022 04:52PM

It looks like it could be ag/18440844/

ma...@google.com <ma...@google.com> Jun 16, 2022 07:34PM

Assigned to ma...@google.com.

gh...@google.com <gh...@google.com> #4Jun 21, 2022 04:49PM

I guess the problem is near these lines:

val evaluator = project.client.getUastParser(project).evaluator
val manifest = evaluator.findClass("android.Manifest.permission")

I think the problem is that the UAST environment is not really available during the checkMergedProject callback.

These lines do not seem to have test coverage, but you can induce a similar exception more easily by adding the following line at the top of PermissionErrorDetector.checkMergedProject:

context.project.client.getUastParser(context.project).evaluator.findClass("some.class")

and then running PermissionErrorDetectorTest.

ma...@google.com <ma...@google.com> Jun 22, 2022 05:12PM

Accepted by ma...@google.com.

tn...@google.com <tn...@google.com> #5Jun 22, 2022 07:54PM

Reassigned to tn...@google.com.

I'll take a look at this

ma...@google.com <ma...@google.com> #6Jun 30, 2022 08:42PM

Marked as fixed.

Fixed by https://cs.android.com/android-studio/platform/tools/base/+/98bee659f15e078efbc7444eabca81c9656cf058

au...@google.com <au...@google.com> #7Jun 30, 2022 08:44PM

Which version of AGP should the fix come out in?

js...@google.com <js...@google.com> #8Jun 30, 2022 09:12PM

Reassigned to ma...@google.com.

According to go/as-calendar, it's likely AGP 7.4 canary 8 (ETA next Wednesday)

js...@google.com <js...@google.com> #9Jun 30, 2022 09:14PM

https://android-build.googleplex.com/builds/where-is-my-cl/search/I505dffc7aee1d267362fdf72a70f5bf2217f9006

At the bottom, ab/8785673 includes the fix.