Generated code for NavArgs has deprecated usages of Bundle [237725966]

Fixed

Bug

Status Update

No update yet.

Description

al...@gmail.com

created issue #1

Jul 1, 2022 08:07AM

Component used: Navigation

Version used: 2.4.2

Target SDK and Compile SDK version: 33

I would like to report that when building our app that targets API 33, the generated code for destination arguments in Navigation graphs use deprecated usages of Bundle (ie. Bundle.get(String key), Bundle.getParcelableArray(String key)

Here is an example of how the generated code looks like (I modified arg names):

 if (bundle.containsKey("someArg")) {
        __someArg = bundle.getParcelableArray("someArg")?.map { it as ResolveInfo
            }?.toTypedArray()
        if (__someArg == null) {
          throw IllegalArgumentException("Argument \"someArg\" is marked as non-null but was passed a null value.")
        }
      } else {
        throw IllegalArgumentException("Required argument \"someArg\" is missing and does not have an android:defaultValue")
      }

and another:

      if (bundle.containsKey("someOtherArg")) {
        if (Parcelable::class.java.isAssignableFrom(SomeOtherArg::class.java) ||
            Serializable::class.java.isAssignableFrom(SomeOtherArg::class.java)) {
          __someOtherArg = bundle.get("someOtherArg") as SomeOtherArg?
        } else {
          throw UnsupportedOperationException(SomeOtherArg::class.java.name +
              " must implement Parcelable or Serializable or must be an Enum.")
        }
        if (__someOtherArg == null) {
          throw IllegalArgumentException("Argument \"someOtherArg\" is marked as non-null but was passed a null value.")
        }
      }

Comments

al...@gmail.com <al...@gmail.com> #2Jul 4, 2022 07:34AM

The attached Build Scan log shows that the emulator process crashed unexpectedly. Could you rerun your task with --info and -Pandroid.experimental.testOptions.managedDevices.emulator.showKernelLogging=true to get more information about the emualtor process logs?

al...@gmail.com <al...@gmail.com> #3Jul 6, 2022 08:07AM

https://scans.gradle.com/s/llyxjwf4ipuzc

jb...@google.com <jb...@google.com> #4Jul 6, 2022 04:14PM

No idea why the scan does not contain log information, here you are: https://productionresultssa13.blob.core.windows.net/actions-results/3ec7e316-56eb-4f55-a7dd-511a2f3cf729/workflow-job-run-2623c0b7-dd66-5503-5665-c65c84dbf243/logs/job/job-logs.txt?rsct=text%2Fplain&se=2024-04-02T20%3A32%3A33Z&sig=Z1BPg7s513VC7nKkyGYEmknivAGxlX3Kdx0NsX%2BttW8%3D&sp=r&spr=https&sr=b&st=2024-04-02T20%3A22%3A28Z&sv=2021-12-02

al...@gmail.com <al...@gmail.com> #5Jul 6, 2022 11:27PM

The link in comment#4 seems not to be working for me. I got "AuthenticationFailed" error. If you run task with those --info and -Pandroid.experimental.testOptions.managedDevices.emulator.showKernelLogging=true, the emulator process output its kernel logging to stdout. Do you see any stacktrace or segfault in the log?

al...@gmail.com <al...@gmail.com> #6Jul 7, 2022 07:09AM

That's strange, the repo and the build is public... But I attached the logs as file

il...@google.com <il...@google.com> #7Jul 8, 2022 08:08PM

Assigned to jb...@google.com.

I looked into the logs and it turns out, the runner didn't have enough disk space. I guess the root cause is the Gradle update causing another Gradle major version (and its new transform-4) folder to cache was too much. Anyway, a better error message of the exit code of GMD would be helpful.

al...@gmail.com <al...@gmail.com> #8Jul 9, 2022 01:18AM

Thanks for uploading the log! Yes, the emulator kernel log says the issue was the insufficient disk space: 2024-04-02T18:31:45.7078429Z ERROR | Not enough space to create userdata partition. Available: 7177.027344 MB at /home/runner/.config/.android/avd/gradle-managed/dev34_aosp_atd_x86_64_Pixel_2.avd, need 7372.800000 MB.

Also, I agreed that GMD should diagnose errors and can provide better messages.

Let me rename this issue's title to improve the error message for disk space error.

mi...@gmail.com <mi...@gmail.com> #9Jul 11, 2022 12:53PM

I've added a fix that will surface all error messages from the emulator in the exception when it closes unexpectedly.

il...@google.com <il...@google.com> #10Jul 11, 2022 05:54PM

Thank you for your patience while our engineering team worked to resolve this issue. A fix for this issue is now available in:

Android Studio Meerkat | 2024.3.1 Canary 2
Android Gradle Plugin 8.9.0-alpha02

We encourage you to try the latest update.

If you notice further issues or have questions, please file a new bug report.

Thank you for taking the time to submit feedback — we really appreciate it!

mi...@gmail.com <mi...@gmail.com> #11Jul 15, 2022 09:28AM

Is there an estimated release date for 2.5.1? Thank you!

ap...@google.com <ap...@google.com> #12Jul 18, 2022 10:56PM

Project: platform/frameworks/support
Branch: androidx-main

commit 0027220b3ef51bf9c69ac0287c3699e0b87f6422
Author: Jeremy Woods <jbwoods@google.com>
Date: Fri Jul 15 14:38:08 2022

Add deprecation suppressions to generated fromBundle

The getParcelableArray() and get() functions on Bundle have been
deprecated in SDK 33. This causes warning in the generated Safe Args
classes that use the fromBundle function with custom types.

We need to continue to use the old functions since we need to support
older platform versions so we should suppress the warnings on these
calls.

RelNote: "Navigation Safe Args will no longer cause deprecation warnings
in generated classes when using custom types."
Test: ./gradlew :navigation:navigation-safe-args-generator:test
--rerun-tasks
Bug: 237725966

Change-Id: Id86edf231b90176b5a0f03239bff628171a0284c

M navigation/navigation-safe-args-generator/src/test/test-data/expected/java_nav_writer_test/MainFragmentArgs.java
M navigation/navigation-safe-args-generator/src/test/test-data/expected/kotlin_nav_writer_test/MainFragmentArgs.kt
M navigation/navigation-safe-args-generator/src/main/kotlin/androidx/navigation/safe/args/generator/java/JavaNavWriter.kt
M navigation/navigation-safe-args-generator/src/main/kotlin/androidx/navigation/safe/args/generator/kotlin/KotlinNavWriter.kt

https://android-review.googlesource.com/2154200

jb...@google.com <jb...@google.com> #13Jul 18, 2022 10:57PM

Marked as fixed.

This has been fixed internally and will be released in the Navigation 2.5.1 and 2.6.0-alpha01 versions.

na...@google.com <na...@google.com> #14Sep 12, 2022 05:52PM

This bug was linked in a change in the following release(s):

androidx.navigation:navigation-safe-args-generator:2.6.0-alpha01