Fixed

Bug

Status Update

No update yet.

Description

au...@google.com

created issue #1

Jul 1, 2022 07:42PM

DESCRIBE THE ISSUE IN DETAIL:

Android Lint Report tasks are never up-to-date

STEPS TO REPRODUCE:

Open androidx
Run ./gradlew :lint-checks:lintReport
Run ./gradlew :lint-checks:lintReport second time

Expected

Second run is up to date

Actual

Second run is not up to date, it runs again

https://ge.androidx.dev/s/riilyldvtv4j4

Studio Build: N/A
Version of Gradle Plugin: 7.4.0-alpha07
Version of Gradle: 7.5-rc-2
Version of Java: 11
OS: linux

Comments

au...@google.com <au...@google.com> #2Jul 1, 2022 07:43PM

Based on xav@ offline suggestion this is due to us setting baseline file that is non-existent

https://cs.android.com/androidx/platform/frameworks/support/+/androidx-main:buildSrc/private/src/main/kotlin/androidx/build/LintConfiguration.kt;l=303

https://cs.android.com/android-studio/platform/tools/base/+/mirror-goog-studio-main:build-system/gradle-core/src/main/java/com/android/build/gradle/internal/lint/AndroidLintTask.kt;l=614

sh...@google.com <sh...@google.com> Jul 1, 2022 08:55PM

Assigned to an...@google.com.

vi...@google.com <vi...@google.com> Jul 6, 2022 03:23PM

Reassigned to ba...@google.com.

tn...@google.com <tn...@google.com> Jul 6, 2022 03:31PM

Reassigned to sp...@google.com.

sp...@google.com <sp...@google.com> #3Jul 6, 2022 09:36PM

This is happening for you only when android.experimental.lint.missingBaselineIsEmptyBaseline is set to true, right?

xa...@google.com <xa...@google.com> #4Jul 7, 2022 05:00PM

Scott, I think we should revisit the baseline support. Having the baseline be both input and output is a problem.

An option would be to never generate the baseline in its final location from the lint task itself. We can generate it in intermediates and then have a generateLintBaseLine task that copies it from there to the declared location. This would solve this weird setup we have currently. WDYT?

sp...@google.com <sp...@google.com> #5Jul 7, 2022 05:37PM

Re #4, I agree that the baseline being an input and output of the lint report task is a problem.

My plan was to stop writing the baseline file from the lint report task altogether and instead require users to run the updateLintBaseline task to create or update their baseline file. WDYT?

Message last modified on Jul 7, 2022 05:38PM

xa...@google.com <xa...@google.com> #6Jul 7, 2022 05:56PM

Baseline creation requires running the report though, right? It's best of the update task does not actually run its own report, but just use the normal report one, I think.

sp...@google.com <sp...@google.com> #7Jul 7, 2022 07:32PM

Baseline creation requires running the report though, right?

Yes.

It's best of the update task does not actually run its own report, but just use the normal report one, I think.

The way I implemented it, the update task runs the report, but I see now that it would be more efficient to copy it as you suggest.

sp...@google.com <sp...@google.com> #8Jul 11, 2022 05:31PM

Marked as fixed.

Fixed with Change-Id: I80c311499913bcb37f0956a1e66b7090bad7355e.

To track work on moving away from the baseline file being an input and an output of the lint report task, see Issue 193244776.

au...@google.com <au...@google.com> #9Jul 12, 2022 02:15AM

Which version should we see this fix in? 7.4.0-alpha09?

sp...@google.com <sp...@google.com> #10Jul 12, 2022 03:08AM

Yes