Consider ImmutableCollection, PersistentList, etc. stable [238057117]

Fixed

Bug

Status Update

No update yet.

Description

ub...@gmail.com

created issue #1

Jul 6, 2022 08:04AM

Jetpack Compose version: 1.2.0

Jetpack Compose component used: Runtime

Android Studio Build: N/A

Kotlin version: 1.7.0

Steps to Reproduce or Code Sample to Reproduce:

Compose Compiler 1.2.0 treats a few types from kotlinx.collections.immutable as stable, but does not for other types from this same library. For example, ImmutableList and ImmutableMap are considered stable (if element type is stable), but this is not the case for ImmutableCollection and PersistentList. (Observed via compose compiler reports.)

This is inconsistent, confusing, and counterproductive. I am clueless why this is the case, looks like someone just hacked up a bit of stable treatment for a couple of types they could think of.

A user is still better off using their own explicitly stable flavor of these kinds of collection types instead.

Comments

ub...@gmail.com <ub...@gmail.com> #2Jul 6, 2022 08:07AM

For example:

@Composable
fun Foo(value: ImmutableCollection<Int>) {}

@Composable
fun Foo(value: PersistentList<Int>) {}

an...@google.com <an...@google.com> Sep 8, 2022 06:08PM

Reassigned to le...@google.com.

ub...@gmail.com <ub...@gmail.com> #3Nov 9, 2022 02:22PM

PersistentList is particularly relevant for hoisting List state with similar performance characteristics as SnapshotStateList for non-hoisted List state.

ja...@apadmi.com <ja...@apadmi.com> #4Nov 25, 2022 02:10PM

Given that the `immutableListOf`, `immutableSetOf` and `immutableMapOf` functions are all deprecated, it seems like we should be using the Persistent types. However this has a massive performance impact whilst this issue persists.

pe...@gmail.com <pe...@gmail.com> #5Nov 30, 2022 04:08AM

+1 vote, PersistentList is more useful than ImmutableList (for updating items)

ap...@google.com <ap...@google.com> #6Dec 5, 2022 10:06PM

Project: platform/frameworks/support
Branch: androidx-main

commit a91b7d222899c073168661eccc465034106f9895
Author: Andrew Bailey <anbailey@google.com>
Date: Mon Dec 05 11:39:51 2022

Make more of kotlinx.collections.immutable stable

This addresses two issues around stability inferencing for types in the
kotlinx.collections.immutable library. We have a few exceptions to treat
ImmutableList, ImmutableSet, and ImmutableMap as stable types, but we
don't have anything for ImmutableCollection or their Persistent
siblings. This CL adds those exceptions.

We also haven't marked any of their corresponding `*Of()` builders as
stable, which this CL also adds exceptions for.

Bug: 238057117
Bug: 254435410
Test: ClassStabilityTransformTests
Change-Id: Ie19290bfb53dd667e866681f11f266ae7bdb6201

M compose/compiler/compiler-hosted/integration-tests/src/test/java/androidx/compose/compiler/plugins/kotlin/ClassStabilityTransformTests.kt
M compose/compiler/compiler-hosted/src/main/java/androidx/compose/compiler/plugins/kotlin/analysis/Stability.kt

https://android-review.googlesource.com/2328593

an...@google.com <an...@google.com> #7Dec 6, 2022 03:27PM

Marked as fixed.

Thanks for the report! This is addressed in CL 2328593. This should start to behave as expected in an upcoming version of the Compose compiler.

ub...@gmail.com <ub...@gmail.com> #8Dec 6, 2022 03:54PM

Wonderful, can't wait. Thank you!

ph...@chefkoch.de <ph...@chefkoch.de> #9Mar 1, 2023 02:44PM

Which compose version does include this change?

Message last modified on Mar 1, 2023 02:55PM

ph...@chefkoch.de <ph...@chefkoch.de> #10Mar 1, 2023 02:51PM

Nevermind, I just found it. For everyone who might be interested in it: It's 1.4.0 of the compose compiler