OutOfMemory on layoutlib 2021.2.1-patch1 [240425717]

Assigned

Bug

Status Update

No update yet.

Description

fd...@squareup.com

created issue #1

Jul 27, 2022 03:41PM

I'm creating programmatically 100 TextViews in a scrollable LinearLayout and when I call layoutlib embedded in the Paparazzi lib (https://github.com/cashapp/paparazzi) I'm getting the following OutOfMemory:

java.lang.OutOfMemoryError: Java heap space
	at java.desktop/java.awt.image.DataBufferInt.<init>(DataBufferInt.java:75)
	at java.desktop/java.awt.image.Raster.createPackedRaster(Raster.java:467)
	at java.desktop/java.awt.image.DirectColorModel.createCompatibleWritableRaster(DirectColorModel.java:1032)
	at java.desktop/java.awt.image.BufferedImage.<init>(BufferedImage.java:333)
	at com.android.layoutlib.bridge.impl.RenderSessionImpl.renderAndBuildResult(RenderSessionImpl.java:527)
	at com.android.layoutlib.bridge.impl.RenderSessionImpl.render(RenderSessionImpl.java:459)
	at app.cash.paparazzi.Paparazzi$takeSnapshots$1$2.invoke(Paparazzi.kt:296)
	at app.cash.paparazzi.Paparazzi$takeSnapshots$1$2.invoke(Paparazzi.kt:295)
	at app.cash.paparazzi.Paparazzi.withTime(Paparazzi.kt:336)
	at app.cash.paparazzi.Paparazzi.takeSnapshots(Paparazzi.kt:295)
	at app.cash.paparazzi.Paparazzi.snapshot(Paparazzi.kt:211)
	at app.cash.paparazzi.Paparazzi.snapshot$default(Paparazzi.kt:210)
	at app.cash.paparazzi.plugin.test.RenderingModesTest.renderingModes(RenderingModesTest.kt:37)

Steps to reproduce the problem:

Please see https://github.com/cashapp/paparazzi/pull/516

What happened:

OOM issue

What you think the correct behavior should be:

layoutlib to be able to render the view

Is this a security related issue?

Which Android build are you using?

I’m using layoutlib 2021.2.1-patch1.

Which device did you use to reproduce this issue?

N/A. This is an issue with layoutlib, which usually runs in Android Studio

Please provide sample project or apk to reproduce the issue.

Standalone sample here: https://github.com/cashapp/paparazzi/pull/516

Comments

ra...@google.com <ra...@google.com> #2Jul 28, 2022 09:19AM

Assigned to ra...@google.com.

removed the dup; this is possibly about how android spans work on empty strings.

the calculation in the composable level seemed correct but the layout was not
it happens for a new line as well
one problem with both includeFontPadding true/false is that the cursor height is possibly can be visually improved to match the text ascent/descent rather than line top/bottom (might be challenging)

fd...@squareup.com <fd...@squareup.com> #3Jul 28, 2022 02:20PM

I do not fully understand your points, though I was wondering if a similar "trick" to measure "HHHHHHHHHHH" cannot be used here, because if I'm not mistaken the cursor gets drawn by text layout measuring on empty string.

ra...@google.com <ra...@google.com> #4Jul 29, 2022 06:18AM

StaticLayout does not call LineHeightSpan's for empty sstring (or the empty final line at the end of the string - a string that ends with "\n")

fd...@squareup.com <fd...@squareup.com> #5Jul 29, 2022 03:35PM

Project: platform/frameworks/support
Branch: androidx-main

commit b7a67dc25a34b254adbaffd02495b5c6d26ee18c
Author: siyamed <siyamed@google.com>
Date: Thu Jul 28 08:06:35 2022

Fix TextField empty line lineHeight (2)

When a line is empty (including empty text) StaticLayout
does not apply the LineHeightSpans.

This causes the line height to be different for an empty
line compared to a non empty line. The issue becomes more
visible within TextField .

This CL stores adjustment values to report the height and the
last line metrics correctly.

For the other solution option please see aosp/2170504

Performance

There are no performance differences for cases where text
is not empty or does not end with "\n"

The below numbers are for the cases where text is empty or ends with "\n"

+--------+-----------+-----------+------+
| | Before | After | Diff |
+--------+-----------+-----------+------+
| length | ns | ns | ns |
| 0 | 115,835 | 180,161 | 56% |
| 16 | 395,679 | 484,748 | 23% |
| 32 | 513,235 | 590,783 | 15% |
| 64 | 807,133 | 901,896 | 12% |
| 128 | 1,330,733 | 1,421,371 | 7% |
| 256 | 2,338,534 | 2,464,810 | 5% |
+--------+-----------+-----------+------+

Test: Added test
Test: ./gradlew text:text:test
Test: ./gradlew text:text:cAT
Test: ./gradlew compose:ui:ui-text:test
Test: ./gradlew compose:ui:ui-text:cAT
Test: Treehugger

Bug: 236615813

Change-Id: I57f8b6632f569ad06e547cf6ec83df1bc42845c9

M compose/ui/ui-text/lint-baseline.xml
M compose/ui/ui-text/benchmark/src/androidTest/java/androidx/compose/ui/text/benchmark/input/EditProcessorBenchmark.kt
M compose/ui/ui-text/benchmark/src/androidTest/java/androidx/compose/ui/text/benchmark/ParagraphBenchmark.kt
M compose/ui/ui-text/benchmark/src/main/java/androidx/compose/ui/text/benchmark/TextBenchmarkHelper.kt
M compose/ui/ui-text/src/androidAndroidTest/kotlin/androidx/compose/ui/text/ParagraphIntegrationLineHeightStyleTest.kt
M text/text/src/main/java/androidx/compose/ui/text/android/style/LineHeightStyleSpan.kt
A compose/ui/ui-text/benchmark/src/androidTest/java/androidx/compose/ui/text/benchmark/ParagraphWithLineHeightBenchmark.kt
M text/text/src/main/java/androidx/compose/ui/text/android/TextLayout.kt
M compose/ui/ui-text/benchmark/src/androidTest/java/androidx/compose/ui/text/benchmark/TextMeasurerBenchmark.kt
M compose/ui/ui-text/src/androidMain/kotlin/androidx/compose/ui/text/platform/extensions/SpannableExtensions.android.kt

https://android-review.googlesource.com/2168642

ra...@google.com <ra...@google.com> Aug 1, 2022 07:49AM

Status: New

vi...@google.com <vi...@google.com> Aug 1, 2022 08:27PM

Assigned to ra...@google.com.

ra...@google.com <ra...@google.com> #6Aug 2, 2022 05:36AM

Thank you for fixing this. Will be this cherry-picked to 1.2.x release?

fd...@squareup.com <fd...@squareup.com> #7Aug 2, 2022 02:43PM

I think this will be in a 1.3 alpha/beta release (https://developer.android.com/jetpack/androidx/releases/compose-ui#1.3.0-alpha02)

unfortunately we cant cherry pick it into an older release.

jo...@gmail.com <jo...@gmail.com> #8Aug 3, 2022 11:41PM

Can someone on the Google side please re-assign this ticket to Android Studio component?; this is actually an issue with layoutlib, the component that drives Layout Inspector inside Android Studio.

js...@google.com <js...@google.com> Aug 4, 2022 05:00PM