[Feature Request] Bottom Sheets for Material 3 [244189383]

Fixed

Bug

Status Update

No update yet.

Description

de...@gmail.com

created issue #1

Aug 29, 2022 06:10PM

Feature Request to add BottomSheets to Compose for Material 3.
See Bottom sheets - Material Design 3. The Guidelines are also still missing.

Comments

de...@gmail.com <de...@gmail.com> #2Sep 21, 2022 03:19PM

This would be really helpful for us in aligning with our design system!

se...@google.com <se...@google.com> #3Sep 21, 2022 03:35PM

Reassigned to se...@google.com.

Any update about this?

de...@gmail.com <de...@gmail.com> #4Sep 21, 2022 03:39PM

Any update?

Message last modified on Oct 13, 2022 09:40PM

se...@google.com <se...@google.com> Oct 18, 2022 06:35PM

Accepted by se...@google.com.

cn...@gmail.com <cn...@gmail.com> #5Nov 2, 2022 11:56AM

Blocked my migration to compose. Bottom sheetDialogFragment already has this.

li...@gmail.com <li...@gmail.com> #6Dec 22, 2022 10:26AM

Any update on the issue?

ca...@gmail.com <ca...@gmail.com> #7Jan 3, 2023 07:29AM

An update would be appreciated. As of now, one workaround I'm using is

confirmValueChange = { it != SheetValue.Hidden }

de...@gmail.com <de...@gmail.com> #8Jan 4, 2023 10:01AM

Any update on the issue?

se...@google.com <se...@google.com> #9Jan 4, 2023 05:10PM

Same question

de...@gmail.com <de...@gmail.com> #10Jan 4, 2023 05:12PM

Any update on this one?

se...@google.com <se...@google.com> #11Jan 11, 2023 03:59PM

Any update on this please?

Message last modified on Jan 26, 2023 08:48PM

an...@gmail.com <an...@gmail.com> #12Jan 25, 2023 10:32AM

It's really impressive how a small feature like this is still not in progress.

b9...@gmail.com <b9...@gmail.com> #13Jan 26, 2023 07:24PM

Comment has been deleted.

Message last modified on Jan 27, 2023 03:24PM

ap...@google.com <ap...@google.com> #14Jan 27, 2023 04:12PM

Project: platform/frameworks/support
Branch: androidx-main
Author: Jose Figueroa <serniebanders@google.com>
Link: https://android-review.googlesource.com/3287876

[Material3][ModalBottomSheet] Add sheetGestureEnabled parameter to allow manual disabling of gestures

Expand for full commit details

[Material3][ModalBottomSheet] Add sheetGestureEnabled parameter to allow manual disabling of gestures

RelNote: "ModalBottomSheet now has sheetGestureEnabled parameter"
Bug: 288211587
Test: Added unit test for nested scrolling behavior
Change-Id: I856cbb6b8907ce773d47589f2c83a828a5740eb8

Files:

M compose/material3/material3/api/current.txt
M compose/material3/material3/api/restricted_current.txt
M compose/material3/material3/src/androidInstrumentedTest/kotlin/androidx/compose/material3/ModalBottomSheetTest.kt
M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/ModalBottomSheet.kt

Hash: 18bebb5575db25ab0ff3b5e439401ea40e7bad0e
Date: Mon Sep 30 14:31:26 2024

se...@google.com <se...@google.com> Jan 27, 2023 08:13PM

Marked as fixed.

b9...@gmail.com <b9...@gmail.com> #15Jan 28, 2023 04:40PM

Can we have the fix version please?

ch...@appswithlove.com <ch...@appswithlove.com> #16Feb 2, 2023 08:49AM

Was this fix also added to Material ModalBottomSheet?

se...@google.com <se...@google.com> #17Feb 7, 2023 01:04PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.compose.material3:material3:1.4.0-alpha02
androidx.compose.material3:material3-android:1.4.0-alpha02
androidx.compose.material3:material3-jvmstubs:1.4.0-alpha02
androidx.compose.material3:material3-linuxx64stubs:1.4.0-alpha02

pr...@google.com <pr...@google.com> #18Feb 8, 2023 06:21PM

deleted

dp...@phunware.com <dp...@phunware.com> #19Feb 8, 2023 09:58PM

We do not have a timeline for a Material implementation. Please create a separate issue for that component if it does not exist.

ma...@gmail.com <ma...@gmail.com> #20Feb 8, 2023 10:48PM

Hi, any delay to have it on a stable release ?

sk...@gmail.com <sk...@gmail.com> #21Feb 8, 2023 10:56PM

I've just reported this https://issuetracker.google.com/issues/268380384 - it seems to be a related issue.

jo...@google.com <jo...@google.com> #22Feb 9, 2023 09:17AM

#20, if the issue reported by #21 isn't the same as yours, can you file an issue with a repro?

na...@gmail.com <na...@gmail.com> #23Feb 9, 2023 09:25AM

Material 2 has a BottomSheetScaffold component with a sheetPeekHeight property, which allows things like small music controls to remain in view at the bottom of the screen when the sheet is collapsed and for this to expand to a full screen player UI when expanded. I can't seem to find how to do this peek effect using the Material 3 modal bottom sheet. Could I be missing something or should I open a ticket to request something like sheetPeekHeight? I apologise if the question is naïve or better suited to SO.

ma...@gmail.com <ma...@gmail.com> #24Feb 9, 2023 04:56PM

#22 it's exactly the same issue, easy to reproduce.

Get a Column with an OutlinedTextField or any input text field with a Bottom Sheet that contains another input text. You cannot type into the one inside the bottom sheet.

In my opinion the problem is not that the bottom sheet covers the keyboard, indeed it does that, but I was testing from the emulator and I was typing on the physical keyboard, I think it's more like a focus issue but we count on you guys to figure it out.

Message last modified on Feb 9, 2023 04:58PM

jo...@google.com <jo...@google.com> #25Feb 9, 2023 05:07PM

#24, gotcha! Please follow along in the other issue then :)

de...@gmail.com <de...@gmail.com> #26Feb 10, 2023 07:23PM

The BottomSheet still has serious problems with positioning. Depending on the height of the content, the BottomSheet floats in the middle of the screen or something similar, so that a lot of the app is still visible below the BottomSheet.

Is this already known, or should I create a ticket?

se...@google.com <se...@google.com> #27Feb 10, 2023 07:41PM

Yes, see https://issuetracker.google.com/268411386

For other issues please file new bugs so we can more effectively triage than coming back to this tracker.

at...@gmail.com <at...@gmail.com> #28Apr 20, 2023 06:37PM

There are some very serious accessibility issues with Bottom Sheet in 1.1.0-alpha-07. Talkback does not correctly find focus when bottom sheet is open

ja...@gmail.com <ja...@gmail.com> #29May 10, 2023 07:02PM

import androidx.compose.material3.BottomSheetScaffold

This import is not working for me

ja...@gmail.com <ja...@gmail.com> #30May 10, 2023 07:05PM

const val composeMaterial3 = "1.0.1"
const val composeVersion = "1.4.3"

compileOptions {
sourceCompatibility JavaVersion.VERSION_17
targetCompatibility JavaVersion.VERSION_17
}
kotlinOptions {
jvmTarget = '17'
}

Using the above version of Material3. Please share any suggestions.