Assigned
Status Update
Comments
jf...@google.com <jf...@google.com> #2
This happens when fragments use animation whereby it doesn't wait for animations to complete and moves directly to RESUMED state.
The entry's listener to Fragment state does not get attached because it was attaching only if Fragment was in CREATED / STARTED state.
ma...@medikoo.com <ma...@medikoo.com> #3
Project: platform/frameworks/support
Branch: androidx-main
commit 16afaea63fc18ca7cc298e6650e0463083ba8ad7
Author: Clara Fok <clarafok@google.com>
Date: Mon Feb 27 17:27:15 2023
Fix FragmentNavigator resume states
Entries previously were not attaching fragment lifecycle observers because it would do so only if Fragment was STARTED or CREATED. But when using animations, Fragments would jump straight to RESUME and no observers would be attached.
Observers are now attached as long as Fragment is atleast STARTED. Since initial entry is not added to backStack, we store its entry to later attach an observer when its fragment is attached.
This CL also lays the foundation for attaching observers upon configuration changes / recreates.
Test: ./gradlew navigation:navigation-fragment:cC
Bug: 269646882
Relnote: "Fixes regression in navigation 2.6.0-alpha06 where NavBackStackEntry is not moved to RESUMED state"
Change-Id: Ib35896636c187da5bd11ea06234a3ea815fdeb68
M navigation/navigation-fragment/src/androidTest/java/androidx/navigation/fragment/FragmentNavigatorTest.kt
A navigation/navigation-fragment/src/androidTest/res/anim/fade_enter.xml
A navigation/navigation-fragment/src/androidTest/res/anim/fade_exit.xml
M navigation/navigation-fragment/src/main/java/androidx/navigation/fragment/FragmentNavigator.kt
https://android-review.googlesource.com/2442040
Branch: androidx-main
commit 16afaea63fc18ca7cc298e6650e0463083ba8ad7
Author: Clara Fok <clarafok@google.com>
Date: Mon Feb 27 17:27:15 2023
Fix FragmentNavigator resume states
Entries previously were not attaching fragment lifecycle observers because it would do so only if Fragment was STARTED or CREATED. But when using animations, Fragments would jump straight to RESUME and no observers would be attached.
Observers are now attached as long as Fragment is atleast STARTED. Since initial entry is not added to backStack, we store its entry to later attach an observer when its fragment is attached.
This CL also lays the foundation for attaching observers upon configuration changes / recreates.
Test: ./gradlew navigation:navigation-fragment:cC
Bug: 269646882
Relnote: "Fixes regression in navigation 2.6.0-alpha06 where NavBackStackEntry is not moved to RESUMED state"
Change-Id: Ib35896636c187da5bd11ea06234a3ea815fdeb68
M navigation/navigation-fragment/src/androidTest/java/androidx/navigation/fragment/FragmentNavigatorTest.kt
A navigation/navigation-fragment/src/androidTest/res/anim/fade_enter.xml
A navigation/navigation-fragment/src/androidTest/res/anim/fade_exit.xml
M navigation/navigation-fragment/src/main/java/androidx/navigation/fragment/FragmentNavigator.kt
do...@google.com <do...@google.com> #4
This has been fixed internally and will be available in navigation 2.6.0-alpha07
me...@gmail.com <me...@gmail.com> #5
Project: platform/frameworks/support
Branch: androidx-main
commit c73552953192ba60a879f5e51218f6e157a24beb
Author: Clara Fok <clarafok@google.com>
Date: Tue Feb 28 14:47:30 2023
Add FragmentNavigator test
Ensure initial fragments and their entries are correctly replaced and destroyed when navigate and popping consecutively
Test: ./gradlew navigation:navigation-fragment:cC
Bug: 269646882
Change-Id: I552ddd3d74f20612c4c91336eb4af9e6aa99c146
M navigation/navigation-fragment/src/androidTest/java/androidx/navigation/fragment/FragmentNavigatorTest.kt
M navigation/navigation-fragment/src/androidTest/res/navigation/nav_simple.xml
https://android-review.googlesource.com/2461555
Branch: androidx-main
commit c73552953192ba60a879f5e51218f6e157a24beb
Author: Clara Fok <clarafok@google.com>
Date: Tue Feb 28 14:47:30 2023
Add FragmentNavigator test
Ensure initial fragments and their entries are correctly replaced and destroyed when navigate and popping consecutively
Test: ./gradlew navigation:navigation-fragment:cC
Bug: 269646882
Change-Id: I552ddd3d74f20612c4c91336eb4af9e6aa99c146
M navigation/navigation-fragment/src/androidTest/java/androidx/navigation/fragment/FragmentNavigatorTest.kt
M navigation/navigation-fragment/src/androidTest/res/navigation/nav_simple.xml
Description
For issues with the Google Photos app, please see:
-----------------------
Before filing an issue, please read and follow these instructions carefully.
First, please search through existing issues to ensure that the bug has not already been reported. You can start the search here:
If the issue has already been reported, you can click the star next to the issue number to subscribe and receive updates. We prioritize responding to the issues with the most stars. You can also comment on the issue to provide any details of your experience with it.
If your issue has not been reported, please delete this introduction and provide all of the following:
(Please enable *Markdown* for improved formatting of your report.)
---------------------------------------------------------------------------
# Description
Listing album items, never ends (after listing all existing photos, again same photos are listed)
# Detailed description
I was uploading photos to my album via API, at 125th photo server rethred 500: Internal error encountered.
After that my album cannot be reliably listed via API. Responses circle around same collection constantly. Additionally there are problems accessing the album on website. I can open it, yet when I try to operate on any options suddenly page hanges
## API calls
Calling `
This album normally has 5482 items, yet above API endpoint after listing all those files again starts returning same field, and so on. I've managed to 407400 items until at some point next request failed
## Steps to reproduce the problem
What steps will reproduce the problem?
1. Attempt to retrieve all album media items via: "
I reproduce it only on this single album, I can provide its id if needed
## What is the expected output?
I want to receive the whole album media list with not repeated items.
## What do you see instead?
Command returns new items all the times, and nextPageToken is provided for all the following pages
## Code sample
A small code sample that reliably reproduces the issue. The sample should run as-is or with minimal setup.
```javascript
const getPhotos = async (auth, albumId, pageToken = null, count = 0) => {
const url = "
const response = await fetch(url, {
method: "POST",
headers: { Authorization: `Bearer ${ auth.credentials.access_token }` },
body: JSON.stringify({ albumId, pageSize: 100, pageToken: pageToken || undefined })
});
if (response.status !== 200) throw new Error(await response.text());
const data = await response.json();
if (data.nextPageToken) {
return [
...data.mediaItems, ...(await getPhotos(auth, albumId, data.nextPageToken, count + 1))
];
}
return data.mediaItems || [];
};
getPhotos(auth, albumId);
```