Fixed
Status Update
Comments
ra...@google.com <ra...@google.com> #2
I see that this issue was assigned. I can create Pull Request if need.
ra...@google.com <ra...@google.com> #3
Feel free to do so and we will review.
ra...@google.com <ra...@google.com> #5
I think your PR also fixes our problem: we have links like
.../search/
.../search?documentId=123
.../search?folder=123
And each should be redirected to different navigation destinations. Currently they all redirect to one page, and sometimes crash.
cc...@google.com <cc...@google.com>
ap...@google.com <ap...@google.com> #7
Thank you for the PR!
This has been fixed internally and will be available as part of the Navigation 2.4.0-alpha08
release.
na...@google.com <na...@google.com> #8
Just a quick note. It seems like NavInflater don't set defaultValue when using android:defaultValue="@null" and thus the check will fail. You will have to add the query argument in your Uri : "
Description
The common pattern for try-finally with resources is to
With Trace.beginSection inside the try block it's possible to break all the sections in the trace by closing unopened section in case if Trace.beginSection throws an exception.
And Trace.beginSection may throw an exception if sectionName exceeds 127 characters (probably there are other cases), so this piece of code will produce wrong trace output:
In the resulting trace file all the sections will be skewed (e.g. anotherFun section will be short, instead of 1s)