Integer.MAX_VALUE does not work for ActivityResultContracts.PickMultipleVisualMedia [249182130]

Fixed

Bug

Status Update

No update yet.

Description

vi...@nobel-systems.com

created issue #1

Sep 27, 2022 03:26AM

Component used: Activity

Version used: 1.6.0

Devices/Android versions reproduced on: Samsung Galaxy S20+ Android 12 (with August 2022 Google Play system update, photo picker is confirmed working)

For ActivityResultContracts.PickMultipleVisualMedia, you use Integer.MAX_VALUE as an overload for the maximum number of items the photo picker is able to select for versions Android 12 and below (as MediaStore.getPickImagesMaxLimit() is only available for TIRAMISU and above).

However, using this value causes the photo picker to not be able to start/be launched.

I tried changing the maxItems value to another value (I tried 100) and the photo picker started to work.

Comments

il...@google.com <il...@google.com> Sep 27, 2022 10:41PM

Assigned to yr...@google.com.

yr...@google.com <yr...@google.com> #2Sep 30, 2022 03:51PM

Accepted by yr...@google.com.

Thank you for the report and the code causing the issue. I have landed a reproduction which shows that the code thrown an ArrayIndexOutOfBoundsException from the last bitSet.toByteArray()[0] when not processed by R8.

ap...@google.com <ap...@google.com> #3Oct 12, 2022 02:57AM

Project: r8
Branch: main
Author: Søren Gjesse <sgjesse@google.com>
Link: https://r8-review.googlesource.com/100168

Add reproduction of issue 391417819

Expand for full commit details

Add reproduction of issue 391417819 
 
Bug: b/391417819 
Change-Id: I37eb909c100104fadeb895bf5d930f4f54e94ba0

Files:

A src/test/java/com/android/tools/r8/B391417819Repro.java

Hash: bf9b1962052bf91689120a09deded518e37862a2
Date: Wed Jan 22 09:41:15 2025

il...@google.com <il...@google.com> #4Oct 12, 2022 07:59PM

Marked as fixed, reassigned to jb...@google.com.

deleted

na...@google.com <na...@google.com> #5Oct 24, 2022 01:37PM

I'm really sorry, please use the source code below:

public class R8Test {

    public byte[] toBytes(boolean on) {
        byte[] bytes = new byte[3];
        bytes[0] = 1;
        BitSet bits = new BitSet(8);
        byte[] byteArray = bits.toByteArray();
        if (byteArray != null && byteArray.length >= 1) {
            bytes[1] = bits.toByteArray()[0];
        }

        BitSet bitSet = new BitSet(8);
        byte[] byteArray2 = bits.toByteArray();
        if (byteArray2 != null && byteArray2.length >= 1) {
            bytes[2] = bitSet.toByteArray()[0];
        }
        return bytes;
    }
}

al...@gmail.com <al...@gmail.com> #6Nov 3, 2022 12:21AM

Comment has been deleted.

Message last modified on Nov 3, 2022 04:37PM

fv...@gmail.com <fv...@gmail.com> #7Mar 5, 2023 06:26AM

Comment has been deleted.

Message last modified on Mar 6, 2023 07:22PM

fv...@gmail.com <fv...@gmail.com> #8Mar 5, 2023 06:28AM

Comment has been deleted.

Message last modified on Mar 6, 2023 07:22PM

fv...@gmail.com <fv...@gmail.com> #9Mar 5, 2023 06:29AM

Comment has been deleted.

Message last modified on Mar 6, 2023 07:22PM

ar...@gmail.com <ar...@gmail.com> #10Jun 25, 2023 05:44PM

Project: r8
Branch: 8.7
Author: Christoffer Adamsen <christofferqa@google.com>
Link: https://r8-review.googlesource.com/100543

Extend ArrayConstructionSimplifier dominance checks

Expand for full commit details

Extend ArrayConstructionSimplifier dominance checks 
 
Fixes: b/391417819 
Change-Id: Id31f2463d9255415d33ce43bcafd9e794c550a49

Files:

M src/main/java/com/android/tools/r8/ir/conversion/passes/ArrayConstructionSimplifier.java
M src/test/java/com/android/tools/r8/B391417819Repro.java

Hash: c609582a812828005c7edf12d17f240c746b08c6
Date: Thu Jan 23 08:33:30 2025

an...@gmail.com <an...@gmail.com> #11Apr 1, 2024 02:26AM

Project: r8
Branch: 8.7
Author: Christoffer Adamsen <christofferqa@google.com>
Link: https://r8-review.googlesource.com/100544

Version 8.7.29

Expand for full commit details

Version 8.7.29 
 
Bug: b/391417819 
Change-Id: I6575d9bb6138a2703066d54d57e2c501a7c143ce

Files:

M src/main/java/com/android/tools/r8/Version.java

Hash: e98195210c16e6878b79635ceaec5d2594768414
Date: Thu Jan 23 08:33:36 2025

al...@gmail.com <al...@gmail.com> #12May 25, 2024 10:10AM

Project: r8
Branch: 8.7
Author: Christoffer Adamsen <christofferqa@google.com>
Link: https://r8-review.googlesource.com/100526

Minimize reproduction for b/391417819

Expand for full commit details

Minimize reproduction for b/391417819 
 
Bug: b/391417819 
Change-Id: I65a9c2427b41f2075305c1383f9dd44c0f580433

Files:

M src/test/java/com/android/tools/r8/B391417819Repro.java

Hash: 2d5ed830b7418a5647d0d46fd7491e8a6c9508c7
Date: Thu Jan 23 08:33:25 2025

al...@gmail.com <al...@gmail.com> #13May 25, 2024 10:11AM

Project: r8
Branch: 8.8
Author: Christoffer Adamsen <christofferqa@google.com>
Link: https://r8-review.googlesource.com/100525

Version 8.8.28

Expand for full commit details

Version 8.8.28 
 
Bug: b/391417819 
Change-Id: Ia53d504317c0f4128fbb1f256ab5660aaf30bcb9

Files:

M src/main/java/com/android/tools/r8/Version.java

Hash: 46c042e66ab65f238d710fabb2635d80864b19f0
Date: Thu Jan 23 08:32:59 2025

al...@gmail.com <al...@gmail.com> #14May 25, 2024 10:11AM

Project: r8
Branch: 8.8
Author: Christoffer Adamsen <christofferqa@google.com>
Link: https://r8-review.googlesource.com/100541

Extend ArrayConstructionSimplifier dominance checks

Expand for full commit details

Extend ArrayConstructionSimplifier dominance checks 
 
Fixes: b/391417819 
Change-Id: Id31f2463d9255415d33ce43bcafd9e794c550a49

Files:

M src/main/java/com/android/tools/r8/ir/conversion/passes/ArrayConstructionSimplifier.java
M src/test/java/com/android/tools/r8/B391417819Repro.java

Hash: 8742667733c823ce28496032566dd67b61c77b93
Date: Thu Jan 23 08:32:53 2025

al...@gmail.com <al...@gmail.com> #15May 25, 2024 10:11AM

Project: r8
Branch: 8.8
Author: Christoffer Adamsen <christofferqa@google.com>
Link: https://r8-review.googlesource.com/100540

Add reproduction of issue 391417819

Expand for full commit details

Add reproduction of issue 391417819 
 
Bug: b/391417819 
Change-Id: I37eb909c100104fadeb895bf5d930f4f54e94ba0

Files:

A src/test/java/com/android/tools/r8/B391417819Repro.java

Hash: cf6351164bfa81c0825804a298a2002427703bb8
Date: Thu Jan 23 08:32:43 2025

al...@gmail.com <al...@gmail.com> #16May 25, 2024 10:11AM

Project: r8
Branch: 8.8
Author: Christoffer Adamsen <christofferqa@google.com>
Link: https://r8-review.googlesource.com/100524

Minimize reproduction for b/391417819

Expand for full commit details

Minimize reproduction for b/391417819 
 
Bug: b/391417819 
Change-Id: I65a9c2427b41f2075305c1383f9dd44c0f580433

Files:

M src/test/java/com/android/tools/r8/B391417819Repro.java

Hash: 9306278ddfbe67c7fe3a81446148a245db8a096b
Date: Thu Jan 23 08:32:49 2025

al...@gmail.com <al...@gmail.com> #17May 25, 2024 10:11AM

Project: r8
Branch: 8.9
Author: Christoffer Adamsen <christofferqa@google.com>
Link: https://r8-review.googlesource.com/100520

Add reproduction of issue 391417819

Expand for full commit details

Add reproduction of issue 391417819 
 
Bug: b/391417819 
Change-Id: I37eb909c100104fadeb895bf5d930f4f54e94ba0

Files:

A src/test/java/com/android/tools/r8/B391417819Repro.java

Hash: 521167ce8ff95379eac380e69f0eb8f7ebd8bb1a
Date: Thu Jan 23 08:28:07 2025

al...@gmail.com <al...@gmail.com> #18May 25, 2024 10:12AM

Project: r8
Branch: 8.9
Author: Christoffer Adamsen <christofferqa@google.com>
Link: https://r8-review.googlesource.com/100523

Version 8.9.23

Expand for full commit details

Version 8.9.23 
 
Bug: b/391417819 
Change-Id: I6dc328cf7316214561496f03c24b233cc9cc2e8f

Files:

M src/main/java/com/android/tools/r8/Version.java

Hash: b8f27da10862efd537f7988c9f5f9d639baaf342
Date: Thu Jan 23 08:28:24 2025

al...@gmail.com <al...@gmail.com> #19May 25, 2024 10:12AM

Project: r8
Branch: 8.9
Author: Christoffer Adamsen <christofferqa@google.com>
Link: https://r8-review.googlesource.com/100522

Extend ArrayConstructionSimplifier dominance checks

Expand for full commit details

Extend ArrayConstructionSimplifier dominance checks 
 
Fixes: b/391417819 
Change-Id: Id31f2463d9255415d33ce43bcafd9e794c550a49

Files:

M src/main/java/com/android/tools/r8/ir/conversion/passes/ArrayConstructionSimplifier.java
M src/test/java/com/android/tools/r8/B391417819Repro.java

Hash: 4f64f9ef6cfad77ca541b339f4d2de3e3bbbb629
Date: Thu Jan 23 08:28:18 2025

al...@gmail.com <al...@gmail.com> #20May 25, 2024 10:12AM

Project: r8
Branch: 8.9
Author: Christoffer Adamsen <christofferqa@google.com>
Link: https://r8-review.googlesource.com/100521

Minimize reproduction for b/391417819

Expand for full commit details

Minimize reproduction for b/391417819 
 
Bug: b/391417819 
Change-Id: I65a9c2427b41f2075305c1383f9dd44c0f580433

Files:

M src/test/java/com/android/tools/r8/B391417819Repro.java

Hash: d4cc4e99e6075a7970e8caa7a2f3d939050053f5
Date: Thu Jan 23 08:28:13 2025

al...@gmail.com <al...@gmail.com> #21May 25, 2024 10:12AM

Project: r8
Branch: 8.7
Author: Christoffer Adamsen <christofferqa@google.com>
Link: https://r8-review.googlesource.com/100542

Add reproduction of issue 391417819

Expand for full commit details

Add reproduction of issue 391417819 
 
Bug: b/391417819 
Change-Id: I37eb909c100104fadeb895bf5d930f4f54e94ba0

Files:

A src/test/java/com/android/tools/r8/B391417819Repro.java

Hash: 3353b45090549cf6d57d6cf0a65b8b5959a705b1
Date: Thu Jan 23 08:33:20 2025

Issue 249182130

Description

Issue summary

Comments

il...@google.com <il...@google.com> Sep 27, 2022 10:41PM

yr...@google.com <yr...@google.com> #2Sep 30, 2022 03:51PM

ap...@google.com <ap...@google.com> #3Oct 12, 2022 02:57AM

il...@google.com <il...@google.com> #4Oct 12, 2022 07:59PM

na...@google.com <na...@google.com> #5Oct 24, 2022 01:37PM

al...@gmail.com <al...@gmail.com> #6Nov 3, 2022 12:21AM

fv...@gmail.com <fv...@gmail.com> #7Mar 5, 2023 06:26AM

fv...@gmail.com <fv...@gmail.com> #8Mar 5, 2023 06:28AM

fv...@gmail.com <fv...@gmail.com> #9Mar 5, 2023 06:29AM

ar...@gmail.com <ar...@gmail.com> #10Jun 25, 2023 05:44PM

an...@gmail.com <an...@gmail.com> #11Apr 1, 2024 02:26AM

al...@gmail.com <al...@gmail.com> #12May 25, 2024 10:10AM

al...@gmail.com <al...@gmail.com> #13May 25, 2024 10:11AM

al...@gmail.com <al...@gmail.com> #14May 25, 2024 10:11AM

al...@gmail.com <al...@gmail.com> #15May 25, 2024 10:11AM

al...@gmail.com <al...@gmail.com> #16May 25, 2024 10:11AM

al...@gmail.com <al...@gmail.com> #17May 25, 2024 10:11AM

al...@gmail.com <al...@gmail.com> #18May 25, 2024 10:12AM

al...@gmail.com <al...@gmail.com> #19May 25, 2024 10:12AM

al...@gmail.com <al...@gmail.com> #20May 25, 2024 10:12AM

al...@gmail.com <al...@gmail.com> #21May 25, 2024 10:12AM

Add comment

Issue metadata