[R8 4.0.30] Cannot constrain type: LONG for value: v147 by constraint: OBJECT [251015885]

Fixed

Bug

Status Update

No update yet.

Description

br...@snapchat.com

created issue #1

Oct 5, 2022 06:04AM

Background

After upgrading from R8 3.3 -> R8 4.0, we are seeing a crash at compile time in R8 for our Bazel R8 builds.

We have our own custom implementation of Bazel in R8 which can be found here: https://github.com/bazelbuild/bazel/pull/14741.

Subsequently, here is the logic that constructs the R8Command: https://gist.github.com/mauriciogg/6e7217f03a19a40979f23ca1e5eff297

Possibly, there is a mis-configuration of how we are constructing the R8Command? I did notice the properties are different between Gradle and Bazel.

Bazel:

tool=R8
mode=release
min-api=21 
optimize-multidex-for-linear-alloc=false
desugar-state=ON
enable-missing-library-api-modeling=false
include-data-resources=true
tree-shaking=true
minification=true
force-proguard-compatibility=false

Gradle:

tool=R8
mode=release
min-api=1
optimize-multidex-for-linear-alloc=false
desugar-state=OFF
enable-missing-library-api-modeling=false
tree-shaking=true
minification=true
force-proguard-compatibility=false

Issue

We are seeing the following stacktrace:

Caused by: com.android.tools.r8.utils.AbortException: Cannot constrain type: LONG for value: v147 by constraint: OBJECT
	at com.android.tools.r8.utils.Reporter.handleDiagnostic(Reporter.java:81)
	at com.android.tools.r8.utils.Reporter.fatalError(Reporter.java:127)
	at com.android.tools.r8.ir.code.Value.constrainType(Value.java:60)
	at com.android.tools.r8.ir.conversion.IRBuilder.constrainType(IRBuilder.java:773)
	at com.android.tools.r8.ir.conversion.IRBuilder.readRegister(IRBuilder.java:2126)
	at com.android.tools.r8.ir.conversion.IRBuilder.addInstanceGet(IRBuilder.java:1461)
	at com.android.tools.r8.dex.code.DexIgetBoolean.buildIR(DexIgetBoolean.java:47)
	at com.android.tools.r8.ir.conversion.DexSourceCode.buildInstruction(DexSourceCode.java:176)
	at com.android.tools.r8.ir.conversion.IRBuilder.processWorklist(IRBuilder.java:922)
	at com.android.tools.r8.ir.conversion.IRBuilder.build(IRBuilder.java:668)
	at com.android.tools.r8.graph.DexCode.buildInliningIR(DexCode.java:420)
	at com.android.tools.r8.graph.ProgramMethod.buildInliningIR(ProgramMethod.java:56)
	at com.android.tools.r8.ir.optimize.inliner.InliningIRProvider.getInliningIR(InliningIRProvider.java:83)
	at com.android.tools.r8.ir.optimize.Inliner$InlineAction.buildInliningIR(Inliner.java:555)
	at com.android.tools.r8.ir.optimize.Inliner.performInliningImpl(Inliner.java:1023)
	at com.android.tools.r8.ir.optimize.Inliner.performInlining(Inliner.java:896)
	at com.android.tools.r8.ir.optimize.Inliner.performInlining(Inliner.java:870)
	at com.android.tools.r8.ir.conversion.IRConverter.optimize(IRConverter.java:1255)
	at com.android.tools.r8.ir.conversion.IRConverter.rewriteDesugaredCodeInternal(IRConverter.java:1077)
	at com.android.tools.r8.ir.conversion.IRConverter.lambda$rewriteDesugaredCode$15(IRConverter.java:1026)
	at com.android.tools.r8.utils.ExceptionUtils.withOriginAndPositionAttachmentHandler(ExceptionUtils.java:246)
	at com.android.tools.r8.ir.conversion.IRConverter.rewriteDesugaredCode(IRConverter.java:1022)
	at com.android.tools.r8.ir.conversion.IRConverter.processDesugaredMethod(IRConverter.java:983)
	at com.android.tools.r8.ir.conversion.IRConverter.lambda$optimize$9(IRConverter.java:695)
	at com.android.tools.r8.ir.conversion.PrimaryMethodProcessor.lambda$forEachMethod$0(PrimaryMethodProcessor.java:138)
	at com.android.tools.r8.utils.ThreadUtils.lambda$processItemsWithResults$1(ThreadUtils.java:42)
	at com.android.tools.r8.utils.ThreadUtils.lambda$processItemsWithResults$3(ThreadUtils.java:69)
	at java.base/java.util.concurrent.ForkJoinTask$AdaptedCallable.exec(ForkJoinTask.java:1448)
	at java.base/java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:290)
	at java.base/java.util.concurrent.ForkJoinPool$WorkQueue.topLevelExec(ForkJoinPool.java:1020)
	at java.base/java.util.concurrent.ForkJoinPool.scan(ForkJoinPool.java:1656)
	at java.base/java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1594)
	at java.base/java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:177)

I was able to get Bazel to produce a dump and I can share that over email.

Comments

mk...@google.com <mk...@google.com> #2Oct 5, 2022 06:19AM

Reassigned to mk...@google.com.

Actually I believe it would throw a runtime error, not just be redundant:

if (mRecycled) {
            throw new RuntimeException(toString() + " recycled twice!");
        }

br...@snapchat.com <br...@snapchat.com> #3Oct 5, 2022 06:48AM

Internal note: looks related to Change I39727bc67

mk...@google.com <mk...@google.com> #4Oct 5, 2022 03:09PM

This will be fixed by Change I9baebec66991dd308edda2ce66f1225d25037644 in an upcoming release.

Thank you for the report!

ap...@google.com <ap...@google.com> #5Oct 10, 2022 11:29AM

Project: r8
Branch: main

commit e1eaad36ea07e23f5c9d2bdfe00d46f730782e49
Author: Morten Krogh-Jespersen <mkroghj@google.com>
Date: Mon Oct 10 13:27:37 2022

Add regression test for moving instance get over definition

Bug:

b/251015885

Change-Id: Ifa14d902fba81ca85bdfe9a71d4c719666415e33

A src/test/java/com/android/tools/r8/ir/optimize/canonicalization/InstanceGetOnCheckCastCompareLongTest.java

https://r8-review.googlesource.com/72181

ap...@google.com <ap...@google.com> #6Oct 11, 2022 12:02PM

Project: r8
Branch: main

commit 90a926a1dd3b76382216b30d1ff49d49aa3da66b
Author: Morten Krogh-Jespersen <mkroghj@google.com>
Date: Tue Oct 11 11:40:44 2022

Check for compare when shorting live ranges for instance-get

Bug:

b/251015885

Change-Id: Ia914ba6c4cc1e54686299cc2ce50bb06d1ee2718

M src/test/java/com/android/tools/r8/ir/optimize/canonicalization/InstanceGetOnCheckCastCompareLongTest.java
M src/main/java/com/android/tools/r8/ir/optimize/CodeRewriter.java

https://r8-review.googlesource.com/72205

ap...@google.com <ap...@google.com> #7Oct 12, 2022 01:56PM

Project: r8
Branch: 4.0

commit 456b3c2cf7e94775d5cadeffad09ad8503b3cace
Author: Morten Krogh-Jespersen <mkroghj@google.com>
Date: Wed Oct 12 12:29:55 2022

Version 4.0.33

Bug:

b/251015885

Change-Id: I2eea96d343a364d6019f23a143c90b413e1d737a

M src/main/java/com/android/tools/r8/Version.java

https://r8-review.googlesource.com/72303

ap...@google.com <ap...@google.com> #8Oct 12, 2022 01:56PM

Project: r8
Branch: 4.0

commit c83bb4906a80f23b7dd065d4414a0459129a9613
Author: Morten Krogh-Jespersen <mkroghj@google.com>
Date: Wed Oct 12 12:29:47 2022

Check for compare when shorting live ranges for instance-get

Bug:

b/251015885

https://r8-review.googlesource.com/72302

ap...@google.com <ap...@google.com> #9Oct 12, 2022 01:56PM

Project: r8
Branch: 4.0

commit b9e7c49fc29b8567a8f2dd57faa5dbbd1b4c1f39
Author: Morten Krogh-Jespersen <mkroghj@google.com>
Date: Wed Oct 12 12:29:40 2022

Add regression test for moving instance get over definition

Bug:

b/251015885

Change-Id: Ifa14d902fba81ca85bdfe9a71d4c719666415e33

A src/test/java/com/android/tools/r8/ir/optimize/canonicalization/InstanceGetOnCheckCastCompareLongTest.java

https://r8-review.googlesource.com/72301

mk...@google.com <mk...@google.com> #10Oct 13, 2022 07:00AM

This issue should be fixed from version 4.0.33:

pluginManagement {
    buildscript {
        repositories {
            mavenCentral()
            maven {
                url = uri("https://storage.googleapis.com/r8-releases/raw")
            }
        }

        dependencies {
            classpath("com.android.tools:r8:4.0.33")
        }
    }
}

I was able to compile the dump with this version, but if you see other errors please let me know.

mk...@google.com <mk...@google.com> Oct 26, 2022 12:28PM

Marked as fixed.

Issue 251015885

Description

Issue summary

Comments

mk...@google.com <mk...@google.com> #2Oct 5, 2022 06:19AM

br...@snapchat.com <br...@snapchat.com> #3Oct 5, 2022 06:48AM

mk...@google.com <mk...@google.com> #4Oct 5, 2022 03:09PM

ap...@google.com <ap...@google.com> #5Oct 10, 2022 11:29AM

ap...@google.com <ap...@google.com> #6Oct 11, 2022 12:02PM

ap...@google.com <ap...@google.com> #7Oct 12, 2022 01:56PM

ap...@google.com <ap...@google.com> #8Oct 12, 2022 01:56PM

ap...@google.com <ap...@google.com> #9Oct 12, 2022 01:56PM

mk...@google.com <mk...@google.com> #10Oct 13, 2022 07:00AM

mk...@google.com <mk...@google.com> Oct 26, 2022 12:28PM

Add comment

Issue metadata