Fixed

Bug

Status Update

No update yet.

Description

au...@google.com

created issue #1

Oct 10, 2022 07:31PM

DESCRIBE THE ISSUE IN DETAIL: Gradle 8.0-milestone-2 causes exception in AGP

STEPS TO REPRODUCE:

Run an AGP project while using Gradle 8.0-milestone-2

Expected:

No exceptions

Actual:

Exception

Unable to decide if config caching is enabled	
java.lang.NoSuchMethodError: 'org.gradle.internal.buildoption.BuildOption$Value org.gradle.api.internal.StartParameterInternal.getConfigurationCache()'	
        at com.android.build.gradle.internal.StartParameterUtils.isConfigurationCache(StartParameterUtils.kt:30)	
        at com.android.build.gradle.internal.profile.AnalyticsResourceManager.recordGlobalProperties(AnalyticsResourceManager.kt:301)

https://ge.androidx.dev/s/m4okntwz2h4oo/console-log?anchor=445&page=1

AGP is using internal API that just got refactored in https://github.com/gradle/gradle/commit/8b7dda9a763379c031712ceabcf9ec04cbf87a5e

Note, this does not fail the build, but it does print a giant exception to the log.

Comments

ga...@google.com <ga...@google.com> Oct 11, 2022 06:28AM

Assigned to bi...@google.com.

bi...@google.com <bi...@google.com> Oct 11, 2022 04:34PM

Accepted by bi...@google.com.

bi...@google.com <bi...@google.com> #2Oct 11, 2022 08:06PM

Some things to work out before making the annotations type-use:

Determine guidelines for type nullability in public API
Determine rules for when type nullability can change in public API
Confirm that intellij nullability lint works as expected for type-use nullability annotations
Test what the impact would be on existing arrays (due to ambiguities of type-use annotations on arrays)
Confirm usage of type-use androidx.annotation.NonNull/Nullable in metalava won't break anything for platform

au...@google.com <au...@google.com> #3Oct 11, 2022 08:07PM

Plan for making the annotations type-use: https://docs.google.com/document/d/1tNqV9Dgtii6wvulm8emjs0bwgSL3Fwf3F4LFXfVeyTU/edit

au...@google.com <au...@google.com> #4Oct 28, 2022 08:59PM

Tracking sheet for which projects have been migrated.

bi...@google.com <bi...@google.com> #5Oct 28, 2022 10:04PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit 558f17c6f9e237897fcc87fa556ca4af5c1808c6
Author: Julia McClellan <juliamcclellan@google.com>
Date: Thu Sep 19 14:50:25 2024

Add JSpecify to list of Dackka allowed nullness annotations

Test: Compared the output of `./gradlew docs-tip-of-tree:docs` with the current codebase and aosp/3190072, which switches all nullness annotations to jspecify. Only observed changes were updated nullness annotation links and additional copies of some inherited methods when a parent used a different nullness annotation (similar to

b/280845383

)
Bug: 326456246

Change-Id: I40ede9c84dbae3a1ac7d3d4e98f77a56e119caaa

M buildSrc/private/src/main/kotlin/androidx/build/docs/AndroidXDocsImplPlugin.kt

https://android-review.googlesource.com/3272873

sa...@google.com <sa...@google.com> #6Nov 2, 2022 05:32PM

Project: platform/frameworks/support
Branch: androidx-main

commit c8f5025ba9bf1deb5effbebb7e79683ee7ff9f50
Author: Julia McClellan <juliamcclellan@google.com>
Date: Fri Sep 20 12:31:45 2024

Add JSpecify package-list

Bug: 326456246
Test: checking links in output of `./gradlew docs-tip-of-tree:docs` with aosp/3190072 which switches annotations to jspecify
Change-Id: Ic52ecc37cfb84002ba830dfca6186db2dc5bae67

M buildSrc/private/src/main/kotlin/androidx/build/dackka/DackkaTask.kt
A docs-public/package-lists/jspecify/package-list

https://android-review.googlesource.com/3275171

sa...@google.com <sa...@google.com> #7Nov 3, 2022 01:42PM

Project: platform/frameworks/support
Branch: androidx-main

commit b05578cabee04fdccd2f24c7e2d6a8b25b94a97a
Author: Julia McClellan <juliamcclellan@google.com>
Date: Mon Sep 23 11:21:48 2024

Add java format task

Will be used by the jspecify update script

Bug: 326456246
Test: `./gradlew core:core:javaFormat`, `./gradlew core:core:javaFormat --fix-imports-only` to check java diffs. `./gradlew paging:paging-guava:javaFormat` to check the task succeeds for a project with no java files

Change-Id: I6027419d4ad520a4bd82decd009d252b7077d8a6

M buildSrc/private/src/main/kotlin/androidx/build/AndroidXImplPlugin.kt
A buildSrc/private/src/main/kotlin/androidx/build/JavaFormat.kt
M gradle/libs.versions.toml

https://android-review.googlesource.com/3277031

ph...@gmail.com <ph...@gmail.com> #8Nov 3, 2022 06:26PM

Project: platform/frameworks/support
Branch: androidx-main

commit 7d0e9ad06dd1a8372872053b882be71ec2208df7
Author: Julia McClellan <juliamcclellan@google.com>
Date: Fri Sep 20 13:55:03 2024

Add script to migrate projects to JSpecify

This script runs lint to update usage of AndroidX nullness annotations to type-use position, switches the imports to point to JSpecify, and adds a dependency in each build.gradle file.

Bug: 326456246
Test: `development/jspecify_update.py` runs over all projects and created aosp/3190072. Tested `development/jspecify_update.py cursoradapter` to run over a specific directory.
Change-Id: Id0b0620d4d2dd12f88bdd6ece6885b8abb7b7843

A development/jspecify_update.py

https://android-review.googlesource.com/3275093

pa...@gmail.com <pa...@gmail.com> #9Jan 4, 2023 04:01PM

Project: platform/frameworks/support
Branch: androidx-main

commit 619650cc911ddda040d11f5162d6cdd3bcd48b04
Author: Julia McClellan <juliamcclellan@google.com>
Date: Mon Sep 23 11:38:03 2024

Add kotlin compiler args for JSpecify

These arguments make the kotlin compiler enforce correct usage of jspecify nullness annotations. They will become default in language version 2.1 but are needed until then.

Bug: 326456246
Test: Local testing of running `compileKotlin` when using jspecify nullness incorrectly
Change-Id: I635baf825df0e67d489879dcb2e812b3ee3cffb4

M buildSrc/private/src/main/kotlin/androidx/build/AndroidXImplPlugin.kt

https://android-review.googlesource.com/3277032