SupportSQLiteQueryBuilder selection() should use Array<out Any?>? to prevent unnecessary casts [253531073]

Fixed

Bug

Status Update

No update yet.

Description

ia...@gmail.com

created issue #1

Oct 14, 2022 03:13AM

Component used: Sqlite

Version used: 2.3.0-beta01

ContentProviders have methods of the signature:

override fun query(
    uri: Uri,
    projection: Array<String>?,
    selection: String?,
    selectionArgs: Array<String>?,
    sortOrder: String?
): Cursor? {

You'll note that the type of the selectionArgs is Array<String>?.

If you try to pass that to SupportSQLiteQueryBuilder.builder's selection method, you get the following error:

Type mismatch.
  Required:
    Array<Any?>?
  Found:
    Array<String>?

However, String is a subtype of Any?, so this should work without any casting, but selection is defined as

fun selection(selection: String?, bindArgs: Array<Any?>?)

Which means the only valid type is exactly Array<Any?>?.

Can you change it to

fun selection(selection: String?, bindArgs: Array<out Any?>?)

So that subtypes of Any? can also be accepted?

That would mean I could remove this hacky workaround:

// Convert from an Array<String>? to an Array<Any?>?
// without an unsafe cast
qb.selection(selection, selectionArgs?.toList()?.toTypedArray())

Comments

da...@google.com <da...@google.com> #2Oct 14, 2022 02:28PM

I created a thread on the android-developers forum related to this bug:

http://groups.google.com/group/android-
developers/browse_thread/thread/6caa57135927e242/86d4d895e88a5ebb?
lnk=gst&q=custom+account#86d4d895e88a5ebb

ap...@google.com <ap...@google.com> #3Oct 18, 2022 12:12PM

My personal theory is that Google broke this part of the API intentionally to keep
the lock-in on sync functionality they've enjoyed since Android 1.0.....

da...@google.com <da...@google.com> Oct 18, 2022 12:15PM

Marked as fixed.

na...@google.com <na...@google.com> #4Nov 9, 2022 06:28PM

Also see the latter part of the Contacts FAQ thread:

http://groups.google.com/group/android-developers/browse_thread/thread/58c69a2ea5056a01

pr...@google.com <pr...@google.com> #5Mar 22, 2023 08:24PM

[Comment deleted]

pr...@google.com <pr...@google.com> #6Oct 18, 2023 08:42PM

Here's an intact link to the "Adding contacts to a custom account" thread that Carlo
refers to above:

http://groups.google.com/group/android-developers/browse_thread/thread/6caa57135927e242

na...@google.com <na...@google.com> #7Mar 12, 2025 06:13PM

ExternalSource.java bug

protected void inflate(Context context, XmlPullParser parser)
{
final AttributeSet attrs = Xml.asAttributeSet(parser); << It can't read any
attributes from the ContactsDataKind tag. It should located blow the second while
loop.

try
{
int type;
while((type = parser.next()) != XmlPullParser.START_TAG &&
type != XmlPullParser.END_DOCUMENT)
{
// Drain comments and whitespace
}

if(type != XmlPullParser.START_TAG)
{
throw new IllegalStateException("No start tag found");
}

if(!InflateTags.CONTACTS_SOURCE.equals(parser.getName()))
{
throw new IllegalStateException("Top level element must be " +
InflateTags.CONTACTS_SOURCE);
}